[GitHub] [commons-collections] marcwrobel commented on pull request #323: (chore) Fix minor typos

2022-10-19 Thread GitBox
marcwrobel commented on PR #323: URL: https://github.com/apache/commons-collections/pull/323#issuecomment-1285038365 @garydgregory, all changes related to the bloomfilter package have been reverted. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [commons-jxpath] Warxim commented on a diff in pull request #26: Fix CVE-2022-41852

2022-10-19 Thread GitBox
Warxim commented on code in PR #26: URL: https://github.com/apache/commons-jxpath/pull/26#discussion_r999896659 ## src/main/java/org/apache/commons/jxpath/ClassFunctions.java: ## @@ -91,6 +92,13 @@ public Function getFunction( final String namespace, final Stri

[GitHub] [commons-jxpath] Warxim commented on a diff in pull request #26: Fix CVE-2022-41852

2022-10-19 Thread GitBox
Warxim commented on code in PR #26: URL: https://github.com/apache/commons-jxpath/pull/26#discussion_r27379 ## src/main/java/org/apache/commons/jxpath/ClassFunctions.java: ## @@ -91,6 +92,13 @@ public Function getFunction( final String namespace, final Stri

[GitHub] [commons-jxpath] Warxim commented on a diff in pull request #26: Fix CVE-2022-41852

2022-10-19 Thread GitBox
Warxim commented on code in PR #26: URL: https://github.com/apache/commons-jxpath/pull/26#discussion_r999896659 ## src/main/java/org/apache/commons/jxpath/ClassFunctions.java: ## @@ -91,6 +92,13 @@ public Function getFunction( final String namespace, final Stri

[GitHub] [commons-jxpath] kyakdan commented on a diff in pull request #26: Fix CVE-2022-41852

2022-10-19 Thread GitBox
kyakdan commented on code in PR #26: URL: https://github.com/apache/commons-jxpath/pull/26#discussion_r1000142254 ## src/test/java/org/apache/commons/jxpath/ri/compiler/ExtensionFunctionTest.java: ## @@ -60,9 +59,9 @@ public void setUp() { lib.addFunctions(new Class

[GitHub] [commons-configuration] codecov-commenter commented on pull request #229: CONFIGURATION-822: Fix ambiguity on the section determining

2022-10-19 Thread GitBox
codecov-commenter commented on PR #229: URL: https://github.com/apache/commons-configuration/pull/229#issuecomment-1284847793 # [Codecov](https://codecov.io/gh/apache/commons-configuration/pull/229?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [commons-pool] aooohan commented on pull request #182: Avoid potential ConcurrentModificationException by using Iterator.

2022-10-19 Thread GitBox
aooohan commented on PR #182: URL: https://github.com/apache/commons-pool/pull/182#issuecomment-1284790607 > You have not addressed my comment on why the locking already provided through synchronized blocks and synchronized methods is not enough For this, it's not a synchronization pr

[GitHub] [commons-pool] aooohan closed pull request #182: Avoid potential ConcurrentModificationException by using Iterator.

2022-10-19 Thread GitBox
aooohan closed pull request #182: Avoid potential ConcurrentModificationException by using Iterator. URL: https://github.com/apache/commons-pool/pull/182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [commons-pool] aooohan commented on pull request #182: Avoid potential ConcurrentModificationException by using Iterator.

2022-10-19 Thread GitBox
aooohan commented on PR #182: URL: https://github.com/apache/commons-pool/pull/182#issuecomment-1284788430 > Then this PR won't make it because: > > * You cannot prove anything is wrong > * You have not addressed my comment on why the locking already provided through synchronized b

[GitHub] [commons-scxml] dependabot[bot] closed pull request #80: Bump ossf/scorecard-action from 1.1.2 to 2.0.5

2022-10-19 Thread GitBox
dependabot[bot] closed pull request #80: Bump ossf/scorecard-action from 1.1.2 to 2.0.5 URL: https://github.com/apache/commons-scxml/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [commons-scxml] dependabot[bot] commented on pull request #80: Bump ossf/scorecard-action from 1.1.2 to 2.0.5

2022-10-19 Thread GitBox
dependabot[bot] commented on PR #80: URL: https://github.com/apache/commons-scxml/pull/80#issuecomment-1284725125 Superseded by #81. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [commons-scxml] dependabot[bot] opened a new pull request, #81: Bump ossf/scorecard-action from 1.1.2 to 2.0.6

2022-10-19 Thread GitBox
dependabot[bot] opened a new pull request, #81: URL: https://github.com/apache/commons-scxml/pull/81 Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 1.1.2 to 2.0.6. Release notes Sourced from https://github.com/ossf/scorecard-action/releases";>ossf/scor

[GitHub] [commons-collections] garydgregory commented on pull request #323: (chore) Fix minor typos

2022-10-19 Thread GitBox
garydgregory commented on PR #323: URL: https://github.com/apache/commons-collections/pull/323#issuecomment-1284639342 Hi @marcwrobel Please revert changes to the `bloomfilter` package, I don't make to make work for #335 TY -- This is an automated message from the Apache Git Serv

[GitHub] [commons-configuration] BranislavBeno commented on a diff in pull request #229: CONFIGURATION-822: Fix ambiguity on the section determining

2022-10-19 Thread GitBox
BranislavBeno commented on code in PR #229: URL: https://github.com/apache/commons-configuration/pull/229#discussion_r84426 ## src/main/java/org/apache/commons/configuration2/INIConfiguration.java: ## @@ -349,7 +364,7 @@ public void setCommentLeadingCharsUsedInInput(final S

[GitHub] [commons-configuration] BranislavBeno commented on a diff in pull request #229: CONFIGURATION-822: Fix ambiguity on the section determining

2022-10-19 Thread GitBox
BranislavBeno commented on code in PR #229: URL: https://github.com/apache/commons-configuration/pull/229#discussion_r83770 ## src/main/java/org/apache/commons/configuration2/INIConfiguration.java: ## @@ -236,12 +236,27 @@ public class INIConfiguration extends BaseHierarch

[GitHub] [commons-configuration] garydgregory commented on a diff in pull request #229: CONFIGURATION-822: Fix ambiguity on the section determining

2022-10-19 Thread GitBox
garydgregory commented on code in PR #229: URL: https://github.com/apache/commons-configuration/pull/229#discussion_r69785 ## src/main/java/org/apache/commons/configuration2/INIConfiguration.java: ## @@ -349,7 +364,7 @@ public void setCommentLeadingCharsUsedInInput(final St

[GitHub] [commons-configuration] BranislavBeno commented on pull request #229: CONFIGURATION-822: Fix ambiguity on the section determining

2022-10-19 Thread GitBox
BranislavBeno commented on PR #229: URL: https://github.com/apache/commons-configuration/pull/229#issuecomment-1284607829 It seems, that inline comments are already allowed, however, currently only on value lines. Tested with e.g.: [TestINIConfiguration#testValueWithComment](https://g

[jira] [Work logged] (CSV-302) CSVFormat.duplicateHeaderMode requires default for backward compatibility

2022-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CSV-302?focusedWorklogId=818609&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-818609 ] ASF GitHub Bot logged work on CSV-302: -- Author: ASF GitHub Bot

[GitHub] [commons-csv] sman-81 commented on a diff in pull request #276: [CSV-302] CSVFormat.duplicateHeaderMode requires default DISALLOW, fix deserialization of v1.9.0 CSVFormat objects

2022-10-19 Thread GitBox
sman-81 commented on code in PR #276: URL: https://github.com/apache/commons-csv/pull/276#discussion_r47561 ## src/test/java/org/apache/commons/csv/CSVFormatSerializationTest.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Work logged] (CSV-302) CSVFormat.duplicateHeaderMode requires default for backward compatibility

2022-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CSV-302?focusedWorklogId=818608&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-818608 ] ASF GitHub Bot logged work on CSV-302: -- Author: ASF GitHub Bot

[jira] [Work logged] (CSV-302) CSVFormat.duplicateHeaderMode requires default for backward compatibility

2022-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CSV-302?focusedWorklogId=818607&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-818607 ] ASF GitHub Bot logged work on CSV-302: -- Author: ASF GitHub Bot

[GitHub] [commons-csv] sman-81 commented on a diff in pull request #276: [CSV-302] CSVFormat.duplicateHeaderMode requires default DISALLOW, fix deserialization of v1.9.0 CSVFormat objects

2022-10-19 Thread GitBox
sman-81 commented on code in PR #276: URL: https://github.com/apache/commons-csv/pull/276#discussion_r47561 ## src/test/java/org/apache/commons/csv/CSVFormatSerializationTest.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [commons-csv] sman-81 commented on a diff in pull request #276: [CSV-302] CSVFormat.duplicateHeaderMode requires default DISALLOW, fix deserialization of v1.9.0 CSVFormat objects

2022-10-19 Thread GitBox
sman-81 commented on code in PR #276: URL: https://github.com/apache/commons-csv/pull/276#discussion_r46899 ## src/main/java/org/apache/commons/csv/CSVFormat.java: ## @@ -2280,6 +2279,27 @@ private void validate() throws IllegalArgumentException { } } +pr

[GitHub] [commons-jxpath] Warxim commented on a diff in pull request #26: Fix CVE-2022-41852

2022-10-19 Thread GitBox
Warxim commented on code in PR #26: URL: https://github.com/apache/commons-jxpath/pull/26#discussion_r27379 ## src/main/java/org/apache/commons/jxpath/ClassFunctions.java: ## @@ -91,6 +92,13 @@ public Function getFunction( final String namespace, final Stri

[jira] [Updated] (NUMBERS-70) Userguide and reports

2022-10-19 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/NUMBERS-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Herbert updated NUMBERS-70: Affects Version/s: 1.0 > Userguide and reports > - > > Key: NUM

[jira] [Commented] (NUMBERS-70) Userguide and reports

2022-10-19 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/NUMBERS-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17620590#comment-17620590 ] Alex Herbert commented on NUMBERS-70: - Initial user guide added in commit: 07443607d

[jira] [Updated] (NUMBERS-70) Userguide and reports

2022-10-19 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/NUMBERS-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Herbert updated NUMBERS-70: Fix Version/s: 1.1 > Userguide and reports > - > > Key: NUMBERS

[GitHub] [commons-validator] codecov-commenter commented on pull request #95: JUnit5 assertThrows UrlValidatorTest

2022-10-19 Thread GitBox
codecov-commenter commented on PR #95: URL: https://github.com/apache/commons-validator/pull/95#issuecomment-1284538017 # [Codecov](https://codecov.io/gh/apache/commons-validator/pull/95?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [commons-jxpath] Warxim commented on a diff in pull request #26: Fix CVE-2022-41852

2022-10-19 Thread GitBox
Warxim commented on code in PR #26: URL: https://github.com/apache/commons-jxpath/pull/26#discussion_r999896659 ## src/main/java/org/apache/commons/jxpath/ClassFunctions.java: ## @@ -91,6 +92,13 @@ public Function getFunction( final String namespace, final Stri

[GitHub] [commons-jxpath] garydgregory commented on a diff in pull request #26: Fix CVE-2022-41852

2022-10-19 Thread GitBox
garydgregory commented on code in PR #26: URL: https://github.com/apache/commons-jxpath/pull/26#discussion_r999895278 ## src/test/java/org/apache/commons/jxpath/ri/compiler/ExtensionFunctionTest.java: ## @@ -60,9 +59,9 @@ public void setUp() { lib.addFunctions(new C

[GitHub] [commons-jxpath] kyakdan commented on a diff in pull request #26: Fix CVE-2022-41852

2022-10-19 Thread GitBox
kyakdan commented on code in PR #26: URL: https://github.com/apache/commons-jxpath/pull/26#discussion_r999887762 ## src/main/java/org/apache/commons/jxpath/ri/JXPathFilter.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[GitHub] [commons-email] dependabot[bot] closed pull request #104: Bump ossf/scorecard-action from 1.1.2 to 2.0.5

2022-10-19 Thread GitBox
dependabot[bot] closed pull request #104: Bump ossf/scorecard-action from 1.1.2 to 2.0.5 URL: https://github.com/apache/commons-email/pull/104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [commons-email] dependabot[bot] commented on pull request #104: Bump ossf/scorecard-action from 1.1.2 to 2.0.5

2022-10-19 Thread GitBox
dependabot[bot] commented on PR #104: URL: https://github.com/apache/commons-email/pull/104#issuecomment-1284512210 Superseded by #105. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [commons-email] dependabot[bot] opened a new pull request, #105: Bump ossf/scorecard-action from 1.1.2 to 2.0.6

2022-10-19 Thread GitBox
dependabot[bot] opened a new pull request, #105: URL: https://github.com/apache/commons-email/pull/105 Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 1.1.2 to 2.0.6. Release notes Sourced from https://github.com/ossf/scorecard-action/releases";>ossf/sc

[GitHub] [commons-validator] nhojpatrick closed pull request #45: JUnit assertThrows

2022-10-19 Thread GitBox
nhojpatrick closed pull request #45: JUnit assertThrows URL: https://github.com/apache/commons-validator/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [commons-validator] nhojpatrick commented on pull request #45: JUnit assertThrows

2022-10-19 Thread GitBox
nhojpatrick commented on PR #45: URL: https://github.com/apache/commons-validator/pull/45#issuecomment-1284507552 @garydgregory breaking it out into separate pr's, as i keep needing to rebase and often face merge issues, so easier if 1 pr per test. then it might be easier to get them review

[GitHub] [commons-validator] nhojpatrick opened a new pull request, #95: JUnit5 assertThrows UrlValidatorTest

2022-10-19 Thread GitBox
nhojpatrick opened a new pull request, #95: URL: https://github.com/apache/commons-validator/pull/95 Breaking out https://github.com/apache/commons-validator/pull/45 into separate pr's are it's hard to keep rebase these old changed. -- This is an automated message from the Apache Git Serv

[GitHub] [commons-validator] nhojpatrick opened a new pull request, #94: JUnit5 assertThrows IBANValidatorTest

2022-10-19 Thread GitBox
nhojpatrick opened a new pull request, #94: URL: https://github.com/apache/commons-validator/pull/94 Breaking out https://github.com/apache/commons-validator/pull/45 into separate pr's are it's hard to keep rebase these old changed. -- This is an automated message from the Apache Git Serv

[GitHub] [commons-validator] nhojpatrick opened a new pull request, #93: JUnit5 assertThrows EmailValidatorTest

2022-10-19 Thread GitBox
nhojpatrick opened a new pull request, #93: URL: https://github.com/apache/commons-validator/pull/93 Breaking out https://github.com/apache/commons-validator/pull/45 into separate pr's are it's hard to keep rebase these old changed. -- This is an automated message from the Apache Git Serv

[GitHub] [commons-validator] nhojpatrick opened a new pull request, #92: JUnit5 assertThrows DomainValidatorStartupTest

2022-10-19 Thread GitBox
nhojpatrick opened a new pull request, #92: URL: https://github.com/apache/commons-validator/pull/92 Breaking out https://github.com/apache/commons-validator/pull/45 into separate pr's are it's hard to keep rebase these old changed. -- This is an automated message from the Apache Git Serv

[GitHub] [commons-jxpath] Warxim commented on a diff in pull request #26: Fix CVE-2022-41852

2022-10-19 Thread GitBox
Warxim commented on code in PR #26: URL: https://github.com/apache/commons-jxpath/pull/26#discussion_r999879987 ## src/main/java/org/apache/commons/jxpath/ri/JXPathFilter.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * con

[GitHub] [commons-jxpath] kyakdan commented on pull request #26: Fix CVE-2022-41852

2022-10-19 Thread GitBox
kyakdan commented on PR #26: URL: https://github.com/apache/commons-jxpath/pull/26#issuecomment-1284500165 @madrob @garydgregory Thanks for the review. @garydgregory I've rebased again and the PR does not contain changes to pom.xml or changes.xml now. -- This is an automated messa

[GitHub] [commons-jxpath] kyakdan commented on a diff in pull request #26: Fix CVE-2022-41852

2022-10-19 Thread GitBox
kyakdan commented on code in PR #26: URL: https://github.com/apache/commons-jxpath/pull/26#discussion_r999615893 ## src/main/java/org/apache/commons/jxpath/ri/JXPathFilter.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[jira] [Work logged] (CSV-302) CSVFormat.duplicateHeaderMode requires default for backward compatibility

2022-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CSV-302?focusedWorklogId=818588&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-818588 ] ASF GitHub Bot logged work on CSV-302: -- Author: ASF GitHub Bot

[GitHub] [commons-csv] garydgregory commented on a diff in pull request #276: [CSV-302] CSVFormat.duplicateHeaderMode requires default DISALLOW, fix deserialization of v1.9.0 CSVFormat objects

2022-10-19 Thread GitBox
garydgregory commented on code in PR #276: URL: https://github.com/apache/commons-csv/pull/276#discussion_r999872386 ## src/main/java/org/apache/commons/csv/CSVFormat.java: ## @@ -2280,6 +2279,27 @@ private void validate() throws IllegalArgumentException { } } +

[jira] [Work logged] (CSV-302) CSVFormat.duplicateHeaderMode requires default for backward compatibility

2022-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CSV-302?focusedWorklogId=818584&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-818584 ] ASF GitHub Bot logged work on CSV-302: -- Author: ASF GitHub Bot

[GitHub] [commons-csv] garydgregory commented on a diff in pull request #276: [CSV-302] CSVFormat.duplicateHeaderMode requires default DISALLOW, fix deserialization of v1.9.0 CSVFormat objects

2022-10-19 Thread GitBox
garydgregory commented on code in PR #276: URL: https://github.com/apache/commons-csv/pull/276#discussion_r999860555 ## src/main/java/org/apache/commons/csv/CSVFormat.java: ## @@ -2280,6 +2279,27 @@ private void validate() throws IllegalArgumentException { } } +

[GitHub] [commons-ognl] dependabot[bot] closed pull request #93: Bump ossf/scorecard-action from 1.1.2 to 2.0.5

2022-10-19 Thread GitBox
dependabot[bot] closed pull request #93: Bump ossf/scorecard-action from 1.1.2 to 2.0.5 URL: https://github.com/apache/commons-ognl/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [commons-ognl] dependabot[bot] commented on pull request #93: Bump ossf/scorecard-action from 1.1.2 to 2.0.5

2022-10-19 Thread GitBox
dependabot[bot] commented on PR #93: URL: https://github.com/apache/commons-ognl/pull/93#issuecomment-1284453080 Superseded by #94. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [commons-ognl] dependabot[bot] opened a new pull request, #94: Bump ossf/scorecard-action from 1.1.2 to 2.0.6

2022-10-19 Thread GitBox
dependabot[bot] opened a new pull request, #94: URL: https://github.com/apache/commons-ognl/pull/94 Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 1.1.2 to 2.0.6. Release notes Sourced from https://github.com/ossf/scorecard-action/releases";>ossf/score

[jira] [Work logged] (CSV-302) CSVFormat.duplicateHeaderMode requires default for backward compatibility

2022-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CSV-302?focusedWorklogId=818578&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-818578 ] ASF GitHub Bot logged work on CSV-302: -- Author: ASF GitHub Bot

[GitHub] [commons-csv] sman-81 commented on pull request #276: [CSV-302] CSVFormat.duplicateHeaderMode requires default DISALLOW, fix deserialization of v1.9.0 CSVFormat objects

2022-10-19 Thread GitBox
sman-81 commented on PR #276: URL: https://github.com/apache/commons-csv/pull/276#issuecomment-1284441177 Thanks for your feedback, @garydgregory Changes implemented, please re-review. TY! -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Work logged] (CSV-302) CSVFormat.duplicateHeaderMode requires default for backward compatibility

2022-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CSV-302?focusedWorklogId=818576&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-818576 ] ASF GitHub Bot logged work on CSV-302: -- Author: ASF GitHub Bot

[jira] [Work logged] (CSV-302) CSVFormat.duplicateHeaderMode requires default for backward compatibility

2022-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CSV-302?focusedWorklogId=818577&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-818577 ] ASF GitHub Bot logged work on CSV-302: -- Author: ASF GitHub Bot

[GitHub] [commons-csv] codecov-commenter commented on pull request #276: [CSV-302] CSVFormat.duplicateHeaderMode requires default DISALLOW, fix deserialization of v1.9.0 CSVFormat objects

2022-10-19 Thread GitBox
codecov-commenter commented on PR #276: URL: https://github.com/apache/commons-csv/pull/276#issuecomment-1284439699 # [Codecov](https://codecov.io/gh/apache/commons-csv/pull/276?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apach

[GitHub] [commons-csv] sman-81 commented on a diff in pull request #276: [CSV-302] CSVFormat.duplicateHeaderMode requires default DISALLOW, fix deserialization of v1.9.0 CSVFormat objects

2022-10-19 Thread GitBox
sman-81 commented on code in PR #276: URL: https://github.com/apache/commons-csv/pull/276#discussion_r999828857 ## src/test/java/org/apache/commons/csv/CSVFormatSerializationTest.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Work logged] (CSV-302) CSVFormat.duplicateHeaderMode requires default for backward compatibility

2022-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CSV-302?focusedWorklogId=818575&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-818575 ] ASF GitHub Bot logged work on CSV-302: -- Author: ASF GitHub Bot

[GitHub] [commons-csv] sman-81 commented on a diff in pull request #276: [CSV-302] CSVFormat.duplicateHeaderMode requires default DISALLOW, fix deserialization of v1.9.0 CSVFormat objects

2022-10-19 Thread GitBox
sman-81 commented on code in PR #276: URL: https://github.com/apache/commons-csv/pull/276#discussion_r999826904 ## src/main/java/org/apache/commons/csv/CSVFormat.java: ## @@ -2280,6 +2279,27 @@ private void validate() throws IllegalArgumentException { } } +pr

[GitHub] [commons-digester] nhojpatrick closed pull request #7: JUnit assertThrows

2022-10-19 Thread GitBox
nhojpatrick closed pull request #7: JUnit assertThrows URL: https://github.com/apache/commons-digester/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [commons-digester] nhojpatrick commented on pull request #7: JUnit assertThrows

2022-10-19 Thread GitBox
nhojpatrick commented on PR #7: URL: https://github.com/apache/commons-digester/pull/7#issuecomment-1284426626 Splitting into separate PR as if this takes ages to get merged it's easier to rebase. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [commons-proxy] nhojpatrick closed pull request #7: Junit5 assert throws

2022-10-19 Thread GitBox
nhojpatrick closed pull request #7: Junit5 assert throws URL: https://github.com/apache/commons-proxy/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [commons-proxy] nhojpatrick commented on pull request #7: Junit5 assert throws

2022-10-19 Thread GitBox
nhojpatrick commented on PR #7: URL: https://github.com/apache/commons-proxy/pull/7#issuecomment-1284415898 Splitting into separate PR so easier to re-merge if takes long time to get merged -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [commons-proxy] nhojpatrick opened a new pull request, #16: JUnit5 assertThrows AbstractSubclassingProxyFactoryTestCase

2022-10-19 Thread GitBox
nhojpatrick opened a new pull request, #16: URL: https://github.com/apache/commons-proxy/pull/16 Convert all legacy junit v4 exception checking to junit v5 assertThrows. Test not run locally due to this error in master. ``` % mvn clean install [INFO] Scanning for projects...

[GitHub] [commons-proxy] nhojpatrick opened a new pull request, #15: JUnit5 assertThrows AbstractProxyFactoryTestCase

2022-10-19 Thread GitBox
nhojpatrick opened a new pull request, #15: URL: https://github.com/apache/commons-proxy/pull/15 Convert all legacy junit v4 exception checking to junit v5 assertThrows. Test not run locally due to this error in master. ``` % mvn clean install [INFO] Scanning for projects...

[GitHub] [commons-proxy] nhojpatrick opened a new pull request, #14: JUnit5 assertThrows BeanProviderTest

2022-10-19 Thread GitBox
nhojpatrick opened a new pull request, #14: URL: https://github.com/apache/commons-proxy/pull/14 Convert all legacy junit v4 exception checking to junit v5 assertThrows. Test not run locally due to this error in master. ``` % mvn clean install [INFO] Scanning for projects...

[GitHub] [commons-proxy] nhojpatrick opened a new pull request, #13: JUnit5 assertThrows CloningProviderTest

2022-10-19 Thread GitBox
nhojpatrick opened a new pull request, #13: URL: https://github.com/apache/commons-proxy/pull/13 Convert all legacy junit v4 exception checking to junit v5 assertThrows. Test not run locally due to this error in master. ``` % mvn clean install [INFO] Scanning for projects...

[GitHub] [commons-proxy] nhojpatrick opened a new pull request, #12: JUnit5 assertThrows InterceptorUtilsTest

2022-10-19 Thread GitBox
nhojpatrick opened a new pull request, #12: URL: https://github.com/apache/commons-proxy/pull/12 Convert all legacy junit v4 exception checking to junit v5 assertThrows. Test not run locally due to this error in master. ``` % mvn clean install [INFO] Scanning for projects...

[GitHub] [commons-proxy] nhojpatrick opened a new pull request, #11: JUnit5 assertThrows ObjectProviderInterceptorTest

2022-10-19 Thread GitBox
nhojpatrick opened a new pull request, #11: URL: https://github.com/apache/commons-proxy/pull/11 Convert all legacy junit v4 exception checking to junit v5 assertThrows. Test not run locally due to this error in master. ``` % mvn clean install [INFO] Scanning for projects...

[GitHub] [commons-proxy] nhojpatrick opened a new pull request, #10: Junit5 assertThrows SerializationProxyTest

2022-10-19 Thread GitBox
nhojpatrick opened a new pull request, #10: URL: https://github.com/apache/commons-proxy/pull/10 Convert all legacy junit v4 exception checking to junit v5 assertThrows. Test not run locally due to this error in master. ``` % mvn clean install [INFO] Scanning for projects...

[GitHub] [commons-proxy] nhojpatrick opened a new pull request, #9: Junit5 assertThrows AnnotationBuilderTest

2022-10-19 Thread GitBox
nhojpatrick opened a new pull request, #9: URL: https://github.com/apache/commons-proxy/pull/9 Convert all legacy junit v4 exception checking to junit v5 assertThrows. Test not run locally due to this error in master. ``` % mvn clean install [INFO] Scanning for projects...

[GitHub] [commons-proxy] nhojpatrick opened a new pull request, #8: Junit5 assertThrows AbstractStubTestCase

2022-10-19 Thread GitBox
nhojpatrick opened a new pull request, #8: URL: https://github.com/apache/commons-proxy/pull/8 Convert all legacy junit v4 exception checking to junit v5 assertThrows. Test not run locally due to this error in master. ``` % mvn clean install [INFO] Scanning for projects...

[GitHub] [commons-fileupload] dependabot[bot] closed pull request #176: Bump ossf/scorecard-action from 2.0.4 to 2.0.5

2022-10-19 Thread GitBox
dependabot[bot] closed pull request #176: Bump ossf/scorecard-action from 2.0.4 to 2.0.5 URL: https://github.com/apache/commons-fileupload/pull/176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [commons-fileupload] dependabot[bot] commented on pull request #176: Bump ossf/scorecard-action from 2.0.4 to 2.0.5

2022-10-19 Thread GitBox
dependabot[bot] commented on PR #176: URL: https://github.com/apache/commons-fileupload/pull/176#issuecomment-1284388303 Superseded by #177. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [commons-fileupload] dependabot[bot] opened a new pull request, #177: Bump ossf/scorecard-action from 2.0.4 to 2.0.6

2022-10-19 Thread GitBox
dependabot[bot] opened a new pull request, #177: URL: https://github.com/apache/commons-fileupload/pull/177 Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.0.4 to 2.0.6. Release notes Sourced from https://github.com/ossf/scorecard-action/releases";>os

[GitHub] [commons-exec] dependabot[bot] opened a new pull request, #71: Bump ossf/scorecard-action from 1.1.2 to 2.0.6

2022-10-19 Thread GitBox
dependabot[bot] opened a new pull request, #71: URL: https://github.com/apache/commons-exec/pull/71 Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 1.1.2 to 2.0.6. Release notes Sourced from https://github.com/ossf/scorecard-action/releases";>ossf/score

[jira] [Work logged] (CSV-302) CSVFormat.duplicateHeaderMode requires default for backward compatibility

2022-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CSV-302?focusedWorklogId=818531&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-818531 ] ASF GitHub Bot logged work on CSV-302: -- Author: ASF GitHub Bot

[GitHub] [commons-csv] garydgregory commented on a diff in pull request #276: [CSV-302] CSVFormat.duplicateHeaderMode requires default DISALLOW, fix deserialization of v1.9.0 CSVFormat objects

2022-10-19 Thread GitBox
garydgregory commented on code in PR #276: URL: https://github.com/apache/commons-csv/pull/276#discussion_r999720402 ## src/main/java/org/apache/commons/csv/CSVFormat.java: ## @@ -2280,6 +2279,27 @@ private void validate() throws IllegalArgumentException { } } +

[GitHub] [commons-pool] garydgregory commented on pull request #182: Avoid potential ConcurrentModificationException by using Iterator.

2022-10-19 Thread GitBox
garydgregory commented on PR #182: URL: https://github.com/apache/commons-pool/pull/182#issuecomment-1284297988 Then this PR won't make it because: - You cannot prove anything is wrong - You have not addressed my comment on why the locking already provided through synchronized blocks a

[GitHub] [commons-configuration] garydgregory commented on pull request #230: Add more detailed statement around CVE-2022-33980

2022-10-19 Thread GitBox
garydgregory commented on PR #230: URL: https://github.com/apache/commons-configuration/pull/230#issuecomment-1284285755 TY @raboof 👍 💯 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [commons-configuration] garydgregory merged pull request #230: Add more detailed statement around CVE-2022-33980

2022-10-19 Thread GitBox
garydgregory merged PR #230: URL: https://github.com/apache/commons-configuration/pull/230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[jira] [Work logged] (COLLECTIONS-799) UnmodifiableNavigableSet can be modified by pollFirst() and pollLast()

2022-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-799?focusedWorklogId=818489&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-818489 ] ASF GitHub Bot logged work on COLLECTIONS-799: -- Author: ASF

[GitHub] [commons-collections] scordio commented on pull request #250: COLLECTIONS-799 - Prevent modifications of `UnmodifiableNavigableSet`

2022-10-19 Thread GitBox
scordio commented on PR #250: URL: https://github.com/apache/commons-collections/pull/250#issuecomment-1284114178 @garydgregory hope you can get unstuck from that weekend soon! (just a joke, of course, inspired by https://github.com/gkoberger/stacksort/pull/4#issuecomment-747656340 🙂 )

[GitHub] [commons-pool] aooohan commented on pull request #182: Avoid potential ConcurrentModificationException by using Iterator.

2022-10-19 Thread GitBox
aooohan commented on PR #182: URL: https://github.com/apache/commons-pool/pull/182#issuecomment-1284072077 > We can wait until you update this PR with a failing test. It is somewhat difficult to verify this through unit tests, as there is nothing to assert and I think it is just a usage

[GitHub] [commons-pool] garydgregory commented on pull request #182: Avoid potential ConcurrentModificationException by using Iterator.

2022-10-19 Thread GitBox
garydgregory commented on PR #182: URL: https://github.com/apache/commons-pool/pull/182#issuecomment-1284043771 Hi @aooohan Thank you for the update. We can wait until you update this PR with a failing test. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [commons-pool] aooohan commented on pull request #182: Avoid potential ConcurrentModificationException by using Iterator.

2022-10-19 Thread GitBox
aooohan commented on PR #182: URL: https://github.com/apache/commons-pool/pull/182#issuecomment-1283987610 Hi @garydgregory Sorry for the late reply. The following is unit test. ```java try (final GenericObjectPool pool = new GenericObjectPool<>(new BasePooledObj

[GitHub] [commons-collections] marcwrobel commented on pull request #323: (chore) Fix minor typos

2022-10-19 Thread GitBox
marcwrobel commented on PR #323: URL: https://github.com/apache/commons-collections/pull/323#issuecomment-1283924410 I resolved a conflict and rolled back the changes in files that were also changed in #335 (only two typos were rolled back). The two PRs should not conflict with each other.

[GitHub] [commons-collections] garydgregory commented on pull request #323: (chore) Fix minor typos

2022-10-19 Thread GitBox
garydgregory commented on PR #323: URL: https://github.com/apache/commons-collections/pull/323#issuecomment-1283890565 That might be worse, it's just the same to review but spread out ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [commons-collections] marcwrobel commented on pull request #323: (chore) Fix minor typos

2022-10-19 Thread GitBox
marcwrobel commented on PR #323: URL: https://github.com/apache/commons-collections/pull/323#issuecomment-1283880403 @garydgregory, will it help you if I split this PR into multiple smaller PRs ? -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [commons-jxpath] garydgregory commented on a diff in pull request #26: Fix CVE-2022-41852

2022-10-19 Thread GitBox
garydgregory commented on code in PR #26: URL: https://github.com/apache/commons-jxpath/pull/26#discussion_r999316059 ## src/main/java/org/apache/commons/jxpath/Functions.java: ## @@ -43,4 +45,15 @@ public interface Functions { * @return Function */ Function get

[GitHub] [commons-jxpath] garydgregory commented on a diff in pull request #26: Fix CVE-2022-41852

2022-10-19 Thread GitBox
garydgregory commented on code in PR #26: URL: https://github.com/apache/commons-jxpath/pull/26#discussion_r999316059 ## src/main/java/org/apache/commons/jxpath/Functions.java: ## @@ -43,4 +45,15 @@ public interface Functions { * @return Function */ Function get

[GitHub] [commons-jxpath] garydgregory commented on pull request #26: Fix CVE-2022-41852

2022-10-19 Thread GitBox
garydgregory commented on PR #26: URL: https://github.com/apache/commons-jxpath/pull/26#issuecomment-1283849870 @kyakdan I'm not sure what happened on your rebase but you should not have to edit pom.xml or changes.xml. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [commons-jxpath] garydgregory commented on a diff in pull request #26: Fix CVE-2022-41852

2022-10-19 Thread GitBox
garydgregory commented on code in PR #26: URL: https://github.com/apache/commons-jxpath/pull/26#discussion_r999300705 ## src/main/java/org/apache/commons/jxpath/ri/JXPathFilter.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[jira] [Updated] (CONFIGURATION-823) Update Apache Commons Text from 1.9 to 1.10.0

2022-10-19 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/CONFIGURATION-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated CONFIGURATION-823: - Summary: Update Apache Commons Text from 1.9 to 1.10.0 (was: Update Apache

[GitHub] [commons-jxpath] garydgregory commented on pull request #16: Performance fixes

2022-10-19 Thread GitBox
garydgregory commented on PR #16: URL: https://github.com/apache/commons-jxpath/pull/16#issuecomment-1283794434 Hi @bilisie There are changes in this PR that don't belong (pom.xml, download_jxpath.xml). Please rebase on git master too now that we have a GitHub Actions build. -- This

[GitHub] [commons-pool] garydgregory commented on pull request #182: Avoid potential ConcurrentModificationException by using Iterator.

2022-10-19 Thread GitBox
garydgregory commented on PR #182: URL: https://github.com/apache/commons-pool/pull/182#issuecomment-1283783719 Hi @aooohan You'll need a unit test to prove this is a problem because the code appears to provide all the locking needed through synchronized blocks and methods. -- This is

[GitHub] [commons-configuration] dependabot[bot] commented on pull request #222: Bump ossf/scorecard-action from 1.1.2 to 2.0.4

2022-10-19 Thread GitBox
dependabot[bot] commented on PR #222: URL: https://github.com/apache/commons-configuration/pull/222#issuecomment-1283771333 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [commons-configuration] garydgregory commented on pull request #222: Bump ossf/scorecard-action from 1.1.2 to 2.0.4

2022-10-19 Thread GitBox
garydgregory commented on PR #222: URL: https://github.com/apache/commons-configuration/pull/222#issuecomment-1283771284 Closing: Needs Apache Infra -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [commons-configuration] garydgregory closed pull request #222: Bump ossf/scorecard-action from 1.1.2 to 2.0.4

2022-10-19 Thread GitBox
garydgregory closed pull request #222: Bump ossf/scorecard-action from 1.1.2 to 2.0.4 URL: https://github.com/apache/commons-configuration/pull/222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Created] (CONFIGURATION-823) Update Apache Commons Text from 1.9 to 1.10.0.

2022-10-19 Thread MOREAU (Jira)
MOREAU created CONFIGURATION-823: Summary: Update Apache Commons Text from 1.9 to 1.10.0. Key: CONFIGURATION-823 URL: https://issues.apache.org/jira/browse/CONFIGURATION-823 Project: Commons Configurat

[GitHub] [commons-text] raboof closed pull request #374: Add statement about CVE-2022-42889 to frontpage

2022-10-19 Thread GitBox
raboof closed pull request #374: Add statement about CVE-2022-42889 to frontpage URL: https://github.com/apache/commons-text/pull/374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

  1   2   >