[GitHub] [commons-bcel] KengoTODA commented on pull request #157: Keep ConstantPool.getConstant(int) backward compatible with v6.5.0

2022-11-15 Thread GitBox
KengoTODA commented on PR #157: URL: https://github.com/apache/commons-bcel/pull/157#issuecomment-1316097489 Wmm, I don't think so. This PR affects nothing related to iterating data in the class file, nor writing bytecode to class files... BCEL 6.6.1 has no other big changes,

[GitHub] [commons-collections] aherbert commented on a diff in pull request #358: Collections-817: Reworked calculations and updated javadoc for estimateN(), estimateIntersection() and estimateUnion()

2022-11-15 Thread GitBox
aherbert commented on code in PR #358: URL: https://github.com/apache/commons-collections/pull/358#discussion_r1023145652 ## src/main/java/org/apache/commons/collections4/bloomfilter/SimpleBloomFilter.java: ## @@ -114,10 +114,6 @@ public boolean merge(final BitMapProducer

[GitHub] [commons-bcel] garydgregory commented on pull request #157: Keep ConstantPool.getConstant(int) backward compatible with v6.5.0

2022-11-15 Thread GitBox
garydgregory commented on PR #157: URL: https://github.com/apache/commons-bcel/pull/157#issuecomment-1315765265 Hello @KengoTODA Would you be able to give an opinion on whether this PR is related to a regression we are seeing in Xalan? The (long) thread:

[GitHub] [commons-collections] aherbert merged pull request #360: Fix flaky test in CollectionUtilsTest.Java

2022-11-15 Thread GitBox
aherbert merged PR #360: URL: https://github.com/apache/commons-collections/pull/360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Work logged] (COMMONSSITE-145) upgrade checkstyle in several commons repos

2022-11-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COMMONSSITE-145?focusedWorklogId=826246=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-826246 ] ASF GitHub Bot logged work on COMMONSSITE-145: -- Author: ASF

[jira] [Work logged] (COMMONSSITE-145) upgrade checkstyle in several commons repos

2022-11-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COMMONSSITE-145?focusedWorklogId=826247=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-826247 ] ASF GitHub Bot logged work on COMMONSSITE-145: -- Author: ASF

[GitHub] [commons-dbutils] XenoAmess opened a new pull request, #68: [COMMONSSITE-145]upgrade checkstyle

2022-11-15 Thread GitBox
XenoAmess opened a new pull request, #68: URL: https://github.com/apache/commons-dbutils/pull/68 https://issues.apache.org/jira/browse/COMMONSSITE-145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [commons-dbutils] thecarlhall commented on pull request #68: [COMMONSSITE-145]upgrade checkstyle

2022-11-15 Thread GitBox
thecarlhall commented on PR #68: URL: https://github.com/apache/commons-dbutils/pull/68#issuecomment-1315675852 Ahh, thanks for the call out about scope changing. Would you please update the PR without the checkstyle version change? -- This is an automated message from the Apache Git

[jira] [Commented] (DAEMON-449) Prunsrv fails to stop Open Liberty Windows service

2022-11-15 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/DAEMON-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634439#comment-17634439 ] Gary D. Gregory commented on DAEMON-449: Hi All, What would be a better log event message to

[jira] [Work logged] (COMMONSSITE-145) upgrade checkstyle in several commons repos

2022-11-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COMMONSSITE-145?focusedWorklogId=826181=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-826181 ] ASF GitHub Bot logged work on COMMONSSITE-145: -- Author: ASF

[GitHub] [commons-dbutils] XenoAmess commented on pull request #68: [COMMONSSITE-145]upgrade checkstyle

2022-11-15 Thread GitBox
XenoAmess commented on PR #68: URL: https://github.com/apache/commons-dbutils/pull/68#issuecomment-1315501022 @thecarlhall it WAS the latest version 1.5 years ago. This is a 1.5 years unhandled pr, so as that jira ticket. Glad it be solved in other pr though. And there is never such

[jira] [Commented] (DAEMON-449) Prunsrv fails to stop Open Liberty Windows service

2022-11-15 Thread Mark Thomas (Jira)
[ https://issues.apache.org/jira/browse/DAEMON-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634413#comment-17634413 ] Mark Thomas commented on DAEMON-449: I think you are mis-reading the logs. The line [2022-11-14

[jira] [Comment Edited] (DAEMON-449) Prunsrv fails to stop Open Liberty Windows service

2022-11-15 Thread Jim Blye (Jira)
[ https://issues.apache.org/jira/browse/DAEMON-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634389#comment-17634389 ] Jim Blye edited comment on DAEMON-449 at 11/15/22 2:43 PM: --- [~markt] , the root

[jira] [Commented] (DAEMON-449) Prunsrv fails to stop Open Liberty Windows service

2022-11-15 Thread Jim Blye (Jira)
[ https://issues.apache.org/jira/browse/DAEMON-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634389#comment-17634389 ] Jim Blye commented on DAEMON-449: - [~markt] , the root cause actually seems to be happening on *start*

[jira] [Work logged] (COMMONSSITE-145) upgrade checkstyle in several commons repos

2022-11-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COMMONSSITE-145?focusedWorklogId=826142=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-826142 ] ASF GitHub Bot logged work on COMMONSSITE-145: -- Author: ASF

[jira] [Work logged] (COMMONSSITE-145) upgrade checkstyle in several commons repos

2022-11-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COMMONSSITE-145?focusedWorklogId=826143=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-826143 ] ASF GitHub Bot logged work on COMMONSSITE-145: -- Author: ASF

[GitHub] [commons-dbutils] thecarlhall closed pull request #68: [COMMONSSITE-145]upgrade checkstyle

2022-11-15 Thread GitBox
thecarlhall closed pull request #68: [COMMONSSITE-145]upgrade checkstyle URL: https://github.com/apache/commons-dbutils/pull/68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [commons-dbutils] thecarlhall commented on pull request #68: [COMMONSSITE-145]upgrade checkstyle

2022-11-15 Thread GitBox
thecarlhall commented on PR #68: URL: https://github.com/apache/commons-dbutils/pull/68#issuecomment-1315338939 Closing as dependency upgrades for things like checkstyle are handled by a bot, and this particular version is woefully out of date this point. -- This is an automated message

[GitHub] [commons-dbutils] thecarlhall closed pull request #63: Minor Improvements:

2022-11-15 Thread GitBox
thecarlhall closed pull request #63: Minor Improvements: URL: https://github.com/apache/commons-dbutils/pull/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [commons-dbutils] thecarlhall commented on pull request #63: Minor Improvements:

2022-11-15 Thread GitBox
thecarlhall commented on PR #63: URL: https://github.com/apache/commons-dbutils/pull/63#issuecomment-1315338071 Closing as these changes don't make a material difference or improve the code in a functional way. Many of the variables changes are explicitly setting the default value.

[GitHub] [commons-text] garydgregory commented on pull request #386: Dependabot/maven/com.GitHub.spotbugs spotbugs maven plugin 4.5.0.0

2022-11-15 Thread GitBox
garydgregory commented on PR #386: URL: https://github.com/apache/commons-text/pull/386#issuecomment-1315183243 Notify infra? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [commons-jexl] henrib merged pull request #141: Bump spotbugs-maven-plugin from 4.7.2.1 to 4.7.3.0

2022-11-15 Thread GitBox
henrib merged PR #141: URL: https://github.com/apache/commons-jexl/pull/141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-text] kinow commented on pull request #386: Dependabot/maven/com.GitHub.spotbugs spotbugs maven plugin 4.5.0.0

2022-11-15 Thread GitBox
kinow commented on PR #386: URL: https://github.com/apache/commons-text/pull/386#issuecomment-1314976589 This is spam. Alas only users with access to settings can report/ban users spamming. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [commons-text] kinow closed pull request #386: Dependabot/maven/com.GitHub.spotbugs spotbugs maven plugin 4.5.0.0

2022-11-15 Thread GitBox
kinow closed pull request #386: Dependabot/maven/com.GitHub.spotbugs spotbugs maven plugin 4.5.0.0 URL: https://github.com/apache/commons-text/pull/386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go