[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #180: verifier tests on various opcodes

2023-04-07 Thread via GitHub
garydgregory commented on code in PR #180: URL: https://github.com/apache/commons-bcel/pull/180#discussion_r1161025515 ## src/test/java/org/apache/bcel/verifier/tests/JvmOpCodes.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [commons-bcel] garydgregory commented on pull request #182: added signature test cases for class/method, and bad signatures

2023-04-07 Thread via GitHub
garydgregory commented on PR #182: URL: https://github.com/apache/commons-bcel/pull/182#issuecomment-1500723106 This PR has no description, why is it needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [commons-bcel] garydgregory commented on pull request #183: added accessors to model and unit tests, javadoc comments

2023-04-07 Thread via GitHub
garydgregory commented on PR #183: URL: https://github.com/apache/commons-bcel/pull/183#issuecomment-1500723033 This PR has no description, why is it needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [commons-bcel] garydgregory commented on pull request #185: added org.apache.bcel.classfile.FieldOrMethod.getDeclaringClassName()

2023-04-07 Thread via GitHub
garydgregory commented on PR #185: URL: https://github.com/apache/commons-bcel/pull/185#issuecomment-1500722604 This PR has no description, why is it needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [commons-bcel] garydgregory merged pull request #186: updated Class2HTMLTestCase with new test input Java4Example

2023-04-07 Thread via GitHub
garydgregory merged PR #186: URL: https://github.com/apache/commons-bcel/pull/186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@com

[GitHub] [commons-cli] dhruvdk7 commented on pull request #173: Assignment

2023-04-07 Thread via GitHub
dhruvdk7 commented on PR #173: URL: https://github.com/apache/commons-cli/pull/173#issuecomment-1500554338 Hey there.Sorry for the inconvenience There were design smells in the code. I identified 3 implementation smells and 2 design smell. For the move method Refractoring I have

[GitHub] [commons-jci] garydgregory merged pull request #28: Bump taglist-maven-plugin from 2.2 to 3.0.0

2023-04-07 Thread via GitHub
garydgregory merged PR #28: URL: https://github.com/apache/commons-jci/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@common

[GitHub] [commons-jci] garydgregory merged pull request #29: Bump commons-cli from 1.2 to 1.5.0

2023-04-07 Thread via GitHub
garydgregory merged PR #29: URL: https://github.com/apache/commons-jci/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@common

[jira] [Commented] (VFS-835) Severe Performance Issue - FileObject.copyFrom()

2023-04-07 Thread Bernd Eckenfels (Jira)
[ https://issues.apache.org/jira/browse/VFS-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709745#comment-17709745 ] Bernd Eckenfels commented on VFS-835: - Do native sftp clients have roughly the same spee

[GitHub] [commons-jci] garydgregory merged pull request #34: Bump asm from 9.4 to 9.5

2023-04-07 Thread via GitHub
garydgregory merged PR #34: URL: https://github.com/apache/commons-jci/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@common

[jira] [Resolved] (COMPRESS-581) Make getLocalHeaderOffset() public

2023-04-07 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved COMPRESS-581. -- Fix Version/s: 1.23.1 Resolution: Fixed > Make getLocalHeaderOffset() public >

[jira] [Commented] (NET-718) "Unsupported or unrecognized SSL message" for FTPS via proxy

2023-04-07 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/NET-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709740#comment-17709740 ] Gary D. Gregory commented on NET-718: - If a test like this one is to be brought in, it n

[jira] [Commented] (VFS-835) Severe Performance Issue - FileObject.copyFrom()

2023-04-07 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/VFS-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709739#comment-17709739 ] Gary D. Gregory commented on VFS-835: - You'll have to step into the code with a debugger

[jira] [Commented] (VFS-835) Severe Performance Issue - FileObject.copyFrom()

2023-04-07 Thread Mahesh (Jira)
[ https://issues.apache.org/jira/browse/VFS-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709733#comment-17709733 ] Mahesh commented on VFS-835: Please let us know if any way we can add trace or debug to *copyFro

[jira] [Comment Edited] (VFS-835) Severe Performance Issue - FileObject.copyFrom()

2023-04-07 Thread Mahesh (Jira)
[ https://issues.apache.org/jira/browse/VFS-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709710#comment-17709710 ] Mahesh edited comment on VFS-835 at 4/7/23 4:17 PM: Thank you Gary, we h

[GitHub] [commons-vfs] garydgregory merged pull request #390: Bump jackrabbit2.version from 2.21.15 to 2.21.16

2023-04-07 Thread via GitHub
garydgregory merged PR #390: URL: https://github.com/apache/commons-vfs/pull/390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@comm

[jira] [Commented] (VFS-835) Severe Performance Issue - FileObject.copyFrom()

2023-04-07 Thread Mahesh (Jira)
[ https://issues.apache.org/jira/browse/VFS-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709710#comment-17709710 ] Mahesh commented on VFS-835: Thank you Gary, we have started facing this issue after enabling en

[jira] [Commented] (VFS-835) Severe Performance Issue - FileObject.copyFrom()

2023-04-07 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/VFS-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709706#comment-17709706 ] Gary D. Gregory commented on VFS-835: - How do you expect any help when you provide no in

[GitHub] [commons-validator] ashoknan2 commented on pull request #129: ISINValidator. Added additional exception country code

2023-04-07 Thread via GitHub
ashoknan2 commented on PR #129: URL: https://github.com/apache/commons-validator/pull/129#issuecomment-1500356821 Added the test case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (DAEMON-457) Tomcat9.exe crash in windows server 2016 and 2019 while updating service.

2023-04-07 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/DAEMON-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709704#comment-17709704 ] Gary D. Gregory commented on DAEMON-457: Are you reporting against 1.3.2 or 1.3.3

[GitHub] [commons-scxml] garydgregory merged pull request #120: Bump actions/setup-java from 3.10.0 to 3.11.0

2023-04-07 Thread via GitHub
garydgregory merged PR #120: URL: https://github.com/apache/commons-scxml/pull/120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@co

[GitHub] [commons-scxml] garydgregory merged pull request #117: Bump Saxon-HE from 12.0 to 12.1

2023-04-07 Thread via GitHub
garydgregory merged PR #117: URL: https://github.com/apache/commons-scxml/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@co

[GitHub] [commons-scxml] garydgregory merged pull request #122: Bump groovy from 3.0.16 to 3.0.17

2023-04-07 Thread via GitHub
garydgregory merged PR #122: URL: https://github.com/apache/commons-scxml/pull/122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@co

[GitHub] [commons-cli] garydgregory commented on pull request #143: Change method visibility

2023-04-07 Thread via GitHub
garydgregory commented on PR #143: URL: https://github.com/apache/commons-cli/pull/143#issuecomment-1500342942 @chingjustwe ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [commons-cli] garydgregory commented on pull request #173: Assignment

2023-04-07 Thread via GitHub
garydgregory commented on PR #173: URL: https://github.com/apache/commons-cli/pull/173#issuecomment-1500342451 @dhruvdk7 This PR has no description and its title is meaningless. What are you trying to do? -- This is an automated message from the Apache Git Service. To respond to the m

[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

2023-04-07 Thread Andreas Goss (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709694#comment-17709694 ] Andreas Goss commented on GEOMETRY-144: --- While adjusting the code for the 2D case

[GitHub] [commons-parent] garydgregory merged pull request #251: Bump animal-sniffer-maven-plugin from 1.22 to 1.23

2023-04-07 Thread via GitHub
garydgregory merged PR #251: URL: https://github.com/apache/commons-parent/pull/251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@c

[GitHub] [commons-parent] garydgregory merged pull request #253: Bump cyclonedx-maven-plugin from 2.7.5 to 2.7.6

2023-04-07 Thread via GitHub
garydgregory merged PR #253: URL: https://github.com/apache/commons-parent/pull/253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@c

[GitHub] [commons-parent] garydgregory merged pull request #254: Bump spotbugs-maven-plugin from 4.7.3.3 to 4.7.3.4

2023-04-07 Thread via GitHub
garydgregory merged PR #254: URL: https://github.com/apache/commons-parent/pull/254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@c

[GitHub] [commons-parent] garydgregory merged pull request #255: Bump maven-enforcer-plugin from 3.2.1 to 3.3.0

2023-04-07 Thread via GitHub
garydgregory merged PR #255: URL: https://github.com/apache/commons-parent/pull/255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@c

[GitHub] [commons-parent] garydgregory merged pull request #256: Bump jacoco-maven-plugin from 0.8.8 to 0.8.9

2023-04-07 Thread via GitHub
garydgregory merged PR #256: URL: https://github.com/apache/commons-parent/pull/256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@c

[jira] [Resolved] (JEXL-395) 3.2.1 vs 3.3 hello get property

2023-04-07 Thread Henri Biestro (Jira)
[ https://issues.apache.org/jira/browse/JEXL-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro resolved JEXL-395. Fix Version/s: 3.3 Assignee: Henri Biestro Resolution: Not A Bug This is related to t

[GitHub] [commons-skin] garydgregory merged pull request #55: Bump github/codeql-action from 2.2.9 to 2.2.11

2023-04-07 Thread via GitHub
garydgregory merged PR #55: URL: https://github.com/apache/commons-skin/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commo

[GitHub] [commons-parent] garydgregory merged pull request #252: Bump github/codeql-action from 2.2.9 to 2.2.11

2023-04-07 Thread via GitHub
garydgregory merged PR #252: URL: https://github.com/apache/commons-parent/pull/252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@c

[GitHub] [commons-validator] garydgregory commented on pull request #130: Applied refactoring techniques

2023-04-07 Thread via GitHub
garydgregory commented on PR #130: URL: https://github.com/apache/commons-validator/pull/130#issuecomment-1500299562 You can also run the default Maven goal by running `mvn` from the command line which will run all checks. -- This is an automated message from the Apache Git Service. To r

[GitHub] [commons-io] garydgregory commented on pull request #377: IO-769: FileUtils copyDirectory() should not use COPY_ATTRIBUTES

2023-04-07 Thread via GitHub
garydgregory commented on PR #377: URL: https://github.com/apache/commons-io/pull/377#issuecomment-1500298538 What is the status of this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [commons-build-plugin] garydgregory merged pull request #149: Bump github/codeql-action from 2.2.9 to 2.2.11

2023-04-07 Thread via GitHub
garydgregory merged PR #149: URL: https://github.com/apache/commons-build-plugin/pull/149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Commented] (STATISTICS-54) [GSoC] Summary statistics API for Java 8 streams

2023-04-07 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/STATISTICS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709663#comment-17709663 ] Gilles Sadowski commented on STATISTICS-54: --- bq. [...] accept the specific s

[jira] [Updated] (DAEMON-457) Tomcat9.exe crash in windows server 2016 and 2019 while updating service.

2023-04-07 Thread Denish Kothadiya (Jira)
[ https://issues.apache.org/jira/browse/DAEMON-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Denish Kothadiya updated DAEMON-457: Description: Tomcat9.exe crash in windows server 2016 and 2019 while updating service. We

[jira] [Updated] (DAEMON-457) Tomcat9.exe crash in windows server 2016 and 2019 while updating service.

2023-04-07 Thread Denish Kothadiya (Jira)
[ https://issues.apache.org/jira/browse/DAEMON-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Denish Kothadiya updated DAEMON-457: Description: Tomcat9.exe crash in windows server 2016 and 2019 while updating service. We

[jira] [Updated] (DAEMON-457) Tomcat9.exe crash in windows server 2016 and 2019 while updating service.

2023-04-07 Thread Denish Kothadiya (Jira)
[ https://issues.apache.org/jira/browse/DAEMON-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Denish Kothadiya updated DAEMON-457: Description: Tomcat9.exe crash in windows server 2016 and 2019 while updating service. We

[jira] [Created] (DAEMON-457) Tomcat9.exe crash in windows server 2016 and 2019 while updating service.

2023-04-07 Thread Denish Kothadiya (Jira)
Denish Kothadiya created DAEMON-457: --- Summary: Tomcat9.exe crash in windows server 2016 and 2019 while updating service. Key: DAEMON-457 URL: https://issues.apache.org/jira/browse/DAEMON-457 Project

[GitHub] [commons-io] kinow merged pull request #446: Bump maven-enforcer-plugin from 3.2.1 to 3.3.0

2023-04-07 Thread via GitHub
kinow merged PR #446: URL: https://github.com/apache/commons-io/pull/446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apac

[GitHub] [commons-compress] kinow merged pull request #377: Bump zstd-jni from 1.5.4-2 to 1.5.5-1

2023-04-07 Thread via GitHub
kinow merged PR #377: URL: https://github.com/apache/commons-compress/pull/377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@common

[GitHub] [commons-validator] aherbert commented on pull request #130: Applied refactoring techniques

2023-04-07 Thread via GitHub
aherbert commented on PR #130: URL: https://github.com/apache/commons-validator/pull/130#issuecomment-1500033533 Removing the protected method `protected int determineScale(final NumberFormat format)` from `AbstractNumberValidator` would be a breaking change for binary compatibility. Try t

[GitHub] [commons-numbers] aherbert commented on a diff in pull request #129: Refactoring changes

2023-04-07 Thread via GitHub
aherbert commented on code in PR #129: URL: https://github.com/apache/commons-numbers/pull/129#discussion_r1160488862 ## commons-numbers-examples/examples-jmh/src/main/java/org/apache/commons/numbers/examples/jmh/gamma/ErfPerformance.java: ## @@ -146,6 +146,16 @@ protected doubl

[GitHub] [commons-numbers] aherbert commented on a diff in pull request #129: Refactoring changes

2023-04-07 Thread via GitHub
aherbert commented on code in PR #129: URL: https://github.com/apache/commons-numbers/pull/129#discussion_r1160488862 ## commons-numbers-examples/examples-jmh/src/main/java/org/apache/commons/numbers/examples/jmh/gamma/ErfPerformance.java: ## @@ -146,6 +146,16 @@ protected doubl