[jira] [Commented] (IMAGING-194) Tiff with JPEG,Zip compression fails to decompress

2023-11-11 Thread Gary Lucas (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785258#comment-17785258 ] Gary Lucas commented on IMAGING-194: I created test files using LibTIFF and ImageMag

Re: [PR] COMPRESS-650 lz4 index out of bounds [commons-compress]

2023-11-11 Thread via GitHub
cpreisler commented on code in PR #437: URL: https://github.com/apache/commons-compress/pull/437#discussion_r1390313217 ## src/test/java/org/apache/commons/compress/compressors/lz4/FramedLZ4CompressorRoundtripTest.java: ## @@ -104,15 +104,17 @@ private void roundTripTest(final S

Re: [PR] COMPRESS-650 lz4 index out of bounds [commons-compress]

2023-11-11 Thread via GitHub
cpreisler commented on code in PR #437: URL: https://github.com/apache/commons-compress/pull/437#discussion_r1390310751 ## src/test/java/org/apache/commons/compress/compressors/lz4/FramedLZ4CompressorRoundtripTest.java: ## @@ -104,15 +104,17 @@ private void roundTripTest(final S

Re: [PR] COMPRESS-650 lz4 index out of bounds [commons-compress]

2023-11-11 Thread via GitHub
cpreisler commented on code in PR #437: URL: https://github.com/apache/commons-compress/pull/437#discussion_r1390310674 ## src/test/java/org/apache/commons/compress/compressors/lz4/FramedLZ4CompressorOutputStreamTest.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Softw

Re: [PR] COMPRESS-650 lz4 index out of bounds [commons-compress]

2023-11-11 Thread via GitHub
cpreisler commented on code in PR #437: URL: https://github.com/apache/commons-compress/pull/437#discussion_r1390310608 ## src/test/java/org/apache/commons/compress/compressors/lz4/FramedLZ4CompressorOutputStreamTest.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Softw

Re: [PR] COMPRESS-650 lz4 index out of bounds [commons-compress]

2023-11-11 Thread via GitHub
cpreisler commented on PR #437: URL: https://github.com/apache/commons-compress/pull/437#issuecomment-1806932578 I’ll get it done today. On Sat, Nov 11, 2023 at 3:30 PM Gary Gregory ***@***.***> wrote: > @cpreisler > OK, ty for the update. FY

Re: [PR] COMPRESS-650 lz4 index out of bounds [commons-compress]

2023-11-11 Thread via GitHub
garydgregory commented on PR #437: URL: https://github.com/apache/commons-compress/pull/437#issuecomment-1806921936 @cpreisler OK, ty for the update. FYI, I plan on cutting a release candidate this weekend. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] COMPRESS-650 lz4 index out of bounds [commons-compress]

2023-11-11 Thread via GitHub
cpreisler commented on PR #437: URL: https://github.com/apache/commons-compress/pull/437#issuecomment-1806919375 I’m away from my computer right now. Let me look this over and make sure the right code got committed. Something may have gotten messed up when I tried to revert the other ch

Re: [PR] COMPRESS-650 lz4 index out of bounds [commons-compress]

2023-11-11 Thread via GitHub
garydgregory commented on code in PR #437: URL: https://github.com/apache/commons-compress/pull/437#discussion_r1390286209 ## src/test/java/org/apache/commons/compress/compressors/lz4/FramedLZ4CompressorOutputStreamTest.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache So

Re: [PR] COMPRESS-650 lz4 index out of bounds [commons-compress]

2023-11-11 Thread via GitHub
garydgregory commented on code in PR #437: URL: https://github.com/apache/commons-compress/pull/437#discussion_r1390286159 ## src/test/java/org/apache/commons/compress/compressors/lz4/FramedLZ4CompressorOutputStreamTest.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache So

Re: [PR] COMPRESS-650 lz4 index out of bounds [commons-compress]

2023-11-11 Thread via GitHub
garydgregory commented on code in PR #437: URL: https://github.com/apache/commons-compress/pull/437#discussion_r1390265464 ## src/test/java/org/apache/commons/compress/compressors/lz4/FramedLZ4CompressorRoundtripTest.java: ## @@ -104,15 +104,17 @@ private void roundTripTest(fina

Re: [PR] COMPRESS-650 lz4 index out of bounds [commons-compress]

2023-11-11 Thread via GitHub
cpreisler commented on code in PR #437: URL: https://github.com/apache/commons-compress/pull/437#discussion_r1390254401 ## src/test/java/org/apache/commons/compress/compressors/lz4/FramedLZ4CompressorRoundtripTest.java: ## @@ -104,15 +104,18 @@ private void roundTripTest(final S

Re: [PR] COMPRESS-650 lz4 index out of bounds [commons-compress]

2023-11-11 Thread via GitHub
garydgregory commented on code in PR #437: URL: https://github.com/apache/commons-compress/pull/437#discussion_r1390251770 ## src/test/java/org/apache/commons/compress/compressors/lz4/FramedLZ4CompressorRoundtripTest.java: ## @@ -104,15 +104,18 @@ private void roundTripTest(fina

Re: [PR] COMPRESS-650 lz4 index out of bounds [commons-compress]

2023-11-11 Thread via GitHub
cpreisler commented on PR #437: URL: https://github.com/apache/commons-compress/pull/437#issuecomment-1806857769 New class added and test are moved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] COMPRESS-650 lz4 index out of bounds [commons-compress]

2023-11-11 Thread via GitHub
garydgregory commented on PR #437: URL: https://github.com/apache/commons-compress/pull/437#issuecomment-1806849972 @cpreisler Sure, might as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Commented] (COMPRESS-647) ArrayIndexOutOfBoundsException when reading Zip with data descriptor entries

2023-11-11 Thread Robin Schimpf (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785182#comment-17785182 ] Robin Schimpf commented on COMPRESS-647: Thanks for fixing it! > ArrayIndexOut

[jira] [Commented] (COMPRESS-632) Improve fuzzing coverage in oss-fuzz

2023-11-11 Thread Robin Schimpf (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785181#comment-17785181 ] Robin Schimpf commented on COMPRESS-632: Thanks [~yakovsh] for tackling this!

Re: [PR] COMPRESS-650 lz4 index out of bounds [commons-compress]

2023-11-11 Thread via GitHub
cpreisler commented on PR #437: URL: https://github.com/apache/commons-compress/pull/437#issuecomment-1806833610 Shoot. I just noticed that I put the framed tests in the block tests class. Should I create a new test class for framed? Currently there is only the framed round trip class. The

[PR] COMPRESS-650 lz4 index out of bounds [commons-compress]

2023-11-11 Thread via GitHub
cpreisler opened a new pull request, #437: URL: https://github.com/apache/commons-compress/pull/437 I noticed that the change I made yesterday caused writing byte by byte to produces a different result than writing multiple bytes at one time. I fixed the code and added unit tests. Also I ve

[jira] [Commented] (COLLECTIONS-849) Compilation with Java 21 fails with "error: addFirst(E#1) in AbstractLinkedList cannot implement addFirst(E#2) in List"

2023-11-11 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785154#comment-17785154 ] Alex Herbert commented on COLLECTIONS-849: -- This is a duplicate of COLLECTI