Claudenw commented on code in PR #501:
URL:
https://github.com/apache/commons-collections/pull/501#discussion_r1635902965
##
src/main/java/org/apache/commons/collections4/bloomfilter/EnhancedDoubleHasher.java:
##
@@ -167,41 +167,33 @@ public boolean processIndices(final IntPred
aherbert commented on PR #501:
URL:
https://github.com/apache/commons-collections/pull/501#issuecomment-2162221580
@Claudenw I think this is the wrong solution. You are compromising 99.%
of use cases to handle the edge case of k >= bits. In practical use this will
not be needed. I do n
garydgregory merged PR #428:
URL: https://github.com/apache/commons-parent/pull/428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@c
garydgregory merged PR #395:
URL: https://github.com/apache/commons-dbcp/pull/395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@com
garydgregory commented on PR #395:
URL: https://github.com/apache/commons-dbcp/pull/395#issuecomment-2161336720
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
garydgregory merged PR #537:
URL: https://github.com/apache/commons-compress/pull/537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
garydgregory merged PR #637:
URL: https://github.com/apache/commons-io/pull/637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commo
garydgregory merged PR #434:
URL: https://github.com/apache/commons-configuration/pull/434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubs
garydgregory merged PR #231:
URL: https://github.com/apache/commons-validator/pull/231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
garydgregory merged PR #435:
URL: https://github.com/apache/commons-csv/pull/435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@comm
garydgregory merged PR #432:
URL: https://github.com/apache/commons-configuration/pull/432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubs
garydgregory merged PR #557:
URL: https://github.com/apache/commons-text/pull/557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@com
garydgregory merged PR #261:
URL: https://github.com/apache/commons-net/pull/261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@comm
garydgregory merged PR #283:
URL: https://github.com/apache/commons-cli/pull/283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@comm
garydgregory merged PR #1233:
URL: https://github.com/apache/commons-lang/pull/1233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@c
garydgregory commented on code in PR #501:
URL:
https://github.com/apache/commons-collections/pull/501#discussion_r1635187971
##
src/main/java/org/apache/commons/collections4/bloomfilter/EnhancedDoubleHasher.java:
##
@@ -167,41 +167,33 @@ public boolean processIndices(final Int
aherbert commented on code in PR #501:
URL:
https://github.com/apache/commons-collections/pull/501#discussion_r1635137320
##
src/main/java/org/apache/commons/collections4/bloomfilter/EnhancedDoubleHasher.java:
##
@@ -167,41 +167,33 @@ public boolean processIndices(final IntPred
thachlp commented on code in PR #1229:
URL: https://github.com/apache/commons-lang/pull/1229#discussion_r1634957883
##
src/main/java/org/apache/commons/lang3/event/EventListenerSupport.java:
##
@@ -66,9 +66,14 @@
*
*
* @param the type of event listener that is supported
Claude Warren created CLI-336:
-
Summary: Deprecation use not always reported.
Key: CLI-336
URL: https://issues.apache.org/jira/browse/CLI-336
Project: Commons CLI
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/CLI-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claude Warren updated CLI-336:
--
Assignee: Claude Warren
> Deprecation use not always reported.
>
>
>
Claudenw commented on code in PR #501:
URL:
https://github.com/apache/commons-collections/pull/501#discussion_r1634913568
##
src/main/java/org/apache/commons/collections4/bloomfilter/EnhancedDoubleHasher.java:
##
@@ -167,41 +167,33 @@ public boolean processIndices(final IntPred
aherbert commented on code in PR #501:
URL:
https://github.com/apache/commons-collections/pull/501#discussion_r1634862521
##
src/main/java/org/apache/commons/collections4/bloomfilter/EnhancedDoubleHasher.java:
##
@@ -167,41 +167,33 @@ public boolean processIndices(final IntPred
Claudenw commented on PR #501:
URL:
https://github.com/apache/commons-collections/pull/501#issuecomment-2160622978
We do have coverage in the tests for the bad case.
If we start an integer variable `int tet = 1;` and use it on line 198 rather
than i. We can then do
```
if (++
garydgregory merged PR #503:
URL: https://github.com/apache/commons-collections/pull/503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr
garydgregory commented on PR #259:
URL: https://github.com/apache/commons-net/pull/259#issuecomment-2160544465
😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
garydgregory commented on PR #501:
URL:
https://github.com/apache/commons-collections/pull/501#issuecomment-2160537613
Perhaps some of the information captured in this conversation could be
preserved in a Java document or in-line comment.
--
This is an automated message from the Apache G
aherbert commented on PR #501:
URL:
https://github.com/apache/commons-collections/pull/501#issuecomment-2160492067
The increment `inc` is adjusted by `i`. If it is negative then it has
wrapped and we add `bits`. This works only if `i` is always less than `bits`.
If `i > bits` then wh
Claudenw commented on PR #501:
URL:
https://github.com/apache/commons-collections/pull/501#issuecomment-2160483512
OK, I figured out what the lines 173-192 are doing . They ensure that the
`inc` does not get greater than `bits`.
--
This is an automated message from the Apache Git Servi
Claudenw commented on PR #501:
URL:
https://github.com/apache/commons-collections/pull/501#issuecomment-2160361892
I think this block is wrong:
https://github.com/apache/commons-collections/blob/bb2fac47dc24033bae8a180bc59cb1e6e8769318/src/main/java/org/apache/commons/collections4/bloomfilt
thachlp commented on code in PR #1229:
URL: https://github.com/apache/commons-lang/pull/1229#discussion_r1634357210
##
src/main/java/org/apache/commons/lang3/event/EventListenerSupport.java:
##
@@ -66,9 +66,14 @@
*
*
* @param the type of event listener that is supported
30 matches
Mail list logo
