aaaZayne opened a new pull request, #519:
URL: https://github.com/apache/commons-dbcp/pull/519
Refactor three common code patterns in CPDSConnectionFactory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ecki commented on PR #781:
URL: https://github.com/apache/commons-io/pull/781#issuecomment-3267054419
> Have @ecki's issues been resolved?
I think I had trouble implementing a similar function compatible with the
OS, that’s the base of my comments but I think it might be a good attemp
[
https://issues.apache.org/jira/browse/COMPRESS-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018860#comment-18018860
]
Gary D. Gregory commented on COMPRESS-708:
--
Hello [~yuweiboy]
Feel free to pr
garydgregory commented on code in PR #776:
URL: https://github.com/apache/commons-io/pull/776#discussion_r2330658794
##
src/main/java/org/apache/commons/io/IOUtils.java:
##
@@ -2637,57 +2652,65 @@ public static BufferedReader toBufferedReader(final
Reader reader, final int siz
garydgregory commented on PR #781:
URL: https://github.com/apache/commons-io/pull/781#issuecomment-3266919288
Hi @ppkarwasz
Could you please rebase on Git master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ecki commented on code in PR #781:
URL: https://github.com/apache/commons-io/pull/781#discussion_r2330580155
##
src/main/java/org/apache/commons/io/FileSystem.java:
##
@@ -107,7 +107,7 @@ public enum FileSystem {
"LPT1", "LPT2", "LPT3", "LPT4", "LPT5", "LPT6
ecki commented on code in PR #781:
URL: https://github.com/apache/commons-io/pull/781#discussion_r2330587757
##
src/main/java/org/apache/commons/io/FileSystem.java:
##
@@ -530,4 +623,76 @@ CharSequence trimExtension(final CharSequence cs) {
final int index = indexOf(cs,
ecki commented on PR #781:
URL: https://github.com/apache/commons-io/pull/781#issuecomment-3266844482
BTW: here is the place in the JDK I was refering about, but not sure about
the conditions it applies
https://github.com/openjdk/jdk/blob/166ef5e7b1c6d6a9f0f1f29fedb7f65b94f53119/src/
ecki commented on code in PR #781:
URL: https://github.com/apache/commons-io/pull/781#discussion_r2330575838
##
src/main/java/org/apache/commons/io/FileSystem.java:
##
@@ -519,13 +528,11 @@ public boolean isLegalFileName(final CharSequence
candidate) {
* @since 2.21.0
garydgregory commented on PR #779:
URL: https://github.com/apache/commons-io/pull/779#issuecomment-3266746579
Merged, thank you @ppkarwasz.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
ppkarwasz commented on code in PR #781:
URL: https://github.com/apache/commons-io/pull/781#discussion_r2330550220
##
src/main/java/org/apache/commons/io/FileSystem.java:
##
@@ -519,13 +528,11 @@ public boolean isLegalFileName(final CharSequence
candidate) {
* @since 2.21.
garydgregory merged PR #779:
URL: https://github.com/apache/commons-io/pull/779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commo
ppkarwasz commented on code in PR #781:
URL: https://github.com/apache/commons-io/pull/781#discussion_r2330394828
##
src/main/java/org/apache/commons/io/FileSystem.java:
##
@@ -315,6 +327,8 @@ private static String replace(final String path, final char
oldChar, final char
ppkarwasz commented on code in PR #781:
URL: https://github.com/apache/commons-io/pull/781#discussion_r2330357144
##
src/main/java/org/apache/commons/io/FileSystem.java:
##
@@ -411,30 +424,26 @@ public int getMaxFileNameLength() {
/**
* Gets the maximum length for fil
ppkarwasz commented on code in PR #781:
URL: https://github.com/apache/commons-io/pull/781#discussion_r2330355662
##
src/main/java/org/apache/commons/io/FileSystem.java:
##
@@ -624,75 +631,102 @@ CharSequence trimExtension(final CharSequence cs) {
return index < 0 ? cs
ppkarwasz commented on code in PR #779:
URL: https://github.com/apache/commons-io/pull/779#discussion_r2329756637
##
src/main/java/org/apache/commons/io/input/BoundedInputStream.java:
##
@@ -370,16 +370,10 @@ protected synchronized void afterRead(final int n) throws
IOException
ppkarwasz commented on code in PR #779:
URL: https://github.com/apache/commons-io/pull/779#discussion_r2329732635
##
src/test/java/org/apache/commons/io/input/BoundedInputStreamTest.java:
##
@@ -80,21 +91,75 @@ void testAfterReadConsumer() throws Exception {
// @formatt
vy commented on code in PR #776:
URL: https://github.com/apache/commons-io/pull/776#discussion_r2329688265
##
src/main/java/org/apache/commons/io/IOUtils.java:
##
@@ -221,6 +221,21 @@ public class IOUtils {
*/
private static final char[] SCRATCH_CHAR_BUFFER_WO = charA
ppkarwasz commented on code in PR #779:
URL: https://github.com/apache/commons-io/pull/779#discussion_r2329731761
##
src/main/java/org/apache/commons/io/input/BoundedInputStream.java:
##
@@ -427,13 +421,19 @@ public long getMaxLength() {
}
/**
- * Gets how many b
ppkarwasz commented on code in PR #779:
URL: https://github.com/apache/commons-io/pull/779#discussion_r2329730820
##
src/main/java/org/apache/commons/io/input/BoundedInputStream.java:
##
@@ -405,9 +399,9 @@ public synchronized long getCount() {
}
/**
- * Gets the
ppkarwasz commented on code in PR #779:
URL: https://github.com/apache/commons-io/pull/779#discussion_r2329746955
##
src/test/java/org/apache/commons/io/input/BoundedInputStreamTest.java:
##
@@ -80,21 +91,75 @@ void testAfterReadConsumer() throws Exception {
// @formatt
ppkarwasz commented on code in PR #779:
URL: https://github.com/apache/commons-io/pull/779#discussion_r2329733267
##
src/test/java/org/apache/commons/io/input/BoundedInputStreamTest.java:
##
@@ -203,10 +268,10 @@ void testCounts(final long startCount) throws Exception {
@
ppkarwasz commented on code in PR #776:
URL: https://github.com/apache/commons-io/pull/776#discussion_r2329706213
##
src/main/java/org/apache/commons/io/IOUtils.java:
##
@@ -2637,57 +2652,65 @@ public static BufferedReader toBufferedReader(final
Reader reader, final int siz
ppkarwasz commented on code in PR #776:
URL: https://github.com/apache/commons-io/pull/776#discussion_r2329705832
##
src/main/java/org/apache/commons/io/IOUtils.java:
##
@@ -2697,6 +2720,69 @@ public static byte[] toByteArray(final InputStream
input, final long size) throw
ppkarwasz commented on code in PR #776:
URL: https://github.com/apache/commons-io/pull/776#discussion_r2329705120
##
src/main/java/org/apache/commons/io/IOUtils.java:
##
@@ -221,6 +221,21 @@ public class IOUtils {
*/
private static final char[] SCRATCH_CHAR_BUFFER_WO
ppkarwasz commented on code in PR #776:
URL: https://github.com/apache/commons-io/pull/776#discussion_r2329702187
##
src/main/java/org/apache/commons/io/IOUtils.java:
##
@@ -221,6 +221,21 @@ public class IOUtils {
*/
private static final char[] SCRATCH_CHAR_BUFFER_WO
ppkarwasz commented on code in PR #776:
URL: https://github.com/apache/commons-io/pull/776#discussion_r2329690275
##
src/main/java/org/apache/commons/io/IOUtils.java:
##
@@ -2637,57 +2652,65 @@ public static BufferedReader toBufferedReader(final
Reader reader, final int siz
ppkarwasz commented on PR #776:
URL: https://github.com/apache/commons-io/pull/776#issuecomment-3265381781
> > JDK 11+ uses 16 KiB.
>
> Where do you see that?
In the [source code of
`InputStream`](https://github.com/openjdk/jdk/blob/bea2b029a77e126171d17c3a44baec6d5cafed4a/src/
aaaZayne opened a new pull request, #369:
URL: https://github.com/apache/commons-net/pull/369
Simple duplicate code removal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
29 matches
Mail list logo
