[GitHub] [commons-collections] kinow commented on pull request #300: [COLLECTIONS-802] Fix remove failed by removing set null to currentKe…

2022-04-24 Thread GitBox
kinow commented on PR #300: URL: https://github.com/apache/commons-collections/pull/300#issuecomment-1108008975 Also created a follow-up issue, https://issues.apache.org/jira/browse/COLLECTIONS-811, to consider adding Guava's testlib or similar solution to our tests/CI. -- This is an

[GitHub] [commons-collections] kinow commented on pull request #300: [COLLECTIONS-802] Fix remove failed by removing set null to currentKe…

2022-04-24 Thread GitBox
kinow commented on PR #300: URL: https://github.com/apache/commons-collections/pull/300#issuecomment-1108007330 Thanks @ben-manes, much easier now to run the tests and compare the results with your updated test. For `master`: ```bash [ERROR] Failures: [ERROR]

[GitHub] [commons-collections] kinow commented on pull request #300: [COLLECTIONS-802] Fix remove failed by removing set null to currentKe…

2022-04-24 Thread GitBox
kinow commented on PR #300: URL: https://github.com/apache/commons-collections/pull/300#issuecomment-1107932772 > oops. I must have forgotten, not realized, or master has new failures. I very much like Guava’s collection tests as reusable and catch these minor mistakes. I’d recommend

[GitHub] [commons-collections] kinow commented on pull request #300: [COLLECTIONS-802] Fix remove failed by removing set null to currentKe…

2022-04-24 Thread GitBox
kinow commented on PR #300: URL: https://github.com/apache/commons-collections/pull/300#issuecomment-1107931652 Ah, I think I may have spoken too fast. I executed the `ApacheMapTest` against `master`, and got this: ``` [ERROR] Tests run: 25662, Failures: 8, Errors: 139, Skipped: