[GitHub] [commons-configuration] kinow commented on pull request #37: Configuration-766: BigDecimal(double) should not be used.

kinow commented on PR #37: URL: https://github.com/apache/commons-configuration/pull/37#issuecomment-1121962737 Rebased. See my previous comment on the patch from JIRA and updating the tests too :+1: -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [commons-configuration] kinow commented on pull request #37: Configuration-766: BigDecimal(double) should not be used.

kinow commented on pull request #37: URL: https://github.com/apache/commons-configuration/pull/37#issuecomment-67899 I applied @aherbert's suggestion in his last comment in CONFIGURATION-766 locally, and it worked with no issues. That approach looks good to me, modifying the

[GitHub] [commons-configuration] kinow commented on pull request #37: Configuration-766: BigDecimal(double) should not be used.

kinow commented on pull request #37: URL: https://github.com/apache/commons-configuration/pull/37#issuecomment-677995279 Rebased, but looks like we had a test verifying the old behavior >[ERROR] TestPropertyConverter.testToBigDecimalDoubleConstructor:68 Incorrect BigDecimal value