kinow commented on pull request #72:
URL: https://github.com/apache/commons-imaging/pull/72#issuecomment-628883600
Excellent Gary! I have time to review it again this weekend. I think it
should be ready to merge now if I find nothing else in the review
Should we delay mergimg until
kinow commented on pull request #72:
URL: https://github.com/apache/commons-imaging/pull/72#issuecomment-629250783
Nice! Will start going through it tomorrow. Thanks
This is an automated message from the Apache Git Servic
kinow commented on pull request #72:
URL: https://github.com/apache/commons-imaging/pull/72#issuecomment-629593803
No blockers so far, another 9 files to go, and then review is done. Comments
added now can either be fixed before merging, or afterwards.
@gwlucastrig do you mind if whe
kinow commented on pull request #72:
URL: https://github.com/apache/commons-imaging/pull/72#issuecomment-629638135
Brilliant! Then tomorrow I will finish the review. Final things I'm looking
at are
- test coverage of new code (I lost track of how much is covered here)
- possible i
kinow commented on pull request #72:
URL: https://github.com/apache/commons-imaging/pull/72#issuecomment-629740020
>test coverage of new code (I lost track of how much is covered here)
Some of the new code is not covered by tests. But alas I think it's quite
hard to find images for t
kinow commented on pull request #72:
URL: https://github.com/apache/commons-imaging/pull/72#issuecomment-629740729
>possible issues for security (those N/0, or loading values from the data
without checking boundaries, etc)
Nothing obvious. A fuzzer could still find some images that c
kinow commented on pull request #72:
URL: https://github.com/apache/commons-imaging/pull/72#issuecomment-629740776
> how much we broke backward compatibility—if any
Nothing too drastic—i.e. API changes OK IMHO for next **alpha** release
(this will change once we have 1.0 out)
-
kinow commented on pull request #72:
URL: https://github.com/apache/commons-imaging/pull/72#issuecomment-629740790
Approved. Rebasing and merging. Thanks @gwlucastrig !
This is an automated message from the Apache Git Service
