XenoAmess edited a comment on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-669180712
@sebbASF
> Do you have any proof that using UnsyncBufferedReader etc in contentEquals
will result in a slow-down unless further changes are made to contentEquals?
XenoAmess edited a comment on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-669180712
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
XenoAmess edited a comment on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-669143244
@sebbASF
> AFAICT the new classes UnsyncBufferedReader etc are not actually used
(except in test code).
yes, they are not quite used, but used for being
XenoAmess edited a comment on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-669144943
@sebbASF @garydgregory
> Also, the existing prefix we use is Undynchronized, not Unsync. Gary
> Undynchronized should presumably be Unsynchronized?
>
XenoAmess edited a comment on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-669143244
@sebbASF
> AFAICT the new classes UnsyncBufferedReader etc are not actually used
(except in test code).
yes, they are not quite used, but used for being
XenoAmess edited a comment on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-665831472
Hi.
I just found a bug in contentEqualsIgnoreEOLNew2.
Will redo it tomorrow.
---
Actually will redo it anyway, as I thought it good to split
XenoAmess edited a comment on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-665609575
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
XenoAmess edited a comment on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-640937650
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
XenoAmess edited a comment on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-637035997
@garydgregory
Performance test done.
**Conclusion:**
In cases for small content readers (a File), the new function is slightly
faster.
but in cases for
XenoAmess edited a comment on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-637035997
@garydgregory
Performance test done.
**Conclusion:**
In cases for small content readers, the new function is slightly faster.
but in cases for large
XenoAmess edited a comment on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-636994263
@garydgregory
> @XenoAmess
>
> * When you create a PR, please do not leave the description empty. It
makes it harder to review.
OK
> * If
XenoAmess edited a comment on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-636994263
@garydgregory
> @XenoAmess
>
> * When you create a PR, please do not leave the description empty. It
makes it harder to review.
OK
> * If
XenoAmess edited a comment on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-636994263
@garydgregory
> @XenoAmess
>
> * When you create a PR, please do not leave the description empty. It
makes it harder to review.
OK
> * If
XenoAmess edited a comment on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-636971532
need I make a performance test case to show the performance?
This is an automated message from the
14 matches
Mail list logo
