[GitHub] [commons-io] wodencafe commented on pull request #296: Update FileWriterWithEncoding to extend ProxyWriter

2021-11-03 Thread GitBox
wodencafe commented on pull request #296: URL: https://github.com/apache/commons-io/pull/296#issuecomment-958602720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [commons-io] wodencafe commented on pull request #296: Update FileWriterWithEncoding to extend ProxyWriter

2021-11-03 Thread GitBox
wodencafe commented on pull request #296: URL: https://github.com/apache/commons-io/pull/296#issuecomment-958602720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [commons-io] wodencafe commented on pull request #296: Update FileWriterWithEncoding to extend ProxyWriter

2021-11-02 Thread GitBox
wodencafe commented on pull request #296: URL: https://github.com/apache/commons-io/pull/296#issuecomment-958611431 Hello again @kinow , just wanted to let you know that the changes have been made. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [commons-io] wodencafe commented on pull request #296: Update FileWriterWithEncoding to extend ProxyWriter

2021-11-02 Thread GitBox
wodencafe commented on pull request #296: URL: https://github.com/apache/commons-io/pull/296#issuecomment-958602720 Hi @kinow , thanks for reviewing the code. Actually I think that bottom approach is simpler, I'll give it a try, and update the PR accordingly. -- This is an automated

[GitHub] [commons-io] wodencafe commented on pull request #296: Update FileWriterWithEncoding to extend ProxyWriter

2021-11-02 Thread GitBox
wodencafe commented on pull request #296: URL: https://github.com/apache/commons-io/pull/296#issuecomment-957649989 @garydgregory Now the FileWriterWithEncoding extends ProxyWriter, and the actual Proxy class for writing is stored in ProxyWriter rather than inside FileWriterWithEncoding

[GitHub] [commons-io] wodencafe commented on pull request #296: Update FileWriterWithEncoding to extend ProxyWriter

2021-11-02 Thread GitBox
wodencafe commented on pull request #296: URL: https://github.com/apache/commons-io/pull/296#issuecomment-957649989 @garydgregory Now the FileWriterWithEncoding extends ProxyWriter, and the actual Proxy class for writing is stored in ProxyWriter rather than inside FileWriterWithEncoding

[GitHub] [commons-io] wodencafe commented on pull request #296: Update FileWriterWithEncoding to extend ProxyWriter

2021-11-02 Thread GitBox
wodencafe commented on pull request #296: URL: https://github.com/apache/commons-io/pull/296#issuecomment-957649989 @garydgregory Now the FileWriterWithEncoding extends ProxyWriter, and the actual Proxy class for writing is stored in ProxyWriter rather than inside FileWriterWithEncoding