[GitHub] [commons-lang] garydgregory commented on issue #495: LANG-1519 Add zero, positive & negative util methods

2020-03-22 Thread GitBox
garydgregory commented on issue #495: LANG-1519 Add zero, positive & negative util methods URL: https://github.com/apache/commons-lang/pull/495#issuecomment-602246497 @nnivruth , Thank you for your updates. The code covers all the cases it seems which is nice. The drawback ATM is that i

[GitHub] [commons-lang] garydgregory commented on issue #495: LANG-1519 Add zero, positive & negative util methods

2020-03-19 Thread GitBox
garydgregory commented on issue #495: LANG-1519 Add zero, positive & negative util methods URL: https://github.com/apache/commons-lang/pull/495#issuecomment-601159310 Hi @nnivruth In general, since we are a general purpose library, I would say that you should consider all subclasses of

[GitHub] [commons-lang] garydgregory commented on issue #495: LANG-1519 Add zero, positive & negative util methods

2020-03-02 Thread GitBox
garydgregory commented on issue #495: LANG-1519 Add zero, positive & negative util methods URL: https://github.com/apache/commons-lang/pull/495#issuecomment-593574286 What about other JRE numbers like atomic numbers and big numbers? How should those be treated? ---

[GitHub] [commons-lang] garydgregory commented on issue #495: LANG-1519 Add zero, positive & negative util methods

2020-02-25 Thread GitBox
garydgregory commented on issue #495: LANG-1519 Add zero, positive & negative util methods URL: https://github.com/apache/commons-lang/pull/495#issuecomment-591078721 What should these method return when a double is not-a-number?