[GitHub] [commons-statistics] aherbert commented on pull request #26: Add truncated normal distribution.

2021-02-21 Thread GitBox
aherbert commented on pull request #26: URL: https://github.com/apache/commons-statistics/pull/26#issuecomment-782818168 I agree with the parameterised tests. This is a change that can be implemented later. We can discuss the approach on the mailing list. I think the `TOO_LARGE` and

[GitHub] [commons-statistics] aherbert commented on pull request #26: Add truncated normal distribution.

2021-02-19 Thread GitBox
aherbert commented on pull request #26: URL: https://github.com/apache/commons-statistics/pull/26#issuecomment-782051472 Thanks for the contribution. The implementation and tests look good (all edge cases are covered). The code is currently failing PMD checks. Most of these are for m