[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

2023-07-19 Thread Andreas Goss (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744759#comment-17744759 ] Andreas Goss commented on GEOMETRY-144: --- I created a pull request on the github project for my

[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

2023-04-07 Thread Andreas Goss (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709694#comment-17709694 ] Andreas Goss commented on GEOMETRY-144: --- While adjusting the code for the 2D case, I ran into

[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

2023-02-19 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690953#comment-17690953 ] Matt Juntunen commented on GEOMETRY-144: Sounds great! Thank you for your contributions on

[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

2023-02-16 Thread Andreas Goss (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690015#comment-17690015 ] Andreas Goss commented on GEOMETRY-144: --- Great! I think there are no major points left. If you

[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

2023-02-11 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687515#comment-17687515 ] Matt Juntunen commented on GEOMETRY-144: bq. i think that is a good proposition. At least in

[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

2023-02-10 Thread Andreas Goss (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687268#comment-17687268 ] Andreas Goss commented on GEOMETRY-144: --- Having thought about it some more i believe we could go

[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

2023-02-08 Thread Andreas Goss (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17686090#comment-17686090 ] Andreas Goss commented on GEOMETRY-144: --- [~mattjuntunen] i think that is a good proposition. At

[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

2023-02-05 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684354#comment-17684354 ] Matt Juntunen commented on GEOMETRY-144: [~agoss], I've looked over your PR and it's looking

[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

2023-02-01 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683155#comment-17683155 ] Gilles Sadowski commented on GEOMETRY-144: -- bq.  I still believe we should just go with one

[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

2023-01-31 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682847#comment-17682847 ] Matt Juntunen commented on GEOMETRY-144: I still believe we should just go with one algorithm

[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

2023-01-30 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682258#comment-17682258 ] Gilles Sadowski commented on GEOMETRY-144: -- {quote}Having thought on this some more, I believe

[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

2023-01-30 Thread Andreas Goss (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682200#comment-17682200 ] Andreas Goss commented on GEOMETRY-144: --- Is there really a need for a ConvexHull interface as

[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

2022-05-01 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530519#comment-17530519 ] Matt Juntunen commented on GEOMETRY-144: I'm thinking it would be useful to apply the builder

[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

2022-04-25 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527327#comment-17527327 ] Gilles Sadowski commented on GEOMETRY-144: -- +1 {code} package

[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

2022-04-24 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527276#comment-17527276 ] Matt Juntunen commented on GEOMETRY-144: Having thought on this some more, I believe the best

[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

2022-04-24 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527270#comment-17527270 ] Matt Juntunen commented on GEOMETRY-144: {quote}Could different algorithms have their

[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

2022-04-24 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527250#comment-17527250 ] Gilles Sadowski commented on GEOMETRY-144: -- Could different algorithms have their respective

[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

2022-04-23 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526836#comment-17526836 ] Matt Juntunen commented on GEOMETRY-144: The current implementation uses an algorithm-specific