[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator

[ https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576349#comment-16576349 ] Gilles commented on MATH-1459: -- bq. cleanup pull resquest Thanks, done. If all seems OK, please "resolve"

[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator

[ https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576333#comment-16576333 ] adrian commented on MATH-1459: -- I can fix the "@inheritDoc" problem I created, but when I run "mvn test site"

[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator

[ https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573591#comment-16573591 ] adrian commented on MATH-1459: -- Hey [~erans] I also made a cleanup pull request (deleting a file that was

[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator

[ https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477539#comment-16477539 ] Gilles commented on MATH-1459: -- Commit 6dc6cf5b2fba50eb602283101de4910787ad5579 ("master" branch). > Create a

[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator

[ https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477537#comment-16477537 ] Gilles commented on MATH-1459: -- bq. I assume I should also remove the java 8 lambda Not necessarily since the

[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator

[ https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476437#comment-16476437 ] adrian commented on MATH-1459: -- [~erans] I made the change you suggested regarding the unit test. Let me know

[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator

[ https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465752#comment-16465752 ] Gilles commented on MATH-1459: -- bq. Will the unit test extend AbstractLeastSquaresOptimizerAbstractTest? Or

[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator

[ https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463982#comment-16463982 ] adrian commented on MATH-1459: -- [~erans], that makes sense. I've moved the BevingtonProblem class out

[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator

[ https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463924#comment-16463924 ] Gilles commented on MATH-1459: -- Thanks for the changes; the functionality looks more flexible now. As noted

[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator

[ https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463107#comment-16463107 ] adrian commented on MATH-1459: -- [~erans] I think I've fixed most of the things you suggest. * The checkstyle

[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator

[ https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462240#comment-16462240 ] Gilles commented on MATH-1459: -- I've already fixed the tolerance typo (1e14 vs 1e-14); thanks. Please run

[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator

[ https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461582#comment-16461582 ] adrian commented on MATH-1459: -- [~erans] [https://github.com/apache/commons-math/pull/84] thanks! > Create a

[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator

[ https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460865#comment-16460865 ] Gilles commented on MATH-1459: -- bq. I have done this with a pull request, but would like feedback. Please