[
https://issues.apache.org/jira/browse/MATH-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13211321#comment-13211321
]
Patrick Meyer commented on MATH-449:
I think everything looks fine and hiding the
[
https://issues.apache.org/jira/browse/MATH-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13211163#comment-13211163
]
Gilles commented on MATH-449:
-
Thomas,
It is not necessary to resolve this issue before 3.0.
[
https://issues.apache.org/jira/browse/MATH-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13209670#comment-13209670
]
Thomas Neidhart commented on MATH-449:
--
I had missed some suggestions from Phil at
[
https://issues.apache.org/jira/browse/MATH-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208702#comment-13208702
]
Thomas Neidhart commented on MATH-449:
--
Patch applied together with additional changes
[
https://issues.apache.org/jira/browse/MATH-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088719#comment-13088719
]
Patrick Meyer commented on MATH-449:
I like all of these ideas. When I wrote the patch,
[
https://issues.apache.org/jira/browse/MATH-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088843#comment-13088843
]
Phil Steitz commented on MATH-449:
--
We could allow NaNs in the input vectors and skip
[
https://issues.apache.org/jira/browse/MATH-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088913#comment-13088913
]
Patrick Meyer commented on MATH-449:
I like that idea. It's probably the best way to
[
https://issues.apache.org/jira/browse/MATH-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088996#comment-13088996
]
Phil Steitz commented on MATH-449:
--
Good point on the stored data version. This is really
[
https://issues.apache.org/jira/browse/MATH-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088390#comment-13088390
]
Patrick Meyer commented on MATH-449:
These changes sound fine to me. I'd be happy to add
[
https://issues.apache.org/jira/browse/MATH-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088398#comment-13088398
]
Phil Steitz commented on MATH-449:
--
I will commit the new classes, refactored per last
[
https://issues.apache.org/jira/browse/MATH-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088421#comment-13088421
]
Phil Steitz commented on MATH-449:
--
Code has been committed in r1160026 with the following
[
https://issues.apache.org/jira/browse/MATH-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088317#comment-13088317
]
Phil Steitz commented on MATH-449:
--
Thanks for the patch!
Definitely a useful addition.
[
https://issues.apache.org/jira/browse/MATH-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13051765#comment-13051765
]
Phil Steitz commented on MATH-449:
--
Right, we tend to use primitives. Don't hesitate to
[
https://issues.apache.org/jira/browse/MATH-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13049850#comment-13049850
]
Phil Steitz commented on MATH-449:
--
Can you please either add a comment indicating the code
[
https://issues.apache.org/jira/browse/MATH-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13049943#comment-13049943
]
Patrick Meyer commented on MATH-449:
I've added the comment to the code. If you have
[
https://issues.apache.org/jira/browse/MATH-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13049956#comment-13049956
]
Phil Steitz commented on MATH-449:
--
I am leaning toward just adding a new class called
[
https://issues.apache.org/jira/browse/MATH-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13050013#comment-13050013
]
Patrick Meyer commented on MATH-449:
I agree. A new class would be best. Now that I am
17 matches
Mail list logo