arthurscchan commented on PR #222:
URL: https://github.com/apache/commons-codec/pull/222#issuecomment-1828039723
Hi @garydgregory, thanks for your comments and suggestions. I will surely
keep that in mind.
--
This is an automated message from the Apache Git Service.
To respond to the
arthurscchan commented on PR #222:
URL: https://github.com/apache/commons-codec/pull/222#issuecomment-1827848126
Hi @garydgregory, OK. Sorry for not considering in that direction. I will
change the code in this PR to wrap around the possible IndexOutOfBoundException
in an EncoderException,
garydgregory commented on PR #222:
URL: https://github.com/apache/commons-codec/pull/222#issuecomment-1827843610
Hi @arthurscchan
I'm not a fan of making the ctor overly clever in a way that was never
documented and is not expected or obvious (IMO). This violates the principle of
least
garydgregory commented on PR #222:
URL: https://github.com/apache/commons-codec/pull/222#issuecomment-1827859750
TY @arthurscchan
Let's keep in mind that this is a library that needs to make sense (or try
to) for users. As opposed to just addressing fuzzing issues in the most
expedient
Claudenw commented on code in PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#discussion_r1406448257
##
src/test/java/org/apache/commons/collections4/bloomfilter/CountingPredicateTest.java:
##
@@ -16,31 +16,103 @@
*/
package
[
https://issues.apache.org/jira/browse/COMPRESS-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790278#comment-17790278
]
Yakov Shafranovich commented on COMPRESS-632:
-
The oss-fuzz PR has been merged in, please
[
https://issues.apache.org/jira/browse/CRYPTO-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790274#comment-17790274
]
Sebb commented on CRYPTO-136:
-
FIPS_mode was not enabled in 1.1, and has been removed in 3.x
See
cortlepp-intershop commented on PR #322:
URL: https://github.com/apache/commons-dbcp/pull/322#issuecomment-1828575790
Hey @garydgregory @psteitz, just checking in: did you have a chance to think
about this some more and how we could proceed here?
--
This is an automated message from the
arthurscchan opened a new pull request, #1139:
URL: https://github.com/apache/commons-lang/pull/1139
The Javadoc description comments for most methods of the Conversion class,
it contains a detailed description of the reason for some expected exceptions
thrown by each method. These
yakovsh commented on code in PR #442:
URL: https://github.com/apache/commons-compress/pull/442#discussion_r1406841978
##
src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveConstants.java:
##
@@ -26,7 +26,7 @@ public final class DumpArchiveConstants {
*
shubham-1503 opened a new pull request, #478:
URL: https://github.com/apache/commons-text/pull/478
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Sheung Chi Chan created LANG-1720:
-
Summary: Add better description of possible exception thrown by
methods in the Javadoc
Key: LANG-1720
URL: https://issues.apache.org/jira/browse/LANG-1720
Project:
[
https://issues.apache.org/jira/browse/LANG-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790263#comment-17790263
]
Bernd Eckenfels commented on LANG-1720:
---
Good point, can you tell us which ones you missed the doc?
[
https://issues.apache.org/jira/browse/CRYPTO-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved CRYPTO-180.
-
Resolution: Fixed
> Need instructions for building distributions
>
yakovsh commented on code in PR #441:
URL: https://github.com/apache/commons-compress/pull/441#discussion_r1406805346
##
src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveInputStream.java:
##
@@ -362,7 +362,11 @@ public int read(final byte[] b, final int off,
[
https://issues.apache.org/jira/browse/CRYPTO-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved CRYPTO-179.
-
Resolution: Fixed
> Crash on macOS with default crypto library
> --
>
>
arthurscchan commented on PR #222:
URL: https://github.com/apache/commons-codec/pull/222#issuecomment-1827764168
@garydgregory Oh, you are right, if we filtered out invalid data, then the
round trip result will be differed from the original input. Sorry for missing
that. Maybe throwing
arthurscchan commented on PR #222:
URL: https://github.com/apache/commons-codec/pull/222#issuecomment-1827774135
Hi @garydgregory,
I think it is a different case. The invalid bytes are provided through
constructor, it is only used for the initial setting of the PercentCodec object
garydgregory commented on PR #108:
URL: https://github.com/apache/commons-digester/pull/108#issuecomment-1827724597
Hello @shreyakapoor08
It would be more helpful if you looked at our Jira database and fixed bugs
instead of proposing non-functional changes.
Any PR takes time to
Radar wen created IO-823:
Summary: The response time of some interfaces is inconsistent with
the expected time.
Key: IO-823
URL: https://issues.apache.org/jira/browse/IO-823
Project: Commons IO
20 matches
Mail list logo