Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/316#issuecomment-70348260
I will take a look at it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/316
[FLINK-1369] [types] Add support for Subclasses, Interfaces, Abstract
Classes
This PR rebased PR #236 to the current master.
Some tests were failing and I had a closer look. The original PR handl
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/292#discussion_r23110179
--- Diff: docs/yarn_setup.md ---
@@ -173,6 +171,24 @@ You can check the number of TaskManagers in the
JobManager web interface. The ad
If the TaskManager
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/313#issuecomment-70308172
Okay, thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
[
https://issues.apache.org/jira/browse/FLINK-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280590#comment-14280590
]
Henry Saputra commented on FLINK-655:
-
I change the summary to reflect the new task to
[
https://issues.apache.org/jira/browse/FLINK-655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Saputra updated FLINK-655:
Summary: Add support for both single and set of broadcast values (was:
Rename DataSet.withBroadcastS
Github user he-sk commented on the pull request:
https://github.com/apache/flink/pull/243#issuecomment-70294808
Hi @fhueske,
If you want to take over the PR I would appreciate that. My Scala knowledge
is extremely limited so I would need help to implement the Scala API anyway.
--
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/313#issuecomment-70284303
Thanks @rmetzger, will merge this today. Not a blocker for 0.8 so I will
not merge it to 0.8 branch.
---
If your project is set up for it, you can reply to this email a
[
https://issues.apache.org/jira/browse/FLINK-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280476#comment-14280476
]
Henry Saputra commented on FLINK-655:
-
That's what I thought. I wanted to change the si
[
https://issues.apache.org/jira/browse/FLINK-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279683#comment-14279683
]
Henry Saputra edited comment on FLINK-655 at 1/16/15 4:36 PM:
--
Till Rohrmann created FLINK-1411:
Summary: PlanVisualizer is not working
Key: FLINK-1411
URL: https://issues.apache.org/jira/browse/FLINK-1411
Project: Flink
Issue Type: Bug
Repor
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/299#issuecomment-70269761
Oh, yes .. sorry. I need to be more careful when reviewing pull requests.
+1 to merge this.
---
If your project is set up for it, you can reply to this email and
[
https://issues.apache.org/jira/browse/FLINK-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280327#comment-14280327
]
Robert Metzger commented on FLINK-1387:
---
There are two footer files (one md and one
Robert Metzger created FLINK-1410:
-
Summary: Integrate Flink version variables into website layout
Key: FLINK-1410
URL: https://issues.apache.org/jira/browse/FLINK-1410
Project: Flink
Issue T
[
https://issues.apache.org/jira/browse/FLINK-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger resolved FLINK-1379.
---
Resolution: Fixed
Resolved in http://svn.apache.org/r1652422.
Thank you Max.
> add RSS feed f
[
https://issues.apache.org/jira/browse/FLINK-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280297#comment-14280297
]
Timo Walther commented on FLINK-1098:
-
What do you think about a additional method "co
[
https://issues.apache.org/jira/browse/FLINK-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280295#comment-14280295
]
Stephan Ewen commented on FLINK-1407:
-
Does it make sense to:
- disable logging for c
[
https://issues.apache.org/jira/browse/FLINK-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280296#comment-14280296
]
Till Rohrmann commented on FLINK-1407:
--
4 MB it must not exceed
> Enable log output
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/210#issuecomment-70258735
With the scheduler and intermediate data set enhancements coming up for 0.9
soon, this is now quite feasible to use. I suggest to merge it once the inline
comments are
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/249#issuecomment-70257415
I think that this one can go into the 0.9 master now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/60#issuecomment-70257305
I think at this time, we can close the pull request. We need a different
angle for this, given the new scheduler implementation.
---
If your project is set up for it,
[
https://issues.apache.org/jira/browse/FLINK-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280251#comment-14280251
]
Till Rohrmann commented on FLINK-1407:
--
How long can the log file be?
> Enable log o
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/210#discussion_r23081185
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/AbstractIDTest.java ---
@@ -23,8 +23,8 @@
import static org.junit.Assert.fail;
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/210#discussion_r23081083
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/Utils.java ---
@@ -32,4 +38,44 @@ public static String getCallLocationName(int depth) {
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/210#discussion_r23081023
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -302,7 +308,48 @@ public ExecutionEnvironment getExecutionEnvironment() {
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/210#discussion_r23080920
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/accumulators/ListAccumulator.java
---
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apac
[
https://issues.apache.org/jira/browse/FLINK-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280231#comment-14280231
]
Ufuk Celebi commented on FLINK-1409:
Thanks :-) I've just looked into it and I know wh
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/299#issuecomment-70255146
There are test cases. I have adapted the existing ones.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
[
https://issues.apache.org/jira/browse/FLINK-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280224#comment-14280224
]
Gyula Fora commented on FLINK-1409:
---
Thanks, let me know if I can help in any way.
> Co
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/315
[FLINK-1147][Java API] TypeInference on POJOs
The TypeExtractor now also fully supports generic POJOs and tries to get
missing types by using type inference.
Functions can look like:
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/311#issuecomment-70236149
Thanks for the review!
Proposed names for "constant field" semantic properties:
* constant fields (current)
* unmodified fields
* forwarded fields
*
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/311#discussion_r23073054
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -45,6 +46,16 @@
*/
public class PojoTypeInfo extend
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/301#issuecomment-70234744
BTW: How is that done in Hadoop? Can we follow a similar way, to make it
easier for users to understand this?
---
If your project is set up for it, you can reply to t
[
https://issues.apache.org/jira/browse/FLINK-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Max Michels updated FLINK-1406:
---
Attachment: flink_1406.patch
Here is the patch for the "how to contribute" guide in addition to the pu
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/314#issuecomment-70234048
Good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/314
[FLINK-1406] update Flink compatibility notice
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink flink_1406
Alternatively you can review and
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/304#issuecomment-70231876
Change looks good except for comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/304#discussion_r23071236
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/KryoSerializer.java
---
@@ -185,6 +187,8 @@ private void checkKryoInitialized(
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/313#issuecomment-70230897
Looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/311#issuecomment-70230559
Except for the comments and the missing documentation, the change looks
good.
I can however not really validate the changes in the optimizer.
---
If your project is
[
https://issues.apache.org/jira/browse/FLINK-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280036#comment-14280036
]
Max Michels commented on FLINK-1379:
Thank you for the hint, Robert. I guess I'm too m
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/311#discussion_r23070841
--- Diff:
flink-compiler/src/main/java/org/apache/flink/compiler/dag/BinaryUnionNode.java
---
@@ -266,4 +268,44 @@ public void computeOutputEstimates(DataSta
[
https://issues.apache.org/jira/browse/FLINK-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280035#comment-14280035
]
Ufuk Celebi commented on FLINK-1409:
I'll add a test case and look into it right now.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/296
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/311#discussion_r23070438
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -45,6 +46,16 @@
*/
public class PojoTypeInfo exten
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/311#discussion_r23070484
--- Diff:
flink-compiler/src/main/java/org/apache/flink/compiler/dag/BinaryUnionNode.java
---
@@ -266,4 +268,44 @@ public void computeOutputEstimates(DataStat
[
https://issues.apache.org/jira/browse/FLINK-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280030#comment-14280030
]
Fabian Hueske commented on FLINK-655:
-
Aren't we going for two methods?
1. {{op.withBro
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/311#discussion_r23069937
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/functions/SemanticPropUtil.java
---
@@ -40,38 +45,108 @@
import org.apache.flink.api.java.f
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/311#discussion_r23069617
--- Diff:
flink-compiler/src/main/java/org/apache/flink/compiler/dag/BinaryUnionNode.java
---
@@ -266,4 +268,44 @@ public void computeOutputEstimates(DataSta
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/311#issuecomment-70226947
How about names along the lines of "Unmodified Fields" ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/299#issuecomment-70226685
The change looks good. I would like to see some test cases there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
[
https://issues.apache.org/jira/browse/FLINK-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280004#comment-14280004
]
Till Rohrmann commented on FLINK-655:
-
I think the getBroadcastVariable returns a List
[
https://issues.apache.org/jira/browse/FLINK-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279982#comment-14279982
]
Robert Metzger commented on FLINK-1372:
---
Yes, switching the logger sounds good. The
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/304#discussion_r23068156
--- Diff: flink-java/pom.xml ---
@@ -64,6 +64,18 @@ under the License.
0.5.1
+
--- End diff -
54 matches
Mail list logo
