[jira] [Created] (FLINK-2627) Make Scala Data Set utils easier to access

2015-09-07 Thread Sachin Goel (JIRA)
Sachin Goel created FLINK-2627: -- Summary: Make Scala Data Set utils easier to access Key: FLINK-2627 URL: https://issues.apache.org/jira/browse/FLINK-2627 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-2627) Make Scala Data Set utils easier to access

2015-09-07 Thread Sachin Goel (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sachin Goel updated FLINK-2627: --- Priority: Trivial (was: Major) > Make Scala Data Set utils easier to access > ---

[jira] [Assigned] (FLINK-2627) Make Scala Data Set utils easier to access

2015-09-07 Thread Sachin Goel (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sachin Goel reassigned FLINK-2627: -- Assignee: Sachin Goel > Make Scala Data Set utils easier to access > --

[jira] [Updated] (FLINK-2627) Make Scala Data Set utils easier to access

2015-09-07 Thread Sachin Goel (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sachin Goel updated FLINK-2627: --- Issue Type: Improvement (was: Bug) > Make Scala Data Set utils easier to access > ---

[jira] [Updated] (FLINK-2627) Make Scala Data Set utils easier to access

2015-09-07 Thread Sachin Goel (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sachin Goel updated FLINK-2627: --- Component/s: Scala API > Make Scala Data Set utils easier to access >

[jira] [Commented] (FLINK-2627) Make Scala Data Set utils easier to access

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1478#comment-1478 ] ASF GitHub Bot commented on FLINK-2627: --- GitHub user sachingoel0101 opened a pull re

[GitHub] flink pull request: [FLINK-2627][utils]Make Scala Data Set utils e...

2015-09-07 Thread sachingoel0101
GitHub user sachingoel0101 opened a pull request: https://github.com/apache/flink/pull/1099 [FLINK-2627][utils]Make Scala Data Set utils easier to access Introduces a package object for Scala data set utils to simplify usage. New usage: `import org.apache.flink.api.scala.utils._`

[jira] [Commented] (FLINK-2626) Add a AverageAccumulator for FLINK-Accumulator

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733341#comment-14733341 ] ASF GitHub Bot commented on FLINK-2626: --- Github user sachingoel0101 commented on a d

[jira] [Commented] (FLINK-2626) Add a AverageAccumulator for FLINK-Accumulator

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733340#comment-14733340 ] ASF GitHub Bot commented on FLINK-2626: --- Github user sachingoel0101 commented on a d

[GitHub] flink pull request: [FLINK-2626][CORE]add averageaccumulator

2015-09-07 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1096#discussion_r38838868 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/accumulators/AverageAccumulator.java --- @@ -0,0 +1,98 @@ +/* + * Licensed to t

[GitHub] flink pull request: [FLINK-2626][CORE]add averageaccumulator

2015-09-07 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1096#discussion_r38838895 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/accumulators/AverageAccumulator.java --- @@ -0,0 +1,98 @@ +/* + * Licensed to t

[GitHub] flink pull request: [FLINK-2626][CORE]add averageaccumulator

2015-09-07 Thread HuangWHWHW
Github user HuangWHWHW commented on a diff in the pull request: https://github.com/apache/flink/pull/1096#discussion_r38839459 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/accumulators/AverageAccumulator.java --- @@ -0,0 +1,98 @@ +/* + * Licensed to the A

[jira] [Commented] (FLINK-2626) Add a AverageAccumulator for FLINK-Accumulator

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733351#comment-14733351 ] ASF GitHub Bot commented on FLINK-2626: --- Github user HuangWHWHW commented on a diff

[GitHub] flink pull request: [FLINK-2626][CORE]add averageaccumulator

2015-09-07 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1096#discussion_r38839638 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/accumulators/AverageAccumulator.java --- @@ -0,0 +1,98 @@ +/* + * Licensed to t

[jira] [Commented] (FLINK-2626) Add a AverageAccumulator for FLINK-Accumulator

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733352#comment-14733352 ] ASF GitHub Bot commented on FLINK-2626: --- Github user sachingoel0101 commented on a d

[GitHub] flink pull request: [FLINK-2106] [runtime] add Left-, Right- and F...

2015-09-07 Thread r-pogalz
Github user r-pogalz commented on the pull request: https://github.com/apache/flink/pull/1052#issuecomment-138221929 The warnings fix commit is ready for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[jira] [Commented] (FLINK-2106) Add outer joins to Runtime

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733362#comment-14733362 ] ASF GitHub Bot commented on FLINK-2106: --- Github user r-pogalz commented on the pull

[GitHub] flink pull request: [FLINK-2627][utils]Make Scala Data Set utils e...

2015-09-07 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1099#discussion_r38841668 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/utils/package.scala --- @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software F

[jira] [Commented] (FLINK-2627) Make Scala Data Set utils easier to access

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733374#comment-14733374 ] ASF GitHub Bot commented on FLINK-2627: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request: [FLINK-2017] Add predefined required parameter...

2015-09-07 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1097#issuecomment-138229357 Thanks for the PR! I am sure that the mentioned test failure is unrelated to your changes. If you like, you can create a new issue with the label test-instability for the fa

[jira] [Commented] (FLINK-2017) Add predefined required parameters to ParameterTool

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733376#comment-14733376 ] ASF GitHub Bot commented on FLINK-2017: --- Github user uce commented on the pull reque

[jira] [Commented] (FLINK-2625) Configuration not passed to JobGraphGenerator

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733379#comment-14733379 ] ASF GitHub Bot commented on FLINK-2625: --- Github user uce commented on the pull reque

[GitHub] flink pull request: [FLINK-2622][streaming]add WriteMode for write...

2015-09-07 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1098#issuecomment-138230399 Thanks for your contribution @HuangWHWHW. However, your changes are not compatible to the Java DataStream API. Both APIs should support the same functionality with

[jira] [Commented] (FLINK-2622) Scala DataStream API does not have writeAsText method which supports WriteMode

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733380#comment-14733380 ] ASF GitHub Bot commented on FLINK-2622: --- Github user tillrohrmann commented on the p

[GitHub] flink pull request: [FLINK-2625] Configuration not passed to JobGr...

2015-09-07 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1095#issuecomment-138230380 Good catch, Greg! Looks good to merge. I guess this fixed your "max-fan" issue as well, right? --- If your project is set up for it, you can reply to this email and have yo

[GitHub] flink pull request: [FLINK-2626][CORE]add averageaccumulator

2015-09-07 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1096#issuecomment-138230933 @sachingoel0101 Hi, I removed these two methods as you said. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-2627][utils]Make Scala Data Set utils e...

2015-09-07 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1099#discussion_r38842188 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/utils/package.scala --- @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Softwar

[jira] [Commented] (FLINK-2627) Make Scala Data Set utils easier to access

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733385#comment-14733385 ] ASF GitHub Bot commented on FLINK-2627: --- Github user sachingoel0101 commented on a d

[jira] [Commented] (FLINK-2626) Add a AverageAccumulator for FLINK-Accumulator

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733386#comment-14733386 ] ASF GitHub Bot commented on FLINK-2626: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2625] Configuration not passed to JobGr...

2015-09-07 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1095#issuecomment-138234651 +1 Will merge this to `master` and `0.10-milestone1` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (FLINK-2627) Make Scala Data Set utils easier to access

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733394#comment-14733394 ] ASF GitHub Bot commented on FLINK-2627: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2627][utils]Make Scala Data Set utils e...

2015-09-07 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1099#discussion_r38842611 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/utils/package.scala --- @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-2625) Configuration not passed to JobGraphGenerator

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733393#comment-14733393 ] ASF GitHub Bot commented on FLINK-2625: --- Github user StephanEwen commented on the pu

[jira] [Commented] (FLINK-2622) Scala DataStream API does not have writeAsText method which supports WriteMode

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733398#comment-14733398 ] ASF GitHub Bot commented on FLINK-2622: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2622][streaming]add WriteMode for write...

2015-09-07 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1098#issuecomment-138236351 @tillrohrmann Hi, I see. The issue about order is just in the scala-example SocketTextStreamWordCount.scala as following: { if (fileOutput)

[jira] [Commented] (FLINK-2619) Some Scala Tests not being executed by Maven

2015-09-07 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733405#comment-14733405 ] Stephan Ewen commented on FLINK-2619: - +1 for option 1 > Some Scala Tests not being e

[GitHub] flink pull request: [FLINK-2583] Add Stream Sink For Rolling HDFS ...

2015-09-07 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1084#issuecomment-138237480 I mean can we get the "truncate()" behavior for local file systems even if you build for Hadoop versions earlier than 2.7? --- If your project is set up for it, yo

[jira] [Commented] (FLINK-1320) Add an off-heap variant of the managed memory

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733406#comment-14733406 ] ASF GitHub Bot commented on FLINK-1320: --- Github user uce commented on the pull reque

[GitHub] flink pull request: [FLINK-1320] [core] Add an off-heap variant of...

2015-09-07 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1093#issuecomment-138237365 Impressive! :-) Thanks for the write up. I think I've learned something about the JVM by reading your PR description. ;) With some minor refactorings in the network

[jira] [Commented] (FLINK-2583) Add Stream Sink For Rolling HDFS Files

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733408#comment-14733408 ] ASF GitHub Bot commented on FLINK-2583: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-1320] Add an off-heap variant of the ma...

2015-09-07 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/290#issuecomment-138237563 This is subsumed by Stephan's new PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (FLINK-1320) Add an off-heap variant of the managed memory

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733409#comment-14733409 ] ASF GitHub Bot commented on FLINK-1320: --- Github user uce commented on the pull reque

[jira] [Commented] (FLINK-2624) RabbitMQ source / sink should participate in checkpointing

2015-09-07 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733412#comment-14733412 ] Aljoscha Krettek commented on FLINK-2624: - Is it even possible with RabbitMQ to se

[GitHub] flink pull request: [FLINK-2493] Simplify names of example program...

2015-09-07 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1094#issuecomment-138239089 Looks nice. Can you help me quickly? I would like to understand why the internal maven dependencies on the Java examples have problems when you use the "fina

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733417#comment-14733417 ] ASF GitHub Bot commented on FLINK-2493: --- Github user StephanEwen commented on the pu

[jira] [Commented] (FLINK-2348) Instable (failing) Test

2015-09-07 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733418#comment-14733418 ] Aljoscha Krettek commented on FLINK-2348: - I don't think that's possible since it

[GitHub] flink pull request: Implementation of distributed copying utility ...

2015-09-07 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1090#issuecomment-138240660 Okay, let's merge it to the examples. @detonator413 Can you add some class-level comments to the files that explains what they do? Also, we need to remov

[jira] [Created] (FLINK-2628) Failing Test: StreamFaultToleranceTestBase.runCheckpointedProgram

2015-09-07 Thread Martin Liesenberg (JIRA)
Martin Liesenberg created FLINK-2628: Summary: Failing Test: StreamFaultToleranceTestBase.runCheckpointedProgram Key: FLINK-2628 URL: https://issues.apache.org/jira/browse/FLINK-2628 Project: Flin

[jira] [Commented] (FLINK-2372) Update KafkaSink to use new Producer API

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733425#comment-14733425 ] ASF GitHub Bot commented on FLINK-2372: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2372] Add new FlinkKafkaProducer

2015-09-07 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1082#issuecomment-138241493 Looks good. Merging this to "master" and "0.10-milestone1" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-2017) Add predefined required parameters to ParameterTool

2015-09-07 Thread Martin Liesenberg (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733426#comment-14733426 ] Martin Liesenberg commented on FLINK-2017: -- Yes, I wasnt able to reproduce it loc

[GitHub] flink pull request: Implementation of distributed copying utility ...

2015-09-07 Thread detonator413
Github user detonator413 commented on the pull request: https://github.com/apache/flink/pull/1090#issuecomment-138241466 Sure, will push some changes soon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[jira] [Updated] (FLINK-2348) IterateExampleITCase failing

2015-09-07 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi updated FLINK-2348: --- Summary: IterateExampleITCase failing (was: Instable (failing) Test) > IterateExampleITCase failing >

[GitHub] flink pull request: [FLINK-1320] [core] Add an off-heap variant of...

2015-09-07 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1093#issuecomment-138242989 Really impressive work @StephanEwen. Will be hard to review due to its sheer extent. --- If your project is set up for it, you can reply to this email and have you

[jira] [Commented] (FLINK-1320) Add an off-heap variant of the managed memory

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733427#comment-14733427 ] ASF GitHub Bot commented on FLINK-1320: --- Github user tillrohrmann commented on the p

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-09-07 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1046#discussion_r38844529 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers/StormWrapperSetupHelp

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733429#comment-14733429 ] ASF GitHub Bot commented on FLINK-2525: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request: [FLINK-2017] Add predefined required parameter...

2015-09-07 Thread mliesenberg
Github user mliesenberg commented on the pull request: https://github.com/apache/flink/pull/1097#issuecomment-138243384 OK, cool. I have created a separate ticket. https://issues.apache.org/jira/browse/FLINK-2628 --- If your project is set up for it, you can reply to this email and h

[jira] [Commented] (FLINK-2017) Add predefined required parameters to ParameterTool

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733431#comment-14733431 ] ASF GitHub Bot commented on FLINK-2017: --- Github user mliesenberg commented on the pu

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733432#comment-14733432 ] ASF GitHub Bot commented on FLINK-2525: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-09-07 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1046#discussion_r38844654 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/test/java/org/apache/flink/stormcompatibility/wrappers/StormBoltWrapperTest.

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-09-07 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1046#discussion_r38844802 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/excamation/ExclamationWith

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733433#comment-14733433 ] ASF GitHub Bot commented on FLINK-2525: --- Github user rmetzger commented on a diff in

[jira] [Commented] (FLINK-2622) Scala DataStream API does not have writeAsText method which supports WriteMode

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733434#comment-14733434 ] ASF GitHub Bot commented on FLINK-2622: --- Github user tillrohrmann commented on the p

[GitHub] flink pull request: [FLINK-2622][streaming]add WriteMode for write...

2015-09-07 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1098#issuecomment-138243780 It's not only about the order but also about the support signatures. Best you take a look at the Java `DataStream` implementation to see what's supported. T

[GitHub] flink pull request: [FLINK-2622][streaming]add WriteMode for write...

2015-09-07 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1098#issuecomment-138247906 @tillrohrmann Hi, Thank you for the CI info! As I see, the writeAsText in scala DataStream calls the same method in Java DataStream(any misunderstanding?)

[jira] [Commented] (FLINK-2622) Scala DataStream API does not have writeAsText method which supports WriteMode

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733449#comment-14733449 ] ASF GitHub Bot commented on FLINK-2622: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2622][streaming]add WriteMode for write...

2015-09-07 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1098#issuecomment-138249409 I mean that the APIs are not consistent. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[jira] [Commented] (FLINK-2622) Scala DataStream API does not have writeAsText method which supports WriteMode

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733452#comment-14733452 ] ASF GitHub Bot commented on FLINK-2622: --- Github user tillrohrmann commented on the p

[GitHub] flink pull request: [FLINK-2622][streaming]add WriteMode for write...

2015-09-07 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1098#issuecomment-138249745 In the Java DataStream API you can call the `writeAsText` method with: * path * path, write frequency * path, writemode * path. writemode, write

[jira] [Commented] (FLINK-2622) Scala DataStream API does not have writeAsText method which supports WriteMode

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733456#comment-14733456 ] ASF GitHub Bot commented on FLINK-2622: --- Github user tillrohrmann commented on the p

[jira] [Commented] (FLINK-2622) Scala DataStream API does not have writeAsText method which supports WriteMode

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733461#comment-14733461 ] ASF GitHub Bot commented on FLINK-2622: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2622][streaming]add WriteMode for write...

2015-09-07 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1098#issuecomment-138250808 Ah, I get you. Maybe one writeAsText method is not enough. Add more writeAsText methods as JAVA DataStream? And is there the same issue in writeAsCsv()?

[GitHub] flink pull request: [FLINK-2622][streaming]add WriteMode for write...

2015-09-07 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1098#issuecomment-138251605 1. Yes 2. You should check --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (FLINK-2622) Scala DataStream API does not have writeAsText method which supports WriteMode

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733465#comment-14733465 ] ASF GitHub Bot commented on FLINK-2622: --- Github user tillrohrmann commented on the p

[jira] [Commented] (FLINK-2583) Add Stream Sink For Rolling HDFS Files

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733470#comment-14733470 ] ASF GitHub Bot commented on FLINK-2583: --- Github user aljoscha commented on the pull

[GitHub] flink pull request: [FLINK-2583] Add Stream Sink For Rolling HDFS ...

2015-09-07 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1084#issuecomment-138252252 It could be done by circumventing FileSystem and just using the regular Java File I/O API to perform the truncate if we detect that the FileSystem works on file "file:/

[GitHub] flink pull request: [FLINK-2627][utils]Make Scala Data Set utils e...

2015-09-07 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1099#issuecomment-138258862 I am unable to get rid of the implicit type information for the `zip` functions, presumably because the type information for `(Long,T)` isn't found. --- If your

[jira] [Commented] (FLINK-2627) Make Scala Data Set utils easier to access

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733501#comment-14733501 ] ASF GitHub Bot commented on FLINK-2627: --- Github user sachingoel0101 commented on the

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733522#comment-14733522 ] ASF GitHub Bot commented on FLINK-2525: --- Github user ffbin commented on the pull req

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-09-07 Thread ffbin
Github user ffbin commented on the pull request: https://github.com/apache/flink/pull/1046#issuecomment-138267349 @rmetzger Thanks.I have use the classloader of `StormWrapperSetupHelper´ instead of 'map' and change the fashion of creating Strings. --- If your project is set up for

[jira] [Commented] (FLINK-2622) Scala DataStream API does not have writeAsText method which supports WriteMode

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733528#comment-14733528 ] ASF GitHub Bot commented on FLINK-2622: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2622][streaming]add WriteMode for write...

2015-09-07 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1098#issuecomment-138267803 @tillrohrmann Thank you for the comments! I will take the fix and add tests for this. BTW:Can you take a look about this PR:https://github.com/apache/flin

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-09-07 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/992#issuecomment-138268476 @mxm @StephanEwen Hi, very sorry for bothering. I got the CI passed. Is there any new comment or this can be merged? --- If your project is set up f

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733535#comment-14733535 ] ASF GitHub Bot commented on FLINK-2490: --- Github user HuangWHWHW commented on the pul

[jira] [Commented] (FLINK-2583) Add Stream Sink For Rolling HDFS Files

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733537#comment-14733537 ] ASF GitHub Bot commented on FLINK-2583: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2583] Add Stream Sink For Rolling HDFS ...

2015-09-07 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1084#issuecomment-138268930 Let's add this after we merge this, but it sounds quite valueable to me... --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] flink pull request: [FLINK-1320] [core] Add an off-heap variant of...

2015-09-07 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1093#issuecomment-138269258 I think it looks larger than it is. Many small changes dues to changes signatures of the MemoryManager and the MemorySegment instantiation. Also, the vast ma

[jira] [Commented] (FLINK-1320) Add an off-heap variant of the managed memory

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733540#comment-14733540 ] ASF GitHub Bot commented on FLINK-1320: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2627][utils]Make Scala Data Set utils e...

2015-09-07 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1099#issuecomment-138269532 Have you tried constructing the type information explicitly `createTypeInformation[(Long, T)]`? --- If your project is set up for it, you can reply to this email a

[jira] [Commented] (FLINK-2627) Make Scala Data Set utils easier to access

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733541#comment-14733541 ] ASF GitHub Bot commented on FLINK-2627: --- Github user tillrohrmann commented on the p

[GitHub] flink pull request: [FLINK-1320] [core] Add an off-heap variant of...

2015-09-07 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1093#issuecomment-138270482 Since this does not break or alter any existing behavior, I would like to merge it rather soon (as soon as concerns have been cleared). We an polish the off-

[jira] [Commented] (FLINK-1320) Add an off-heap variant of the managed memory

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733543#comment-14733543 ] ASF GitHub Bot commented on FLINK-1320: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2626][CORE]add averageaccumulator

2015-09-07 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1096#issuecomment-138273532 Looks good, +1 to merge this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (FLINK-2626) Add a AverageAccumulator for FLINK-Accumulator

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733555#comment-14733555 ] ASF GitHub Bot commented on FLINK-2626: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2626][CORE]add averageaccumulator

2015-09-07 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1096#issuecomment-138274145 Why is `public void add(Double value)` overloaded with `public void add(double value)`? The usage of primitive types and there class counterparts seem to be mixed... Why?

[jira] [Commented] (FLINK-2626) Add a AverageAccumulator for FLINK-Accumulator

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733562#comment-14733562 ] ASF GitHub Bot commented on FLINK-2626: --- Github user mjsax commented on the pull req

[GitHub] flink pull request: [FLINK-2626][CORE]add averageaccumulator

2015-09-07 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1096#issuecomment-138276764 @mjsax Do you mean that remove the `public void add(double value)`? I`m not quite sure how this can be used in the feature. @StephanEwen Thank yo

[jira] [Commented] (FLINK-2493) Simplify names of example program JARs

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733570#comment-14733570 ] ASF GitHub Bot commented on FLINK-2493: --- Github user chenliang613 commented on the p

[jira] [Commented] (FLINK-2626) Add a AverageAccumulator for FLINK-Accumulator

2015-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733571#comment-14733571 ] ASF GitHub Bot commented on FLINK-2626: --- Github user HuangWHWHW commented on the pul

  1   2   3   >