Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1099#discussion_r38841668
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/utils/package.scala ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/FLINK-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733374#comment-14733374
]
ASF GitHub Bot commented on FLINK-2627:
---
Github user StephanEwen commented on a diff in the pull
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-138229357
Thanks for the PR! I am sure that the mentioned test failure is unrelated
to your changes. If you like, you can create a new issue with the label
test-instability for the
[
https://issues.apache.org/jira/browse/FLINK-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733376#comment-14733376
]
ASF GitHub Bot commented on FLINK-2017:
---
Github user uce commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733405#comment-14733405
]
Stephan Ewen commented on FLINK-2619:
-
+1 for option 1
> Some Scala Tests not being executed by Maven
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38844802
--- Diff:
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733433#comment-14733433
]
ASF GitHub Bot commented on FLINK-2525:
---
Github user rmetzger commented on a diff in the pull
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1098#issuecomment-138249409
I mean that the APIs are not consistent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/FLINK-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733452#comment-14733452
]
ASF GitHub Bot commented on FLINK-2622:
---
Github user tillrohrmann commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1478#comment-1478
]
ASF GitHub Bot commented on FLINK-2627:
---
GitHub user sachingoel0101 opened a pull request:
GitHub user sachingoel0101 opened a pull request:
https://github.com/apache/flink/pull/1099
[FLINK-2627][utils]Make Scala Data Set utils easier to access
Introduces a package object for Scala data set utils to simplify usage.
New usage: `import
[
https://issues.apache.org/jira/browse/FLINK-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733406#comment-14733406
]
ASF GitHub Bot commented on FLINK-1320:
---
Github user uce commented on the pull request:
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1093#issuecomment-138237365
Impressive! :-) Thanks for the write up. I think I've learned something
about the JVM by reading your PR description. ;)
With some minor refactorings in the network
[
https://issues.apache.org/jira/browse/FLINK-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733408#comment-14733408
]
ASF GitHub Bot commented on FLINK-2583:
---
Github user StephanEwen commented on the pull request:
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1084#issuecomment-138237480
I mean can we get the "truncate()" behavior for local file systems even if
you build for Hadoop versions earlier than 2.7?
---
If your project is set up for it,
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/290#issuecomment-138237563
This is subsumed by Stephan's new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Martin Liesenberg created FLINK-2628:
Summary: Failing Test:
StreamFaultToleranceTestBase.runCheckpointedProgram
Key: FLINK-2628
URL: https://issues.apache.org/jira/browse/FLINK-2628
Project:
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1090#issuecomment-138240660
Okay, let's merge it to the examples.
@detonator413 Can you add some class-level comments to the files that
explains what they do?
Also, we need to
[
https://issues.apache.org/jira/browse/FLINK-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733461#comment-14733461
]
ASF GitHub Bot commented on FLINK-2622:
---
Github user HuangWHWHW commented on the pull request:
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/1098#issuecomment-138250808
Ah, I get you.
Maybe one writeAsText method is not enough.
Add more writeAsText methods as JAVA DataStream?
And is there the same issue in writeAsCsv()?
[
https://issues.apache.org/jira/browse/FLINK-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sachin Goel updated FLINK-2627:
---
Priority: Trivial (was: Major)
> Make Scala Data Set utils easier to access
>
[
https://issues.apache.org/jira/browse/FLINK-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sachin Goel reassigned FLINK-2627:
--
Assignee: Sachin Goel
> Make Scala Data Set utils easier to access
>
Sachin Goel created FLINK-2627:
--
Summary: Make Scala Data Set utils easier to access
Key: FLINK-2627
URL: https://issues.apache.org/jira/browse/FLINK-2627
Project: Flink
Issue Type: Bug
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1096#discussion_r38838868
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/accumulators/AverageAccumulator.java
---
@@ -0,0 +1,98 @@
+/*
+ * Licensed to
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1096#discussion_r38838895
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/accumulators/AverageAccumulator.java
---
@@ -0,0 +1,98 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733340#comment-14733340
]
ASF GitHub Bot commented on FLINK-2626:
---
Github user sachingoel0101 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733341#comment-14733341
]
ASF GitHub Bot commented on FLINK-2626:
---
Github user sachingoel0101 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733351#comment-14733351
]
ASF GitHub Bot commented on FLINK-2626:
---
Github user HuangWHWHW commented on a diff in the pull
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1096#discussion_r38839638
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/accumulators/AverageAccumulator.java
---
@@ -0,0 +1,98 @@
+/*
+ * Licensed to
Github user HuangWHWHW commented on a diff in the pull request:
https://github.com/apache/flink/pull/1096#discussion_r38839459
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/accumulators/AverageAccumulator.java
---
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the
Github user r-pogalz commented on the pull request:
https://github.com/apache/flink/pull/1052#issuecomment-138221929
The warnings fix commit is ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1099#discussion_r38842611
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/utils/package.scala ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/FLINK-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733393#comment-14733393
]
ASF GitHub Bot commented on FLINK-2625:
---
Github user StephanEwen commented on the pull request:
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1094#issuecomment-138239089
Looks nice.
Can you help me quickly? I would like to understand why the internal maven
dependencies on the Java examples have problems when you use the
[
https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733417#comment-14733417
]
ASF GitHub Bot commented on FLINK-2493:
---
Github user StephanEwen commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733418#comment-14733418
]
Aljoscha Krettek commented on FLINK-2348:
-
I don't think that's possible since it is a Streaming
[
https://issues.apache.org/jira/browse/FLINK-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733431#comment-14733431
]
ASF GitHub Bot commented on FLINK-2017:
---
Github user mliesenberg commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733432#comment-14733432
]
ASF GitHub Bot commented on FLINK-2525:
---
Github user rmetzger commented on a diff in the pull
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-138243384
OK, cool. I have created a separate ticket.
https://issues.apache.org/jira/browse/FLINK-2628
---
If your project is set up for it, you can reply to this email and
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38844654
--- Diff:
[
https://issues.apache.org/jira/browse/FLINK-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733470#comment-14733470
]
ASF GitHub Bot commented on FLINK-2583:
---
Github user aljoscha commented on the pull request:
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1084#issuecomment-138252252
It could be done by circumventing FileSystem and just using the regular
Java File I/O API to perform the truncate if we detect that the FileSystem
works on file
Github user detonator413 commented on the pull request:
https://github.com/apache/flink/pull/1090#issuecomment-138241466
Sure, will push some changes soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1082#issuecomment-138241493
Looks good. Merging this to "master" and "0.10-milestone1"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
[
https://issues.apache.org/jira/browse/FLINK-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733426#comment-14733426
]
Martin Liesenberg commented on FLINK-2017:
--
Yes, I wasnt able to reproduce it locally as well.
I
[
https://issues.apache.org/jira/browse/FLINK-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733425#comment-14733425
]
ASF GitHub Bot commented on FLINK-2372:
---
Github user StephanEwen commented on the pull request:
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1098#issuecomment-138243780
It's not only about the order but also about the support signatures. Best
you take a look at the Java `DataStream` implementation to see what's supported.
[
https://issues.apache.org/jira/browse/FLINK-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733434#comment-14733434
]
ASF GitHub Bot commented on FLINK-2622:
---
Github user tillrohrmann commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733449#comment-14733449
]
ASF GitHub Bot commented on FLINK-2622:
---
Github user HuangWHWHW commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733456#comment-14733456
]
ASF GitHub Bot commented on FLINK-2622:
---
Github user tillrohrmann commented on the pull request:
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1098#issuecomment-138251605
1. Yes
2. You should check
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
[
https://issues.apache.org/jira/browse/FLINK-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733465#comment-14733465
]
ASF GitHub Bot commented on FLINK-2622:
---
Github user tillrohrmann commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733352#comment-14733352
]
ASF GitHub Bot commented on FLINK-2626:
---
Github user sachingoel0101 commented on a diff in the pull
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1099#discussion_r38842188
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/utils/package.scala ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/FLINK-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733385#comment-14733385
]
ASF GitHub Bot commented on FLINK-2627:
---
Github user sachingoel0101 commented on a diff in the pull
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/1096#issuecomment-138230933
@sachingoel0101
Hi,
I removed these two methods as you said.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
[
https://issues.apache.org/jira/browse/FLINK-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733398#comment-14733398
]
ASF GitHub Bot commented on FLINK-2622:
---
Github user HuangWHWHW commented on the pull request:
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/1098#issuecomment-138247906
@tillrohrmann
Hi,
Thank you for the CI info!
As I see, the writeAsText in scala DataStream calls the same method in Java
DataStream(any
[
https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733386#comment-14733386
]
ASF GitHub Bot commented on FLINK-2626:
---
Github user HuangWHWHW commented on the pull request:
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/1098#issuecomment-138236351
@tillrohrmann
Hi,
I see.
The issue about order is just in the scala-example
SocketTextStreamWordCount.scala as following:
{
if (fileOutput)
[
https://issues.apache.org/jira/browse/FLINK-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733412#comment-14733412
]
Aljoscha Krettek commented on FLINK-2624:
-
Is it even possible with RabbitMQ to set an arbitrary
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1093#issuecomment-138242989
Really impressive work @StephanEwen. Will be hard to review due to its
sheer extent.
---
If your project is set up for it, you can reply to this email and have
[
https://issues.apache.org/jira/browse/FLINK-2348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ufuk Celebi updated FLINK-2348:
---
Summary: IterateExampleITCase failing (was: Instable (failing) Test)
> IterateExampleITCase failing
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1098#issuecomment-138249745
In the Java DataStream API you can call the `writeAsText` method with:
* path
* path, write frequency
* path, writemode
* path. writemode, write
[
https://issues.apache.org/jira/browse/FLINK-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sachin Goel updated FLINK-2627:
---
Issue Type: Improvement (was: Bug)
> Make Scala Data Set utils easier to access
>
[
https://issues.apache.org/jira/browse/FLINK-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sachin Goel updated FLINK-2627:
---
Component/s: Scala API
> Make Scala Data Set utils easier to access
>
[
https://issues.apache.org/jira/browse/FLINK-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733362#comment-14733362
]
ASF GitHub Bot commented on FLINK-2106:
---
Github user r-pogalz commented on the pull request:
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1098#issuecomment-138230399
Thanks for your contribution @HuangWHWHW. However, your changes are not
compatible to the Java DataStream API. Both APIs should support the same
functionality with
[
https://issues.apache.org/jira/browse/FLINK-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733380#comment-14733380
]
ASF GitHub Bot commented on FLINK-2622:
---
Github user tillrohrmann commented on the pull request:
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1095#issuecomment-138230380
Good catch, Greg! Looks good to merge. I guess this fixed your "max-fan"
issue as well, right?
---
If your project is set up for it, you can reply to this email and have
[
https://issues.apache.org/jira/browse/FLINK-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733394#comment-14733394
]
ASF GitHub Bot commented on FLINK-2627:
---
Github user tillrohrmann commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733427#comment-14733427
]
ASF GitHub Bot commented on FLINK-1320:
---
Github user tillrohrmann commented on the pull request:
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38844529
--- Diff:
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733429#comment-14733429
]
ASF GitHub Bot commented on FLINK-2525:
---
Github user rmetzger commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733541#comment-14733541
]
ASF GitHub Bot commented on FLINK-2627:
---
Github user tillrohrmann commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733580#comment-14733580
]
ASF GitHub Bot commented on FLINK-2626:
---
Github user mjsax commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733626#comment-14733626
]
Stephan Ewen commented on FLINK-2628:
-
This is a similar issue as we had in one other test. We cannot
[
https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733645#comment-14733645
]
ASF GitHub Bot commented on FLINK-2626:
---
Github user mjsax commented on the pull request:
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1096#issuecomment-138289016
I am pushing a hotfix to increase timeouts in the Kafka tests. That will
hopefully make the Kafka tests more reliable on Travis
---
If your project is set up for
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-138292133
@mjsax @StephanEwen @rmetzger I have finish the change about all comments.
Can you have a look at it if it can be merged? Thank you very much!
---
If your project is set
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733670#comment-14733670
]
ASF GitHub Bot commented on FLINK-2525:
---
Github user ffbin commented on the pull request:
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1084#issuecomment-138268930
Let's add this after we merge this, but it sounds quite valueable to me...
---
If your project is set up for it, you can reply to this email and have your
reply
[
https://issues.apache.org/jira/browse/FLINK-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733537#comment-14733537
]
ASF GitHub Bot commented on FLINK-2583:
---
Github user StephanEwen commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733562#comment-14733562
]
ASF GitHub Bot commented on FLINK-2626:
---
Github user mjsax commented on the pull request:
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1096#issuecomment-138274145
Why is `public void add(Double value)` overloaded with `public void
add(double value)`? The usage of primitive types and there class counterparts
seem to be mixed... Why?
[
https://issues.apache.org/jira/browse/FLINK-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733570#comment-14733570
]
ASF GitHub Bot commented on FLINK-2493:
---
Github user chenliang613 commented on the pull request:
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/1096#issuecomment-138276764
@mjsax
Do you mean that remove the `public void add(double value)`?
I`m not quite sure how this can be used in the feature.
@StephanEwen
Thank
[
https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733571#comment-14733571
]
ASF GitHub Bot commented on FLINK-2626:
---
Github user HuangWHWHW commented on the pull request:
Github user chenliang613 commented on the pull request:
https://github.com/apache/flink/pull/1094#issuecomment-138276703
Just as maillist the last message mentioned:
[
https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733594#comment-14733594
]
ASF GitHub Bot commented on FLINK-2626:
---
Github user HuangWHWHW commented on the pull request:
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1096#issuecomment-138288718
We should discuss this over the dev list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
[
https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733667#comment-14733667
]
ASF GitHub Bot commented on FLINK-2626:
---
Github user HuangWHWHW commented on the pull request:
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/992#issuecomment-138268476
@mxm
@StephanEwen
Hi, very sorry for bothering.
I got the CI passed.
Is there any new comment or this can be merged?
---
If your project is set up
[
https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733577#comment-14733577
]
ASF GitHub Bot commented on FLINK-2626:
---
Github user mjsax commented on the pull request:
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1096#issuecomment-138277939
Yes, I don't see any advantage in having this overload. I would also change
`add(long value)` and `add(int value)` into `add(Long value)` and `add(Integer
value)` for
Github user HuangWHWHW commented on a diff in the pull request:
https://github.com/apache/flink/pull/1096#discussion_r38856538
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/accumulators/AverageAccumulatorTest.java
---
@@ -0,0 +1,117 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733585#comment-14733585
]
ASF GitHub Bot commented on FLINK-2626:
---
Github user sachingoel0101 commented on the pull request:
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38856545
--- Diff: docs/apis/cli.md ---
@@ -185,6 +189,18 @@ Action "list" lists running and scheduled programs.
-s,--scheduledShow only
[
https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733601#comment-14733601
]
ASF GitHub Bot commented on FLINK-2626:
---
Github user mjsax commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733617#comment-14733617
]
ASF GitHub Bot commented on FLINK-2626:
---
Github user HuangWHWHW commented on the pull request:
1 - 100 of 234 matches
Mail list logo
