[
https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733571#comment-14733571
]
ASF GitHub Bot commented on FLINK-2626:
---------------------------------------
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/1096#issuecomment-138276764
@mjsax
Do you mean that remove the `public void add(double value)`?
I`m not quite sure how this can be used in the feature.
@StephanEwen
Thank you!
Otherwise, Can you take a look about my earlier PRs?
Since I have been fixing those for a long time and recently I took fixes
and passed the CI of them.
Many thanks for you and sorry for wasting your time.
> Add a AverageAccumulator for FLINK-Accumulator
> ----------------------------------------------
>
> Key: FLINK-2626
> URL: https://issues.apache.org/jira/browse/FLINK-2626
> Project: Flink
> Issue Type: New Feature
> Components: Core
> Affects Versions: 0.10
> Reporter: Huang Wei
> Fix For: 0.10
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Add a AverageAccumulator for Flink-Accumulator to calculate the average of
> values.
> The feature is like Storm-MultiReducedMetric.
> Feature in detail:
> 1.This class is named AverageAccumulator(any suggestion? I`m not good at
> English name) and implements SimpleAccumulator.
> 2.This class support long, integer and double input.
> 3.This class will return a double value as the average when the method
> getLocalValue() called.
> 4.Member method description:
> * add():
> A variety of add() method to support different inputs(e.g. Double, double,
> Long, long, Integer, int).
> It will add the input value and make the count + 1 each time.
> * public Double getLocalValue():
> To return the sum of value dividing count as average and the result will be
> "double".
> * public void resetLocal():
> To reset the value and count.
> It won`t be called automatically and it will be better to call this every
> time the getLocalValue() method called.
> * public void merge(Accumulator<Double, Double> other):
> To merge another accumulator(only support AverageAccumulator).
> * public AverageAccumulator clone():
> To return the whole current AverageAccumulator class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
