Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/858#discussion_r39017774
--- Diff:
flink-tests/src/test/scala/org/apache/flink/api/scala/runtime/jobmanager/JobManagerFailsITCase.scala
---
@@ -53,41 +54,41 @@ class
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1108#issuecomment-138823043
Manually merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1030#issuecomment-138841521
I think this looks good, except for the comment with the final variable for
the lock.
One more comment: When concatenating strings, avoid constructs like `"
[
https://issues.apache.org/jira/browse/FLINK-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736489#comment-14736489
]
ASF GitHub Bot commented on FLINK-2536:
---
Github user StephanEwen commented on a diff in the pull
Jonas Traub created FLINK-2642:
--
Summary: Scala Table API crashes when executing word count example
Key: FLINK-2642
URL: https://issues.apache.org/jira/browse/FLINK-2642
Project: Flink
Issue
[
https://issues.apache.org/jira/browse/FLINK-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736262#comment-14736262
]
Arnaud Linz commented on FLINK-2617:
hive-hcatalog-core-0.14.0.jar
> ConcurrentModificationException
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/889#issuecomment-138821798
Yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
[
https://issues.apache.org/jira/browse/FLINK-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736430#comment-14736430
]
ASF GitHub Bot commented on FLINK-2321:
---
Github user tillrohrmann commented on the pull request:
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1083#issuecomment-138825832
Hi @sachingoel0101,
I think there was no consensus in the discussion (FLINK-1730) for how to
implement this feature. @StephanEwen pointed that persisting data
[
https://issues.apache.org/jira/browse/FLINK-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736449#comment-14736449
]
ASF GitHub Bot commented on FLINK-1730:
---
Github user fhueske commented on the pull request:
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/858#issuecomment-138825995
Could you elaborate a little bit on what you refactored and which
components would be important to review?
---
If your project is set up for it, you can reply to
[
https://issues.apache.org/jira/browse/FLINK-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736450#comment-14736450
]
ASF GitHub Bot commented on FLINK-2097:
---
Github user tillrohrmann commented on the pull request:
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1078#issuecomment-138825531
Thanks a lot for the pull request.
Sorry that nobody looked at it yet. It seems that all committers are
currently very busy. I'm sure somebody will give you soon
[
https://issues.apache.org/jira/browse/FLINK-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736448#comment-14736448
]
ASF GitHub Bot commented on FLINK-1737:
---
Github user rmetzger commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736495#comment-14736495
]
ASF GitHub Bot commented on FLINK-2536:
---
Github user HuangWHWHW commented on the pull request:
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/1030#issuecomment-138842285
@tillrohrmann
Ah,sorry for bothering.
It doesn't matter.
Just I thought I did something wrong in the community.
:-D
---
If your project is set up
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/605#issuecomment-138847826
After rebasing the PR to the current master, the
`OperatorStatsAccumulatorTest` is failing. In the original PR (based on a
master from begin of August) the test is
[
https://issues.apache.org/jira/browse/FLINK-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736513#comment-14736513
]
ASF GitHub Bot commented on FLINK-1297:
---
Github user fhueske commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736432#comment-14736432
]
ASF GitHub Bot commented on FLINK-2321:
---
Github user asfgit closed the pull request at:
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1078#issuecomment-138826497
Your build is failing due to scalastyle checks
```
[INFO]
[INFO] --- maven-failsafe-plugin:2.17:verify (default) @ flink-ml ---
[INFO] Failsafe
[
https://issues.apache.org/jira/browse/FLINK-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736451#comment-14736451
]
ASF GitHub Bot commented on FLINK-1737:
---
Github user rmetzger commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736499#comment-14736499
]
ASF GitHub Bot commented on FLINK-2536:
---
Github user StephanEwen commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736502#comment-14736502
]
ASF GitHub Bot commented on FLINK-1730:
---
Github user sachingoel0101 commented on the pull request:
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1083#issuecomment-138844139
Hey @fhueske , thanks for your comments.
I was not aware this was intended to allow for recovery on failed jobs.
For reusing among different jobs in the
[
https://issues.apache.org/jira/browse/FLINK-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maximilian Michels reassigned FLINK-2640:
-
Assignee: Maximilian Michels
> Integrate the off-heap configurations with YARN
[
https://issues.apache.org/jira/browse/FLINK-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736429#comment-14736429
]
ASF GitHub Bot commented on FLINK-2321:
---
Github user tillrohrmann commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maximilian Michels reassigned FLINK-2641:
-
Assignee: Maximilian Michels
> Integrate the off-heap memory configuration with
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/889#issuecomment-138821828
Will merge it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1030#issuecomment-138836978
Sorry, @HuangWHWHW, currently we're really busy. I'll try to review your PR
once I find a free minute.
---
If your project is set up for it, you can reply to this
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1030#issuecomment-138843852
No worries. We are simply overloaded right now. Many hard features under
development, and many pull requests being opened.
---
If your project is set up for it,
[
https://issues.apache.org/jira/browse/FLINK-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger reassigned FLINK-2392:
-
Assignee: Robert Metzger
> Instable test in flink-yarn-tests
>
[
https://issues.apache.org/jira/browse/FLINK-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736424#comment-14736424
]
ASF GitHub Bot commented on FLINK-2600:
---
Github user rmetzger commented on the pull request:
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1108#issuecomment-138820891
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/889#issuecomment-138821087
@tillrohrmann Is this still good to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/FLINK-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann resolved FLINK-2321.
--
Resolution: Fixed
Fixed via 1b318c91fda0358430e0fc590e8c4328f2dc052c
> The seed for the SVM
[
https://issues.apache.org/jira/browse/FLINK-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736481#comment-14736481
]
ASF GitHub Bot commented on FLINK-2536:
---
Github user tillrohrmann commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736410#comment-14736410
]
Robert Metzger commented on FLINK-2392:
---
I've changed the shutdown behavior of the YARN mini
[
https://issues.apache.org/jira/browse/FLINK-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736427#comment-14736427
]
ASF GitHub Bot commented on FLINK-2321:
---
Github user fhueske commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736428#comment-14736428
]
Behrouz Derakhshan commented on FLINK-2392:
---
Thanks [~rmetzger], it seems this has also fixed
[
https://issues.apache.org/jira/browse/FLINK-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek closed FLINK-2600.
---
Resolution: Fixed
(Hopefully) fixed in
[
https://issues.apache.org/jira/browse/FLINK-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736438#comment-14736438
]
ASF GitHub Bot commented on FLINK-2097:
---
Github user mxm commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736439#comment-14736439
]
ASF GitHub Bot commented on FLINK-2600:
---
Github user aljoscha commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Gevay updated FLINK-2181:
---
Assignee: (was: Gabor Gevay)
> SessionWindowing example has a memleak
>
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/1108
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736444#comment-14736444
]
ASF GitHub Bot commented on FLINK-2600:
---
Github user aljoscha closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736470#comment-14736470
]
ASF GitHub Bot commented on FLINK-2633:
---
Github user tillrohrmann commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736493#comment-14736493
]
ASF GitHub Bot commented on FLINK-2536:
---
Github user StephanEwen commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736515#comment-14736515
]
ASF GitHub Bot commented on FLINK-2097:
---
Github user mxm commented on the pull request:
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/858#issuecomment-138848287
Of course! The following classes have been refactored in the course of
integrating them with the session management:
**Client**
- Establish connection to
[
https://issues.apache.org/jira/browse/FLINK-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann reopened FLINK-2616:
--
Does not seem to be fixed by increasing the timeout
[
https://issues.apache.org/jira/browse/FLINK-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek reassigned FLINK-2181:
---
Assignee: Aljoscha Krettek
> SessionWindowing example has a memleak
>
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/889
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736454#comment-14736454
]
Robert Metzger commented on FLINK-2606:
---
If we are sure that Storm's HdfsSpout is properly working
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/1030#issuecomment-138832801
@StephanEwen
@tillrohrmann
Hallo?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1104#issuecomment-138832160
Will do. FLINK-2633 is basically subsumed by FLINK-2637. Thus, I'll close
this PR and open a new one for FLINK-2637.
---
If your project is set up for it, you can
[
https://issues.apache.org/jira/browse/FLINK-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736473#comment-14736473
]
ASF GitHub Bot commented on FLINK-2536:
---
Github user HuangWHWHW commented on the pull request:
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1030#discussion_r39020317
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/sink/SocketClientSink.java
---
@@
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1083#issuecomment-138861596
You are certainly right that there should be an API call to explicitly
persist data in memory (or transparently on disk if memory is short) and later
access this data
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1083#issuecomment-138861709
I don't think this really works. It violates so many assumptions, like the
fact that memory is available after a job ends. The accounting for that depends
on task
[
https://issues.apache.org/jira/browse/FLINK-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736582#comment-14736582
]
ASF GitHub Bot commented on FLINK-1730:
---
Github user fhueske commented on the pull request:
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030573
--- Diff:
flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java
---
@@ -0,0 +1,383 @@
+/*
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030601
--- Diff:
flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala
---
@@ -0,0 +1,216 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736706#comment-14736706
]
ASF GitHub Bot commented on FLINK-2591:
---
Github user rmetzger commented on the pull request:
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39033258
--- Diff:
flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala
---
@@ -0,0 +1,449 @@
+/*
+ *
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39033252
--- Diff:
flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala
---
@@ -0,0 +1,449 @@
+/*
+ *
Aljoscha Krettek created FLINK-2643:
---
Summary: Change Travis Build Profile to Exclude Hadoop
2.0.0-alpha, Include 2.7.0
Key: FLINK-2643
URL: https://issues.apache.org/jira/browse/FLINK-2643
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39034189
--- Diff:
flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala
---
@@ -0,0 +1,216 @@
+/*
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39034170
--- Diff:
flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala
---
@@ -0,0 +1,216 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736615#comment-14736615
]
ASF GitHub Bot commented on FLINK-2525:
---
Github user ffbin commented on the pull request:
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39031803
--- Diff:
flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala
---
@@ -0,0 +1,449 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736697#comment-14736697
]
ASF GitHub Bot commented on FLINK-1297:
---
Github user tammymendt commented on the pull request:
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39032671
--- Diff:
flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java
---
@@ -0,0 +1,383 @@
+/*
Github user tammymendt commented on the pull request:
https://github.com/apache/flink/pull/605#issuecomment-138895774
Yes, I'm on it
On Wed, Sep 9, 2015 at 2:34 PM, Max wrote:
> Could you update the pull request with the new clone() method?
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-138863295
Looks good. Is it possible that we cover both cases with tests?
1. Start the shell in local mode, submit some commands.
2. Start a
[
https://issues.apache.org/jira/browse/FLINK-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736598#comment-14736598
]
ASF GitHub Bot commented on FLINK-1297:
---
Github user mxm commented on the pull request:
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/605#issuecomment-138863134
Hi @tammymendt. Thanks for the pull request! The accumulators work a little
bit different now because they are now accumulated on a per-task basis and
reported to the job
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-138865484
@mjsax Thanks. I have finish the change about all comments.
@StephanEwen @rmetzger Can you have a look at it if it can be merged?
Thank you very much!
---
If your
Github user sachingoel0101 closed the pull request at:
https://github.com/apache/flink/pull/1083
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
[
https://issues.apache.org/jira/browse/FLINK-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736635#comment-14736635
]
ASF GitHub Bot commented on FLINK-1730:
---
Github user sachingoel0101 commented on the pull request:
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1103#issuecomment-138868121
Okay, the issue is that this mock execution never reaches a "FAILED" state
in time, because the canceling of the other vertices (after one failed) is
never
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1083#issuecomment-138868165
I apologize. Like I said before, the way I've implemented this, it seemed
pretty trivial. Foremost, I needed this for something else and decided to take
a shot
[
https://issues.apache.org/jira/browse/FLINK-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736636#comment-14736636
]
ASF GitHub Bot commented on FLINK-1730:
---
Github user sachingoel0101 closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736634#comment-14736634
]
ASF GitHub Bot commented on FLINK-2619:
---
Github user StephanEwen commented on the pull request:
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030988
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030971
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030949
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030957
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030888
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030975
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030982
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed
Github user tammymendt commented on the pull request:
https://github.com/apache/flink/pull/605#issuecomment-138883419
The test I wrote checks if the final accumulator result is the one that is
expected. If I understand correctly, now accumulator values are sent
periodically before a
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39032520
--- Diff:
flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala
---
@@ -0,0 +1,449 @@
+/*
+ *
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39032562
--- Diff:
flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java
---
@@ -0,0 +1,383 @@
+/*
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39032533
--- Diff:
flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java
---
@@ -0,0 +1,383 @@
+/*
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39032608
--- Diff:
flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java
---
@@ -0,0 +1,383 @@
+/*
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39033094
--- Diff:
flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala
---
@@ -0,0 +1,216 @@
+/*
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39033950
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39033997
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/FLINK-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736767#comment-14736767
]
ASF GitHub Bot commented on FLINK-1297:
---
Github user mxm commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736534#comment-14736534
]
ASF GitHub Bot commented on FLINK-1297:
---
Github user tammymendt commented on the pull request:
1 - 100 of 261 matches
Mail list logo