[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408925#comment-15408925 ] ASF GitHub Bot commented on FLINK-4094: --- GitHub user ramkrish86 opened a pull request:

[GitHub] flink pull request #2336: FLINK-4094 Off heap memory deallocation might not ...

2016-08-04 Thread ramkrish86
GitHub user ramkrish86 opened a pull request: https://github.com/apache/flink/pull/2336 FLINK-4094 Off heap memory deallocation might not properly work (Ram) Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[jira] [Commented] (FLINK-4035) Bump Kafka producer in Kafka sink to Kafka 0.10.0.0

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408921#comment-15408921 ] ASF GitHub Bot commented on FLINK-4035: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #2231: [FLINK-4035] Bump Kafka producer in Kafka sink to Kafka 0...

2016-08-04 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2231 Sorry for the delay on the review. Reviewing + testing now ... @radekg Yup the failure is unrelated to the changes here. Some of the tests are currently a bit flaky. --- If your project

[jira] [Commented] (FLINK-4282) Add Offset Parameter to WindowAssigners

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408877#comment-15408877 ] ASF GitHub Bot commented on FLINK-4282: --- Github user aditivin commented on the issue:

[GitHub] flink issue #2333: [FLINK-4282] [streaming] Add Offset Parameter to WindowAs...

2016-08-04 Thread aditivin
Github user aditivin commented on the issue: https://github.com/apache/flink/pull/2333 Hi, Only the relevant changes are now visible. Pasting the details from the previous pull request (#2331) here: Added offset parameter for the following processing time window

[jira] [Commented] (FLINK-4313) Inconsistent code for Key/Value in the CheckpointCoordinator

2016-08-04 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408652#comment-15408652 ] Aljoscha Krettek commented on FLINK-4313: - Yes, the key-group support is only in there partially.

[jira] [Commented] (FLINK-4282) Add Offset Parameter to WindowAssigners

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408643#comment-15408643 ] ASF GitHub Bot commented on FLINK-4282: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #2333: [FLINK-4282] [streaming] Add Offset Parameter to WindowAs...

2016-08-04 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2333 Hi, it doesn't help to just rebase it. I think you need to take the changes to the relevant files and create a new commit from that since the commit you have here contains a lot of other

[jira] [Commented] (FLINK-4312) Remove Serializabiliy of ExecutionGraph

2016-08-04 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408646#comment-15408646 ] Aljoscha Krettek commented on FLINK-4312: - +1 > Remove Serializabiliy of ExecutionGraph >

[jira] [Comment Edited] (FLINK-4308) Allow uploaded jar directory to be configurable

2016-08-04 Thread Zhenzhong Xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404889#comment-15404889 ] Zhenzhong Xu edited comment on FLINK-4308 at 8/4/16 10:23 PM: -- The proposal

[jira] [Commented] (FLINK-4308) Allow uploaded jar directory to be configurable

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408570#comment-15408570 ] ASF GitHub Bot commented on FLINK-4308: --- GitHub user zhenzhongxu opened a pull request:

[GitHub] flink pull request #2335: [FLINK-4308] Allow uploaded jar directory to be co...

2016-08-04 Thread zhenzhongxu
GitHub user zhenzhongxu opened a pull request: https://github.com/apache/flink/pull/2335 [FLINK-4308] Allow uploaded jar directory to be configurable Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.

[GitHub] flink issue #2298: [FLINK-4247] [table] CsvTableSource.getDataSet() expects ...

2016-08-04 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2298 +1 for sticking to Java DataSet / DataStream for the reasons @twalthr gave. The methods should be tagged with the `@Internal` annotation when we add them to the Table API. I would not

[jira] [Commented] (FLINK-4247) CsvTableSource.getDataSet() expects Java ExecutionEnvironment

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408524#comment-15408524 ] ASF GitHub Bot commented on FLINK-4247: --- Github user fhueske commented on the issue:

[jira] [Assigned] (FLINK-3318) Add support for quantifiers to CEP's pattern API

2016-08-04 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Mushketyk reassigned FLINK-3318: - Assignee: Ivan Mushketyk > Add support for quantifiers to CEP's pattern API >

[jira] [Assigned] (FLINK-3703) Add sequence matching semantics to discard matched events

2016-08-04 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Mushketyk reassigned FLINK-3703: - Assignee: Ivan Mushketyk > Add sequence matching semantics to discard matched events >

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

2016-08-04 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408274#comment-15408274 ] ramkrishna.s.vasudevan commented on FLINK-4094: --- I created the log related msg and the doc.

[jira] [Created] (FLINK-4313) Inconsistent code for Key/Value in the CheckpointCoordinator

2016-08-04 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-4313: --- Summary: Inconsistent code for Key/Value in the CheckpointCoordinator Key: FLINK-4313 URL: https://issues.apache.org/jira/browse/FLINK-4313 Project: Flink

[jira] [Commented] (FLINK-4271) There is no way to set parallelism of operators produced by CoGroupedStreams

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408106#comment-15408106 ] ASF GitHub Bot commented on FLINK-4271: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2305: [FLINK-4271] [DataStreamAPI] Enable CoGroupedStreams and ...

2016-08-04 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2305 @zentol I think that works only in theory. In practice, probably no user is going to realize that this trick is possible (even if we put it into the JavaDocs). It also seems pretty mean thing to

[jira] [Commented] (FLINK-4310) Move BinaryCompatibility Check plugin to relevant projects

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408097#comment-15408097 ] ASF GitHub Bot commented on FLINK-4310: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2334: [FLINK-4310] [build] Selectively run API compatibility ch...

2016-08-04 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2334 The added benefit is that this increases build stability on Travis, because it relies on fewer flink-specific JARs to be downloaded and cached. --- If your project is set up for it, you can

[jira] [Commented] (FLINK-4310) Move BinaryCompatibility Check plugin to relevant projects

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408080#comment-15408080 ] ASF GitHub Bot commented on FLINK-4310: --- GitHub user StephanEwen opened a pull request:

[GitHub] flink pull request #2334: [FLINK-4310] [build] Selectively run API compatibi...

2016-08-04 Thread StephanEwen
GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/2334 [FLINK-4310] [build] Selectively run API compatibility checks in API projects. This moves the API compatibility checks into the API projects that use stability annotations. Previously,

[jira] [Commented] (FLINK-4271) There is no way to set parallelism of operators produced by CoGroupedStreams

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408008#comment-15408008 ] ASF GitHub Bot commented on FLINK-4271: --- Github user zentol commented on the issue:

[GitHub] flink issue #2305: [FLINK-4271] [DataStreamAPI] Enable CoGroupedStreams and ...

2016-08-04 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2305 I'm not so sure about breaking compatibility. Let's keep in mind that users can work around this by casting the returned `DataStream` to a `SingleOutputStreamOperator`. --- If your project is set

[jira] [Commented] (FLINK-4271) There is no way to set parallelism of operators produced by CoGroupedStreams

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407910#comment-15407910 ] ASF GitHub Bot commented on FLINK-4271: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #2305: [FLINK-4271] [DataStreamAPI] Enable CoGroupedStreams and ...

2016-08-04 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2305 As I said, I think it would be very good to change the return type to `SingleOutputStreamOperator`. However, breaking binary compatibility should also not be taken lightly. --- If your project is

[jira] [Created] (FLINK-4312) Remove Serializabiliy of ExecutionGraph

2016-08-04 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-4312: --- Summary: Remove Serializabiliy of ExecutionGraph Key: FLINK-4312 URL: https://issues.apache.org/jira/browse/FLINK-4312 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-4256) Fine-grained recovery

2016-08-04 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407870#comment-15407870 ] Stephan Ewen commented on FLINK-4256: - [~zjwang] Preventing downstream restarts would be a followup

[jira] [Commented] (FLINK-4256) Fine-grained recovery

2016-08-04 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407866#comment-15407866 ] Stephan Ewen commented on FLINK-4256: - [~wenlong.lwl] True, one has to find the entire "connected

[jira] [Assigned] (FLINK-3398) Flink Kafka consumer should support auto-commit opt-outs

2016-08-04 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai reassigned FLINK-3398: -- Assignee: Tzu-Li (Gordon) Tai > Flink Kafka consumer should support

[jira] [Comment Edited] (FLINK-4280) New Flink-specific option to set starting position of Kafka consumer without respecting external offsets in ZK / Broker

2016-08-04 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407822#comment-15407822 ] Tzu-Li (Gordon) Tai edited comment on FLINK-4280 at 8/4/16 2:08 PM: Hi

[jira] [Comment Edited] (FLINK-4280) New Flink-specific option to set starting position of Kafka consumer without respecting external offsets in ZK / Broker

2016-08-04 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407822#comment-15407822 ] Tzu-Li (Gordon) Tai edited comment on FLINK-4280 at 8/4/16 2:10 PM: Hi

[jira] [Commented] (FLINK-4280) New Flink-specific option to set starting position of Kafka consumer without respecting external offsets in ZK / Broker

2016-08-04 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407822#comment-15407822 ] Tzu-Li (Gordon) Tai commented on FLINK-4280: [~StephanEwen] I'd like to start working on this

[jira] [Assigned] (FLINK-4280) New Flink-specific option to set starting position of Kafka consumer without respecting external offsets in ZK / Broker

2016-08-04 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai reassigned FLINK-4280: -- Assignee: Tzu-Li (Gordon) Tai > New Flink-specific option to set starting

[jira] [Commented] (FLINK-3839) Support wildcards in classpath parameters

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407747#comment-15407747 ] ASF GitHub Bot commented on FLINK-3839: --- Github user thormanrd commented on the issue:

[GitHub] flink issue #2114: FLINK-3839 Added the extraction of jar files from a URL s...

2016-08-04 Thread thormanrd
Github user thormanrd commented on the issue: https://github.com/apache/flink/pull/2114 I do have them. I need to make time to re-do the PR. What is the best way to sync my fork with the apache master? I can pull from apache master, push to my forked master? Or should I create a

[GitHub] flink issue #2251: [FLINK-4212] [scripts] Lock PID file when starting daemon...

2016-08-04 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2251 Checked it out locally and all processes start up as expected. @greghogan I think it's good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-4212) Lock PID file when starting daemons

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407715#comment-15407715 ] ASF GitHub Bot commented on FLINK-4212: --- Github user uce commented on the issue:

[jira] [Commented] (FLINK-3839) Support wildcards in classpath parameters

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407678#comment-15407678 ] ASF GitHub Bot commented on FLINK-3839: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2114: FLINK-3839 Added the extraction of jar files from a URL s...

2016-08-04 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2114 I think we unfortunately need to redo this pull request. It is almost impossible to review, because 90% of the changes in the diff are code re-formattings. It is very hard to spot lines with

[jira] [Commented] (FLINK-4219) Quote PDSH opts in start-cluster.sh

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407661#comment-15407661 ] ASF GitHub Bot commented on FLINK-4219: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2253: [FLINK-4219] [scripts] Quote PDSH opts in start-cluster.s...

2016-08-04 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2253 Looks good to me. +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-4212) Lock PID file when starting daemons

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407660#comment-15407660 ] ASF GitHub Bot commented on FLINK-4212: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2251: [FLINK-4212] [scripts] Lock PID file when starting daemon...

2016-08-04 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2251 This works on my machine (Ubuntu Linux 14.04) Can someone verify it for MacOS? (@uce, @aljoscha, @tillrohrmann)? --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (FLINK-2042) Increase font size for stack figure on website home

2016-08-04 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407650#comment-15407650 ] Stephan Ewen commented on FLINK-2042: - I think this is still relevant, yes > Increase font size for

[GitHub] flink issue #2288: Feature/s3 a fix

2016-08-04 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2288 Thank you for this contribution. Can you help us a bit so we can review this? - Remove the template text for the Pull Request - Tag the pull request with the JIRA issue it

[GitHub] flink pull request #2333: [FLINK-4282] [streaming] Add Offset Parameter to W...

2016-08-04 Thread aditivin
GitHub user aditivin opened a pull request: https://github.com/apache/flink/pull/2333 [FLINK-4282] [streaming] Add Offset Parameter to WindowAssigners I seem to be getting all these changes however I rebase it :/ It is currently rebased with the latest code of apache/master,

[jira] [Commented] (FLINK-4282) Add Offset Parameter to WindowAssigners

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407569#comment-15407569 ] ASF GitHub Bot commented on FLINK-4282: --- GitHub user aditivin opened a pull request:

[GitHub] flink pull request #2331: [FLINK-4282] [streaming] Added an offset parameter...

2016-08-04 Thread aditivin
Github user aditivin closed the pull request at: https://github.com/apache/flink/pull/2331 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-4282) Add Offset Parameter to WindowAssigners

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407547#comment-15407547 ] ASF GitHub Bot commented on FLINK-4282: --- Github user aditivin closed the pull request at:

[GitHub] flink pull request #2324: Bump version to 1.2-SNAPSHOT

2016-08-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2324 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #2324: Bump version to 1.2-SNAPSHOT

2016-08-04 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2324 I already merged it before you appended the commit, needed it locally to prevent always overwriting my cache with different versions. I basically pushed the same thing now spread over two

[jira] [Closed] (FLINK-4161) Quickstarts can exclude more flink-dist dependencies

2016-08-04 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-4161. --- > Quickstarts can exclude more flink-dist dependencies >

[jira] [Resolved] (FLINK-4161) Quickstarts can exclude more flink-dist dependencies

2016-08-04 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-4161. - Resolution: Fixed Fix Version/s: 1.2.0 Fixed via 745b393f83563aa0efe95a0433aeb7a05c9263cc

[GitHub] flink pull request #2309: [FLINK-4161] Add Quickstart exclusion for flink-di...

2016-08-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2309 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-4161) Quickstarts can exclude more flink-dist dependencies

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407475#comment-15407475 ] ASF GitHub Bot commented on FLINK-4161: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-4311) TableInputFormat fails when reused on next split

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407443#comment-15407443 ] ASF GitHub Bot commented on FLINK-4311: --- Github user nielsbasjes commented on the issue:

[GitHub] flink issue #2330: FLINK-4311 Fixed several problems in TableInputFormat

2016-08-04 Thread nielsbasjes
Github user nielsbasjes commented on the issue: https://github.com/apache/flink/pull/2330 I had another look at the "multiple tables" question. The name of the table comes from the getTableName method that is to be implemented by the subclass. I consider it to be extremely unlikely

[jira] [Commented] (FLINK-2055) Implement Streaming HBaseSink

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407427#comment-15407427 ] ASF GitHub Bot commented on FLINK-2055: --- Github user delding commented on the issue:

[GitHub] flink issue #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-04 Thread delding
Github user delding commented on the issue: https://github.com/apache/flink/pull/2332 Hi, this is my second PR to Flink, any comments or suggestions will be very appreciated :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-2055) Implement Streaming HBaseSink

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407422#comment-15407422 ] ASF GitHub Bot commented on FLINK-2055: --- GitHub user delding opened a pull request:

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-04 Thread delding
GitHub user delding opened a pull request: https://github.com/apache/flink/pull/2332 [FLINK-2055] Implement Streaming HBaseSink Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes

[GitHub] flink pull request #2330: FLINK-4311 Fixed several problems in TableInputFor...

2016-08-04 Thread nielsbasjes
Github user nielsbasjes commented on a diff in the pull request: https://github.com/apache/flink/pull/2330#discussion_r73482199 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java --- @@ -328,7 +328,11 @@

[jira] [Commented] (FLINK-4311) TableInputFormat fails when reused on next split

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407410#comment-15407410 ] ASF GitHub Bot commented on FLINK-4311: --- Github user nielsbasjes commented on a diff in the pull

[jira] [Commented] (FLINK-4311) TableInputFormat fails when reused on next split

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407394#comment-15407394 ] ASF GitHub Bot commented on FLINK-4311: --- Github user nielsbasjes commented on a diff in the pull

[GitHub] flink pull request #2330: FLINK-4311 Fixed several problems in TableInputFor...

2016-08-04 Thread nielsbasjes
Github user nielsbasjes commented on a diff in the pull request: https://github.com/apache/flink/pull/2330#discussion_r73480826 --- Diff: flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java --- @@ -237,7 +244,7 @@ private void

[GitHub] flink issue #2109: [FLINK-3677] FileInputFormat: Allow to specify include/ex...

2016-08-04 Thread mushketyk
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2109 The build was failing because Jenkins couldn't merge my changes. I rebased them to current master. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-3677) FileInputFormat: Allow to specify include/exclude file name patterns

2016-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407357#comment-15407357 ] ASF GitHub Bot commented on FLINK-3677: --- Github user mushketyk commented on the issue: