[GitHub] flink pull request #2570: [FLINK-3674] Add an interface for Time aware User ...

2016-10-20 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2570#discussion_r84251918 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java --- @@ -0,0 +1,317 @@ +/* + *

[GitHub] flink pull request #2570: [FLINK-3674] Add an interface for Time aware User ...

2016-10-20 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2570#discussion_r84251732 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java --- @@ -0,0 +1,317 @@ +/* + *

[jira] [Comment Edited] (FLINK-4850) FlinkML - SVM predict Operation for Vector and not LaveledVector

2016-10-20 Thread Theodore Vasiloudis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591622#comment-15591622 ] Theodore Vasiloudis edited comment on FLINK-4850 at 10/20/16 11:57 AM:

[jira] [Commented] (FLINK-4850) FlinkML - SVM predict Operation for Vector and not LaveledVector

2016-10-20 Thread Theodore Vasiloudis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591622#comment-15591622 ] Theodore Vasiloudis commented on FLINK-4850: Just to note, the PR I opened only fixes the

[GitHub] flink issue #2636: [FLINK-4784] Unique MetricQueryService actor names

2016-10-20 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2636 I tested the change this morning, and its not working: ``` 2016-10-20 11:08:28,216 WARN org.apache.flink.runtime.metrics.MetricRegistry - Could not start Metr

[GitHub] flink issue #2448: [FLINK-3030][web frontend] Enhance dashboard to show exec...

2016-10-20 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2448 Good to go from my side. @rmetzger and @iampeter - since you are working on the web UI currently, can you try and merge this? --- If your project is set up for it, you can reply to this

[jira] [Commented] (FLINK-3030) Enhance Dashboard to show Execution Attempts

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591587#comment-15591587 ] ASF GitHub Bot commented on FLINK-3030: --- Github user StephanEwen commented on the issue:

[GitHub] flink pull request #2570: [FLINK-3674] Add an interface for Time aware User ...

2016-10-20 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2570#discussion_r84236439 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java --- @@ -0,0 +1,317 @@ +/* + *

[jira] [Commented] (FLINK-3999) Rename the `running` flag in the drivers to `canceled`

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591577#comment-15591577 ] ASF GitHub Bot commented on FLINK-3999: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2642: [FLINK-3999]: Rename the `running` flag in the drivers to...

2016-10-20 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2642 @nssalian Thanks for understanding. We as a community together have actually gone into that mode (more conservative and stability focused) not too long ago. So it is still a bit of a

[GitHub] flink issue #2652: [FLINK-4715] Fail TaskManager with fatal error if task ca...

2016-10-20 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2652 +1 go ahead --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591567#comment-15591567 ] ASF GitHub Bot commented on FLINK-4715: --- Github user StephanEwen commented on the issue:

[GitHub] flink pull request #2570: [FLINK-3674] Add an interface for Time aware User ...

2016-10-20 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2570#discussion_r84251996 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java --- @@ -0,0 +1,317 @@ +/* + *

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591460#comment-15591460 ] ASF GitHub Bot commented on FLINK-3674: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink issue #2570: [FLINK-3674] Add an interface for Time aware User Functio...

2016-10-20 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2570 Thanks for your comments @StefanRRichter and @kl0u. I incorporated most of them by now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591462#comment-15591462 ] ASF GitHub Bot commented on FLINK-3674: --- Github user aljoscha commented on the issue:

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591424#comment-15591424 ] ASF GitHub Bot commented on FLINK-3674: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591422#comment-15591422 ] ASF GitHub Bot commented on FLINK-3674: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591419#comment-15591419 ] ASF GitHub Bot commented on FLINK-3674: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink issue #2636: [FLINK-4784] Unique MetricQueryService actor names

2016-10-20 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2636 should be fixed now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[jira] [Commented] (FLINK-4784) MetricQueryService actor name collision

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591353#comment-15591353 ] ASF GitHub Bot commented on FLINK-4784: --- Github user zentol commented on the issue:

[GitHub] flink pull request #2667: README.md - Description of the bluemix specif…

2016-10-20 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2667#discussion_r84241679 --- Diff: flink-contrib/docker-flink/docker-entrypoint.sh --- @@ -20,11 +20,19 @@ if [ "$1" = "jobmanager" ]; then echo "Starting Job Manager"

[GitHub] flink issue #2662: [FLINK-4824] [client] CliFrontend shows misleading error ...

2016-10-20 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2662 Thanks for the PR @greghogan! Having a custom exception for missing arguments to a user program is a good approach. However, it requires the author of the program to use the custom exception. At least,

[jira] [Commented] (FLINK-4784) MetricQueryService actor name collision

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591287#comment-15591287 ] ASF GitHub Bot commented on FLINK-4784: --- Github user rmetzger commented on the issue:

[jira] [Commented] (FLINK-4824) CliFrontend shows misleading error message when main() method returns before env.execute()

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591288#comment-15591288 ] ASF GitHub Bot commented on FLINK-4824: --- Github user mxm commented on the issue:

[GitHub] flink pull request #2570: [FLINK-3674] Add an interface for Time aware User ...

2016-10-20 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2570#discussion_r84235862 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java --- @@ -390,4 +425,141 @@ public void close()

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591260#comment-15591260 ] ASF GitHub Bot commented on FLINK-3674: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591264#comment-15591264 ] ASF GitHub Bot commented on FLINK-3674: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #2570: [FLINK-3674] Add an interface for Time aware User ...

2016-10-20 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2570#discussion_r84237685 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/DefaultProcessingTimeService.java --- @@ -35,10 +34,10 @@ import

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591263#comment-15591263 ] ASF GitHub Bot commented on FLINK-3674: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591262#comment-15591262 ] ASF GitHub Bot commented on FLINK-3674: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #2570: [FLINK-3674] Add an interface for Time aware User ...

2016-10-20 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2570#discussion_r84236659 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java --- @@ -0,0 +1,317 @@ +/* + *

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591261#comment-15591261 ] ASF GitHub Bot commented on FLINK-3674: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #2570: [FLINK-3674] Add an interface for Time aware User ...

2016-10-20 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2570#discussion_r84237459 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java --- @@ -0,0 +1,317 @@ +/* + *

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591201#comment-15591201 ] ASF GitHub Bot commented on FLINK-3674: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #2667: README.md - Description of the bluemix specif…

2016-10-20 Thread sedgewickmm18
GitHub user sedgewickmm18 opened a pull request: https://github.com/apache/flink/pull/2667 README.md -Description of the bluemix specif… Hi, as per discussion with @mxm I'm proposing to include the following change that makes use of container

[jira] [Commented] (FLINK-4863) states of merging window and trigger are set to different TimeWindows on merge

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591051#comment-15591051 ] ASF GitHub Bot commented on FLINK-4863: --- GitHub user manuzhang opened a pull request:

[GitHub] flink pull request #2666: [FLINK-4863] fix trigger context window on merge

2016-10-20 Thread manuzhang
GitHub user manuzhang opened a pull request: https://github.com/apache/flink/pull/2666 [FLINK-4863] fix trigger context window on merge Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your

[jira] [Created] (FLINK-4863) states of merging window and trigger are set to different TimeWindows on merge

2016-10-20 Thread Manu Zhang (JIRA)
Manu Zhang created FLINK-4863: - Summary: states of merging window and trigger are set to different TimeWindows on merge Key: FLINK-4863 URL: https://issues.apache.org/jira/browse/FLINK-4863 Project:

[jira] [Commented] (FLINK-4840) Measure latency/delay of record processing and expose it as a metric

2016-10-20 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591000#comment-15591000 ] Chesnay Schepler commented on FLINK-4840: - There are some things that are concerning: A histogram,

<    1   2