[jira] [Commented] (FLINK-5067) Make Flink compile with 1.8 Java compiler

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671655#comment-15671655 ] ASF GitHub Bot commented on FLINK-5067: --- Github user melentye commented on the issue

[GitHub] flink issue #2804: [FLINK-5067] Make Flink compile with 1.8 Java compiler

2016-11-16 Thread melentye
Github user melentye commented on the issue: https://github.com/apache/flink/pull/2804 @StephanEwen I initially introduced a new Travis profile so that the coverage would be strictly improved, i.e. all old combinations tests plus the new ones. But I am also fine reusing some of the ex

[GitHub] flink pull request #2804: [FLINK-5067] Make Flink compile with 1.8 Java comp...

2016-11-16 Thread melentye
Github user melentye commented on a diff in the pull request: https://github.com/apache/flink/pull/2804#discussion_r88331708 --- Diff: flink-tests/src/test/java/org/apache/flink/test/windowing/sessionwindows/SessionWindowITCase.java --- @@ -122,11 +122,11 @@ private void runTest(

[GitHub] flink pull request #2804: [FLINK-5067] Make Flink compile with 1.8 Java comp...

2016-11-16 Thread melentye
Github user melentye commented on a diff in the pull request: https://github.com/apache/flink/pull/2804#discussion_r88331670 --- Diff: flink-java/src/test/java/org/apache/flink/api/common/operators/CollectionExecutionAccumulatorsTest.java --- @@ -35,7 +35,7 @@ @Test

[jira] [Commented] (FLINK-5067) Make Flink compile with 1.8 Java compiler

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671650#comment-15671650 ] ASF GitHub Bot commented on FLINK-5067: --- Github user melentye commented on a diff in

[jira] [Commented] (FLINK-5067) Make Flink compile with 1.8 Java compiler

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671652#comment-15671652 ] ASF GitHub Bot commented on FLINK-5067: --- Github user melentye commented on a diff in

[jira] [Commented] (FLINK-3869) WindowedStream.apply with FoldFunction is too restrictive

2016-11-16 Thread Seth Wiesman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671614#comment-15671614 ] Seth Wiesman commented on FLINK-3869: - [~aljoscha] [~ymarzougui] This is an issue I ha

[jira] [Comment Edited] (FLINK-3869) WindowedStream.apply with FoldFunction is too restrictive

2016-11-16 Thread Seth Wiesman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671614#comment-15671614 ] Seth Wiesman edited comment on FLINK-3869 at 11/16/16 9:05 PM: -

[jira] [Commented] (FLINK-5063) State handles are not properly cleaned up for declined or expired checkpoints

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671523#comment-15671523 ] ASF GitHub Bot commented on FLINK-5063: --- Github user StephanEwen commented on the is

[GitHub] flink issue #2813: [backport] [FLINK-5063] Discard state handles of declined...

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2813 Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] flink issue #2794: [backport] [FLINK-5057] [task] Pick cancellation timeout ...

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2794 Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[jira] [Commented] (FLINK-5057) Cancellation timeouts are picked from wrong config

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671510#comment-15671510 ] ASF GitHub Bot commented on FLINK-5057: --- Github user StephanEwen commented on the is

[jira] [Created] (FLINK-5083) Race condition in Rolling/Bucketing Sink pending files cleanup

2016-11-16 Thread Cliff Resnick (JIRA)
Cliff Resnick created FLINK-5083: Summary: Race condition in Rolling/Bucketing Sink pending files cleanup Key: FLINK-5083 URL: https://issues.apache.org/jira/browse/FLINK-5083 Project: Flink

[jira] [Commented] (FLINK-5006) SystemProcessingTimeServiceTest.testTimerSorting fails

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671485#comment-15671485 ] ASF GitHub Bot commented on FLINK-5006: --- Github user StephanEwen commented on the is

[GitHub] flink issue #2785: [FLINK-5006] SystemProcessingTimeServiceTest.testTimerSor...

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2785 Looks good, merging this! Thanks, @BorisOsipov for bearing with us on this one through the long discussion! --- If your project is set up for it, you can reply to this email and have yo

[jira] [Commented] (FLINK-4913) Per-job Yarn clusters: include user jar in system class loader

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671478#comment-15671478 ] ASF GitHub Bot commented on FLINK-4913: --- Github user StephanEwen commented on the is

[GitHub] flink issue #2795: Revert "[FLINK-4913][yarn] include user jars in system cl...

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2795 I also was very torn when it came to this change. In the end, I lean towards keeping user behavior in 1.1.4 consistent. The fix is in 1.2, which is not too far away, and there it is great

[jira] [Commented] (FLINK-5061) Remove ContinuousEventTimeTrigger

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671461#comment-15671461 ] ASF GitHub Bot commented on FLINK-5061: --- Github user StephanEwen commented on the is

[GitHub] flink issue #2803: [FLINK-5061] Remove ContinuousEventTimeTrigger

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2803 Fine by me. IIRC, the `ContinuousEventTimeTrigger` is a relic from imitating event time windows on global windows, correct? In that case, +1 for removing it --- If your project is set u

[jira] [Updated] (FLINK-3551) Sync Scala and Java Streaming Examples

2016-11-16 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri updated FLINK-3551: - Assignee: Lim Chee Hau > Sync Scala and Java Streaming Examples >

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

2016-11-16 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671432#comment-15671432 ] Stephan Ewen commented on FLINK-5048: - Fixed in 1.2.0 via a66e7ad14e41fa07737f447d6892

[jira] [Commented] (FLINK-3921) StringParser not specifying encoding to use

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671427#comment-15671427 ] ASF GitHub Bot commented on FLINK-3921: --- Github user greghogan commented on the issu

[jira] [Updated] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

2016-11-16 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen updated FLINK-5048: Fix Version/s: 1.1.4 > Kafka Consumer (0.9/0.10) threading model leads problematic cancellation > b

[jira] [Updated] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

2016-11-16 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen updated FLINK-5048: Priority: Blocker (was: Major) > Kafka Consumer (0.9/0.10) threading model leads problematic cancel

[GitHub] flink issue #2060: [FLINK-3921] StringParser encoding

2016-11-16 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2060 @rekhajoshm have you had a chance to look again at this PR? The 1.2 feature freeze will be in a few weeks. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] flink pull request #2789: [FLINK-5048] [Kafka Consumer] Change thread model ...

2016-11-16 Thread StephanEwen
Github user StephanEwen closed the pull request at: https://github.com/apache/flink/pull/2789 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671424#comment-15671424 ] ASF GitHub Bot commented on FLINK-5048: --- Github user StephanEwen closed the pull req

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671423#comment-15671423 ] ASF GitHub Bot commented on FLINK-5048: --- Github user StephanEwen commented on the is

[GitHub] flink issue #2789: [FLINK-5048] [Kafka Consumer] Change thread model of Flin...

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2789 Manually merged in a66e7ad14e41fa07737f447d68920ad5cc4ed6d3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] flink pull request #2814: Corrected log4j files.

2016-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2814 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-4872) Type erasure problem exclusively on cluster execution

2016-11-16 Thread Martin Junghanns (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671192#comment-15671192 ] Martin Junghanns commented on FLINK-4872: - I just reproduced it using the followin

[jira] [Commented] (FLINK-5082) Pull ExecutionService lifecycle management out of the JobManager

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671130#comment-15671130 ] ASF GitHub Bot commented on FLINK-5082: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #2820: [FLINK-5082] Pull ExecutorService lifecycle manage...

2016-11-16 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/2820 [FLINK-5082] Pull ExecutorService lifecycle management out of the JobManager The provided ExecutorService will no longer be closed by the JobManager. Instead the lifecycle is managed outsid

[GitHub] flink issue #2066: Updated ssh configuration in base Dockerfile

2016-11-16 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2066 The `Dockerfile` has been fully rewritten since this PR. @techmaniack is there additional functionality still needed or can this PR be closed? --- If your project is set up for it, you can reply t

[GitHub] flink issue #1033: Add Scala version of GraphAlgorithm

2016-11-16 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/1033 Is this PR's functionality still requested or can it be closed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Created] (FLINK-5082) Pull ExecutionService lifecycle management out of the JobManager

2016-11-16 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-5082: Summary: Pull ExecutionService lifecycle management out of the JobManager Key: FLINK-5082 URL: https://issues.apache.org/jira/browse/FLINK-5082 Project: Flink

[GitHub] flink issue #2761: [FLINK-3551] [examples] Sync Scala Streaiming Examples

2016-11-16 Thread ch33hau
Github user ch33hau commented on the issue: https://github.com/apache/flink/pull/2761 @thvasilo thanks! I will do that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670911#comment-15670911 ] ASF GitHub Bot commented on FLINK-5048: --- Github user tzulitai commented on a diff in

[jira] [Commented] (FLINK-3551) Sync Scala and Java Streaming Examples

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670912#comment-15670912 ] ASF GitHub Bot commented on FLINK-3551: --- Github user ch33hau commented on the issue:

[GitHub] flink pull request #2789: [FLINK-5048] [Kafka Consumer] Change thread model ...

2016-11-16 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2789#discussion_r88273352 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09Fetcher.java --- @@

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670854#comment-15670854 ] ASF GitHub Bot commented on FLINK-5048: --- Github user tzulitai commented on the issue

[GitHub] flink issue #2789: [FLINK-5048] [Kafka Consumer] Change thread model of Flin...

2016-11-16 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2789 > Also, both the fetcher and the KafkaConsumerThread are written to encapsulate all necessary logic self contained. That means they do not rely on each other to call handover.close() in any situatio

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670803#comment-15670803 ] ASF GitHub Bot commented on FLINK-5048: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request #2789: [FLINK-5048] [Kafka Consumer] Change thread model ...

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2789#discussion_r88264932 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09Fetcher.java ---

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670798#comment-15670798 ] ASF GitHub Bot commented on FLINK-5048: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request #2789: [FLINK-5048] [Kafka Consumer] Change thread model ...

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2789#discussion_r88264489 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java --

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670757#comment-15670757 ] ASF GitHub Bot commented on FLINK-5048: --- Github user StephanEwen commented on the is

[GitHub] flink issue #2789: [FLINK-5048] [Kafka Consumer] Change thread model of Flin...

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2789 I would actually like to not change how/when `handover.close()` is called. It is called more often that necessary (probably), but since it is an idempotent operation, it does not matter.

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670743#comment-15670743 ] ASF GitHub Bot commented on FLINK-5048: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request #2789: [FLINK-5048] [Kafka Consumer] Change thread model ...

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2789#discussion_r88260220 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java --

[jira] [Created] (FLINK-5081) unable to set yarn.maximum-failed-containers with flink one-time YARN setup

2016-11-16 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-5081: -- Summary: unable to set yarn.maximum-failed-containers with flink one-time YARN setup Key: FLINK-5081 URL: https://issues.apache.org/jira/browse/FLINK-5081 Project: Flink

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670717#comment-15670717 ] ASF GitHub Bot commented on FLINK-5048: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request #2789: [FLINK-5048] [Kafka Consumer] Change thread model ...

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2789#discussion_r88258273 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaShortRetentionTestBase.java --

[jira] [Commented] (FLINK-4872) Type erasure problem exclusively on cluster execution

2016-11-16 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670710#comment-15670710 ] Timo Walther commented on FLINK-4872: - I still can't reproduce your problem. What I no

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670707#comment-15670707 ] ASF GitHub Bot commented on FLINK-5048: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request #2789: [FLINK-5048] [Kafka Consumer] Change thread model ...

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2789#discussion_r88257338 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerCallBridge010.

[GitHub] flink issue #2819: [FLINK-4961] [ml] SGD for Matrix Factorization (WIP)

2016-11-16 Thread gaborhermann
Github user gaborhermann commented on the issue: https://github.com/apache/flink/pull/2819 There are some open questions: 1. Should we optimize 3 way join? For now the join order is burnt into the code, also we might be able to give hints for join strategies. 2. How should

[jira] [Commented] (FLINK-4961) SGD for Matrix Factorization

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670658#comment-15670658 ] ASF GitHub Bot commented on FLINK-4961: --- Github user gaborhermann commented on the i

[GitHub] flink pull request #2819: [FLINK-4961] [ml] SGD for Matrix Factorization (WI...

2016-11-16 Thread gaborhermann
GitHub user gaborhermann opened a pull request: https://github.com/apache/flink/pull/2819 [FLINK-4961] [ml] SGD for Matrix Factorization (WIP) Please note, that this is a work-in-progress PR, to discuss some design questions. There are minor things to be done including the documenta

[jira] [Commented] (FLINK-4961) SGD for Matrix Factorization

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670629#comment-15670629 ] ASF GitHub Bot commented on FLINK-4961: --- GitHub user gaborhermann opened a pull requ

[GitHub] flink pull request #2789: [FLINK-5048] [Kafka Consumer] Change thread model ...

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2789#discussion_r88245373 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java --

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670534#comment-15670534 ] ASF GitHub Bot commented on FLINK-5048: --- Github user StephanEwen commented on a diff

[jira] [Commented] (FLINK-5063) State handles are not properly cleaned up for declined or expired checkpoints

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670518#comment-15670518 ] ASF GitHub Bot commented on FLINK-5063: --- Github user StephanEwen commented on the is

[GitHub] flink issue #2812: [FLINK-5063] Discard state handles of declined or expired...

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2812 Good catch and patch! +1 from my side to merge this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] flink issue #2813: [backport] [FLINK-5063] Discard state handles of declined...

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2813 Similar to #2812 - good fix! +1 from my side! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[jira] [Commented] (FLINK-5063) State handles are not properly cleaned up for declined or expired checkpoints

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670516#comment-15670516 ] ASF GitHub Bot commented on FLINK-5063: --- Github user StephanEwen commented on the is

[jira] [Commented] (FLINK-4631) NullPointerException during stream task cleanup

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670507#comment-15670507 ] ASF GitHub Bot commented on FLINK-4631: --- Github user StephanEwen commented on the is

[jira] [Commented] (FLINK-4263) SQL's VALUES does not work properly

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670509#comment-15670509 ] ASF GitHub Bot commented on FLINK-4263: --- GitHub user twalthr opened a pull request:

[GitHub] flink pull request #2818: [FLINK-4263] [table] SQL's VALUES does not work pr...

2016-11-16 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/2818 [FLINK-4263] [table] SQL's VALUES does not work properly Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If y

[GitHub] flink issue #2807: [FLINK-4631] Prevent some possible NPEs.

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2807 I think we need to go through these changes one by one. In many situations, field being null indicates an error. These situations now silently do nothing, rather than at least reporting a

[jira] [Commented] (FLINK-3551) Sync Scala and Java Streaming Examples

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670501#comment-15670501 ] ASF GitHub Bot commented on FLINK-3551: --- Github user thvasilo commented on the issue

[GitHub] flink issue #2761: [FLINK-3551] [examples] Sync Scala Streaiming Examples

2016-11-16 Thread thvasilo
Github user thvasilo commented on the issue: https://github.com/apache/flink/pull/2761 Hello Lim, thank you for your contribution! I've taken a quick look and most of these look fine, plus I see you've included the required tests. I'll do a review this week and hopefully a

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670496#comment-15670496 ] ASF GitHub Bot commented on FLINK-5048: --- Github user StephanEwen commented on the is

[GitHub] flink issue #2789: [FLINK-5048] [Kafka Consumer] Change thread model of Flin...

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2789 Thanks for the review, @tzulitai I would go ahead and merge this, addressing the comments. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] flink pull request #2804: [FLINK-5067] Make Flink compile with 1.8 Java comp...

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2804#discussion_r88241945 --- Diff: flink-tests/src/test/java/org/apache/flink/test/windowing/sessionwindows/SessionWindowITCase.java --- @@ -122,11 +122,11 @@ private void runTes

[GitHub] flink pull request #2804: [FLINK-5067] Make Flink compile with 1.8 Java comp...

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2804#discussion_r88242077 --- Diff: flink-java/src/test/java/org/apache/flink/api/common/operators/CollectionExecutionAccumulatorsTest.java --- @@ -35,7 +35,7 @@ @Test

[jira] [Commented] (FLINK-5067) Make Flink compile with 1.8 Java compiler

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670490#comment-15670490 ] ASF GitHub Bot commented on FLINK-5067: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request #2804: [FLINK-5067] Make Flink compile with 1.8 Java comp...

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2804#discussion_r88242410 --- Diff: pom.xml --- @@ -96,7 +96,7 @@ under the License. 1.7.7 18.0 2.3.7 - 1.7 +

[jira] [Commented] (FLINK-5067) Make Flink compile with 1.8 Java compiler

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670491#comment-15670491 ] ASF GitHub Bot commented on FLINK-5067: --- Github user StephanEwen commented on a diff

[jira] [Commented] (FLINK-5067) Make Flink compile with 1.8 Java compiler

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670492#comment-15670492 ] ASF GitHub Bot commented on FLINK-5067: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request #:

2016-11-16 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/commit/57208e650f94edece537ccdeb1a2c19b4f7ccca8#commitcomment-19845489 In flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java: In flink-runtime/src/main/java/org/apache/

[GitHub] flink pull request #:

2016-11-16 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/commit/57208e650f94edece537ccdeb1a2c19b4f7ccca8#commitcomment-19845484 In flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java: In flink-runtime/src/main/java/org/apache/

[GitHub] flink pull request #:

2016-11-16 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/commit/57208e650f94edece537ccdeb1a2c19b4f7ccca8#commitcomment-19845479 In flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java: In flink-runtime/src/main/java/org/apache/

[GitHub] flink pull request #:

2016-11-16 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/commit/57208e650f94edece537ccdeb1a2c19b4f7ccca8#commitcomment-19845480 In flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java: In flink-runtime/src/main/java/org/apache/

[jira] [Created] (FLINK-5080) Cassandra connector ignores saveAsync result onSuccess

2016-11-16 Thread Jakub Nowacki (JIRA)
Jakub Nowacki created FLINK-5080: Summary: Cassandra connector ignores saveAsync result onSuccess Key: FLINK-5080 URL: https://issues.apache.org/jira/browse/FLINK-5080 Project: Flink Issue Ty

[jira] [Commented] (FLINK-5016) EventTimeWindowCheckpointingITCase testTumblingTimeWindowWithKVStateMaxMaxParallelism with RocksDB hangs

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670419#comment-15670419 ] ASF GitHub Bot commented on FLINK-5016: --- Github user StephanEwen commented on the is

[GitHub] flink issue #2814: Corrected log4j files.

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2814 +1 @greghogan feel free to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] flink issue #2786: [FLINK-5016] [ci] Increase no output timeout to 10 mins

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2786 I think we should split up the tests that take so long into multiple files. That should do the trick as well. For example, the `EventTimeWindowCheckpointingITCase` can simply have an abs

[GitHub] flink pull request #:

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/commit/57208e650f94edece537ccdeb1a2c19b4f7ccca8#commitcomment-19844935 In flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java: In flink-runtime/src/main/java/org/ap

[GitHub] flink pull request #:

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/commit/57208e650f94edece537ccdeb1a2c19b4f7ccca8#commitcomment-19844939 In flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java: In flink-runtime/src/main/java/org/ap

[GitHub] flink pull request #:

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/commit/57208e650f94edece537ccdeb1a2c19b4f7ccca8#commitcomment-19844923 In flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java: In flink-runtime/src/main/java/org/ap

[jira] [Commented] (FLINK-5073) ZooKeeperCompleteCheckpointStore executes blocking delete operation in ZooKeeper client thread

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670380#comment-15670380 ] ASF GitHub Bot commented on FLINK-5073: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2816: [backport] [FLINK-5073] Use Executor to run ZooKee...

2016-11-16 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2816#discussion_r88231145 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java --- @@ -237,11 +242,12 @@ public static CompletedCheckpointStore

[jira] [Commented] (FLINK-4872) Type erasure problem exclusively on cluster execution

2016-11-16 Thread Martin Junghanns (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670241#comment-15670241 ] Martin Junghanns commented on FLINK-4872: - [~twalthr] Thanks for looking into it.

[jira] [Comment Edited] (FLINK-4872) Type erasure problem exclusively on cluster execution

2016-11-16 Thread Martin Junghanns (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670241#comment-15670241 ] Martin Junghanns edited comment on FLINK-4872 at 11/16/16 11:44 AM:

[jira] [Comment Edited] (FLINK-2646) Rich functions should provide a method "closeAfterFailure()"

2016-11-16 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670219#comment-15670219 ] Stephan Ewen edited comment on FLINK-2646 at 11/16/16 11:34 AM:

[jira] [Commented] (FLINK-2646) Rich functions should provide a method "closeAfterFailure()"

2016-11-16 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670219#comment-15670219 ] Stephan Ewen commented on FLINK-2646: - One thing we can do is mirror the way it is don

[jira] [Commented] (FLINK-5078) Introduce annotations for classes copied from Calcite

2016-11-16 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670189#comment-15670189 ] Fabian Hueske commented on FLINK-5078: -- +1 That's a good idea! > Introduce annotatio

[jira] [Created] (FLINK-5079) Failed to submit job to YARN cluster

2016-11-16 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-5079: -- Summary: Failed to submit job to YARN cluster Key: FLINK-5079 URL: https://issues.apache.org/jira/browse/FLINK-5079 Project: Flink Issue Type: Bug Affects Ve

[jira] [Commented] (FLINK-5056) BucketingSink deletes valid data when checkpoint notification is slow.

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670169#comment-15670169 ] ASF GitHub Bot commented on FLINK-5056: --- Github user zentol commented on a diff in t

<    1   2   3   >