Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/3461
HI, @haohu thanks for your contribution!
Can you tell me why we need this change? and can you add simple unit test ?
Best,
SunJincheng
---
If your project is set up for it, yo
[
https://issues.apache.org/jira/browse/FLINK-5954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893879#comment-15893879
]
ASF GitHub Bot commented on FLINK-5954:
---
Github user sunjincheng121 commented on the
[
https://issues.apache.org/jira/browse/FLINK-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893873#comment-15893873
]
radu commented on FLINK-5654:
-
Thanks sunjincheng - I saw the message to late unfortunately. I
[
https://issues.apache.org/jira/browse/FLINK-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893867#comment-15893867
]
ASF GitHub Bot commented on FLINK-5791:
---
Github user shuai-xu commented on the issue
Github user shuai-xu commented on the issue:
https://github.com/apache/flink/pull/3304
The failed case pass in my local work copy, I think maybe it is due to the
environment of travis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
[
https://issues.apache.org/jira/browse/FLINK-5927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893844#comment-15893844
]
ASF GitHub Bot commented on FLINK-5927:
---
GitHub user shaoxuan-wang opened a pull req
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/3465
[FLINK-5927] [table] Remove old Aggregate interface and built-in functions
This PR deprecate and remove the old Aggregate interface, built-in
functions, and associated Agg functions.
[
https://issues.apache.org/jira/browse/FLINK-5803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893836#comment-15893836
]
ASF GitHub Bot commented on FLINK-5803:
---
Github user sunjincheng121 commented on the
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/3397
Hi, @fhueske I have rebase the code on #3423 's commit, and updated the PR.
I appreciate if you can have look at this PR again.
Thanks,
SunJincheng
---
If your project is set up for i
[
https://issues.apache.org/jira/browse/FLINK-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893830#comment-15893830
]
Aljoscha Krettek commented on FLINK-5929:
-
Sorry, overlooked the other comment. Ye
[
https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893813#comment-15893813
]
ASF GitHub Bot commented on FLINK-5653:
---
Github user shaoxuan-wang commented on a di
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3443#discussion_r104096189
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/aggs/DoubleSummaryAggregation.java
---
@@ -0,0 +1,214
[
https://issues.apache.org/jira/browse/FLINK-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893780#comment-15893780
]
ASF GitHub Bot commented on FLINK-5955:
---
GitHub user shaoxuan-wang opened a pull req
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/3464
[FLINK-5955] [table] Merging a list of buffered records will have problem
when ObjectReuse is turned on
This PR changes the dataSet AGG merge to pair-merge.
If we buffer the iterated
[
https://issues.apache.org/jira/browse/FLINK-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kurt Young updated FLINK-5955:
--
Component/s: Table API & SQL
> Merging a list of buffered records will have problem when ObjectReuse is
[
https://issues.apache.org/jira/browse/FLINK-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893761#comment-15893761
]
ASF GitHub Bot commented on FLINK-5856:
---
Github user shuai-xu commented on the issue
Github user shuai-xu commented on the issue:
https://github.com/apache/flink/pull/3398
The travis failure seems to have nothing with the change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
[
https://issues.apache.org/jira/browse/FLINK-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893743#comment-15893743
]
ASF GitHub Bot commented on FLINK-5952:
---
Github user mtunique closed the pull reques
Github user mtunique closed the pull request at:
https://github.com/apache/flink/pull/3463
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
[
https://issues.apache.org/jira/browse/FLINK-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893718#comment-15893718
]
ASF GitHub Bot commented on FLINK-5952:
---
GitHub user mtunique opened a pull request:
GitHub user mtunique opened a pull request:
https://github.com/apache/flink/pull/3463
[FLINK-5952] JobCancellationWithSavepointHandlersTest uses deprecated
JsonNode#getValuesAsText
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following
[
https://issues.apache.org/jira/browse/FLINK-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893670#comment-15893670
]
ASF GitHub Bot commented on FLINK-5584:
---
Github user hongyuhong closed the pull requ
Github user hongyuhong closed the pull request at:
https://github.com/apache/flink/pull/3175
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated FLINK-5541:
--
Description:
{code}
if (localJar == null) {
try {
for (final URL url : ((ContextEnvironm
[
https://issues.apache.org/jira/browse/FLINK-5629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854366#comment-15854366
]
Ted Yu edited comment on FLINK-5629 at 3/3/17 3:19 AM:
---
RandomAccess
[
https://issues.apache.org/jira/browse/FLINK-5219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893618#comment-15893618
]
ASF GitHub Bot commented on FLINK-5219:
---
Github user sunjincheng121 commented on the
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/3266
Hi, @fhueske I had rebase the code on PR
[#3423|https://github.com/apache/flink/pull/3423]'s commit.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Shaoxuan Wang created FLINK-5955:
Summary: Merging a list of buffered records will have problem when
ObjectReuse is turned on
Key: FLINK-5955
URL: https://issues.apache.org/jira/browse/FLINK-5955
Proj
[
https://issues.apache.org/jira/browse/FLINK-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893604#comment-15893604
]
ASF GitHub Bot commented on FLINK-5917:
---
GitHub user shixiaogang opened a pull reque
GitHub user shixiaogang opened a pull request:
https://github.com/apache/flink/pull/3462
[FLINK-5917][state] Remove size() method from MapState
The `size()` method is removed from `MapState` because its implementation
is costly in the backends.
You can merge this pull request into
[
https://issues.apache.org/jira/browse/FLINK-5586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893595#comment-15893595
]
ASF GitHub Bot commented on FLINK-5586:
---
Github user KurtYoung commented on the issu
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3339
Seems like this will effect the new aggregate interface and make the tests
failed, will wait for that fix first.
---
If your project is set up for it, you can reply to this email and have your
rep
[
https://issues.apache.org/jira/browse/FLINK-5954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893551#comment-15893551
]
ASF GitHub Bot commented on FLINK-5954:
---
GitHub user haohui opened a pull request:
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3461
[FLINK-5954] Always assign names to the window in the Stream SQL API.
Please see jira for more details.
You can merge this pull request into a Git repository by running:
$ git pull https://gith
[
https://issues.apache.org/jira/browse/FLINK-5954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haohui Mai updated FLINK-5954:
--
Summary: Always assign names to the window in the Stream SQL API (was:
Always assign names to the windo
Haohui Mai created FLINK-5954:
-
Summary: Always assign names to the window in the Stream SQL APi
Key: FLINK-5954
URL: https://issues.apache.org/jira/browse/FLINK-5954
Project: Flink
Issue Type: I
[
https://issues.apache.org/jira/browse/FLINK-5918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893383#comment-15893383
]
ASF GitHub Bot commented on FLINK-5918:
---
Github user barcahead commented on a diff i
Github user barcahead commented on a diff in the pull request:
https://github.com/apache/flink/pull/3416#discussion_r104065323
--- Diff: flink-core/pom.xml ---
@@ -165,6 +165,7 @@ under the License.
org.apache.flink.configurat
[
https://issues.apache.org/jira/browse/FLINK-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Hogan closed FLINK-5597.
-
Resolution: Implemented
Implemented in cb9e409b764f95e07441a0c8da6c24e21bc1564b
> Improve the LocalCluste
[
https://issues.apache.org/jira/browse/FLINK-4896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Hogan closed FLINK-4896.
-
Resolution: Implemented
Implemented in ea14053fe32280ffc36e586b5d3712c751fa1f84
> PageRank algorithm for
[
https://issues.apache.org/jira/browse/FLINK-4896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893249#comment-15893249
]
ASF GitHub Bot commented on FLINK-4896:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893250#comment-15893250
]
ASF GitHub Bot commented on FLINK-5597:
---
Github user asfgit closed the pull request
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2733
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3404
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-5414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893216#comment-15893216
]
ASF GitHub Bot commented on FLINK-5414:
---
Github user haohui commented on the issue:
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3426
Fix the unit tests.
There are two additional changes:
1. There are precision differences when converting `double` to
`BigDecimal`. Fix the unit tests.
2. When registering UDFs Fli
Github user mariusz89016 commented on the issue:
https://github.com/apache/flink/pull/3356
Thanks for the review!
Currently, dynamic properties are set by
`GlobalConfiguration.dynamicProperties` instead of saving in cluster descriptor.
---
If your project is set up for it, you c
[
https://issues.apache.org/jira/browse/FLINK-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893108#comment-15893108
]
ASF GitHub Bot commented on FLINK-5253:
---
Github user mariusz89016 commented on the i
[
https://issues.apache.org/jira/browse/FLINK-5945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Hogan closed FLINK-5945.
-
Resolution: Fixed
Fix Version/s: (was: 1.1.4)
1.1.5
1.3.0: 243ef69bf5233998d
[
https://issues.apache.org/jira/browse/FLINK-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haohui Mai updated FLINK-3679:
--
Summary: Allow Kafka consumer to skip corrupted messages (was:
DeserializationSchema should handle zero
[
https://issues.apache.org/jira/browse/FLINK-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Hueske closed FLINK-5768.
Resolution: Implemented
Fix Version/s: 1.3.0
Implemented with 438276de8fab4f1a8f2b62b6452c2e5
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3423
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892937#comment-15892937
]
ASF GitHub Bot commented on FLINK-5768:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-4949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892696#comment-15892696
]
Vasia Kalavri edited comment on FLINK-4949 at 3/2/17 6:05 PM:
--
[
https://issues.apache.org/jira/browse/FLINK-4949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892696#comment-15892696
]
Vasia Kalavri commented on FLINK-4949:
--
Thanks you [~greghogan]. I can review during
[
https://issues.apache.org/jira/browse/FLINK-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892693#comment-15892693
]
ASF GitHub Bot commented on FLINK-1579:
---
GitHub user zentol opened a pull request:
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3460
[FLINK-1579] Implement History Server
This PR adds a slightly unpolished HistoryServer implementation. It is
missing tests and some documentation, but is working.
This PR builds on top of #3
[
https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892689#comment-15892689
]
ASF GitHub Bot commented on FLINK-4565:
---
Github user DmytroShkvyra commented on a di
Github user DmytroShkvyra commented on a diff in the pull request:
https://github.com/apache/flink/pull/2870#discussion_r103987812
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/ScalarFunctionsTest.scala
---
@@ -1101,6 +1101,45 @@ class
[
https://issues.apache.org/jira/browse/FLINK-5953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew Billson updated FLINK-5953:
---
Description:
In the Scala Kinesis example here:
https://ci.apache.org/projects/flink/flink-do
[
https://issues.apache.org/jira/browse/FLINK-5107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892658#comment-15892658
]
ASF GitHub Bot commented on FLINK-5107:
---
Github user zentol commented on a diff in t
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2837#discussion_r103984233
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/JobManagerOptions.java
---
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache
Matthew Billson created FLINK-5953:
--
Summary: Sample Kinesis Scala code doesn't work
Key: FLINK-5953
URL: https://issues.apache.org/jira/browse/FLINK-5953
Project: Flink
Issue Type: Bug
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3444
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-5941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892645#comment-15892645
]
ASF GitHub Bot commented on FLINK-5941:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-5941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-5941.
---
Resolution: Fixed
Implemented in 7fe0eb477df52cfd7254695a67d41f3cba34ef0a.
> Let handlers tak
[
https://issues.apache.org/jira/browse/FLINK-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892640#comment-15892640
]
ASF GitHub Bot commented on FLINK-5441:
---
Github user fhueske commented on the issue:
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3107
Yes, you are right. Forgot that we lazily translate the plans. :-/
Let's keep the tables then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
[
https://issues.apache.org/jira/browse/FLINK-5769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Hueske closed FLINK-5769.
Resolution: Duplicate
Will be done as part of FLINK-5768.
> Apply new aggregation functions for dat
[
https://issues.apache.org/jira/browse/FLINK-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892625#comment-15892625
]
ASF GitHub Bot commented on FLINK-5768:
---
Github user fhueske commented on the issue:
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3423
thanks for the update @shaoxuan-wang. The PR looks good to merge.
I do some final tests and run another build.
Thanks, Fabian
---
If your project is set up for it, you can reply to this
[
https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892619#comment-15892619
]
ASF GitHub Bot commented on FLINK-4565:
---
Github user DmytroShkvyra commented on a di
Github user DmytroShkvyra commented on a diff in the pull request:
https://github.com/apache/flink/pull/2870#discussion_r103976547
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
@@ -150,7 +150,35 @@ class Table(
* }}}
[
https://issues.apache.org/jira/browse/FLINK-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892596#comment-15892596
]
ASF GitHub Bot commented on FLINK-5654:
---
GitHub user huawei-flink opened a pull requ
GitHub user huawei-flink opened a pull request:
https://github.com/apache/flink/pull/3459
[FLINK-5654] Add processing time OVER RANGE BETWEEN x PRECEDING aggregation
to SQL
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check l
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3107
I think the point is that we don't know if the table will ever be used
again. If we unregister them after optimization, we can not have multiple
`toDataStream()` calls for one table.
---
If your pr
[
https://issues.apache.org/jira/browse/FLINK-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892592#comment-15892592
]
ASF GitHub Bot commented on FLINK-5441:
---
Github user twalthr commented on the issue:
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2870#discussion_r103963098
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/calls/ScalarOperators.scala
---
@@ -79,6 +79,72 @@ object ScalarOper
[
https://issues.apache.org/jira/browse/FLINK-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892517#comment-15892517
]
ASF GitHub Bot commented on FLINK-5441:
---
Github user fhueske commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892519#comment-15892519
]
ASF GitHub Bot commented on FLINK-4565:
---
Github user twalthr commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892534#comment-15892534
]
ASF GitHub Bot commented on FLINK-4565:
---
Github user twalthr commented on the issue:
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2870
Thanks for taking care of this PR @DmytroShkvyra. It would be great if we
could use `SubQueryRemoveRule` rules together with the RexSubQuery.in() RexNode
in order to reduce code complexity.
---
If
[
https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892526#comment-15892526
]
ASF GitHub Bot commented on FLINK-4565:
---
Github user twalthr commented on a diff in
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2870#discussion_r103963525
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/calls/ScalarOperators.scala
---
@@ -1002,12 +1068,17 @@ object Scala
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3107
But what's the point of keeping tables that will never be used again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
[
https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892485#comment-15892485
]
ASF GitHub Bot commented on FLINK-4565:
---
Github user twalthr commented on a diff in
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2870#discussion_r103962015
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
@@ -150,7 +150,35 @@ class Table(
* }}}
*/
[
https://issues.apache.org/jira/browse/FLINK-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892476#comment-15892476
]
ASF GitHub Bot commented on FLINK-5698:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892474#comment-15892474
]
ASF GitHub Bot commented on FLINK-5698:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892480#comment-15892480
]
ASF GitHub Bot commented on FLINK-5698:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892478#comment-15892478
]
ASF GitHub Bot commented on FLINK-5698:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892479#comment-15892479
]
ASF GitHub Bot commented on FLINK-5698:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892475#comment-15892475
]
ASF GitHub Bot commented on FLINK-5698:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-3695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892473#comment-15892473
]
ASF GitHub Bot commented on FLINK-3695:
---
Github user greghogan commented on the issu
[
https://issues.apache.org/jira/browse/FLINK-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892477#comment-15892477
]
ASF GitHub Bot commented on FLINK-5698:
---
Github user fhueske commented on a diff in
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3382
@vasia, if you are available to review, I think the easiest way to do so is
to first review the classes for `LongValue` then compare the diff for
`IntValue` and `StringValue`. I think we are forced
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3269#discussion_r103913118
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/NestedFieldsProjectableTableSource.scala
---
@@ -0,0 +1,55 @@
+/*
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3269#discussion_r103918266
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/util/RexProgramProjectExtractor.scala
---
@@ -84,6 +108,49 @@ object
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3269#discussion_r103958236
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/NestedFieldsProjectableTableSource.scala
---
@@ -0,0 +1,55 @@
+/*
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3269#discussion_r103960833
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/plan/rules/util/RexProgramProjectExtractorTest.scala
---
@@ -55,6 +56,34 @@ clas
1 - 100 of 312 matches
Mail list logo
