[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112198474 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamSortRule.scala --- @@ -0,0 +1,67 @@ +/*

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112220586 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala --- @@ -0,0 +1,353 @@ +/* + * Licensed

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112226659 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala --- @@ -29,6 +29,27 @@ class Wind

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112227142 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedSortProcessFunction.scala --- @@ -0,0 +1,114 @@

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112203273 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala --- @@ -0,0 +1,169 @@ +/* + *

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112208301 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala --- @@ -0,0 +1,169 @@ +/* + *

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112200587 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala --- @@ -0,0 +1,169 @@ +/* + *

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112205545 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala --- @@ -0,0 +1,169 @@ +/* + *

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112212356 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala --- @@ -0,0 +1,353 @@ +/* + * Licensed

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112208929 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala --- @@ -0,0 +1,169 @@ +/* + *

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112209644 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala --- @@ -0,0 +1,353 @@ +/* + * Licensed

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112204008 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala --- @@ -0,0 +1,169 @@ +/* + *

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112204101 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala --- @@ -0,0 +1,169 @@ +/* + *

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112198880 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamSortRule.scala --- @@ -0,0 +1,67 @@ +/*

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112202924 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala --- @@ -0,0 +1,169 @@ +/* + *

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112224889 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedSortProcessFunction.scala --- @@ -0,0 +1,114 @@

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112206935 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala --- @@ -0,0 +1,169 @@ +/* + *

[GitHub] flink issue #3741: [FLINK-6177] Add support for "Distributed Cache" in strea...

2017-04-19 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3741 @zohar-pm You don't have to open a new one, feel free to update the branch in this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (FLINK-6177) Add support for "Distributed Cache" in streaming applications

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974815#comment-15974815 ] ASF GitHub Bot commented on FLINK-6177: --- Github user zentol commented on the issue:

[GitHub] flink issue #3738: [FLINK-6311] [Kinesis Connector] NPE in FlinkKinesisConsu...

2017-04-19 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3738 @StephanEwen Shouldn't we also make ```shardConsumersExecutor``` variable ```volatile``` as well ? --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (FLINK-6311) NPE in FlinkKinesisConsumer if source was closed before run

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974814#comment-15974814 ] ASF GitHub Bot commented on FLINK-6311: --- Github user zhangminglei commented on the i

[jira] [Commented] (FLINK-6315) Notify on checkpoint timeout

2017-04-19 Thread Seth Wiesman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974811#comment-15974811 ] Seth Wiesman commented on FLINK-6315: - [~aljoscha] Apologies, didn't see this comment.

[GitHub] flink issue #3736: [Flink-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-19 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3736 A few more comments on this: - Guava is so conflict heavy that should avoid using it in the framework wherever possible. Adding a multiple MBs dependency to write `Lists.newArrayList`

[jira] [Commented] (FLINK-6177) Add support for "Distributed Cache" in streaming applications

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974798#comment-15974798 ] ASF GitHub Bot commented on FLINK-6177: --- Github user zohar-pm commented on the issue

[GitHub] flink issue #3741: [FLINK-6177] Add support for "Distributed Cache" in strea...

2017-04-19 Thread zohar-pm
Github user zohar-pm commented on the issue: https://github.com/apache/flink/pull/3741 No problem. Will follow it and will create a new pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[jira] [Commented] (FLINK-6008) collection of BlobServer improvements

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974787#comment-15974787 ] ASF GitHub Bot commented on FLINK-6008: --- Github user NicoK commented on the issue:

[GitHub] flink issue #3512: [FLINK-6008] collection of BlobServer improvements

2017-04-19 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/3512 * I removed the exposed `BlobService` from the `LibraryCacheManager` * Also, I developed a new cleanup story that removes blobs only if there are no tasks referring to the job ID anymore. The extens

[jira] [Commented] (FLINK-6311) NPE in FlinkKinesisConsumer if source was closed before run

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974782#comment-15974782 ] ASF GitHub Bot commented on FLINK-6311: --- Github user StephanEwen commented on the is

[GitHub] flink issue #3738: [FLINK-6311] [Kinesis Connector] NPE in FlinkKinesisConsu...

2017-04-19 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3738 Looks good. To make this really safe, we should actually make the `mainThread` variable `volatile`. --- If your project is set up for it, you can reply to this email and have your reply appear o

[jira] [Commented] (FLINK-6177) Add support for "Distributed Cache" in streaming applications

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974778#comment-15974778 ] ASF GitHub Bot commented on FLINK-6177: --- Github user StephanEwen commented on the is

[GitHub] flink issue #3741: [FLINK-6177] Add support for "Distributed Cache" in strea...

2017-04-19 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3741 Thanks for contributing this, the added functionality looks good. I would prefer to add this change without changing the dependencies and test base classes. You could for example change t

[jira] [Created] (FLINK-6329) refactor name-addressable accessors in BlobService classes from returning a URL to a File or InputStream

2017-04-19 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-6329: -- Summary: refactor name-addressable accessors in BlobService classes from returning a URL to a File or InputStream Key: FLINK-6329 URL: https://issues.apache.org/jira/browse/FLINK-6329

[jira] [Commented] (FLINK-6315) Notify on checkpoint timeout

2017-04-19 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974756#comment-15974756 ] Aljoscha Krettek commented on FLINK-6315: - [~StephanEwen] do you have any comments

[jira] [Commented] (FLINK-6315) Notify on checkpoint timeout

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974757#comment-15974757 ] ASF GitHub Bot commented on FLINK-6315: --- Github user aljoscha commented on the issue

[GitHub] flink issue #3729: [FLINK-6315] Notify on checkpoint timeout

2017-04-19 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3729 I commented on the issue because we might need a general discussion about the feature first. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[jira] [Commented] (FLINK-6250) Distinct procTime with Rows boundaries

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974731#comment-15974731 ] ASF GitHub Bot commented on FLINK-6250: --- Github user huawei-flink commented on a dif

[GitHub] flink pull request #3732: [FLINK-6250] Distinct procTime with Rows boundarie...

2017-04-19 Thread huawei-flink
Github user huawei-flink commented on a diff in the pull request: https://github.com/apache/flink/pull/3732#discussion_r112210389 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedDistinctRowsOver.scala --- @@ -0,0 +1,238

[jira] [Commented] (FLINK-6250) Distinct procTime with Rows boundaries

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974726#comment-15974726 ] ASF GitHub Bot commented on FLINK-6250: --- Github user huawei-flink commented on a dif

[GitHub] flink pull request #3732: [FLINK-6250] Distinct procTime with Rows boundarie...

2017-04-19 Thread huawei-flink
Github user huawei-flink commented on a diff in the pull request: https://github.com/apache/flink/pull/3732#discussion_r112210097 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedDistinctRowsOver.scala --- @@ -0,0 +1,238

[jira] [Commented] (FLINK-6315) Notify on checkpoint timeout

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974694#comment-15974694 ] ASF GitHub Bot commented on FLINK-6315: --- Github user sjwiesman commented on the issu

[GitHub] flink issue #3729: [FLINK-6315] Notify on checkpoint timeout

2017-04-19 Thread sjwiesman
Github user sjwiesman commented on the issue: https://github.com/apache/flink/pull/3729 @aljoscha Could you review this or point me in the direction of the correct person? I need this to land for the EventualConsistencySink --- If your project is set up for it, you can reply to this

[jira] [Commented] (FLINK-6247) Build a jar-with-dependencies for flink-table and put it into ./opt

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974658#comment-15974658 ] ASF GitHub Bot commented on FLINK-6247: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3666: [FLINK-6247][table] Build a jar-with-dependencies ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3666#discussion_r112201348 --- Diff: flink-libraries/flink-table/pom.xml --- @@ -40,6 +40,12 @@ under the License. org.apache.flink flink

[jira] [Created] (FLINK-6328) Savepoints must not be counted as retained checkpoints

2017-04-19 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-6328: --- Summary: Savepoints must not be counted as retained checkpoints Key: FLINK-6328 URL: https://issues.apache.org/jira/browse/FLINK-6328 Project: Flink Issue Type

[jira] [Commented] (FLINK-6177) Add support for "Distributed Cache" in streaming applications

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974594#comment-15974594 ] ASF GitHub Bot commented on FLINK-6177: --- GitHub user zohar-pm opened a pull request:

[GitHub] flink pull request #3741: [FLINK-6177] Add support for "Distributed Cache" i...

2017-04-19 Thread zohar-pm
GitHub user zohar-pm opened a pull request: https://github.com/apache/flink/pull/3741 [FLINK-6177] Add support for "Distributed Cache" in streaming applica… …tions Thanks for contributing to Apache Flink. Before you open your pull request, please take the following chec

[jira] [Commented] (FLINK-6326) add ProjectMergeRule at logical optimization stage

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974584#comment-15974584 ] ASF GitHub Bot commented on FLINK-6326: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3739: [FLINK-6326] [table] add ProjectMergeRule at logic...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3739#discussion_r112192763 --- Diff: flink-libraries/flink-table/src/test/scala/resources/testProjectMerge.out --- @@ -0,0 +1,156 @@ +== Abstract Syntax Tree == --- End diff --

[jira] [Commented] (FLINK-6326) add ProjectMergeRule at logical optimization stage

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974585#comment-15974585 ] ASF GitHub Bot commented on FLINK-6326: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3739: [FLINK-6326] [table] add ProjectMergeRule at logic...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3739#discussion_r112192706 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/ExplainTest.scala --- @@ -119,4 +120,25 @@ class ExplainTest

[jira] [Resolved] (FLINK-5904) jobmanager.heap.mb and taskmanager.heap.mb not work in YARN mode

2017-04-19 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-5904. -- Resolution: Fixed Fix Version/s: 1.3.0 Fixed via 0da62e8d77dceca6f39e70fb6a313a8169364de0

[jira] [Commented] (FLINK-5904) jobmanager.heap.mb and taskmanager.heap.mb not work in YARN mode

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974568#comment-15974568 ] ASF GitHub Bot commented on FLINK-5904: --- Github user asfgit closed the pull request

[GitHub] flink pull request #3414: [FLINK-5904][YARN]make jobmanager.heap.mb and task...

2017-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3414 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-6327) Bug in CommonCalc's estimateRowCount() method

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974519#comment-15974519 ] ASF GitHub Bot commented on FLINK-6327: --- Github user fhueske commented on the issue:

[GitHub] flink issue #3740: [FLINK-6327] [table] Bug in CommonCalc's estimateRowCount...

2017-04-19 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3740 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-6327) Bug in CommonCalc's estimateRowCount() method

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974487#comment-15974487 ] ASF GitHub Bot commented on FLINK-6327: --- GitHub user godfreyhe opened a pull request

[GitHub] flink pull request #3740: [FLINK-6327] [table] Bug in CommonCalc's estimateR...

2017-04-19 Thread godfreyhe
GitHub user godfreyhe opened a pull request: https://github.com/apache/flink/pull/3740 [FLINK-6327] [table] Bug in CommonCalc's estimateRowCount() method (rowCnt * 0.75).min(1.0) should be changed to (rowCnt * 0.75).max(1.0) You can merge this pull request into a Git repository by r

[jira] [Commented] (FLINK-6250) Distinct procTime with Rows boundaries

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974485#comment-15974485 ] ASF GitHub Bot commented on FLINK-6250: --- Github user huawei-flink commented on a dif

[GitHub] flink pull request #3732: [FLINK-6250] Distinct procTime with Rows boundarie...

2017-04-19 Thread huawei-flink
Github user huawei-flink commented on a diff in the pull request: https://github.com/apache/flink/pull/3732#discussion_r112180091 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedDistinctRowsOver.scala --- @@ -0,0 +1,238

[jira] [Commented] (FLINK-6326) add ProjectMergeRule at logical optimization stage

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974484#comment-15974484 ] ASF GitHub Bot commented on FLINK-6326: --- GitHub user godfreyhe opened a pull request

[GitHub] flink pull request #3739: [FLINK-6326] [table] add ProjectMergeRule at logic...

2017-04-19 Thread godfreyhe
GitHub user godfreyhe opened a pull request: https://github.com/apache/flink/pull/3739 [FLINK-6326] [table] add ProjectMergeRule at logical optimization stage add ProjectMergeRule to merge projections You can merge this pull request into a Git repository by running: $ git pull

[jira] [Created] (FLINK-6327) Bug in CommonCalc's estimateRowCount() method

2017-04-19 Thread godfrey he (JIRA)
godfrey he created FLINK-6327: - Summary: Bug in CommonCalc's estimateRowCount() method Key: FLINK-6327 URL: https://issues.apache.org/jira/browse/FLINK-6327 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-6149) add additional flink logical relation nodes

2017-04-19 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974471#comment-15974471 ] Kurt Young commented on FLINK-6149: --- Hi [~dshkvyra], i have tried to reproduce the probl

[jira] [Commented] (FLINK-6149) add additional flink logical relation nodes

2017-04-19 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974460#comment-15974460 ] Kurt Young commented on FLINK-6149: --- [~dshkvyra] Thanks for the reporting, i will look i

[jira] [Commented] (FLINK-6247) Build a jar-with-dependencies for flink-table and put it into ./opt

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974427#comment-15974427 ] ASF GitHub Bot commented on FLINK-6247: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6247) Build a jar-with-dependencies for flink-table and put it into ./opt

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974426#comment-15974426 ] ASF GitHub Bot commented on FLINK-6247: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6247) Build a jar-with-dependencies for flink-table and put it into ./opt

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974425#comment-15974425 ] ASF GitHub Bot commented on FLINK-6247: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3666: [FLINK-6247][table] Build a jar-with-dependencies ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3666#discussion_r112152700 --- Diff: flink-dist/src/main/assemblies/opt.xml --- @@ -66,6 +66,14 @@ 0644 + +

[GitHub] flink pull request #3666: [FLINK-6247][table] Build a jar-with-dependencies ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3666#discussion_r112152396 --- Diff: flink-libraries/flink-table/pom.xml --- @@ -231,6 +237,25 @@ under the License.

[GitHub] flink pull request #3666: [FLINK-6247][table] Build a jar-with-dependencies ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3666#discussion_r109594633 --- Diff: flink-libraries/flink-table/pom.xml --- @@ -40,6 +40,12 @@ under the License. org.apache.flink flink

[jira] [Closed] (FLINK-6307) Refactor JDBC tests

2017-04-19 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6307. --- Resolution: Fixed 1.3: 9fb074c9ca97bbfedac1e527fadbe4aeac80af18 > Refactor JDBC tests > -

[jira] [Commented] (FLINK-6196) Support dynamic schema in Table Function

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974420#comment-15974420 ] ASF GitHub Bot commented on FLINK-6196: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3623: [FLINK-6196] [table] Support dynamic schema in Tab...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3623#discussion_r112165650 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/DeferredTypeFlinkTableFunction.scala --- @@ -40,6 +43,10 @@ class De

[jira] [Commented] (FLINK-6307) Refactor JDBC tests

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974421#comment-15974421 ] ASF GitHub Bot commented on FLINK-6307: --- Github user asfgit closed the pull request

[GitHub] flink pull request #3723: [FLINK-6307] [jdbc] Refactor JDBC tests

2017-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3723 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-5095) Add explicit notifyOfAddedX methods to MetricReporter interface

2017-04-19 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974410#comment-15974410 ] Chesnay Schepler commented on FLINK-5095: - My current thinking goes i the directio

[jira] [Comment Edited] (FLINK-5095) Add explicit notifyOfAddedX methods to MetricReporter interface

2017-04-19 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974410#comment-15974410 ] Chesnay Schepler edited comment on FLINK-5095 at 4/19/17 10:08 AM: -

[jira] [Comment Edited] (FLINK-6311) NPE in FlinkKinesisConsumer if source was closed before run

2017-04-19 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974012#comment-15974012 ] mingleizhang edited comment on FLINK-6311 at 4/19/17 10:02 AM: -

[jira] [Commented] (FLINK-6325) Refinement of slot reuse for task manager failure

2017-04-19 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974401#comment-15974401 ] zhijiang commented on FLINK-6325: - [~StephanEwen], for specific implementation, we would l

[jira] [Updated] (FLINK-6326) add ProjectMergeRule at logical optimization stage

2017-04-19 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-6326: -- Description: add ProjectMergeRule to merge projections. Some SQLs can not push projection into scan wit

[GitHub] flink pull request #3738: [FLINK-6311] [Kinesis Connector] NPE in FlinkKines...

2017-04-19 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/3738 [FLINK-6311] [Kinesis Connector] NPE in FlinkKinesisConsumer if sourc… …e was closed before run. Thanks for contributing to Apache Flink. Before you open your pull request, please

[jira] [Commented] (FLINK-6311) NPE in FlinkKinesisConsumer if source was closed before run

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974400#comment-15974400 ] ASF GitHub Bot commented on FLINK-6311: --- GitHub user zhangminglei opened a pull requ

[jira] [Created] (FLINK-6326) add ProjectMergeRule at logical optimization stage

2017-04-19 Thread godfrey he (JIRA)
godfrey he created FLINK-6326: - Summary: add ProjectMergeRule at logical optimization stage Key: FLINK-6326 URL: https://issues.apache.org/jira/browse/FLINK-6326 Project: Flink Issue Type: New Fe

[jira] [Commented] (FLINK-6311) NPE in FlinkKinesisConsumer if source was closed before run

2017-04-19 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974385#comment-15974385 ] mingleizhang commented on FLINK-6311: - [~tzulitai] Thanks and I will give a PR to this

[jira] [Commented] (FLINK-6196) Support dynamic schema in Table Function

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974380#comment-15974380 ] ASF GitHub Bot commented on FLINK-6196: --- Github user clarkyzl commented on a diff in

[GitHub] flink pull request #3623: [FLINK-6196] [table] Support dynamic schema in Tab...

2017-04-19 Thread clarkyzl
Github user clarkyzl commented on a diff in the pull request: https://github.com/apache/flink/pull/3623#discussion_r112156728 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/DeferredTypeFlinkTableFunction.scala --- @@ -40,6 +43,10 @@ class D

[jira] [Commented] (FLINK-6250) Distinct procTime with Rows boundaries

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974357#comment-15974357 ] ASF GitHub Bot commented on FLINK-6250: --- Github user huawei-flink commented on a dif

[GitHub] flink pull request #3732: [FLINK-6250] Distinct procTime with Rows boundarie...

2017-04-19 Thread huawei-flink
Github user huawei-flink commented on a diff in the pull request: https://github.com/apache/flink/pull/3732#discussion_r112151646 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedDistinctRowsOver.scala --- @@ -0,0 +1,238

[jira] [Commented] (FLINK-6149) add additional flink logical relation nodes

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974354#comment-15974354 ] ASF GitHub Bot commented on FLINK-6149: --- Github user DmytroShkvyra commented on the

[jira] [Commented] (FLINK-6250) Distinct procTime with Rows boundaries

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974352#comment-15974352 ] ASF GitHub Bot commented on FLINK-6250: --- Github user huawei-flink commented on a dif

[GitHub] flink issue #3594: [FLINK-6149] [table] Add additional flink logical relatio...

2017-04-19 Thread DmytroShkvyra
Github user DmytroShkvyra commented on the issue: https://github.com/apache/flink/pull/3594 @KurtYoung, @fhueske This PR violated work with null nodes: ` org.apache.flink.table.api.TableException: Cannot generate a valid execution plan for the given query: LogicalPro

[GitHub] flink pull request #3732: [FLINK-6250] Distinct procTime with Rows boundarie...

2017-04-19 Thread huawei-flink
Github user huawei-flink commented on a diff in the pull request: https://github.com/apache/flink/pull/3732#discussion_r112151222 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedDistinctRowsOver.scala --- @@ -0,0 +1,238

[jira] [Reopened] (FLINK-6149) add additional flink logical relation nodes

2017-04-19 Thread Dmytro Shkvyra (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmytro Shkvyra reopened FLINK-6149: --- This change make fail SQL statements with null parts: Like this: {code} val sqlQuery =

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112144159 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,85 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http:/

[jira] [Commented] (FLINK-6219) Add a state backend which supports sorting

2017-04-19 Thread Fang Yong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974314#comment-15974314 ] Fang Yong commented on FLINK-6219: -- Hi [~fhueske], the SortedQueueState sounds good. In a

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112141950 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DMetric.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to th

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112142267 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,216 @@ +/* + * L

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112143069 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/metric/MetricType.java --- @@ -0,0 +1,26 @@ +/* + * Lice

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112142751 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/metric/DGauge.java --- @@ -0,0 +1,30 @@ +/* + * Licensed

[jira] [Assigned] (FLINK-6325) Refinement of slot reuse for task manager failure

2017-04-19 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang reassigned FLINK-6325: --- Assignee: zhijiang > Refinement of slot reuse for task manager failure >

<    1   2   3   4   >