[jira] [Commented] (FLINK-7127) Remove unnecessary null check or add null check

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112291#comment-16112291 ] ASF GitHub Bot commented on FLINK-7127: --- Github user tzulitai commented on the issue

[GitHub] flink issue #4349: [FLINK-7127] [runtime] Remove unnecessary null check or a...

2017-08-02 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4349 One other thing: For commit messages, they should convey the exact final fix. So, instead of "Remove unnecessary null check OR add null check", it should simply state how it is fixed. I'll ad

[jira] [Commented] (FLINK-7127) Remove unnecessary null check or add null check

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112289#comment-16112289 ] ASF GitHub Bot commented on FLINK-7127: --- Github user tzulitai commented on the issue

[GitHub] flink issue #4349: [FLINK-7127] [runtime] Remove unnecessary null check or a...

2017-08-02 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4349 Thanks for the fix! LGTM, merging .. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] flink issue #4408: Release 1.3

2017-08-02 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4408 Closing this with the github bot now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] flink pull request #4454: [hotfix][docs] Add section in docs about writing u...

2017-08-02 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4454#discussion_r131060102 --- Diff: docs/dev/testing.md --- @@ -0,0 +1,102 @@ +--- +title: "Testing" +nav-parent_id: dev +nav-pos: 110 +--- + + +This p

[GitHub] flink pull request #4454: [hotfix][docs] Add section in docs about writing u...

2017-08-02 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4454#discussion_r131059884 --- Diff: docs/dev/testing.md --- @@ -0,0 +1,102 @@ +--- +title: "Testing" +nav-parent_id: dev +nav-pos: 110 +--- + + +This p

[GitHub] flink pull request #4454: [hotfix][docs] Add section in docs about writing u...

2017-08-02 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4454#discussion_r131059770 --- Diff: docs/dev/testing.md --- @@ -0,0 +1,102 @@ +--- +title: "Testing" +nav-parent_id: dev +nav-pos: 110 +--- + + +This p

[GitHub] flink issue #4466: [FLINK-7356][configuration] misleading s3 file uri in con...

2017-08-02 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4466 Nice catch! LGTM, merging .. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[jira] [Commented] (FLINK-7356) misleading s3 file uri in configuration file

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112237#comment-16112237 ] ASF GitHub Bot commented on FLINK-7356: --- Github user tzulitai commented on the issue

[GitHub] flink issue #4328: [FLINK-6493] Fix ineffective null check in RegisteredOper...

2017-08-02 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4328 LGTM, merging .. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[jira] [Commented] (FLINK-6493) Ineffective null check in RegisteredOperatorBackendStateMetaInfo#equals()

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112235#comment-16112235 ] ASF GitHub Bot commented on FLINK-6493: --- Github user tzulitai commented on the issue

[jira] [Updated] (FLINK-7358) Add implicitly converts support for User-defined function

2017-08-02 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-7358: --- Description: Currently if user defined a UDF as follows: {code} object Func extends ScalarFunction {

[jira] [Updated] (FLINK-7358) Add implicitly converts support for User-defined function

2017-08-02 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-7358: --- Description: Currently if user defined a UDF as follows: {code} object Func extends ScalarFunction {

[jira] [Created] (FLINK-7358) Add implicitly converts support for User-defined function

2017-08-02 Thread sunjincheng (JIRA)
sunjincheng created FLINK-7358: -- Summary: Add implicitly converts support for User-defined function Key: FLINK-7358 URL: https://issues.apache.org/jira/browse/FLINK-7358 Project: Flink Issue Ty

[jira] [Created] (FLINK-7357) HOP_START() HOP_END() does not work when using HAVING clause with GROUP BY HOP window

2017-08-02 Thread Rong Rong (JIRA)
Rong Rong created FLINK-7357: Summary: HOP_START() HOP_END() does not work when using HAVING clause with GROUP BY HOP window Key: FLINK-7357 URL: https://issues.apache.org/jira/browse/FLINK-7357 Project:

[jira] [Commented] (FLINK-7076) Implement container release to support dynamic scaling

2017-08-02 Thread yuemeng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112117#comment-16112117 ] yuemeng commented on FLINK-7076: [~till.rohrmann] To support dynamic scaling,for my unders

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112113#comment-16112113 ] ASF GitHub Bot commented on FLINK-7251: --- Github user zjureel commented on the issue:

[GitHub] flink issue #4455: [FLINK-7251] Merge the flink-java8 project into correspon...

2017-08-02 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4455 1. For the `StateBackendITCase`, it can be resolved by bumping the tycho compiler version to 1.0.0, but when I try to use tycho compiler version 1.0.0 in `flink-java`, it will cause lambda exception

[jira] [Assigned] (FLINK-7076) Implement container release to support dynamic scaling

2017-08-02 Thread yuemeng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuemeng reassigned FLINK-7076: -- Assignee: yuemeng > Implement container release to support dynamic scaling > --

[jira] [Updated] (FLINK-6997) SavepointITCase fails in master branch sometimes

2017-08-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-6997: -- Description: I got the following test failure (with commit a0b781461bcf8c2f1d00b93464995f03eda589f1) {code} te

[jira] [Updated] (FLINK-7260) Match not exhaustive in WindowJoinUtil.scala

2017-08-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-7260: -- Description: Here is the warning: {code} [WARNING] /flink/flink-libraries/flink-table/src/main/scala/org/apach

[jira] [Comment Edited] (FLINK-7049) TestingApplicationMaster keeps running after integration tests finish

2017-08-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069086#comment-16069086 ] Ted Yu edited comment on FLINK-7049 at 8/3/17 2:36 AM: --- Stack trace

[jira] [Commented] (FLINK-6493) Ineffective null check in RegisteredOperatorBackendStateMetaInfo#equals()

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112082#comment-16112082 ] ASF GitHub Bot commented on FLINK-6493: --- Github user zhangminglei commented on the i

[GitHub] flink issue #4328: [FLINK-6493] Fix ineffective null check in RegisteredOper...

2017-08-02 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4328 This time, build pass. ![build](https://user-images.githubusercontent.com/6520673/28903370-11085ea4-7837-11e7-8805-ac4dcc6e9eda.png) --- If your project is set up for it, yo

[jira] [Commented] (FLINK-7344) Migrate usage of joda-time to the Java 8 DateTime API

2017-08-02 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112055#comment-16112055 ] Jark Wu commented on FLINK-7344: +1 to do this. > Migrate usage of joda-time to the Java

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-02 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112054#comment-16112054 ] Jark Wu commented on FLINK-7337: +1 for the approach. > Refactor handling of time indicat

[jira] [Commented] (FLINK-6493) Ineffective null check in RegisteredOperatorBackendStateMetaInfo#equals()

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112038#comment-16112038 ] ASF GitHub Bot commented on FLINK-6493: --- Github user zhangminglei commented on the i

[GitHub] flink issue #4328: [FLINK-6493] Fix ineffective null check in RegisteredOper...

2017-08-02 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4328 Thanks @tzulitai. I updated the code, let us wait the build ending. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[jira] [Commented] (FLINK-6105) Properly handle InterruptedException in HadoopInputFormatBase

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112030#comment-16112030 ] ASF GitHub Bot commented on FLINK-6105: --- Github user zhangminglei commented on the i

[GitHub] flink issue #4316: [FLINK-6105] Use InterruptedIOException instead of IOExce...

2017-08-02 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4316 @greghogan I saw Ted comment on the jira before. But I am not sure whether we will adopt Ted's comments. So, that is why I leave this PR until someone adopt it, I will keep working on this then.

[jira] [Commented] (FLINK-7221) JDBCOutputFormat swallows errors on last batch

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111652#comment-16111652 ] ASF GitHub Bot commented on FLINK-7221: --- Github user fhueske commented on the issue:

[GitHub] flink issue #4459: [FLINK-7221] [jdbc] Throw exception if execution of last ...

2017-08-02 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4459 Thanks for the review @kgeis! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[jira] [Commented] (FLINK-7350) only execute japicmp in one build profile

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111619#comment-16111619 ] ASF GitHub Bot commented on FLINK-7350: --- Github user zentol commented on the issue:

[GitHub] flink issue #4461: [FLINK-7350] [travis] Only execute japicmp in misc profil...

2017-08-02 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4461 @greghogan That's a great idea, implemented it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[jira] [Commented] (FLINK-7350) only execute japicmp in one build profile

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111611#comment-16111611 ] ASF GitHub Bot commented on FLINK-7350: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4461: [FLINK-7350] [travis] Only execute japicmp in misc...

2017-08-02 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4461#discussion_r130973288 --- Diff: tools/travis_mvn_watchdog.sh --- @@ -145,8 +150,11 @@ esac # -nsu option forbids downloading snapshot artifacts. The only snapshot artifacts we

[jira] [Commented] (FLINK-7356) misleading s3 file uri in configuration file

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111543#comment-16111543 ] ASF GitHub Bot commented on FLINK-7356: --- GitHub user bowenli86 opened a pull request

[GitHub] flink pull request #4466: [FLINK-7356][configuration] misleading s3 file uri...

2017-08-02 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4466 [FLINK-7356][configuration] misleading s3 file uri in configuration file **(The sections below can be removed for hotfixes of typos)** ## What is the purpose of the change *Correc

[jira] [Created] (FLINK-7356) misleading s3 file uri in configuration file

2017-08-02 Thread Bowen Li (JIRA)
Bowen Li created FLINK-7356: --- Summary: misleading s3 file uri in configuration file Key: FLINK-7356 URL: https://issues.apache.org/jira/browse/FLINK-7356 Project: Flink Issue Type: Bug Co

[jira] [Commented] (FLINK-7350) only execute japicmp in one build profile

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111475#comment-16111475 ] ASF GitHub Bot commented on FLINK-7350: --- Github user greghogan commented on a diff i

[GitHub] flink pull request #4461: [FLINK-7350] [travis] Only execute japicmp in misc...

2017-08-02 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4461#discussion_r130957157 --- Diff: tools/travis_mvn_watchdog.sh --- @@ -145,8 +150,11 @@ esac # -nsu option forbids downloading snapshot artifacts. The only snapshot artifacts

[jira] [Commented] (FLINK-7334) Replace Flink's futures by CompletableFuture in RpcGateway

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111425#comment-16111425 ] ASF GitHub Bot commented on FLINK-7334: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4462: [FLINK-7334] [futures] Replace Flink's futures wit...

2017-08-02 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4462#discussion_r130949194 --- Diff: flink-runtime/src/test/resources/log4j-test.properties --- @@ -16,7 +16,7 @@ # limitations under the License.

[jira] [Commented] (FLINK-7350) only execute japicmp in one build profile

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111414#comment-16111414 ] ASF GitHub Bot commented on FLINK-7350: --- Github user zentol commented on the issue:

[GitHub] flink issue #4461: [FLINK-7350] [travis] Only execute japicmp in misc profil...

2017-08-02 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4461 I tried upgrading the plugin, but then more violations were detected causing the build to fail. I didn't have the time to properly investigate whether it makes sense to upgrade the plugin now or not.

[GitHub] flink issue #4316: [FLINK-6105] Use InterruptedIOException instead of IOExce...

2017-08-02 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4316 @zhangminglei, not sure if you saw @tedyu's comment on the Jira. There are more instances of this in the same file and package. If these are internal classes and Flink is not using `InterruptedIOEx

[jira] [Commented] (FLINK-6105) Properly handle InterruptedException in HadoopInputFormatBase

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111351#comment-16111351 ] ASF GitHub Bot commented on FLINK-6105: --- Github user greghogan commented on the issu

[jira] [Commented] (FLINK-7221) JDBCOutputFormat swallows errors on last batch

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111305#comment-16111305 ] ASF GitHub Bot commented on FLINK-7221: --- Github user kgeis commented on the issue:

[GitHub] flink issue #4459: [FLINK-7221] [jdbc] Throw exception if execution of last ...

2017-08-02 Thread kgeis
Github user kgeis commented on the issue: https://github.com/apache/flink/pull/4459 (I filed FLINK-7221). Thanks for putting this together. I've reviewed the change and have no criticism. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink issue #4461: [FLINK-7350] [travis] Only execute japicmp in misc profil...

2017-08-02 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4461 Should we upgrade to japicmp 0.10 or delay this change until such time? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[jira] [Commented] (FLINK-7350) only execute japicmp in one build profile

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111300#comment-16111300 ] ASF GitHub Bot commented on FLINK-7350: --- Github user greghogan commented on the issu

[jira] [Commented] (FLINK-7349) Only execute checkstyle in one build profile

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111270#comment-16111270 ] ASF GitHub Bot commented on FLINK-7349: --- Github user greghogan commented on the issu

[GitHub] flink issue #4460: [FLINK-7349] [travis] Only execute checkstyle in misc pro...

2017-08-02 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4460 +1; looks to be 20 to 30 minutes faster than recent test jobs on master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[jira] [Commented] (FLINK-7334) Replace Flink's futures by CompletableFuture in RpcGateway

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111258#comment-16111258 ] ASF GitHub Bot commented on FLINK-7334: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #4462: [FLINK-7334] [futures] Replace Flink's futures with Java ...

2017-08-02 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4462 Thanks for your review @zentol. I've addressed your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request #4462: [FLINK-7334] [futures] Replace Flink's futures wit...

2017-08-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4462#discussion_r130930816 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java --- @@ -168,7 +165,7 @@ public void testHeartbeatTime

[jira] [Commented] (FLINK-7334) Replace Flink's futures by CompletableFuture in RpcGateway

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111256#comment-16111256 ] ASF GitHub Bot commented on FLINK-7334: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-7334) Replace Flink's futures by CompletableFuture in RpcGateway

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111255#comment-16111255 ] ASF GitHub Bot commented on FLINK-7334: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #4462: [FLINK-7334] [futures] Replace Flink's futures wit...

2017-08-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4462#discussion_r130930727 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rpc/TestingSerialRpcService.java --- @@ -178,20 +178,19 @@ public int getPort() {

[jira] [Commented] (FLINK-7334) Replace Flink's futures by CompletableFuture in RpcGateway

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111253#comment-16111253 ] ASF GitHub Bot commented on FLINK-7334: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #4462: [FLINK-7334] [futures] Replace Flink's futures wit...

2017-08-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4462#discussion_r130930461 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rpc/TestingRpcService.java --- @@ -92,20 +92,19 @@ public void registerGateway(String ad

[jira] [Commented] (FLINK-7334) Replace Flink's futures by CompletableFuture in RpcGateway

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111251#comment-16111251 ] ASF GitHub Bot commented on FLINK-7334: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #4462: [FLINK-7334] [futures] Replace Flink's futures wit...

2017-08-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4462#discussion_r130929937 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -755,48 +751,42 @@ public void failSlot(final ResourceID

[jira] [Updated] (FLINK-6738) HBaseConnectorITCase is flaky

2017-08-02 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-6738: --- Labels: hbase test-stability (was: hbase) > HBaseConnectorITCase is flaky > -

[jira] [Updated] (FLINK-6738) HBaseConnectorITCase is flaky

2017-08-02 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-6738: --- Priority: Critical (was: Minor) > HBaseConnectorITCase is flaky > - > >

[jira] [Updated] (FLINK-6738) HBaseConnectorITCase is flaky

2017-08-02 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-6738: --- Issue Type: Bug (was: Test) > HBaseConnectorITCase is flaky > - > >

[jira] [Updated] (FLINK-7355) ignored (manual) tests in YARNSessionFIFOITCase do not run anymore

2017-08-02 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-7355: --- Summary: ignored (manual) tests in YARNSessionFIFOITCase do not run anymore (was: YARNSessionFIFOITCa

[jira] [Commented] (FLINK-7355) ignored (manual) tests in YARNSessionFIFOITCase do not run anymore

2017-08-02 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111214#comment-16111214 ] Nico Kruber commented on FLINK-7355: similarly for {{YARNSessionFIFOITCase#testResourc

[jira] [Created] (FLINK-7355) YARNSessionFIFOITCase#testfullAlloc does not run anymore

2017-08-02 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-7355: -- Summary: YARNSessionFIFOITCase#testfullAlloc does not run anymore Key: FLINK-7355 URL: https://issues.apache.org/jira/browse/FLINK-7355 Project: Flink Issue Type

[jira] [Commented] (FLINK-7013) Add shaded netty dependency

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1655#comment-1655 ] ASF GitHub Bot commented on FLINK-7013: --- Github user rmetzger commented on the issue

[GitHub] flink issue #4452: [FLINK-7013] [shading] Introduce flink-shaded-netty-4

2017-08-02 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/4452 +1 to merge: - Checked with a project depending on Flink. It doesn't fail anymore after using your PR - mvn build passes - the dependency-red-pom of flink-runtime looks good (no netty de

[jira] [Commented] (FLINK-7013) Add shaded netty dependency

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111098#comment-16111098 ] ASF GitHub Bot commented on FLINK-7013: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4452: [FLINK-7013] [shading] Introduce flink-shaded-nett...

2017-08-02 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4452#discussion_r130909676 --- Diff: tools/travis_mvn_watchdog.sh --- @@ -290,6 +290,15 @@ check_shaded_artifacts() { echo "=

[jira] [Assigned] (FLINK-7083) Adapt WebRuntimeMonitor to work with Flip-6 architecture

2017-08-02 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-7083: Assignee: Till Rohrmann > Adapt WebRuntimeMonitor to work with Flip-6 architecture > --

[jira] [Commented] (FLINK-7107) Start Yarn session via start-up script

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111068#comment-16111068 ] ASF GitHub Bot commented on FLINK-7107: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #4465: [FLINK-7107] [flip6] Add option to start a Flip-6 ...

2017-08-02 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/4465 [FLINK-7107] [flip6] Add option to start a Flip-6 Yarn session cluster ## What is the purpose of the change The Flip-6 Yarn session cluster can now be started with yarn-session.sh --fl

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-02 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111066#comment-16111066 ] Timo Walther commented on FLINK-7337: - That makes sense. +1 for this change. I also di

[jira] [Commented] (FLINK-7293) Support custom order by in PatternStream

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111037#comment-16111037 ] ASF GitHub Bot commented on FLINK-7293: --- Github user dianfu commented on the issue:

[GitHub] flink issue #4418: [FLINK-7293] [cep] Support custom order by in PatternStre...

2017-08-02 Thread dianfu
Github user dianfu commented on the issue: https://github.com/apache/flink/pull/4418 @dawidwys Thanks a lot for your review. Have updated the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] flink pull request #4418: [FLINK-7293] [cep] Support custom order by in Patt...

2017-08-02 Thread dianfu
Github user dianfu commented on a diff in the pull request: https://github.com/apache/flink/pull/4418#discussion_r130896153 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPOperatorTest.java --- @@ -923,6 +934,126 @@ public boolean filter(Event va

[jira] [Commented] (FLINK-7293) Support custom order by in PatternStream

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111031#comment-16111031 ] ASF GitHub Bot commented on FLINK-7293: --- Github user dianfu commented on a diff in t

[jira] [Commented] (FLINK-7293) Support custom order by in PatternStream

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111034#comment-16111034 ] ASF GitHub Bot commented on FLINK-7293: --- Github user dianfu commented on a diff in t

[jira] [Commented] (FLINK-7293) Support custom order by in PatternStream

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111029#comment-16111029 ] ASF GitHub Bot commented on FLINK-7293: --- Github user dianfu commented on a diff in t

[GitHub] flink pull request #4418: [FLINK-7293] [cep] Support custom order by in Patt...

2017-08-02 Thread dianfu
Github user dianfu commented on a diff in the pull request: https://github.com/apache/flink/pull/4418#discussion_r130896034 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java --- @@ -257,7 +289,32 @@ public void onE

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-02 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111030#comment-16111030 ] Fabian Hueske commented on FLINK-7337: -- We would of course still have a logical and a

[jira] [Commented] (FLINK-7293) Support custom order by in PatternStream

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111033#comment-16111033 ] ASF GitHub Bot commented on FLINK-7293: --- Github user dianfu commented on a diff in t

[GitHub] flink pull request #4418: [FLINK-7293] [cep] Support custom order by in Patt...

2017-08-02 Thread dianfu
Github user dianfu commented on a diff in the pull request: https://github.com/apache/flink/pull/4418#discussion_r130896085 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPOperatorTest.java --- @@ -923,6 +934,126 @@ public boolean filter(Event va

[GitHub] flink pull request #4418: [FLINK-7293] [cep] Support custom order by in Patt...

2017-08-02 Thread dianfu
Github user dianfu commented on a diff in the pull request: https://github.com/apache/flink/pull/4418#discussion_r130895852 --- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/CEP.scala --- @@ -36,8 +38,26 @@ object CEP { * @tparam T Type o

[jira] [Commented] (FLINK-7293) Support custom order by in PatternStream

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111026#comment-16111026 ] ASF GitHub Bot commented on FLINK-7293: --- Github user dianfu commented on a diff in t

[GitHub] flink pull request #4418: [FLINK-7293] [cep] Support custom order by in Patt...

2017-08-02 Thread dianfu
Github user dianfu commented on a diff in the pull request: https://github.com/apache/flink/pull/4418#discussion_r130895782 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/CEP.java --- @@ -38,4 +40,17 @@ public static PatternStream pattern(DataStream

[jira] [Resolved] (FLINK-7166) generated avro sources not cleaned up or re-created after changes

2017-08-02 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-7166. Resolution: Fixed Fix Version/s: 1.4.0 Thanks for the contribution [~NicoK]!

[GitHub] flink pull request #4290: [FLINK-7133]Excluding optional asm dependencies fr...

2017-08-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4290 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-7133) Fix Elasticsearch version interference

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111010#comment-16111010 ] ASF GitHub Bot commented on FLINK-7133: --- Github user asfgit closed the pull request

[GitHub] flink pull request #4309: [FLINK-7166][avro] cleanup generated test classes ...

2017-08-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4309 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-7166) generated avro sources not cleaned up or re-created after changes

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111009#comment-16111009 ] ASF GitHub Bot commented on FLINK-7166: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-7354) test instability in LocalFlinkMiniClusterITCase#testLocalFlinkMiniClusterWithMultipleTaskManagers

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111007#comment-16111007 ] ASF GitHub Bot commented on FLINK-7354: --- GitHub user NicoK opened a pull request:

[GitHub] flink pull request #4464: [FLINK-7354][tests] ignore "initialSeedUniquifierG...

2017-08-02 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4464 [FLINK-7354][tests] ignore "initialSeedUniquifierGenerator" thread in thread list ## What is the purpose of the change Netty may spawn a thread in its `ThreadLocalRandom` because of some secu

[jira] [Commented] (FLINK-7013) Add shaded netty dependency

2017-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110999#comment-16110999 ] ASF GitHub Bot commented on FLINK-7013: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request #4452: [FLINK-7013] [shading] Introduce flink-shaded-nett...

2017-08-02 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/4452#discussion_r130890710 --- Diff: tools/travis_mvn_watchdog.sh --- @@ -290,6 +290,15 @@ check_shaded_artifacts() { echo "===

  1   2   3   >