[jira] [Commented] (FLINK-7366) Upgrade kinesis producer library, kinesis client library, and AWS SDK in flink-connector-kinesis

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124340#comment-16124340 ] ASF GitHub Bot commented on FLINK-7366: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #4522: [FLINK-7366][kinesis connector] Upgrade kinesis producer ...

2017-08-11 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4522 @bowenli86 its fine to upgrade KPL. It's consumer related libraries version that currently cannot be touched. Consumer related versions can currently only be upgraded until 1) Flink 1.2 is

[jira] [Comment Edited] (FLINK-6333) Utilize Bloomfilters in RocksDb

2017-08-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095490#comment-16095490 ] Ted Yu edited comment on FLINK-6333 at 8/11/17 11:56 PM: - Looks like rocksdb issue

[jira] [Comment Edited] (FLINK-6402) Consider removing annotation for REAPER_THREAD_LOCK in SafetyNetCloseableRegistry#doRegister()

2017-08-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986965#comment-15986965 ] Ted Yu edited comment on FLINK-6402 at 8/11/17 11:49 PM: - Pardon the typo. The

[GitHub] flink issue #4522: [FLINK-7366][kinesis connector] Upgrade kinesis producer ...

2017-08-11 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4522 @tzulitai @aljoscha there's another major bug in KPL that we need to fix for flink-connector-kinesis https://github.com/awslabs/amazon-kinesis-producer/issues/10 We've been seeing that bug

[jira] [Commented] (FLINK-7366) Upgrade kinesis producer library, kinesis client library, and AWS SDK in flink-connector-kinesis

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124126#comment-16124126 ] ASF GitHub Bot commented on FLINK-7366: --- Github user bowenli86 commented on the issue:

[jira] [Commented] (FLINK-7226) REST responses contain invalid content-encoding header

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123939#comment-16123939 ] ASF GitHub Bot commented on FLINK-7226: --- Github user zentol commented on the issue:

[GitHub] flink issue #4392: [FLINK-7226] [webUI] Properly include UTF-8 in content-ty...

2017-08-11 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4392 @willddy Please open a new JIRA @ https://issues.apache.org/jira/browse/FLINK with a description of what error you are encountering. I looked through the code and we never set the encoding header

[jira] [Commented] (FLINK-7366) Upgrade kinesis producer library, kinesis client library, and AWS SDK in flink-connector-kinesis

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123860#comment-16123860 ] ASF GitHub Bot commented on FLINK-7366: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #4522: [FLINK-7366][kinesis connector] Upgrade kinesis producer ...

2017-08-11 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4522 oh.this is not goodDo you mean that we cannot upgrade KPL/KCL until Flink 1.5? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request #4515: Logging improvements in NetworkFailuresProxy

2017-08-11 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4515#discussion_r132754963 --- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/networking/NetworkFailureHandler.java --- @@ -92,7 +92,14 @@ public void

[jira] [Commented] (FLINK-7423) Always reuse an instance to get elements from the inputFormat

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123772#comment-16123772 ] ASF GitHub Bot commented on FLINK-7423: --- Github user greghogan commented on the issue:

[GitHub] flink issue #4525: [FLINK-7423] Always reuse an instance to get elements fro...

2017-08-11 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4525 Hi @XuPingyong thanks for submitting this PR. I'm not clear on why the `null` check was added in FLINK-4075 and `ContinuousFileProcessingTest` is not running locally for me. When calling

[jira] [Commented] (FLINK-7245) Enhance the operators to support holding back watermarks

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123696#comment-16123696 ] ASF GitHub Bot commented on FLINK-7245: --- GitHub user xccui opened a pull request:

[GitHub] flink pull request #4530: [FLINK-7245] [stream] Support holding back waterma...

2017-08-11 Thread xccui
GitHub user xccui opened a pull request: https://github.com/apache/flink/pull/4530 [FLINK-7245] [stream] Support holding back watermarks with static delays ## What is the purpose of the change *This pull request aims to allow the operators to support holding back

[jira] [Created] (FLINK-7433) Lack of synchronization accessing inProgress in JobCancellationWithSavepointHandlers

2017-08-11 Thread Ted Yu (JIRA)
Ted Yu created FLINK-7433: - Summary: Lack of synchronization accessing inProgress in JobCancellationWithSavepointHandlers Key: FLINK-7433 URL: https://issues.apache.org/jira/browse/FLINK-7433 Project: Flink

[jira] [Created] (FLINK-7432) Unclosed HighAvailabilityServices instance in QueryableStateClient

2017-08-11 Thread Ted Yu (JIRA)
Ted Yu created FLINK-7432: - Summary: Unclosed HighAvailabilityServices instance in QueryableStateClient Key: FLINK-7432 URL: https://issues.apache.org/jira/browse/FLINK-7432 Project: Flink Issue

[jira] [Commented] (FLINK-7378) Implement the FixedBufferPool for floating buffers of SingleInputGate

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123534#comment-16123534 ] ASF GitHub Bot commented on FLINK-7378: --- Github user zhijiangW commented on the issue:

[GitHub] flink issue #4485: [FLINK-7378][core]Implement the FixedBufferPool for float...

2017-08-11 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4485 @NicoK , Thank you for reviews! Considering the difference between `FixedBufferPool` and `LocalBufferPool`, I think you are right. I also think of this question when implement this new

[GitHub] flink issue #4529: [FLINK-7428][network] avoid buffer copies when receiving ...

2017-08-11 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4529 FYI: - newer netty 4.0.xx versions also use `buffer.slice(index, length)` inside their `extractFrame()` method (see https://github.com/netty/netty/commit/891be30a28c6dc5a1edf1cb5a3690644cf4ff66e)

[jira] [Commented] (FLINK-7428) avoid one additional buffer copy when receiving messages

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123525#comment-16123525 ] ASF GitHub Bot commented on FLINK-7428: --- Github user NicoK commented on the issue:

[jira] [Commented] (FLINK-3133) Introduce collect()/count()/print() methods in DataStream API

2017-08-11 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123522#comment-16123522 ] Aljoscha Krettek commented on FLINK-3133: - I would be in favour of closing this issue. The

[jira] [Commented] (FLINK-3785) Add REST resource to query information about checkpointing

2017-08-11 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123515#comment-16123515 ] Ufuk Celebi commented on FLINK-3785: It is possible but not documented as part of the rest API. We

[jira] [Closed] (FLINK-6281) Create TableSink for JDBC

2017-08-11 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-6281. Resolution: Implemented Fix Version/s: 1.4.0 Implemented for 1.4.0 with

[jira] [Commented] (FLINK-6281) Create TableSink for JDBC

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123487#comment-16123487 ] ASF GitHub Bot commented on FLINK-6281: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #3712: [FLINK-6281] Create TableSink for JDBC.

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3712 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4479: [FLINK-7309][hotfix] fix NullPointerException when...

2017-08-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4479#discussion_r132691900 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala --- @@ -314,5 +314,34 @@ class SqlITCase

[GitHub] flink pull request #4479: [FLINK-7309][hotfix] fix NullPointerException when...

2017-08-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4479#discussion_r132703597 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -1181,8 +1188,12 @@ abstract class

[jira] [Commented] (FLINK-7309) NullPointerException in CodeGenUtils.timePointToInternalCode() generated code

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123449#comment-16123449 ] ASF GitHub Bot commented on FLINK-7309: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7309) NullPointerException in CodeGenUtils.timePointToInternalCode() generated code

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123448#comment-16123448 ] ASF GitHub Bot commented on FLINK-7309: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7309) NullPointerException in CodeGenUtils.timePointToInternalCode() generated code

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123450#comment-16123450 ] ASF GitHub Bot commented on FLINK-7309: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4479: [FLINK-7309][hotfix] fix NullPointerException when...

2017-08-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4479#discussion_r132690201 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -1172,6 +1172,13 @@ abstract class

[jira] [Commented] (FLINK-7309) NullPointerException in CodeGenUtils.timePointToInternalCode() generated code

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123446#comment-16123446 ] ASF GitHub Bot commented on FLINK-7309: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4479: [FLINK-7309][hotfix] fix NullPointerException when...

2017-08-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4479#discussion_r132703400 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -1193,12 +1204,18 @@ abstract class

[jira] [Commented] (FLINK-7309) NullPointerException in CodeGenUtils.timePointToInternalCode() generated code

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123447#comment-16123447 ] ASF GitHub Bot commented on FLINK-7309: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4479: [FLINK-7309][hotfix] fix NullPointerException when...

2017-08-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4479#discussion_r132689501 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -1193,12 +1204,18 @@ abstract class

[jira] [Commented] (FLINK-7226) REST responses contain invalid content-encoding header

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123437#comment-16123437 ] ASF GitHub Bot commented on FLINK-7226: --- Github user willddy commented on the issue:

[GitHub] flink issue #4392: [FLINK-7226] [webUI] Properly include UTF-8 in content-ty...

2017-08-11 Thread willddy
Github user willddy commented on the issue: https://github.com/apache/flink/pull/4392 I still found this issue only when the job id not found as follows in the latest v1.3.2. Pls. reopen the issue localhost:8001/jobs/0e12860ffae73f23dc104aedb814d6d2 --- If your project is set up

[jira] [Commented] (FLINK-7068) change BlobService sub-classes for permanent and transient BLOBs

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123369#comment-16123369 ] ASF GitHub Bot commented on FLINK-7068: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #4358: [FLINK-7068][blob] change BlobService sub-classes for per...

2017-08-11 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4358 Hi Nico, I'm still waiting for Travis before merging FLINK-7056. In the meantime could you rebase this PR and squash all FLINK-7068 commits into one? Thanks. --- If your project is set up for

[jira] [Commented] (FLINK-7396) Don't put multiple directories in HADOOP_CONF_DIR in config.sh

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123367#comment-16123367 ] ASF GitHub Bot commented on FLINK-7396: --- Github user aljoscha commented on the issue:

[jira] [Closed] (FLINK-7396) Don't put multiple directories in HADOOP_CONF_DIR in config.sh

2017-08-11 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-7396. --- Resolution: Fixed Fixed on master in 1de8acc3c89af22f10aed80d7016545db23a0ad5 Fixed on

[jira] [Commented] (FLINK-7057) move BLOB ref-counting from LibraryCacheManager to BlobCache

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123365#comment-16123365 ] ASF GitHub Bot commented on FLINK-7057: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-7396) Don't put multiple directories in HADOOP_CONF_DIR in config.sh

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123364#comment-16123364 ] ASF GitHub Bot commented on FLINK-7396: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #4511: [FLINK-7396] Don't put multiple directories in HADOOP_CON...

2017-08-11 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4511 Could you please close the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink issue #4238: [FLINK-7057][blob] move BLOB ref-counting from LibraryCac...

2017-08-11 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4238 Hi Nico, I'm still waiting for Travis before merging FLINK-7056. Could you rebase this PR in the meantime and maybe also squash all FLINK-7057 commits into one? This helps me to get faster

[GitHub] flink issue #4511: [FLINK-7396] Don't put multiple directories in HADOOP_CON...

2017-08-11 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4511 Thanks! I merged it. 😃 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (FLINK-7245) Enhance the operators to support holding back watermarks

2017-08-11 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123328#comment-16123328 ] Xingcan Cui commented on FLINK-7245: Hi [~fhueske], thanks for the response. I think you are right.

[jira] [Commented] (FLINK-7245) Enhance the operators to support holding back watermarks

2017-08-11 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123314#comment-16123314 ] Fabian Hueske commented on FLINK-7245: -- Hi [~xccui], thanks for the pointer to you code. I had a look

[jira] [Created] (FLINK-7431) test instability in JobManagerFailsITCase

2017-08-11 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-7431: -- Summary: test instability in JobManagerFailsITCase Key: FLINK-7431 URL: https://issues.apache.org/jira/browse/FLINK-7431 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-7431) test instability in JobManagerFailsITCase

2017-08-11 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-7431: --- Labels: test-stability (was: ) > test instability in JobManagerFailsITCase >

[jira] [Commented] (FLINK-7378) Implement the FixedBufferPool for floating buffers of SingleInputGate

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123282#comment-16123282 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4485: [FLINK-7378][core]Implement the FixedBufferPool fo...

2017-08-11 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r132655177 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/FixedBufferPool.java --- @@ -0,0 +1,280 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-7378) Implement the FixedBufferPool for floating buffers of SingleInputGate

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123283#comment-16123283 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4485: [FLINK-7378][core]Implement the FixedBufferPool fo...

2017-08-11 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r132655478 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferPoolListener.java --- @@ -0,0 +1,34 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-7378) Implement the FixedBufferPool for floating buffers of SingleInputGate

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123287#comment-16123287 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7378) Implement the FixedBufferPool for floating buffers of SingleInputGate

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123284#comment-16123284 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4485: [FLINK-7378][core]Implement the FixedBufferPool fo...

2017-08-11 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r13267 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferPoolFactory.java --- @@ -39,6 +39,17 @@ BufferPool

[jira] [Commented] (FLINK-7378) Implement the FixedBufferPool for floating buffers of SingleInputGate

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123285#comment-16123285 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7378) Implement the FixedBufferPool for floating buffers of SingleInputGate

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123286#comment-16123286 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4485: [FLINK-7378][core]Implement the FixedBufferPool fo...

2017-08-11 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r132670989 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/FixedBufferPool.java --- @@ -0,0 +1,280 @@ +/* + * Licensed to the

[GitHub] flink pull request #4485: [FLINK-7378][core]Implement the FixedBufferPool fo...

2017-08-11 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r132655594 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferPool.java --- @@ -79,4 +79,12 @@ * Returns the number of used

[GitHub] flink pull request #4485: [FLINK-7378][core]Implement the FixedBufferPool fo...

2017-08-11 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r132673916 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPool.java --- @@ -221,13 +228,44 @@ public BufferPool

[jira] [Assigned] (FLINK-7429) Add restore from 1.2 / 1.3 migration tests for FlinkKinesisConsumer

2017-08-11 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai reassigned FLINK-7429: -- Assignee: Tzu-Li (Gordon) Tai > Add restore from 1.2 / 1.3 migration tests for

[GitHub] flink issue #4526: [FLINK-7407] [kafka] Adapt AbstractPartitionDiscoverer to...

2017-08-11 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4526 Thanks for the review @aljoscha! Merging this .. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-7407) Assumption of partition id strict contiguity is too naive in Kafka consumer's AbstractPartitionDiscoverer

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123273#comment-16123273 ] ASF GitHub Bot commented on FLINK-7407: --- Github user tzulitai commented on the issue:

[jira] [Commented] (FLINK-7429) Add restore from 1.2 / 1.3 migration tests for FlinkKinesisConsumer

2017-08-11 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123272#comment-16123272 ] Tzu-Li (Gordon) Tai commented on FLINK-7429: [~aljoscha] I agree. > Add restore from 1.2 /

[jira] [Commented] (FLINK-3133) Introduce collect()/count()/print() methods in DataStream API

2017-08-11 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-3133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123262#comment-16123262 ] Gábor Hermann commented on FLINK-3133: -- What's the status of this? We already have collect()

[jira] [Commented] (FLINK-7429) Add restore from 1.2 / 1.3 migration tests for FlinkKinesisConsumer

2017-08-11 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123258#comment-16123258 ] Aljoscha Krettek commented on FLINK-7429: - I promoted to blocker, because we're thinking about

[jira] [Updated] (FLINK-7429) Add restore from 1.2 / 1.3 migration tests for FlinkKinesisConsumer

2017-08-11 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-7429: Fix Version/s: 1.3.3 1.4.0 > Add restore from 1.2 / 1.3 migration tests

[jira] [Updated] (FLINK-7429) Add restore from 1.2 / 1.3 migration tests for FlinkKinesisConsumer

2017-08-11 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-7429: Priority: Blocker (was: Major) > Add restore from 1.2 / 1.3 migration tests for

[jira] [Commented] (FLINK-6244) Emit timeouted Patterns as Side Output

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123255#comment-16123255 ] ASF GitHub Bot commented on FLINK-6244: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #4320: [FLINK-6244] Emit timeouted Patterns as Side Output

2017-08-11 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4320 To me, this looks good now. Let's see if @kl0u want's to take another look, otherwise I would say it's good to merge. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...

2017-08-11 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4331#discussion_r132669361 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -859,7 +940,7 @@ public boolean apply(@Nullable State input) {

[jira] [Commented] (FLINK-7169) Support AFTER MATCH SKIP function in CEP library API

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123249#comment-16123249 ] ASF GitHub Bot commented on FLINK-7169: --- Github user dawidwys commented on a diff in the pull

[jira] [Commented] (FLINK-7387) Let RpcEndpoint directly implement RpcGateways

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123242#comment-16123242 ] ASF GitHub Bot commented on FLINK-7387: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #4498: [FLINK-7387] [rpc] Require RpcEndpoints to directl...

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4498 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-7381) Decouple WebRuntimeMonitor from ActorGateway

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123237#comment-16123237 ] ASF GitHub Bot commented on FLINK-7381: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-7387) Let RpcEndpoint directly implement RpcGateways

2017-08-11 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-7387. Resolution: Fixed Fix Version/s: 1.4.0 Fixed via d95d20eb45185151d731c9b41e9b1ac22cf81334 >

[jira] [Closed] (FLINK-7381) Decouple WebRuntimeMonitor from ActorGateway

2017-08-11 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-7381. Resolution: Fixed Fix Version/s: 1.4.0 Fixed via 9f790d3efe5e8267da05eb97bbe07ca8a0f859fe >

[GitHub] flink pull request #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from...

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4492 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #4320: [FLINK-6244] Emit timeouted Patterns as Side Output

2017-08-11 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/4320 Thanks for the review @aljoscha . I've addressed all your comments. Also changed a section in docs to use the preferred version of handling timeouted results. I've rebased the PR, as it was far

[jira] [Closed] (FLINK-7260) Match not exhaustive in WindowJoinUtil.scala

2017-08-11 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-7260. Resolution: Fixed Assignee: Timo Walther Fix Version/s: 1.4.0 Fixed with

[jira] [Commented] (FLINK-6244) Emit timeouted Patterns as Side Output

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123229#comment-16123229 ] ASF GitHub Bot commented on FLINK-6244: --- Github user dawidwys commented on the issue:

[jira] [Commented] (FLINK-6281) Create TableSink for JDBC

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123225#comment-16123225 ] ASF GitHub Bot commented on FLINK-6281: --- Github user fhueske commented on the issue:

[GitHub] flink issue #3712: [FLINK-6281] Create TableSink for JDBC.

2017-08-11 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3712 Thanks for the update @haohui. I'll merge this PR :-) I have to change some of the type mappings to make it work with `JDBCOutputFormat`. I think it would be a good idea to redesign the

[jira] [Comment Edited] (FLINK-7430) ContinuousFileReaderOperator swallows exceptions

2017-08-11 Thread Peter Ertl (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123207#comment-16123207 ] Peter Ertl edited comment on FLINK-7430 at 8/11/17 11:21 AM: - It seems like

[jira] [Comment Edited] (FLINK-7430) ContinuousFileReaderOperator swallows exceptions

2017-08-11 Thread Peter Ertl (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123207#comment-16123207 ] Peter Ertl edited comment on FLINK-7430 at 8/11/17 11:20 AM: - It seems like

[jira] [Commented] (FLINK-7430) ContinuousFileReaderOperator swallows exceptions

2017-08-11 Thread Peter Ertl (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123207#comment-16123207 ] Peter Ertl commented on FLINK-7430: --- It seems like the task itself is finished but the output format is

[jira] [Updated] (FLINK-7430) ContinuousFileReaderOperator swallows exceptions

2017-08-11 Thread Peter Ertl (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Ertl updated FLINK-7430: -- Description: The class *ContinuousFileReaderOperator* is swallowing exceptions as the following

[jira] [Updated] (FLINK-7430) ContinuousFileReaderOperator swallows exceptions

2017-08-11 Thread Peter Ertl (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Ertl updated FLINK-7430: -- Description: The class *ContinuousFileReaderOperator* is swallowing exceptions as the following

[jira] [Updated] (FLINK-7430) ContinuousFileReaderOperator swallows exceptions

2017-08-11 Thread Peter Ertl (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Ertl updated FLINK-7430: -- Description: The class *ContinuousFileReaderOperator* is swallowing exception as the following example

[jira] [Updated] (FLINK-7430) ContinuousFileReaderOperator swallows exceptions

2017-08-11 Thread Peter Ertl (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Ertl updated FLINK-7430: -- Environment: - macOS 10.12.6 - Oracle JDK 1.8.0_144 - Flink 1.3.2 > ContinuousFileReaderOperator

[jira] [Updated] (FLINK-7430) ContinuousFileReaderOperator swallows exceptions

2017-08-11 Thread Peter Ertl (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Ertl updated FLINK-7430: -- Description: The class ContinuousFileReaderOperator is swallowing exception as the following example

[jira] [Created] (FLINK-7430) ContinuousFileReaderOperator swallows exceptions

2017-08-11 Thread Peter Ertl (JIRA)
Peter Ertl created FLINK-7430: - Summary: ContinuousFileReaderOperator swallows exceptions Key: FLINK-7430 URL: https://issues.apache.org/jira/browse/FLINK-7430 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-7366) Upgrade kinesis producer library, kinesis client library, and AWS SDK in flink-connector-kinesis

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123167#comment-16123167 ] ASF GitHub Bot commented on FLINK-7366: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #4522: [FLINK-7366][kinesis connector] Upgrade kinesis producer ...

2017-08-11 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4522 Ok, so it seems like Java serialization of the Kinesis classes was removed only starting from 1.3.x. That means unless we do some classloading trick, we can't really upgrade the Kinesis

[jira] [Created] (FLINK-7429) Add restore from 1.2 / 1.3 migration tests for FlinkKinesisConsumer

2017-08-11 Thread Tzu-Li (Gordon) Tai (JIRA)
Tzu-Li (Gordon) Tai created FLINK-7429: -- Summary: Add restore from 1.2 / 1.3 migration tests for FlinkKinesisConsumer Key: FLINK-7429 URL: https://issues.apache.org/jira/browse/FLINK-7429

[jira] [Commented] (FLINK-7366) Upgrade kinesis producer library, kinesis client library, and AWS SDK in flink-connector-kinesis

2017-08-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123159#comment-16123159 ] ASF GitHub Bot commented on FLINK-7366: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #4522: [FLINK-7366][kinesis connector] Upgrade kinesis producer ...

2017-08-11 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4522 Hmm, I think Java serialization was removed from the Kinesis connector starting from 1.3. But thinking of it now, I recall that there was some migration path from that. Let me double check ..

  1   2   >