[GitHub] flink pull request #4722: [FLINK-7683] Iterate over keys in KeyedStateBacken...

2017-09-27 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4722#discussion_r141258536 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -1946,4 +19

[jira] [Commented] (FLINK-7683) Add method to iterate over all of the existing keys in a statebackend

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182108#comment-16182108 ] ASF GitHub Bot commented on FLINK-7683: --- Github user pnowojski commented on a diff i

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-27 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r141260601 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/MultisetTypeInfo.java --- @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache S

[jira] [Commented] (FLINK-7491) Support COLLECT Aggregate function in Flink SQL

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182123#comment-16182123 ] ASF GitHub Bot commented on FLINK-7491: --- Github user suez1224 commented on a diff in

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-27 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r141260762 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/MultisetTypeInfo.java --- @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache S

[jira] [Commented] (FLINK-7491) Support COLLECT Aggregate function in Flink SQL

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182125#comment-16182125 ] ASF GitHub Bot commented on FLINK-7491: --- Github user suez1224 commented on a diff in

[jira] [Assigned] (FLINK-7426) Table API does not support null values in keys

2017-09-27 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-7426: --- Assignee: Timo Walther > Table API does not support null values in keys > ---

[GitHub] flink pull request #4722: [FLINK-7683] Iterate over keys in KeyedStateBacken...

2017-09-27 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4722#discussion_r141272559 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateBackend.java --- @@ -37,6 +39,12 @@ void setCurrentKey(K newKey);

[jira] [Commented] (FLINK-7683) Add method to iterate over all of the existing keys in a statebackend

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182174#comment-16182174 ] ASF GitHub Bot commented on FLINK-7683: --- Github user aljoscha commented on a diff in

[GitHub] flink issue #4722: [FLINK-7683] Iterate over keys in KeyedStateBackend

2017-09-27 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4722 I have one more talking point for this: the behaviour of the iterators for RocksDB and heap backends are different now: for RocksDB we iterate over a snapshot of the data and modifications con

[jira] [Commented] (FLINK-7683) Add method to iterate over all of the existing keys in a statebackend

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182179#comment-16182179 ] ASF GitHub Bot commented on FLINK-7683: --- Github user StefanRRichter commented on the

[jira] [Commented] (FLINK-7697) Add metrics for Elasticsearch Sink

2017-09-27 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182195#comment-16182195 ] Tzu-Li (Gordon) Tai commented on FLINK-7697: +1, we previously had another use

[GitHub] flink issue #4698: [FLINK-7661][network] Add credit field in PartitionReques...

2017-09-27 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4698 Actually, what worries me a bit are the test failures of the 3rd and 4th test profile. I think, they're unrelated (especially the Kafka ones which are kind of instable at the moment in general), but th

[jira] [Commented] (FLINK-7661) Add credit field in PartitionRequest message

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182198#comment-16182198 ] ASF GitHub Bot commented on FLINK-7661: --- Github user NicoK commented on the issue:

[jira] [Commented] (FLINK-7648) Port TaskManagersHandler to new REST endpoint

2017-09-27 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182234#comment-16182234 ] Till Rohrmann commented on FLINK-7648: -- [~phoenixjiangnan], currently the new REST se

[jira] [Commented] (FLINK-7694) Port JobMetricsHandler to new REST handler

2017-09-27 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182236#comment-16182236 ] Till Rohrmann commented on FLINK-7694: -- [~phoenixjiangnan], the steps look good to me

[jira] [Created] (FLINK-7698) Join with null literals leads to NPE

2017-09-27 Thread Timo Walther (JIRA)
Timo Walther created FLINK-7698: --- Summary: Join with null literals leads to NPE Key: FLINK-7698 URL: https://issues.apache.org/jira/browse/FLINK-7698 Project: Flink Issue Type: Bug Co

[jira] [Updated] (FLINK-7698) Join with null literals leads to NPE

2017-09-27 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-7698: Affects Version/s: 1.4.0 > Join with null literals leads to NPE > --

[GitHub] flink pull request #4728: [FLINK-7668] Add ExecutionGraphCache for Execution...

2017-09-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4728#discussion_r141288976 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/ExecutionGraphCache.java --- @@ -0,0 +1,182 @@ +/* + * Licensed to

[GitHub] flink pull request #4728: [FLINK-7668] Add ExecutionGraphCache for Execution...

2017-09-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4728#discussion_r141290566 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/ExecutionGraphCacheTest.java --- @@ -0,0 +1,357 @@ +/* + * License

[GitHub] flink pull request #4728: [FLINK-7668] Add ExecutionGraphCache for Execution...

2017-09-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4728#discussion_r141293178 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java --- @@ -193,11 +198,23 @@ public WebRuntimeMonitor(

[jira] [Commented] (FLINK-7668) Add AccessExecutionGraph refresh interval to ExecutionGraphHolder

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182250#comment-16182250 ] ASF GitHub Bot commented on FLINK-7668: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7668) Add AccessExecutionGraph refresh interval to ExecutionGraphHolder

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182249#comment-16182249 ] ASF GitHub Bot commented on FLINK-7668: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7668) Add AccessExecutionGraph refresh interval to ExecutionGraphHolder

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182248#comment-16182248 ] ASF GitHub Bot commented on FLINK-7668: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7668) Add AccessExecutionGraph refresh interval to ExecutionGraphHolder

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182253#comment-16182253 ] ASF GitHub Bot commented on FLINK-7668: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7668) Add AccessExecutionGraph refresh interval to ExecutionGraphHolder

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182252#comment-16182252 ] ASF GitHub Bot commented on FLINK-7668: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4728: [FLINK-7668] Add ExecutionGraphCache for Execution...

2017-09-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4728#discussion_r141290895 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/ExecutionGraphCacheTest.java --- @@ -0,0 +1,357 @@ +/* + * License

[jira] [Commented] (FLINK-7668) Add AccessExecutionGraph refresh interval to ExecutionGraphHolder

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182251#comment-16182251 ] ASF GitHub Bot commented on FLINK-7668: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4728: [FLINK-7668] Add ExecutionGraphCache for Execution...

2017-09-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4728#discussion_r141288926 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/ExecutionGraphCache.java --- @@ -0,0 +1,182 @@ +/* + * Licensed to

[GitHub] flink pull request #4728: [FLINK-7668] Add ExecutionGraphCache for Execution...

2017-09-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4728#discussion_r141285310 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/ExecutionGraphCache.java --- @@ -0,0 +1,182 @@ +/* + * Licensed to

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141293477 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java --- @@ -169,95 +182,19 @@ public void t

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141281604 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -0,0 +1,283 @@ +/* + * Licensed t

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141288898 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -0,0 +1,283 @@ +/* + * Licensed t

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141291264 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java --- @@ -122,6 +113,28 @@ public void te

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141292253 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -0,0 +1,283 @@ +/* + * Licensed t

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141288399 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -0,0 +1,283 @@ +/* + * Licensed t

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141290289 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java --- @@ -193,7 +193,8 @@ private void writeAndFlushN

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141283335 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -0,0 +1,283 @@ +/* + * Licensed t

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141285605 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -0,0 +1,283 @@ +/* + * Licensed t

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182257#comment-16182257 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in th

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182256#comment-16182256 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in th

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182258#comment-16182258 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in th

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182262#comment-16182262 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in th

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182261#comment-16182261 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in th

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182259#comment-16182259 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in th

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182255#comment-16182255 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in th

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182263#comment-16182263 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in th

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182260#comment-16182260 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in th

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-09-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r141293920 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -228,7 +234,14 @@ public void startNewWorker(ResourceProfile r

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-09-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r141294374 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -228,7 +234,14 @@ public void startNewWorker(ResourceProfile r

[jira] [Commented] (FLINK-7076) Implement container release to support dynamic scaling

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182267#comment-16182267 ] ASF GitHub Bot commented on FLINK-7076: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-7076) Implement container release to support dynamic scaling

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182266#comment-16182266 ] ASF GitHub Bot commented on FLINK-7076: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #4697: [FLINK-7650] [flip6] Port JobCancellationHandler t...

2017-09-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4697#discussion_r141294948 --- Diff: flink-runtime-web/src/test/resources/log4j-test.properties --- @@ -16,7 +16,7 @@ # limitations under the License. # -log4j.

[jira] [Commented] (FLINK-7650) Port JobCancellationHandler to new REST endpoint

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182270#comment-16182270 ] ASF GitHub Bot commented on FLINK-7650: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #4697: [FLINK-7650] [flip6] Port JobCancellationHandler t...

2017-09-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4697#discussion_r141295793 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterGateway.java --- @@ -55,6 +55,14 @@ public interface JobMasterGa

[jira] [Commented] (FLINK-7650) Port JobCancellationHandler to new REST endpoint

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182277#comment-16182277 ] ASF GitHub Bot commented on FLINK-7650: --- Github user tillrohrmann commented on a dif

[GitHub] flink issue #4698: [FLINK-7661][network] Add credit field in PartitionReques...

2017-09-27 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4698 @NicoK , thanks for your reviews! I checked the travis failure before and thought it should be existing flaky ones. I will re-trigger the tests later and see the results. ---

[jira] [Commented] (FLINK-7661) Add credit field in PartitionRequest message

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182289#comment-16182289 ] ASF GitHub Bot commented on FLINK-7661: --- Github user zhijiangW commented on the issu

[jira] [Closed] (FLINK-6167) Consider removing ArchivedExecutionGraph classes

2017-09-27 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6167. --- Resolution: Won't Fix The ArchivedExecution* classes will remain in use as per FLINK-7667 & F

[GitHub] flink pull request #4697: [FLINK-7650] [flip6] Port JobCancellationHandler t...

2017-09-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4697#discussion_r141297064 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobPathParameter.java --- @@ -0,0 +1,45 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-7650) Port JobCancellationHandler to new REST endpoint

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182292#comment-16182292 ] ASF GitHub Bot commented on FLINK-7650: --- Github user tillrohrmann commented on a dif

[GitHub] flink issue #4509: [FLINK-7406][network] Implement Netty receiver incoming p...

2017-09-27 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4509 @NicoK , thanks for your reviews! Actually there are still two PRs under submitted before this PR. One is for floating buffer interaction between `RemoteInputChannel` and `BufferPool`, the othe

[GitHub] flink pull request #4697: [FLINK-7650] [flip6] Port JobCancellationHandler t...

2017-09-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4697#discussion_r141298175 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/JobCancellationHandler.java --- @@ -70,4 +82,25 @@ public JobCancell

[GitHub] flink pull request #4697: [FLINK-7650] [flip6] Port JobCancellationHandler t...

2017-09-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4697#discussion_r141298335 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterGateway.java --- @@ -55,6 +55,14 @@ public interface JobMasterGa

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182298#comment-16182298 ] ASF GitHub Bot commented on FLINK-7406: --- Github user zhijiangW commented on the issu

[jira] [Commented] (FLINK-7650) Port JobCancellationHandler to new REST endpoint

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182300#comment-16182300 ] ASF GitHub Bot commented on FLINK-7650: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-7650) Port JobCancellationHandler to new REST endpoint

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182299#comment-16182299 ] ASF GitHub Bot commented on FLINK-7650: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #4697: [FLINK-7650] [flip6] Port JobCancellationHandler t...

2017-09-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4697#discussion_r141299250 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobPathParameter.java --- @@ -0,0 +1,45 @@ +/* + * Licensed to the

[GitHub] flink pull request #4697: [FLINK-7650] [flip6] Port JobCancellationHandler t...

2017-09-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4697#discussion_r141299315 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobCancellationHeaders.java --- @@ -0,0 +1,68 @@ +/* + * Licensed

[jira] [Commented] (FLINK-7650) Port JobCancellationHandler to new REST endpoint

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182306#comment-16182306 ] ASF GitHub Bot commented on FLINK-7650: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-7650) Port JobCancellationHandler to new REST endpoint

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182305#comment-16182305 ] ASF GitHub Bot commented on FLINK-7650: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #4697: [FLINK-7650] [flip6] Port JobCancellationHandler t...

2017-09-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4697#discussion_r141300119 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/messages/JobNotFoundException.java --- @@ -0,0 +1,34 @@ +/* + * Licensed to the

[GitHub] flink pull request #4697: [FLINK-7650] [flip6] Port JobCancellationHandler t...

2017-09-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4697#discussion_r141300155 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/messages/JobNotFoundException.java --- @@ -0,0 +1,34 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-7650) Port JobCancellationHandler to new REST endpoint

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182309#comment-16182309 ] ASF GitHub Bot commented on FLINK-7650: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-7650) Port JobCancellationHandler to new REST endpoint

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182310#comment-16182310 ] ASF GitHub Bot commented on FLINK-7650: --- Github user tillrohrmann commented on a dif

[jira] [Created] (FLINK-7699) Define the BufferListener interface to replace EventlListener in BufferProvider

2017-09-27 Thread zhijiang (JIRA)
zhijiang created FLINK-7699: --- Summary: Define the BufferListener interface to replace EventlListener in BufferProvider Key: FLINK-7699 URL: https://issues.apache.org/jira/browse/FLINK-7699 Project: Flink

[GitHub] flink pull request #4697: [FLINK-7650] [flip6] Port JobCancellationHandler t...

2017-09-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4697#discussion_r141303430 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobCancellationHeaders.java --- @@ -0,0 +1,68 @@ +/* + * Licensed

[jira] [Commented] (FLINK-7650) Port JobCancellationHandler to new REST endpoint

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182328#comment-16182328 ] ASF GitHub Bot commented on FLINK-7650: --- Github user tillrohrmann commented on a dif

[GitHub] flink issue #4697: [FLINK-7650] [flip6] Port JobCancellationHandler to new R...

2017-09-27 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4697 Thanks for the review @bowenli86 and @zentol. I've addressed your PR comments modulo the `DELETE` method. I somehow still think that `DELETE` is the right verb and we maybe should change how we

[jira] [Commented] (FLINK-7650) Port JobCancellationHandler to new REST endpoint

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182336#comment-16182336 ] ASF GitHub Bot commented on FLINK-7650: --- Github user tillrohrmann commented on the i

[GitHub] flink pull request #4700: [FLINK-7649] [flip6] Extend JobTerminationHandler ...

2017-09-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4700#discussion_r141304918 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobTerminationMessageParameters.java --- @@ -26,9 +26,10 @@ *

[jira] [Commented] (FLINK-7649) Port JobStoppingHandler to new REST endpoint

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182340#comment-16182340 ] ASF GitHub Bot commented on FLINK-7649: --- Github user tillrohrmann commented on a dif

[GitHub] flink issue #4700: [FLINK-7649] [flip6] Extend JobTerminationHandler to supp...

2017-09-27 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4700 Thanks for the review @zentol. You are right, that I should rather add a new JobTerminationHandler subsuming the functionality of the `JobCancellationHandler` and the `JobStoppingHandler`. Will

[jira] [Commented] (FLINK-7649) Port JobStoppingHandler to new REST endpoint

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182341#comment-16182341 ] ASF GitHub Bot commented on FLINK-7649: --- Github user tillrohrmann commented on the i

[GitHub] flink pull request #4730: [hotfix] [REST] Various rest-related hotfixes

2017-09-27 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/4730 [hotfix] [REST] Various rest-related hotfixes This PR is based on #4700. ## What is the purpose of the change This PR contains a number of smaller changes that i made while working o

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182370#comment-16182370 ] ASF GitHub Bot commented on FLINK-7072: --- GitHub user zentol opened a pull request:

[jira] [Created] (FLINK-7700) State merging in RocksDB backend leaves old state

2017-09-27 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-7700: --- Summary: State merging in RocksDB backend leaves old state Key: FLINK-7700 URL: https://issues.apache.org/jira/browse/FLINK-7700 Project: Flink Issue T

[jira] [Closed] (FLINK-2268) Provide Flink binary release without Hadoop

2017-09-27 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-2268. --- Resolution: Fixed Fix Version/s: 1.4.0 Implemented in 2b96c8d74b66228484e53a58907157086

[GitHub] flink pull request #4636: [FLINK-2268] Allow Flink binary release without Ha...

2017-09-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4636 ---

[jira] [Closed] (FLINK-4048) Remove Hadoop dependencies from ExecutionEnvironment

2017-09-27 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-4048. --- Resolution: Fixed Fix Version/s: (was: 2.0.0) 1.4.0 Implemented

[jira] [Commented] (FLINK-2268) Provide Flink binary release without Hadoop

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182383#comment-16182383 ] ASF GitHub Bot commented on FLINK-2268: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-5944) Flink should support reading Snappy Files

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182389#comment-16182389 ] ASF GitHub Bot commented on FLINK-5944: --- Github user aljoscha commented on a diff in

[GitHub] flink pull request #4683: [FLINK-5944] Support reading of Snappy files

2017-09-27 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4683#discussion_r141312154 --- Diff: flink-core/pom.xml --- @@ -52,6 +52,12 @@ under the License. flink-shaded-asm + +

[jira] [Commented] (FLINK-7700) State merging in RocksDB backend leaves old state

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182394#comment-16182394 ] ASF GitHub Bot commented on FLINK-7700: --- GitHub user aljoscha opened a pull request:

[GitHub] flink pull request #4731: [FLINK-7700] Fix RocksDB state merging

2017-09-27 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/4731 [FLINK-7700] Fix RocksDB state merging ## What is the purpose of the change See title ## Brief change log This fixes state merging in the respective classes and also conso

[GitHub] flink pull request #4732: [FLINK-7426] [table] Support null values in keys

2017-09-27 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/4732 [FLINK-7426] [table] Support null values in keys ## What is the purpose of the change This PR adds support for null values in keys by not relying on the default `KeySelector`.

[jira] [Commented] (FLINK-7426) Table API does not support null values in keys

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182395#comment-16182395 ] ASF GitHub Bot commented on FLINK-7426: --- GitHub user twalthr opened a pull request:

[jira] [Assigned] (FLINK-7371) user defined aggregator assumes nr of arguments smaller or equal than number of row fields

2017-09-27 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-7371: --- Assignee: Timo Walther > user defined aggregator assumes nr of arguments smaller or equal tha

[jira] [Commented] (FLINK-7649) Port JobStoppingHandler to new REST endpoint

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182396#comment-16182396 ] ASF GitHub Bot commented on FLINK-7649: --- Github user tillrohrmann commented on the i

[GitHub] flink pull request #4727: [FLINK-7667] [flip6] Use ArchivedExecutionGraph as...

2017-09-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4727#discussion_r141314449 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/tasks/JobCheckpointingConfiguration.java --- @@ -0,0 +1,128 @@ +/* + *

  1   2   3   4   5   >