[jira] [Commented] (FLINK-2013) Create generalized linear model framework

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189249#comment-16189249 ] ASF GitHub Bot commented on FLINK-2013: --- Github user mtunique commented on a diff in

[GitHub] flink pull request #3756: [FLINK-2013] Create generalized linear model frame...

2017-10-02 Thread mtunique
Github user mtunique commented on a diff in the pull request: https://github.com/apache/flink/pull/3756#discussion_r142308699 --- Diff: flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/regression/MultipleLinearRegressionITSuite.scala --- @@ -75,15 +75,16 @@ class Multip

[jira] [Commented] (FLINK-2013) Create generalized linear model framework

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189241#comment-16189241 ] ASF GitHub Bot commented on FLINK-2013: --- Github user bowenli86 commented on a diff i

[jira] [Commented] (FLINK-2013) Create generalized linear model framework

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189242#comment-16189242 ] ASF GitHub Bot commented on FLINK-2013: --- Github user bowenli86 commented on the issu

[GitHub] flink issue #3756: [FLINK-2013] Create generalized linear model framework

2017-10-02 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3756 +1, LGTM ---

[GitHub] flink pull request #3756: [FLINK-2013] Create generalized linear model frame...

2017-10-02 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3756#discussion_r142307430 --- Diff: flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/regression/MultipleLinearRegressionITSuite.scala --- @@ -75,15 +75,16 @@ class Multi

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189176#comment-16189176 ] ASF GitHub Bot commented on FLINK-7072: --- Github user bowenli86 commented on a diff i

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-02 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142228578 --- Diff: flink-clients/src/main/java/org/apache/flink/client/deployment/Flip6StandaloneClusterDescriptor.java --- @@ -0,0 +1,62 @@ +/* + * Licens

[jira] [Commented] (FLINK-7737) On HCFS systems, FSDataOutputStream does not issue hsync only hflush which leads to data loss

2017-10-02 Thread Vijay Srinivasaraghavan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189049#comment-16189049 ] Vijay Srinivasaraghavan commented on FLINK-7737: Some observation with res

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188861#comment-16188861 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188860#comment-16188860 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-02 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142258856 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -0,0 +1,206 @@ +/* + * Licensed to the Apach

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-02 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142258814 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -0,0 +1,206 @@ +/* + * Licensed to the Apach

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188850#comment-16188850 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-02 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142257641 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -0,0 +1,206 @@ +/* + * Licensed to the Apach

[jira] [Commented] (FLINK-7371) user defined aggregator assumes nr of arguments smaller or equal than number of row fields

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188843#comment-16188843 ] ASF GitHub Bot commented on FLINK-7371: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7371) user defined aggregator assumes nr of arguments smaller or equal than number of row fields

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188842#comment-16188842 ] ASF GitHub Bot commented on FLINK-7371: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7371) user defined aggregator assumes nr of arguments smaller or equal than number of row fields

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188844#comment-16188844 ] ASF GitHub Bot commented on FLINK-7371: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4736: [FLINK-7371] [table] Add support for constant para...

2017-10-02 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4736#discussion_r142254410 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/OverWindowITCase.scala --- @@ -85,6 +85,46 @@ class OverWin

[GitHub] flink pull request #4736: [FLINK-7371] [table] Add support for constant para...

2017-10-02 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4736#discussion_r142247401 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -1670,4 +1670,34 @@ abstract class CodeGenera

[GitHub] flink pull request #4736: [FLINK-7371] [table] Add support for constant para...

2017-10-02 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4736#discussion_r142256742 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/table/runtime/utils/JavaUserDefinedAggFunctions.java --- @@ -86,6 +86,13 @@ public Long

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-02 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142255730 --- Diff: flink-clients/src/main/java/org/apache/flink/client/deployment/Flip6StandaloneClusterDescriptor.java --- @@ -0,0 +1,62 @@ +/* + * Licensed

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188830#comment-16188830 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188804#comment-16188804 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-02 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142251500 --- Diff: flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java --- @@ -0,0 +1,191 @@ +/* + * Licensed to the A

[jira] [Commented] (FLINK-7695) Port JobConfigHandler to new REST endpoint

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188767#comment-16188767 ] ASF GitHub Bot commented on FLINK-7695: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-7668) Add AccessExecutionGraph refresh interval to ExecutionGraphHolder

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188768#comment-16188768 ] ASF GitHub Bot commented on FLINK-7668: --- Github user asfgit closed the pull request

[jira] [Closed] (FLINK-7668) Add AccessExecutionGraph refresh interval to ExecutionGraphHolder

2017-10-02 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-7668. Resolution: Fixed Fix Version/s: 1.4.0 Added via aae417f113d0f9db3ac3b4cbadd378134f30b440 >

[GitHub] flink pull request #4728: [FLINK-7668] Add ExecutionGraphCache for Execution...

2017-10-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4728 ---

[jira] [Commented] (FLINK-7710) Port CheckpointStatsHandler to new REST endpoint

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188766#comment-16188766 ] ASF GitHub Bot commented on FLINK-7710: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-7708) Port CheckpointConfigHandler to new REST endpoint

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188769#comment-16188769 ] ASF GitHub Bot commented on FLINK-7708: --- Github user asfgit closed the pull request

[GitHub] flink pull request #4744: [FLINK-7708] [flip6] Add CheckpointConfigHandler f...

2017-10-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4744 ---

[GitHub] flink pull request #4750: [FLINK-7710] [flip6] Add CheckpointStatisticsHandl...

2017-10-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4750 ---

[GitHub] flink pull request #4737: [FLINK-7695] [flip6] Add JobConfigHandler for new ...

2017-10-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4737 ---

[jira] [Closed] (FLINK-7695) Port JobConfigHandler to new REST endpoint

2017-10-02 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-7695. Resolution: Fixed Fix Version/s: 1.4.0 Added via 172a64c1488bd6edda97473562c6871ae7f3364d >

[jira] [Resolved] (FLINK-7710) Port CheckpointStatsHandler to new REST endpoint

2017-10-02 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-7710. -- Resolution: Fixed Added via ac82becd21b7766c18d16abfc7e08334c644507e > Port CheckpointStatsHand

[jira] [Resolved] (FLINK-7708) Port CheckpointConfigHandler to new REST endpoint

2017-10-02 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-7708. -- Resolution: Fixed Added via b41f5a66cd6d62bf3c271f1d0bf9d8fa50a5d410 > Port CheckpointConfigHan

[jira] [Commented] (FLINK-7678) SQL UserDefineTableFunction does not take CompositeType input correctly

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188727#comment-16188727 ] ASF GitHub Bot commented on FLINK-7678: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7678) SQL UserDefineTableFunction does not take CompositeType input correctly

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188729#comment-16188729 ] ASF GitHub Bot commented on FLINK-7678: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7678) SQL UserDefineTableFunction does not take CompositeType input correctly

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188728#comment-16188728 ] ASF GitHub Bot commented on FLINK-7678: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4726: [FLINK-7678] [table] Support composite inputs for ...

2017-10-02 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4726#discussion_r142237447 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/table/CorrelateITCase.scala --- @@ -22,7 +22,7 @@ import java.sql.

[GitHub] flink pull request #4726: [FLINK-7678] [table] Support composite inputs for ...

2017-10-02 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4726#discussion_r142238899 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/UserDefinedScalarFunctionTest.scala --- @@ -89,6 +90,14 @@ class Use

[GitHub] flink pull request #4726: [FLINK-7678] [table] Support composite inputs for ...

2017-10-02 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4726#discussion_r142238516 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/CorrelateITCase.scala --- @@ -210,6 +213,31 @@ class Correl

[jira] [Created] (FLINK-7755) Null values are not correctly handled by batch inner and outer joins

2017-10-02 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-7755: Summary: Null values are not correctly handled by batch inner and outer joins Key: FLINK-7755 URL: https://issues.apache.org/jira/browse/FLINK-7755 Project: Flink

[jira] [Created] (FLINK-7754) Complete termination future after actor has been stopped.

2017-10-02 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-7754: Summary: Complete termination future after actor has been stopped. Key: FLINK-7754 URL: https://issues.apache.org/jira/browse/FLINK-7754 Project: Flink Issue

[jira] [Created] (FLINK-7753) HandlerUtils should close the channel on error responses

2017-10-02 Thread Eron Wright (JIRA)
Eron Wright created FLINK-7753: --- Summary: HandlerUtils should close the channel on error responses Key: FLINK-7753 URL: https://issues.apache.org/jira/browse/FLINK-7753 Project: Flink Issue Ty

[jira] [Created] (FLINK-7752) RedirectHandler should execute on the IO thread

2017-10-02 Thread Eron Wright (JIRA)
Eron Wright created FLINK-7752: --- Summary: RedirectHandler should execute on the IO thread Key: FLINK-7752 URL: https://issues.apache.org/jira/browse/FLINK-7752 Project: Flink Issue Type: Sub-t

[jira] [Commented] (FLINK-7709) Port CheckpointStatsDetailsHandler to new REST endpoint

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188511#comment-16188511 ] ASF GitHub Bot commented on FLINK-7709: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #4763: [FLINK-7709] Add CheckpointStatisticDetailsHandler...

2017-10-02 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/4763 [FLINK-7709] Add CheckpointStatisticDetailsHandler for new REST endpoint ## What is the purpose of the change Adds the new `CheckpointStatisticDetailsHandler` for the new REST server e

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188491#comment-16188491 ] ASF GitHub Bot commented on FLINK-7072: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-02 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142207196 --- Diff: flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java --- @@ -0,0 +1,191 @@ +/* + * Licensed to

[GitHub] flink pull request #4732: [FLINK-7426] [table] Support null values in keys

2017-10-02 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4732#discussion_r142165496 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/CRowKeySelector.scala --- @@ -0,0 +1,51 @@ +/* + * Licensed to t

[jira] [Commented] (FLINK-7426) Table API does not support null values in keys

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188421#comment-16188421 ] ASF GitHub Bot commented on FLINK-7426: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7426) Table API does not support null values in keys

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188419#comment-16188419 ] ASF GitHub Bot commented on FLINK-7426: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7426) Table API does not support null values in keys

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188420#comment-16188420 ] ASF GitHub Bot commented on FLINK-7426: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4732: [FLINK-7426] [table] Support null values in keys

2017-10-02 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4732#discussion_r142164921 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/CRowKeySelector.scala --- @@ -0,0 +1,51 @@ +/* + * Licensed to t

[GitHub] flink pull request #4732: [FLINK-7426] [table] Support null values in keys

2017-10-02 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4732#discussion_r142167389 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/CRowKeySelector.scala --- @@ -0,0 +1,51 @@ +/* + * Licensed to t

[jira] [Commented] (FLINK-7749) remove the ResultPartitionWriter

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188308#comment-16188308 ] ASF GitHub Bot commented on FLINK-7749: --- GitHub user NicoK opened a pull request:

[GitHub] flink pull request #4762: [FLINK-7749][network] remove the ResultPartitionWr...

2017-10-02 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4762 [FLINK-7749][network] remove the ResultPartitionWriter wrapper ## What is the purpose of the change After changing task event notification to the `TaskEventDispatcher` (#4759) and buffer writ

[jira] [Commented] (FLINK-7748) remove event listener behaviour from ResultPartitionWriter

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188297#comment-16188297 ] ASF GitHub Bot commented on FLINK-7748: --- GitHub user NicoK opened a pull request:

[GitHub] flink pull request #4761: [FLINK-7748][network] properly use the TaskEventDi...

2017-10-02 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4761 [FLINK-7748][network] properly use the TaskEventDispatcher for subscribing to events ## What is the purpose of the change `ResultPartitionWriter` currently implements the `EventListener` inte

[jira] [Commented] (FLINK-7051) Bump up Calcite version to 1.14

2017-10-02 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188254#comment-16188254 ] Fabian Hueske commented on FLINK-7051: -- The vote for Calcite 1.14 has passed and it w

[jira] [Closed] (FLINK-7728) StatusWatermarkValve has different min watermark advancement behavior depending on the ordering inputs become idle

2017-10-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-7728. --- Resolution: Fixed Fix Version/s: (was: 1.2.2) Fixed on release-1.3 in 4dcd9fba21eef

[GitHub] flink issue #4747: [FLINK-7728] [DataStream] Flush StatusWatermarkValve once...

2017-10-02 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4747 Merged. 👌 Could you please also close this PR? ---

[jira] [Commented] (FLINK-7728) StatusWatermarkValve has different min watermark advancement behavior depending on the ordering inputs become idle

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188232#comment-16188232 ] ASF GitHub Bot commented on FLINK-7728: --- Github user aljoscha commented on the issue

[jira] [Commented] (FLINK-7452) Add helper methods for all built-in Flink types to Types

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188220#comment-16188220 ] ASF GitHub Bot commented on FLINK-7452: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4612: [FLINK-7452] [types] Add helper methods for all bu...

2017-10-02 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4612#discussion_r142158422 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeinfo/Types.java --- @@ -19,56 +19,417 @@ package org.apache.flink.api.common.typeinfo

[jira] [Commented] (FLINK-7452) Add helper methods for all built-in Flink types to Types

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188221#comment-16188221 ] ASF GitHub Bot commented on FLINK-7452: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4612: [FLINK-7452] [types] Add helper methods for all bu...

2017-10-02 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4612#discussion_r142159219 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeinfo/Types.java --- @@ -19,56 +19,417 @@ package org.apache.flink.api.common.typeinfo

[jira] [Commented] (FLINK-7728) StatusWatermarkValve has different min watermark advancement behavior depending on the ordering inputs become idle

2017-10-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188218#comment-16188218 ] Aljoscha Krettek commented on FLINK-7728: - Fixed on master in 6481564cb581164a761

[jira] [Closed] (FLINK-7721) StatusWatermarkValve should output a new min watermark only if it was aggregated from aligned chhanels

2017-10-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-7721. --- Resolution: Fixed Fixed on master in c81a7e519bf3db2f9c5e62fadd7a3a4fb7692904 > StatusWaterma

[jira] [Reopened] (FLINK-7721) StatusWatermarkValve should output a new min watermark only if it was aggregated from aligned chhanels

2017-10-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reopened FLINK-7721: - Reopen to fix git commit hash > StatusWatermarkValve should output a new min watermark only i

[GitHub] flink pull request #4612: [FLINK-7452] [types] Add helper methods for all bu...

2017-10-02 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4612#discussion_r142157854 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/Types.scala --- @@ -20,60 +20,123 @@ package org.apache.flink.table.api

[jira] [Commented] (FLINK-7452) Add helper methods for all built-in Flink types to Types

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188202#comment-16188202 ] ASF GitHub Bot commented on FLINK-7452: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7452) Add helper methods for all built-in Flink types to Types

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188200#comment-16188200 ] ASF GitHub Bot commented on FLINK-7452: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4612: [FLINK-7452] [types] Add helper methods for all bu...

2017-10-02 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4612#discussion_r142157686 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeinfo/Types.java --- @@ -19,56 +19,408 @@ package org.apache.flink.api.common.typeinfo

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188191#comment-16188191 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-02 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142157044 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/JobSubmitHandlerTest.java --- @@ -0,0 +1,90 @@ +/* + * Licensed to th

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188189#comment-16188189 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188190#comment-16188190 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188188#comment-16188188 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-02 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142156728 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/BlobServerPortHandlerTest.java --- @@ -0,0 +1,65 @@ +/* + * Licensed

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-02 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142156635 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobSubmitRequestBody.java --- @@ -0,0 +1,80 @@ +/* + * Licensed to t

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-02 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142156568 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobTerminationMessageParameters.java --- @@ -28,8 +28,8 @@ */ public

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188182#comment-16188182 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-02 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142155888 --- Diff: flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java --- @@ -0,0 +1,191 @@ +/* + * Licensed to the A

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188181#comment-16188181 ] ASF GitHub Bot commented on FLINK-7406: --- Github user zhijiangW commented on the issu

[GitHub] flink issue #4509: [FLINK-7406][network] Implement Netty receiver incoming p...

2017-10-02 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4509 @NicoK , I have fixed the other code issues. For UT, I only added one test for verifying there is no race condition between requesting and recycling floating buffers. I am not sure whethe

[jira] [Assigned] (FLINK-7709) Port CheckpointStatsDetailsHandler to new REST endpoint

2017-10-02 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-7709: Assignee: Till Rohrmann > Port CheckpointStatsDetailsHandler to new REST endpoint > ---

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188047#comment-16188047 ] ASF GitHub Bot commented on FLINK-7406: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-10-02 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r142142736 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java --- @@ -235,14 +240,15 @@ void releaseBuffer() {

[jira] [Commented] (FLINK-7068) change BlobService sub-classes for permanent and transient BLOBs

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188030#comment-16188030 ] ASF GitHub Bot commented on FLINK-7068: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-7068) change BlobService sub-classes for permanent and transient BLOBs

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188031#comment-16188031 ] ASF GitHub Bot commented on FLINK-7068: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-7068) change BlobService sub-classes for permanent and transient BLOBs

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188032#comment-16188032 ] ASF GitHub Bot commented on FLINK-7068: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-7068) change BlobService sub-classes for permanent and transient BLOBs

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188039#comment-16188039 ] ASF GitHub Bot commented on FLINK-7068: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-7068) change BlobService sub-classes for permanent and transient BLOBs

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188036#comment-16188036 ] ASF GitHub Bot commented on FLINK-7068: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-7068) change BlobService sub-classes for permanent and transient BLOBs

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188026#comment-16188026 ] ASF GitHub Bot commented on FLINK-7068: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-7068) change BlobService sub-classes for permanent and transient BLOBs

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188029#comment-16188029 ] ASF GitHub Bot commented on FLINK-7068: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-7068) change BlobService sub-classes for permanent and transient BLOBs

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188024#comment-16188024 ] ASF GitHub Bot commented on FLINK-7068: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-7068) change BlobService sub-classes for permanent and transient BLOBs

2017-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188025#comment-16188025 ] ASF GitHub Bot commented on FLINK-7068: --- Github user tillrohrmann commented on a dif

  1   2   3   >