[jira] [Commented] (FLINK-1743) Add multinomial logistic regression to machine learning library

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189438#comment-16189438 ] ASF GitHub Bot commented on FLINK-1743: --- Github user thvasilo commented on the issue

[GitHub] flink issue #3428: [FLINK-1743] Add multinomial logistic regression to machi...

2017-10-03 Thread thvasilo
Github user thvasilo commented on the issue: https://github.com/apache/flink/pull/3428 Hello @bowenli86, AFAIK nobody's working on the PR's right now. I'm currently 100% focused on finishing my PhD so I won't have time to review. ---

[jira] [Created] (FLINK-7756) RocksDB state backend Checkpointing (Async and Incremental) is not working with CEP.

2017-10-03 Thread Shashank Agarwal (JIRA)
Shashank Agarwal created FLINK-7756: --- Summary: RocksDB state backend Checkpointing (Async and Incremental) is not working with CEP. Key: FLINK-7756 URL: https://issues.apache.org/jira/browse/FLINK-7756

[jira] [Created] (FLINK-7757) RocksDB lock is too strict and can block snapshots in synchronous phase

2017-10-03 Thread Stefan Richter (JIRA)
Stefan Richter created FLINK-7757: - Summary: RocksDB lock is too strict and can block snapshots in synchronous phase Key: FLINK-7757 URL: https://issues.apache.org/jira/browse/FLINK-7757 Project: Flin

[jira] [Commented] (FLINK-7756) RocksDB state backend Checkpointing (Async and Incremental) is not working with CEP.

2017-10-03 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189751#comment-16189751 ] Stephan Ewen commented on FLINK-7756: - Thanks for reporting this. Is this reproducibl

[GitHub] flink issue #4755: [hotfix] [docs] Fix broken links

2017-10-03 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4755 +1 for master and 1.3 ---

[jira] [Commented] (FLINK-7631) Ineffective check in PageRank#open()

2017-10-03 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189835#comment-16189835 ] Greg Hogan commented on FLINK-7631: --- When `vertexCount` is zero the map function will no

[jira] [Commented] (FLINK-7687) Clarify the master and slaves files are not necessary unless using the cluster start/stop scripts

2017-10-03 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189845#comment-16189845 ] Greg Hogan commented on FLINK-7687: --- [~elevy] is there a specific page or pages where th

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-03 Thread StefanRRichter
GitHub user StefanRRichter opened a pull request: https://github.com/apache/flink/pull/4764 [FLINK-7757] [checkpointing] Introduce resource guard for RocksDBKeye… …dStateBackend to reduce locking and avoid blocking behavior. ## What is the purpose of the change

[jira] [Commented] (FLINK-7757) RocksDB lock is too strict and can block snapshots in synchronous phase

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189864#comment-16189864 ] ASF GitHub Bot commented on FLINK-7757: --- GitHub user StefanRRichter opened a pull re

[GitHub] flink issue #4764: [FLINK-7757] [checkpointing] Introduce resource guard for...

2017-10-03 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4764 CC @aljoscha ---

[jira] [Commented] (FLINK-7757) RocksDB lock is too strict and can block snapshots in synchronous phase

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189867#comment-16189867 ] ASF GitHub Bot commented on FLINK-7757: --- Github user StefanRRichter commented on the

[GitHub] flink issue #4748: [hotfix][tests] Use G1GC for tests

2017-10-03 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4748 For speed or consistency? ---

[jira] [Commented] (FLINK-7756) RocksDB state backend Checkpointing (Async and Incremental) is not working with CEP.

2017-10-03 Thread Shashank Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189913#comment-16189913 ] Shashank Agarwal commented on FLINK-7756: - [~StephanEwen] Actually my code base i

[jira] [Commented] (FLINK-7735) Improve date/time handling in publically-facing Expressions

2017-10-03 Thread Kent Murra (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189918#comment-16189918 ] Kent Murra commented on FLINK-7735: --- IMO using Java 8 time after Java 7 is officially dr

[jira] [Resolved] (FLINK-7631) Ineffective check in PageRank#open()

2017-10-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved FLINK-7631. --- Resolution: Not A Problem > Ineffective check in PageRank#open() > > >

[jira] [Commented] (FLINK-5030) Support hostname verification

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189972#comment-16189972 ] ASF GitHub Bot commented on FLINK-5030: --- Github user EronWright commented on the iss

[GitHub] flink issue #3061: [FLINK-5030] Support hostname verification

2017-10-03 Thread EronWright
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/3061 @VanessaHenderson nothing at this time.If you're not able to use hostname verification as-is (given the non-canonical names that are used), consider carefully controlling the truststore that i

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-03 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r142490404 --- Diff: flink-core/src/main/java/org/apache/flink/util/ResourceGuard.java --- @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[jira] [Commented] (FLINK-7757) RocksDB lock is too strict and can block snapshots in synchronous phase

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190149#comment-16190149 ] ASF GitHub Bot commented on FLINK-7757: --- Github user GJL commented on a diff in the

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-03 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r142492040 --- Diff: flink-core/src/main/java/org/apache/flink/util/ResourceGuard.java --- @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Commented] (FLINK-7757) RocksDB lock is too strict and can block snapshots in synchronous phase

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190155#comment-16190155 ] ASF GitHub Bot commented on FLINK-7757: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-03 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r142493960 --- Diff: flink-core/src/main/java/org/apache/flink/util/ResourceGuard.java --- @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Commented] (FLINK-7757) RocksDB lock is too strict and can block snapshots in synchronous phase

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190167#comment-16190167 ] ASF GitHub Bot commented on FLINK-7757: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-03 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142500763 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobSubmitRequestBody.java --- @@ -0,0 +1,80 @@ +/* + * Licensed to t

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190200#comment-16190200 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-03 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142501847 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobSubmitHandler.java --- @@ -0,0 +1,66 @@ +/* + * Licensed to the Ap

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190210#comment-16190210 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-03 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142501950 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobSubmitHandler.java --- @@ -0,0 +1,66 @@ +/* + * Licensed to the Ap

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190211#comment-16190211 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-03 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142502599 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobSubmitHandler.java --- @@ -0,0 +1,66 @@ +/* + * Licensed to the Ap

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190212#comment-16190212 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190233#comment-16190233 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-03 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142504388 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/BlobServerPortHandler.java --- @@ -0,0 +1,63 @@ +/* + * Licensed to t

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-03 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142506368 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -0,0 +1,206 @@ +/* + * Licensed to the Apach

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190241#comment-16190241 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-03 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142507072 --- Diff: flink-clients/src/main/java/org/apache/flink/client/deployment/Flip6StandaloneClusterDescriptor.java --- @@ -0,0 +1,62 @@ +/* + * Licensed

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190248#comment-16190248 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-03 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142507812 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -554,6 +557,18 @@ protected int stop(String[] args) {

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190254#comment-16190254 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-03 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142508400 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -0,0 +1,206 @@ +/* + * Licensed to the Apach

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190259#comment-16190259 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190287#comment-16190287 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-03 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142512180 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -0,0 +1,206 @@ +/* + * Licensed to the Apach

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190294#comment-16190294 ] ASF GitHub Bot commented on FLINK-7072: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4742: [FLINK-7072] [REST] Add Flip-6 client for submit/j...

2017-10-03 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142513408 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -0,0 +1,206 @@ +/* + * Licensed to the Apach

[jira] [Commented] (FLINK-7735) Improve date/time handling in publically-facing Expressions

2017-10-03 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190323#comment-16190323 ] Chesnay Schepler commented on FLINK-7735: - Java 7 support was officially dropped f

[jira] [Resolved] (FLINK-7223) Increase DEFAULT_SHARD_DISCOVERY_INTERVAL_MILLIS for Flink-kinesis-connector

2017-10-03 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li resolved FLINK-7223. - Resolution: Won't Fix > Increase DEFAULT_SHARD_DISCOVERY_INTERVAL_MILLIS for Flink-kinesis-connector > ---

[jira] [Resolved] (FLINK-6957) WordCountTable example cannot be run

2017-10-03 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li resolved FLINK-6957. - Resolution: Cannot Reproduce > WordCountTable example cannot be run >

[jira] [Commented] (FLINK-7388) ProcessFunction.onTimer() sets processing time as timestamp

2017-10-03 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190514#comment-16190514 ] Bowen Li commented on FLINK-7388: - Hi [~fhueske] , Do you mean that: in {{KeyedProcessOpe

[GitHub] flink pull request #4765: [FLINK-7753] [flip-6] close REST channel on server...

2017-10-03 Thread EronWright
GitHub user EronWright opened a pull request: https://github.com/apache/flink/pull/4765 [FLINK-7753] [flip-6] close REST channel on server error ## What is the purpose of the change Improve REST server handling of unexpected errors. ## Brief change log - Cl

[jira] [Commented] (FLINK-7753) HandlerUtils should close the channel on error responses

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190591#comment-16190591 ] ASF GitHub Bot commented on FLINK-7753: --- GitHub user EronWright opened a pull reques

[jira] [Commented] (FLINK-7388) ProcessFunction.onTimer() sets processing time as timestamp

2017-10-03 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190718#comment-16190718 ] Xingcan Cui commented on FLINK-7388: Hi [~phoenixjiangnan], I think this ticket is for

[GitHub] flink pull request #4766: [FLINK-7752] [flip-6] RedirectHandler should execu...

2017-10-03 Thread EronWright
GitHub user EronWright opened a pull request: https://github.com/apache/flink/pull/4766 [FLINK-7752] [flip-6] RedirectHandler should execute on the IO thread ## What is the purpose of the change Improves the determinism of REST handlers by running the response method (`respondAs

[jira] [Commented] (FLINK-7752) RedirectHandler should execute on the IO thread

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190756#comment-16190756 ] ASF GitHub Bot commented on FLINK-7752: --- GitHub user EronWright opened a pull reques

[jira] [Commented] (FLINK-3089) State API Should Support Data Expiration (State TTL)

2017-10-03 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190781#comment-16190781 ] Bowen Li commented on FLINK-3089: - [~srichter] Do you mean that TTL doesn't guarantee a re

[jira] [Comment Edited] (FLINK-3089) State API Should Support Data Expiration (State TTL)

2017-10-03 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190781#comment-16190781 ] Bowen Li edited comment on FLINK-3089 at 10/4/17 4:18 AM: -- [~sric

[jira] [Commented] (FLINK-7738) Create WebSocket handler (server)

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190784#comment-16190784 ] ASF GitHub Bot commented on FLINK-7738: --- GitHub user EronWright opened a pull reques

[GitHub] flink pull request #4767: [FLINK-7738] [flip-6] Create WebSocket handler (se...

2017-10-03 Thread EronWright
GitHub user EronWright opened a pull request: https://github.com/apache/flink/pull/4767 [FLINK-7738] [flip-6] Create WebSocket handler (server, client) ## What is the purpose of the change Introduces WebSocket support for the FLIP-6 REST server and client. The

[jira] [Commented] (FLINK-7757) RocksDB lock is too strict and can block snapshots in synchronous phase

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190804#comment-16190804 ] ASF GitHub Bot commented on FLINK-7757: --- Github user bowenli86 commented on a diff i

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-03 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r142579521 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -356,28 +35

[GitHub] flink issue #4764: [FLINK-7757] [checkpointing] Introduce resource guard for...

2017-10-03 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4764 The implementation of having s2 `acquire()` a lock while s1 still holds that lock seems problematic to me. Why not making it a `tryAcquire()`, as that in java semaphore? ---

[jira] [Commented] (FLINK-7757) RocksDB lock is too strict and can block snapshots in synchronous phase

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190813#comment-16190813 ] ASF GitHub Bot commented on FLINK-7757: --- Github user bowenli86 commented on the issu

[GitHub] flink issue #4764: [FLINK-7757] [checkpointing] Introduce resource guard for...

2017-10-03 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4764 @bowenli86 Can you go into detail what kind of problem you have in mind? This class does not work like a semaphore, i.e. `acquire` never truly blocks. It is just incrementing a count and does

[jira] [Commented] (FLINK-7757) RocksDB lock is too strict and can block snapshots in synchronous phase

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190837#comment-16190837 ] ASF GitHub Bot commented on FLINK-7757: --- Github user StefanRRichter commented on the

[GitHub] flink pull request #4768: [Flink-7704][flip6] Add JobPlanHandler for new Res...

2017-10-03 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4768 [Flink-7704][flip6] Add JobPlanHandler for new RestServerEndpoint ## What is the purpose of the change Add `JobPlanHandler` for the new `RestServerEndpoint`. ## Verifying this change

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-03 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r142588647 --- Diff: flink-core/src/main/java/org/apache/flink/util/ResourceGuard.java --- @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundatio

[jira] [Commented] (FLINK-7757) RocksDB lock is too strict and can block snapshots in synchronous phase

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190872#comment-16190872 ] ASF GitHub Bot commented on FLINK-7757: --- Github user bowenli86 commented on a diff i

[GitHub] flink issue #4764: [FLINK-7757] [checkpointing] Introduce resource guard for...

2017-10-03 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4764 I was commenting on the scenario described in `What is the purpose of the change`. In that case, we want to either fail s2 or remove the lock for s2 as you did. Since we are required to support par

[jira] [Commented] (FLINK-7757) RocksDB lock is too strict and can block snapshots in synchronous phase

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190874#comment-16190874 ] ASF GitHub Bot commented on FLINK-7757: --- Github user bowenli86 commented on the issu

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-03 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r142592523 --- Diff: flink-core/src/main/java/org/apache/flink/util/ResourceGuard.java --- @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Commented] (FLINK-7757) RocksDB lock is too strict and can block snapshots in synchronous phase

2017-10-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190885#comment-16190885 ] ASF GitHub Bot commented on FLINK-7757: --- Github user StefanRRichter commented on a d