[jira] [Commented] (FLINK-7368) MetricStore makes cpu spin at 100%

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210661#comment-16210661 ] ASF GitHub Bot commented on FLINK-7368: --- Github user pnowojski commented on a diff i

[GitHub] flink pull request #4840: [FLINK-7368][metrics] Make MetricStore ThreadSafe ...

2017-10-18 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4840#discussion_r145611565 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java --- @@ -38,29 +43,136 @@ import static o

[jira] [Commented] (FLINK-7368) MetricStore makes cpu spin at 100%

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210644#comment-16210644 ] ASF GitHub Bot commented on FLINK-7368: --- Github user pnowojski commented on the issu

[jira] [Commented] (FLINK-7368) MetricStore makes cpu spin at 100%

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210645#comment-16210645 ] ASF GitHub Bot commented on FLINK-7368: --- Github user pnowojski closed the pull reque

[GitHub] flink pull request #4841: [FLINK-7368][metrics] Backport synchronization fix...

2017-10-18 Thread pnowojski
Github user pnowojski closed the pull request at: https://github.com/apache/flink/pull/4841 ---

[GitHub] flink issue #4841: [FLINK-7368][metrics] Backport synchronization fix for Me...

2017-10-18 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4841 Yes sure, thanks for merging ---

[jira] [Commented] (FLINK-7866) Weigh list of preferred locations for scheduling

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210619#comment-16210619 ] ASF GitHub Bot commented on FLINK-7866: --- Github user summerleafs commented on the is

[GitHub] flink issue #4369: [Flink-7218] [JobManager] ExecutionVertex.getPreferredLoc...

2017-10-18 Thread summerleafs
Github user summerleafs commented on the issue: https://github.com/apache/flink/pull/4369 duplicate with FLINK-7866. ---

[GitHub] flink pull request #4369: [Flink-7218] [JobManager] ExecutionVertex.getPrefe...

2017-10-18 Thread summerleafs
Github user summerleafs closed the pull request at: https://github.com/apache/flink/pull/4369 ---

[jira] [Commented] (FLINK-7866) Weigh list of preferred locations for scheduling

2017-10-18 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210618#comment-16210618 ] Sihua Zhou commented on FLINK-7866: --- [~till.rohrmann] have you already work on this? If

[jira] [Created] (FLINK-7871) SlotPool should release its unused slot to RM

2017-10-18 Thread shuai.xu (JIRA)
shuai.xu created FLINK-7871: --- Summary: SlotPool should release its unused slot to RM Key: FLINK-7871 URL: https://issues.apache.org/jira/browse/FLINK-7871 Project: Flink Issue Type: Bug

[jira] [Closed] (FLINK-7218) ExecutionVertex.getPreferredLocationsBasedOnInputs() will always return empty

2017-10-18 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sihua Zhou closed FLINK-7218. - Resolution: Duplicate Release Note: Can be resolved in FLINK-7866, closing the PR for this too. > Ex

[jira] [Comment Edited] (FLINK-5372) Fix RocksDBAsyncSnapshotTest.testCancelFullyAsyncCheckpoints()

2017-10-18 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210596#comment-16210596 ] Stefan Richter edited comment on FLINK-5372 at 10/19/17 5:41 AM: ---

[jira] [Commented] (FLINK-5372) Fix RocksDBAsyncSnapshotTest.testCancelFullyAsyncCheckpoints()

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210610#comment-16210610 ] ASF GitHub Bot commented on FLINK-5372: --- Github user StefanRRichter commented on the

[GitHub] flink issue #4855: [FLINK-5372] [tests] Fix RocksDBAsyncSnapshotTest.testCan...

2017-10-18 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4855 CC @aljoscha -- this fixes a release blocker. ---

[jira] [Commented] (FLINK-5372) Fix RocksDBAsyncSnapshotTest.testCancelFullyAsyncCheckpoints()

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210607#comment-16210607 ] ASF GitHub Bot commented on FLINK-5372: --- GitHub user StefanRRichter opened a pull re

[GitHub] flink pull request #4855: [FLINK-5372] [tests] Fix RocksDBAsyncSnapshotTest....

2017-10-18 Thread StefanRRichter
GitHub user StefanRRichter opened a pull request: https://github.com/apache/flink/pull/4855 [FLINK-5372] [tests] Fix RocksDBAsyncSnapshotTest.testCancelFullyAsyn… …cCheckpoints() ## What is the purpose of the change This PR fixes `RocksDBAsyncSnapshotTest.testCa

[jira] [Comment Edited] (FLINK-5372) Fix RocksDBAsyncSnapshotTest.testCancelFullyAsyncCheckpoints()

2017-10-18 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210596#comment-16210596 ] Stefan Richter edited comment on FLINK-5372 at 10/19/17 5:23 AM: ---

[jira] [Commented] (FLINK-5372) Fix RocksDBAsyncSnapshotTest.testCancelFullyAsyncCheckpoints()

2017-10-18 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210596#comment-16210596 ] Stefan Richter commented on FLINK-5372: --- Those are two separate problems and I don't

[jira] [Created] (FLINK-7870) SlotPool should cancel the slot request to RM if not need any more.

2017-10-18 Thread shuai.xu (JIRA)
shuai.xu created FLINK-7870: --- Summary: SlotPool should cancel the slot request to RM if not need any more. Key: FLINK-7870 URL: https://issues.apache.org/jira/browse/FLINK-7870 Project: Flink Issu

[jira] [Commented] (FLINK-7627) SingleElementIterable should implement with Serializable

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210588#comment-16210588 ] ASF GitHub Bot commented on FLINK-7627: --- Github user hequn8128 commented on the issu

[GitHub] flink issue #4674: [FLINK-7627] [table] SingleElementIterable should impleme...

2017-10-18 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/4674 hi, @fhueske I was using sliding window and `NotSerializableException` was thrown when doing incremental snapshot. This can be fixed by implementing `SingleElementIterable` with `Serializable

[jira] [Created] (FLINK-7869) Don't use PipelineErrorHandler on the client

2017-10-18 Thread Eron Wright (JIRA)
Eron Wright created FLINK-7869: --- Summary: Don't use PipelineErrorHandler on the client Key: FLINK-7869 URL: https://issues.apache.org/jira/browse/FLINK-7869 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-5486) Lack of synchronization in BucketingSink#handleRestoredBucketState()

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210488#comment-16210488 ] ASF GitHub Bot commented on FLINK-5486: --- Github user zhangminglei commented on the i

[GitHub] flink issue #4356: [FLINK-5486] Fix lacking of synchronization in BucketingS...

2017-10-18 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4356 @tedyu I am retesting now..let us wait what will happen. ---

[jira] [Commented] (FLINK-6444) Add a check that '@VisibleForTesting' methods are only used in tests

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210479#comment-16210479 ] ASF GitHub Bot commented on FLINK-6444: --- Github user zhangminglei commented on the i

[GitHub] flink issue #4705: [FLINK-6444] [build] Add a check that '@VisibleForTesting...

2017-10-18 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4705 @pnowojski I tried. But It seems that I can not implement that functionality. I think it is very strange to find it's source code comes from. @StephanEwen Could you give me some idea on this ?

[jira] [Commented] (FLINK-7608) LatencyGauge change to histogram metric

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210244#comment-16210244 ] ASF GitHub Bot commented on FLINK-7608: --- Github user zentol commented on the issue:

[GitHub] flink issue #4826: [FLINK-7608][metric] Refactoring latency statistics metri...

2017-10-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4826 Looks very good now. Will have to try it out, but i can't spot anything atm 👍 ---

[jira] [Commented] (FLINK-7758) Fix bug Kafka09Fetcher add offset metrics

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210241#comment-16210241 ] ASF GitHub Bot commented on FLINK-7758: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4769: [FLINK-7758][kafka][hotfix] Fix bug Kafka09Fetcher...

2017-10-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4769#discussion_r145565821 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java --- @@ -543,6

[jira] [Commented] (FLINK-7368) MetricStore makes cpu spin at 100%

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210237#comment-16210237 ] ASF GitHub Bot commented on FLINK-7368: --- Github user zentol commented on the issue:

[GitHub] flink issue #4841: [FLINK-7368][metrics] Backport synchronization fix for Me...

2017-10-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4841 @pnowojski I've merged the PR, could you close it? ---

[jira] [Commented] (FLINK-7368) MetricStore makes cpu spin at 100%

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210236#comment-16210236 ] ASF GitHub Bot commented on FLINK-7368: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4840: [FLINK-7368][metrics] Make MetricStore ThreadSafe ...

2017-10-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4840#discussion_r145565409 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java --- @@ -38,29 +43,136 @@ import static org.

[GitHub] flink issue #4854: [docs] Fix typo in monitoring REST API documentation

2017-10-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4854 +1 ---

[jira] [Comment Edited] (FLINK-7844) Fine Grained Recovery triggers checkpoint timeout failure

2017-10-18 Thread Zhenzhong Xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210134#comment-16210134 ] Zhenzhong Xu edited comment on FLINK-7844 at 10/18/17 10:14 PM:

[jira] [Commented] (FLINK-7844) Fine Grained Recovery triggers checkpoint timeout failure

2017-10-18 Thread Zhenzhong Xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210134#comment-16210134 ] Zhenzhong Xu commented on FLINK-7844: - [~till.rohrmann] Another question regarding che

[jira] [Commented] (FLINK-7021) Flink Task Manager hangs on startup if one Zookeeper node is unresolvable

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210098#comment-16210098 ] ASF GitHub Bot commented on FLINK-7021: --- Github user skidder commented on the issue:

[GitHub] flink issue #4214: [FLINK-7021] Flink Task Manager hangs on startup if one Z...

2017-10-18 Thread skidder
Github user skidder commented on the issue: https://github.com/apache/flink/pull/4214 Sorry for not responding sooner! Thank you @StephanEwen and @tillrohrmann for applying this fix! ---

[jira] [Commented] (FLINK-4808) Allow skipping failed checkpoints

2017-10-18 Thread Jing Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210019#comment-16210019 ] Jing Fan commented on FLINK-4808: - Any update about this PR and ticket? I think this is an

[jira] [Created] (FLINK-7868) Don't run checkstyle again for tests in Misc profile

2017-10-18 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-7868: --- Summary: Don't run checkstyle again for tests in Misc profile Key: FLINK-7868 URL: https://issues.apache.org/jira/browse/FLINK-7868 Project: Flink Issu

[jira] [Updated] (FLINK-6697) Add batch multi-window support

2017-10-18 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-6697: - Priority: Critical (was: Blocker) > Add batch multi-window support >

[jira] [Closed] (FLINK-7853) Reject table function outer joins with predicates in Table API

2017-10-18 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-7853. Resolution: Fixed Fix Version/s: 1.3.3 Fixed for 1.3.3 with c112e236303821b6be38ba3efa019503d

[GitHub] flink pull request #4854: [docs] Fix typo in monitoring REST API documentati...

2017-10-18 Thread mkobit
GitHub user mkobit opened a pull request: https://github.com/apache/flink/pull/4854 [docs] Fix typo in monitoring REST API documentation ## Contribution Checklist ## What is the purpose of the change Doc typo fix. ## Documentation - Does this pul

[jira] [Updated] (FLINK-5789) Make Bucketing Sink independent of Hadoop's FileSystem

2017-10-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-5789: - Priority: Major (was: Blocker) > Make Bucketing Sink independent of Hadoop's FileSystem > ---

[jira] [Commented] (FLINK-6444) Add a check that '@VisibleForTesting' methods are only used in tests

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209563#comment-16209563 ] ASF GitHub Bot commented on FLINK-6444: --- Github user zhangminglei commented on the i

[GitHub] flink issue #4705: [FLINK-6444] [build] Add a check that '@VisibleForTesting...

2017-10-18 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4705 I have got an idea for how to get it's source code whether comes from src/test. Since I can get it's class name. Then I use this name to search in flink project. and judge where it comes from an

[jira] [Commented] (FLINK-7623) Detecting whether an operator is restored doesn't work with chained state

2017-10-18 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209552#comment-16209552 ] Piotr Nowojski commented on FLINK-7623: --- It seems like indeed this bug was fixed in

[GitHub] flink pull request #4853: [FLINK-7867] Start MetricQueryService in TaskManag...

2017-10-18 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/4853 [FLINK-7867] Start MetricQueryService in TaskManagerRunner ## What is the purpose of the change Start the `MetricQueryService` in the `TaskManagerRunner`. This PR is based on #

[jira] [Commented] (FLINK-7867) Start MetricQueryService on TaskManagerRunner

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209551#comment-16209551 ] ASF GitHub Bot commented on FLINK-7867: --- GitHub user tillrohrmann opened a pull requ

[jira] [Commented] (FLINK-7863) Make MetricFetcher work with RestfulGateway

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209544#comment-16209544 ] ASF GitHub Bot commented on FLINK-7863: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #4852: [FLINK-7863] Generalize MetricFetcher to work with...

2017-10-18 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/4852 [FLINK-7863] Generalize MetricFetcher to work with a RestfulGateway ## What is the purpose of the change Generalize MetricFetcher to work with `T extends RestfulGateway` instead of the

[jira] [Commented] (FLINK-7623) Detecting whether an operator is restored doesn't work with chained state

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209537#comment-16209537 ] ASF GitHub Bot commented on FLINK-7623: --- GitHub user pnowojski opened a pull request

[GitHub] flink pull request #4851: [FLINK-7623][tests] Add tests to make sure operato...

2017-10-18 Thread pnowojski
GitHub user pnowojski opened a pull request: https://github.com/apache/flink/pull/4851 [FLINK-7623][tests] Add tests to make sure operator is never restored when using new operator id ## What is the purpose of the change This PR adds tests coverage for correct behaviour of

[jira] [Commented] (FLINK-7853) Reject table function outer joins with predicates in Table API

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209511#comment-16209511 ] ASF GitHub Bot commented on FLINK-7853: --- Github user asfgit closed the pull request

[GitHub] flink pull request #4842: [FLINK-7853] [table] Reject table function outer j...

2017-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4842 ---

[jira] [Commented] (FLINK-6444) Add a check that '@VisibleForTesting' methods are only used in tests

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209505#comment-16209505 ] ASF GitHub Bot commented on FLINK-6444: --- Github user zhangminglei commented on a dif

[GitHub] flink pull request #4705: [FLINK-6444] [build] Add a check that '@VisibleFor...

2017-10-18 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4705#discussion_r145445707 --- Diff: flink-tests/src/test/java/org/apache/flink/test/manual/CheckVisibleForTestingUsage.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-6444) Add a check that '@VisibleForTesting' methods are only used in tests

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209489#comment-16209489 ] ASF GitHub Bot commented on FLINK-6444: --- Github user zhangminglei commented on a dif

[GitHub] flink pull request #4705: [FLINK-6444] [build] Add a check that '@VisibleFor...

2017-10-18 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4705#discussion_r145443119 --- Diff: flink-tests/src/test/java/org/apache/flink/test/manual/CheckVisibleForTestingUsage.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the

[jira] [Updated] (FLINK-6889) Improve Path parsing for Windows paths with scheme

2017-10-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-6889: Fix Version/s: (was: 1.4.0) > Improve Path parsing for Windows paths with scheme > -

[jira] [Commented] (FLINK-7820) remove text related to FoldingState and FoldingStateDescriptor from doc

2017-10-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209469#comment-16209469 ] Chesnay Schepler commented on FLINK-7820: - I would suggest to add a deprecation wa

[jira] [Created] (FLINK-7867) Start MetricQueryService on TaskManagerRunner

2017-10-18 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-7867: Summary: Start MetricQueryService on TaskManagerRunner Key: FLINK-7867 URL: https://issues.apache.org/jira/browse/FLINK-7867 Project: Flink Issue Type: Impro

[GitHub] flink issue #3748: [FLINK-6225] [Cassandra Connector] add CassandraTableSink

2017-10-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3748 ``` [ERROR] src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraRowSink.java:[20,8] (imports) UnusedImports: Unused import: org.apache.flink.configuration.Configuration. [E

[jira] [Commented] (FLINK-6225) Support Row Stream for CassandraSink

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209449#comment-16209449 ] ASF GitHub Bot commented on FLINK-6225: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209444#comment-16209444 ] ASF GitHub Bot commented on FLINK-7251: --- Github user zentol commented on the issue:

[GitHub] flink issue #4455: [FLINK-7251] Merge the flink-java8 project into correspon...

2017-10-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4455 We will have to revert every change that requires the tycho plugin to be moved into any other module. Using a different for these modules may have performance impacts and possibly subtle bugs.

[jira] [Commented] (FLINK-5789) Make Bucketing Sink independent of Hadoop's FileSystem

2017-10-18 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209445#comment-16209445 ] Gary Yao commented on FLINK-5789: - [~till.rohrmann] I am not confident that this will make

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209439#comment-16209439 ] ASF GitHub Bot commented on FLINK-7406: --- Github user zhijiangW commented on the issu

[GitHub] flink issue #4509: [FLINK-7406][network] Implement Netty receiver incoming p...

2017-10-18 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4509 @NicoK @pnowojski , this PR is ready now. I rebased the latest master code and updated the modifications based on previous comments. ---

[jira] [Commented] (FLINK-5513) Remove relocation of internal API classes

2017-10-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209424#comment-16209424 ] Chesnay Schepler commented on FLINK-5513: - It isn't, since with FLINK-7779 the rel

[jira] [Commented] (FLINK-6907) Adjust TupleGenerator javadocs in flink-java

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209414#comment-16209414 ] ASF GitHub Bot commented on FLINK-6907: --- GitHub user zentol opened a pull request:

[GitHub] flink pull request #4850: [FLINK-6907][core] Extend TupleGenerator javadocs

2017-10-18 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/4850 [FLINK-6907][core] Extend TupleGenerator javadocs ## What is the purpose of the change This PR extends the javadocs of the TupleGenerator classes to clarify their responsibilities. You can

[jira] [Commented] (FLINK-7758) Fix bug Kafka09Fetcher add offset metrics

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209403#comment-16209403 ] ASF GitHub Bot commented on FLINK-7758: --- Github user zentol commented on the issue:

[GitHub] flink issue #4769: [FLINK-7758][kafka][hotfix] Fix bug Kafka09Fetcher add ka...

2017-10-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4769 The current solution also straight up doesn't work: ``` java.lang.ClassCastException: java.lang.Object cannot be cast to org.apache.flink.metrics.MetricGroup at org.apache.flink.stream

[jira] [Commented] (FLINK-7758) Fix bug Kafka09Fetcher add offset metrics

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209400#comment-16209400 ] ASF GitHub Bot commented on FLINK-7758: --- Github user zentol commented on the issue:

[GitHub] flink issue #4769: [FLINK-7758][kafka][hotfix] Fix bug Kafka09Fetcher add ka...

2017-10-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4769 As I said, it is better to return an `UnregisteredMetricsGroup`. The current solution will blow up the moment the returned group is used, and can't be guarded against with null checks. ---

[jira] [Updated] (FLINK-7582) Rest client may buffer responses indefinitely under heavy laod

2017-10-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-7582: Fix Version/s: (was: 1.4.0) 1.5.0 > Rest client may buffer responses

[jira] [Updated] (FLINK-7550) Give names to REST client/server for clearer logging.

2017-10-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-7550: Fix Version/s: (was: 1.4.0) 1.5.0 > Give names to REST client/server

[jira] [Updated] (FLINK-7565) Add support for HTTP 1.1 (Chunked transfer encoding) to Flink web UI

2017-10-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-7565: Fix Version/s: (was: 1.4.0) 1.5.0 > Add support for HTTP 1.1 (Chunked

[jira] [Updated] (FLINK-6735) Add a checkbox to hide the plan visualizer

2017-10-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-6735: Fix Version/s: (was: 1.4.0) > Add a checkbox to hide the plan visualizer > -

[jira] [Commented] (FLINK-5513) Remove relocation of internal API classes

2017-10-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209389#comment-16209389 ] Chesnay Schepler commented on FLINK-5513: - Isn't this issue in conflict with FLINK

[jira] [Commented] (FLINK-7843) Improve and enhance documentation for system metrics

2017-10-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209385#comment-16209385 ] Chesnay Schepler commented on FLINK-7843: - sounds good. > Improve and enhance doc

[jira] [Comment Edited] (FLINK-7829) Remove (or at least deprecate) DataStream.writeToFile/Csv

2017-10-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209379#comment-16209379 ] Chesnay Schepler edited comment on FLINK-7829 at 10/18/17 2:07 PM: -

[jira] [Commented] (FLINK-7829) Remove (or at least deprecate) DataStream.writeToFile/Csv

2017-10-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209379#comment-16209379 ] Chesnay Schepler commented on FLINK-7829: - It seems we don't support the same feat

[jira] [Commented] (FLINK-7368) MetricStore makes cpu spin at 100%

2017-10-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209358#comment-16209358 ] Chesnay Schepler commented on FLINK-7368: - Missing synchronization was added for 1

[jira] [Comment Edited] (FLINK-7548) Support watermark generation for TableSource

2017-10-18 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209327#comment-16209327 ] Kurt Young edited comment on FLINK-7548 at 10/18/17 1:29 PM: -

[jira] [Comment Edited] (FLINK-7548) Support watermark generation for TableSource

2017-10-18 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209327#comment-16209327 ] Kurt Young edited comment on FLINK-7548 at 10/18/17 1:28 PM: -

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-18 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209327#comment-16209327 ] Kurt Young commented on FLINK-7548: --- Actually I was thinking that when projections are p

[jira] [Commented] (FLINK-6444) Add a check that '@VisibleForTesting' methods are only used in tests

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209322#comment-16209322 ] ASF GitHub Bot commented on FLINK-6444: --- Github user zhangminglei commented on a dif

[GitHub] flink pull request #4705: [FLINK-6444] [build] Add a check that '@VisibleFor...

2017-10-18 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4705#discussion_r145412067 --- Diff: flink-tests/src/test/java/org/apache/flink/test/manual/CheckVisibleForTestingUsage.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-7548) Support watermark generation for TableSource

2017-10-18 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209299#comment-16209299 ] Fabian Hueske commented on FLINK-7548: -- Thanks for the comment [~ykt836]. I think t

[jira] [Commented] (FLINK-7731) Trigger on GlobalWindow does not clean state completely

2017-10-18 Thread Gerard Garcia (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209294#comment-16209294 ] Gerard Garcia commented on FLINK-7731: -- Yes, I think is OK, and as you say it would h

[jira] [Commented] (FLINK-6444) Add a check that '@VisibleForTesting' methods are only used in tests

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209285#comment-16209285 ] ASF GitHub Bot commented on FLINK-6444: --- Github user zhangminglei commented on a dif

[GitHub] flink pull request #4705: [FLINK-6444] [build] Add a check that '@VisibleFor...

2017-10-18 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4705#discussion_r145404978 --- Diff: flink-tests/src/test/java/org/apache/flink/test/manual/CheckVisibleForTestingUsage.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-6444) Add a check that '@VisibleForTesting' methods are only used in tests

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209277#comment-16209277 ] ASF GitHub Bot commented on FLINK-6444: --- Github user zhangminglei commented on a dif

[GitHub] flink pull request #4705: [FLINK-6444] [build] Add a check that '@VisibleFor...

2017-10-18 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4705#discussion_r145403730 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java --- @@ -439,7 +439,7 @@ public

[jira] [Commented] (FLINK-6444) Add a check that '@VisibleForTesting' methods are only used in tests

2017-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209260#comment-16209260 ] ASF GitHub Bot commented on FLINK-6444: --- Github user zhangminglei commented on a dif

[GitHub] flink pull request #4705: [FLINK-6444] [build] Add a check that '@VisibleFor...

2017-10-18 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4705#discussion_r145401310 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java --- @@ -439,7 +439,7 @@ public

  1   2   3   >