[jira] [Updated] (FLINK-9681) Make sure minRetentionTime not equal to maxRetentionTime

2018-06-29 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hequn Cheng updated FLINK-9681: --- Description: Currently, for a group by(or other operators), if minRetentionTime equals to maxRetenti

[jira] [Updated] (FLINK-9694) Potentially NPE in CompositeTypeSerializerConfigSnapshot constructor

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9694: -- Labels: pull-request-available (was: ) > Potentially NPE in CompositeTypeSerializerConfigSnaps

[jira] [Commented] (FLINK-9694) Potentially NPE in CompositeTypeSerializerConfigSnapshot constructor

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528575#comment-16528575 ] ASF GitHub Bot commented on FLINK-9694: --- GitHub user yanghua opened a pull request:

[GitHub] flink pull request #6231: [FLINK-9694] Potentially NPE in CompositeTypeSeria...

2018-06-29 Thread yanghua
GitHub user yanghua opened a pull request: https://github.com/apache/flink/pull/6231 [FLINK-9694] Potentially NPE in CompositeTypeSerializerConfigSnapshot constructor ## What is the purpose of the change *This pull request fixed a NPE in CompositeTypeSerializerConfigSnapsho

[jira] [Updated] (FLINK-9694) Potentially NPE in CompositeTypeSerializerConfigSnapshot constructor

2018-06-29 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang updated FLINK-9694: Description: the partial specific exception stack traceĀ : {code:java} Caused by: java.lang.NullPointerExcep

[jira] [Created] (FLINK-9694) potentially NPE in CompositeTypeSerializerConfigSnapshot constructor

2018-06-29 Thread vinoyang (JIRA)
vinoyang created FLINK-9694: --- Summary: potentially NPE in CompositeTypeSerializerConfigSnapshot constructor Key: FLINK-9694 URL: https://issues.apache.org/jira/browse/FLINK-9694 Project: Flink Iss

[jira] [Updated] (FLINK-9694) Potentially NPE in CompositeTypeSerializerConfigSnapshot constructor

2018-06-29 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang updated FLINK-9694: Summary: Potentially NPE in CompositeTypeSerializerConfigSnapshot constructor (was: potentially NPE in Com

[jira] [Commented] (FLINK-9672) Fail fatally if we cannot submit job on added JobGraph signal

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528562#comment-16528562 ] ASF GitHub Bot commented on FLINK-9672: --- Github user asfgit closed the pull request

[GitHub] flink pull request #6213: [FLINK-9672] Fail fatally if job submission fails ...

2018-06-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6213 ---

[jira] [Closed] (FLINK-9672) Fail fatally if we cannot submit job on added JobGraph signal

2018-06-29 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-9672. Resolution: Fixed Fixed via 1.6.0: 7b4cb5270d94e17867c40a1b3bb7b71cf77cf695 1.5.1: 5936572fd644b9b4

[jira] [Updated] (FLINK-9681) Make sure minRetentionTime not equal to maxRetentionTime

2018-06-29 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hequn Cheng updated FLINK-9681: --- Component/s: Table API & SQL > Make sure minRetentionTime not equal to maxRetentionTime > ---

[jira] [Commented] (FLINK-9666) short-circuit logic should be used in boolean contexts

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528520#comment-16528520 ] ASF GitHub Bot commented on FLINK-9666: --- Github user lamber-ken closed the pull req

[GitHub] flink pull request #6230: [FLINK-9666] short-circuit logic should be used in...

2018-06-29 Thread lamber-ken
Github user lamber-ken closed the pull request at: https://github.com/apache/flink/pull/6230 ---

[jira] [Commented] (FLINK-9666) short-circuit logic should be used in boolean contexts

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528505#comment-16528505 ] ASF GitHub Bot commented on FLINK-9666: --- Github user lamber-ken commented on the is

[GitHub] flink issue #6230: [FLINK-9666] short-circuit logic should be used in boolea...

2018-06-29 Thread lamber-ken
Github user lamber-ken commented on the issue: https://github.com/apache/flink/pull/6230 difficult to find it out. ---

[jira] [Commented] (FLINK-9666) short-circuit logic should be used in boolean contexts

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528503#comment-16528503 ] ASF GitHub Bot commented on FLINK-9666: --- GitHub user lamber-ken opened a pull reque

[GitHub] flink pull request #6230: [FLINK-9666] short-circuit logic should be used in...

2018-06-29 Thread lamber-ken
GitHub user lamber-ken opened a pull request: https://github.com/apache/flink/pull/6230 [FLINK-9666] short-circuit logic should be used in boolean contexts Backport of #6212 . @tillrohrmann, hi, cc You can merge this pull request into a Git repository by running: $ git

[jira] [Updated] (FLINK-9609) Add bucket ready mechanism for BucketingSink when checkpoint complete

2018-06-29 Thread zhangminglei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangminglei updated FLINK-9609: Description: Currently, BucketingSink only support {{notifyCheckpointComplete}}. However, users wa

[jira] [Updated] (FLINK-9693) possible memory link in jobmanager retaining archived checkpoints

2018-06-29 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated FLINK-9693: -- Description: First, some context about the job * Flink 1.4.1 * stand-alone deployment mode *

[jira] [Updated] (FLINK-9693) possible memory link in jobmanager retaining archived checkpoints

2018-06-29 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated FLINK-9693: -- Attachment: ExecutionVertexZoomIn.png > possible memory link in jobmanager retaining archived c

[jira] [Updated] (FLINK-9693) possible memory link in jobmanager retaining archived checkpoints

2018-06-29 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated FLINK-9693: -- Attachment: 41K_ExecutionVertex_objs_retained_9GB.png > possible memory link in jobmanager reta

[jira] [Updated] (FLINK-9693) possible memory link in jobmanager retaining archived checkpoints

2018-06-29 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated FLINK-9693: -- Attachment: (was: image (1).png) > possible memory link in jobmanager retaining archived ch

[jira] [Updated] (FLINK-9693) possible memory link in jobmanager retaining archived checkpoints

2018-06-29 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated FLINK-9693: -- Description: First, some context about the job * Flink 1.4.1 * embarrassingly parallel: all o

[jira] [Updated] (FLINK-9693) possible memory link in jobmanager retaining archived checkpoints

2018-06-29 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated FLINK-9693: -- Attachment: (was: image.png) > possible memory link in jobmanager retaining archived checkp

[jira] [Created] (FLINK-9693) possible memory link in jobmanager retaining archived checkpoints

2018-06-29 Thread Steven Zhen Wu (JIRA)
Steven Zhen Wu created FLINK-9693: - Summary: possible memory link in jobmanager retaining archived checkpoints Key: FLINK-9693 URL: https://issues.apache.org/jira/browse/FLINK-9693 Project: Flink

[jira] [Updated] (FLINK-9692) Adapt maxRecords parameter in the getRecords call to optimize bytes read from Kinesis

2018-06-29 Thread Lakshmi Rao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lakshmi Rao updated FLINK-9692: --- Description: The Kinesis connector currently has a [constant value|https://github.com/apache/flink/b

[jira] [Created] (FLINK-9692) Adapt maxRecords parameter in the getRecords call to optimize bytes read from Kinesis

2018-06-29 Thread Lakshmi Rao (JIRA)
Lakshmi Rao created FLINK-9692: -- Summary: Adapt maxRecords parameter in the getRecords call to optimize bytes read from Kinesis Key: FLINK-9692 URL: https://issues.apache.org/jira/browse/FLINK-9692 Proj

[jira] [Commented] (FLINK-8785) JobSubmitHandler does not handle JobSubmissionExceptions

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528071#comment-16528071 ] ASF GitHub Bot commented on FLINK-8785: --- Github user zentol commented on a diff in

[GitHub] flink pull request #6222: [FLINK-8785][rest] Handle JobSubmissionExceptions

2018-06-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6222#discussion_r199248513 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobSubmitHandler.java --- @@ -66,6 +67,9 @@ public JobSubmitHandler(

[jira] [Commented] (FLINK-9543) Expose JobMaster IDs to metric system

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528044#comment-16528044 ] ASF GitHub Bot commented on FLINK-9543: --- Github user lamber-ken commented on the is

[GitHub] flink issue #6195: [FLINK-9543][METRICS] Expose JobMaster ID to metric syste...

2018-06-29 Thread lamber-ken
Github user lamber-ken commented on the issue: https://github.com/apache/flink/pull/6195 hi, @zentol, cc. ---

[jira] [Commented] (FLINK-9543) Expose JobMaster IDs to metric system

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528043#comment-16528043 ] ASF GitHub Bot commented on FLINK-9543: --- GitHub user lamber-ken reopened a pull req

[GitHub] flink pull request #6195: [FLINK-9543][METRICS] Expose JobMaster ID to metri...

2018-06-29 Thread lamber-ken
GitHub user lamber-ken reopened a pull request: https://github.com/apache/flink/pull/6195 [FLINK-9543][METRICS] Expose JobMaster ID to metric system ## What is the purpose of the change This pull request makes flink can expose JM_ID to metric system ## Brief change log

[jira] [Commented] (FLINK-9543) Expose JobMaster IDs to metric system

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528039#comment-16528039 ] ASF GitHub Bot commented on FLINK-9543: --- Github user lamber-ken closed the pull req

[GitHub] flink pull request #6195: [FLINK-9543][METRICS] Expose JobMaster ID to metri...

2018-06-29 Thread lamber-ken
Github user lamber-ken closed the pull request at: https://github.com/apache/flink/pull/6195 ---

[jira] [Commented] (FLINK-9280) Extend JobSubmitHandler to accept jar files

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528024#comment-16528024 ] ASF GitHub Bot commented on FLINK-9280: --- Github user zentol commented on a diff in

[GitHub] flink pull request #6203: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6203#discussion_r199236398 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobSubmitHandler.java --- @@ -34,38 +40,137 @@ import javax.annota

[jira] [Comment Edited] (FLINK-9649) TaskManagers are not scheduled on Mesos

2018-06-29 Thread Leonid Ishimnikov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528023#comment-16528023 ] Leonid Ishimnikov edited comment on FLINK-9649 at 6/29/18 5:56 PM:

[jira] [Commented] (FLINK-9649) TaskManagers are not scheduled on Mesos

2018-06-29 Thread Leonid Ishimnikov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528023#comment-16528023 ] Leonid Ishimnikov commented on FLINK-9649: -- [~gjy] Thank you for the explanation

[jira] [Commented] (FLINK-9513) Wrap state binder with TTL logic

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528012#comment-16528012 ] ASF GitHub Bot commented on FLINK-9513: --- Github user azagrebin commented on a diff

[GitHub] flink pull request #6196: [FLINK-9513] Implement TTL state wrappers factory ...

2018-06-29 Thread azagrebin
Github user azagrebin commented on a diff in the pull request: https://github.com/apache/flink/pull/6196#discussion_r199231639 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java --- @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-9513) Wrap state binder with TTL logic

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528009#comment-16528009 ] ASF GitHub Bot commented on FLINK-9513: --- Github user azagrebin commented on the iss

[GitHub] flink issue #6196: [FLINK-9513] Implement TTL state wrappers factory and ser...

2018-06-29 Thread azagrebin
Github user azagrebin commented on the issue: https://github.com/apache/flink/pull/6196 @StefanRRichter @sihuazhou Thanks guys for the helpful review. I refactored the `CompositeSerializer` to rely rather on loops than streams and added tests for it. Please, have a look.

[jira] [Commented] (FLINK-9513) Wrap state binder with TTL logic

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527993#comment-16527993 ] ASF GitHub Bot commented on FLINK-9513: --- Github user azagrebin commented on a diff

[GitHub] flink pull request #6196: [FLINK-9513] Implement TTL state wrappers factory ...

2018-06-29 Thread azagrebin
Github user azagrebin commented on a diff in the pull request: https://github.com/apache/flink/pull/6196#discussion_r199228508 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java --- @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-9513) Wrap state binder with TTL logic

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527988#comment-16527988 ] ASF GitHub Bot commented on FLINK-9513: --- Github user azagrebin commented on a diff

[GitHub] flink pull request #6196: [FLINK-9513] Implement TTL state wrappers factory ...

2018-06-29 Thread azagrebin
Github user azagrebin commented on a diff in the pull request: https://github.com/apache/flink/pull/6196#discussion_r199227970 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java --- @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-9513) Wrap state binder with TTL logic

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527987#comment-16527987 ] ASF GitHub Bot commented on FLINK-9513: --- Github user azagrebin commented on a diff

[GitHub] flink pull request #6196: [FLINK-9513] Implement TTL state wrappers factory ...

2018-06-29 Thread azagrebin
Github user azagrebin commented on a diff in the pull request: https://github.com/apache/flink/pull/6196#discussion_r199227770 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java --- @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-9513) Wrap state binder with TTL logic

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527982#comment-16527982 ] ASF GitHub Bot commented on FLINK-9513: --- Github user azagrebin commented on a diff

[jira] [Commented] (FLINK-9513) Wrap state binder with TTL logic

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527980#comment-16527980 ] ASF GitHub Bot commented on FLINK-9513: --- Github user azagrebin commented on a diff

[GitHub] flink pull request #6196: [FLINK-9513] Implement TTL state wrappers factory ...

2018-06-29 Thread azagrebin
Github user azagrebin commented on a diff in the pull request: https://github.com/apache/flink/pull/6196#discussion_r199226982 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java --- @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #6196: [FLINK-9513] Implement TTL state wrappers factory ...

2018-06-29 Thread azagrebin
Github user azagrebin commented on a diff in the pull request: https://github.com/apache/flink/pull/6196#discussion_r199226833 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java --- @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-8650) Add tests and documentation for WINDOW clause

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527966#comment-16527966 ] ASF GitHub Bot commented on FLINK-8650: --- Github user snuyanzin commented on the iss

[GitHub] flink issue #6226: [FLINK-8650] Tests for WINDOW clause and documentation up...

2018-06-29 Thread snuyanzin
Github user snuyanzin commented on the issue: https://github.com/apache/flink/pull/6226 @fhueske thank you for your review I have left comments and done changes. Please let me know if it is required some more efforts ---

[jira] [Commented] (FLINK-8650) Add tests and documentation for WINDOW clause

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527964#comment-16527964 ] ASF GitHub Bot commented on FLINK-8650: --- Github user snuyanzin commented on a diff

[GitHub] flink pull request #6226: [FLINK-8650] Tests for WINDOW clause and documenta...

2018-06-29 Thread snuyanzin
Github user snuyanzin commented on a diff in the pull request: https://github.com/apache/flink/pull/6226#discussion_r199223615 --- Diff: docs/dev/table/sql.md --- @@ -176,9 +181,20 @@ groupItem: | ROLLUP '(' expression [, expression ]* ')' | GROUPING SETS '(' groupItem

[jira] [Commented] (FLINK-8650) Add tests and documentation for WINDOW clause

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527961#comment-16527961 ] ASF GitHub Bot commented on FLINK-8650: --- Github user snuyanzin commented on a diff

[jira] [Commented] (FLINK-8650) Add tests and documentation for WINDOW clause

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527960#comment-16527960 ] ASF GitHub Bot commented on FLINK-8650: --- Github user snuyanzin commented on a diff

[GitHub] flink pull request #6226: [FLINK-8650] Tests for WINDOW clause and documenta...

2018-06-29 Thread snuyanzin
Github user snuyanzin commented on a diff in the pull request: https://github.com/apache/flink/pull/6226#discussion_r199223349 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/OverWindowTest.scala --- @@ -44,7 +44,26 @@ class OverWindowTes

[GitHub] flink pull request #6226: [FLINK-8650] Tests for WINDOW clause and documenta...

2018-06-29 Thread snuyanzin
Github user snuyanzin commented on a diff in the pull request: https://github.com/apache/flink/pull/6226#discussion_r199222853 --- Diff: docs/dev/table/sql.md --- @@ -176,9 +181,20 @@ groupItem: | ROLLUP '(' expression [, expression ]* ')' | GROUPING SETS '(' groupItem

[jira] [Commented] (FLINK-9666) short-circuit logic should be used in boolean contexts

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527946#comment-16527946 ] ASF GitHub Bot commented on FLINK-9666: --- Github user lamber-ken commented on the is

[jira] [Closed] (FLINK-9627) Extending 'KafkaJsonTableSource' according to comments will result in NPE

2018-06-29 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-9627. Resolution: Fixed Fix Version/s: 1.5.1 1.4.3 1.6.0 Fix

[GitHub] flink issue #6212: [FLINK-9666] short-circuit logic should be used in boolea...

2018-06-29 Thread lamber-ken
Github user lamber-ken commented on the issue: https://github.com/apache/flink/pull/6212 maybe it's a bug ---

[jira] [Commented] (FLINK-9666) short-circuit logic should be used in boolean contexts

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527943#comment-16527943 ] ASF GitHub Bot commented on FLINK-9666: --- Github user lamber-ken commented on the is

[GitHub] flink issue #6212: [FLINK-9666] short-circuit logic should be used in boolea...

2018-06-29 Thread lamber-ken
Github user lamber-ken commented on the issue: https://github.com/apache/flink/pull/6212 hi, @tillrohrmann, if you don't know, I'll ignore it. it's no problem, :smiley: This information is always displayed at the bottom of the page. here's it. ![image](https://user-

[jira] [Commented] (FLINK-9627) Extending 'KafkaJsonTableSource' according to comments will result in NPE

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527941#comment-16527941 ] ASF GitHub Bot commented on FLINK-9627: --- Github user asfgit closed the pull request

[GitHub] flink pull request #6198: [FLINK-9627] Extending KafkaJsonTableSource accord...

2018-06-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6198 ---

[jira] [Commented] (FLINK-9521) Add shade plugin executions to package table example jar

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527922#comment-16527922 ] ASF GitHub Bot commented on FLINK-9521: --- Github user yanghua commented on the issue

[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...

2018-06-29 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6123 hi @tillrohrmann I think we should include the table example jar into Flink's binary distribution just like `batch`, `streaming`, `gelly`, `python` examples for those people who do not want to try SQ

[jira] [Commented] (FLINK-8650) Add tests and documentation for WINDOW clause

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527888#comment-16527888 ] ASF GitHub Bot commented on FLINK-8650: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #6226: [FLINK-8650] Tests for WINDOW clause and documenta...

2018-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/6226#discussion_r199204037 --- Diff: docs/dev/table/sql.md --- @@ -176,9 +181,20 @@ groupItem: | ROLLUP '(' expression [, expression ]* ')' | GROUPING SETS '(' groupItem [

[jira] [Commented] (FLINK-8650) Add tests and documentation for WINDOW clause

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527890#comment-16527890 ] ASF GitHub Bot commented on FLINK-8650: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #6226: [FLINK-8650] Tests for WINDOW clause and documenta...

2018-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/6226#discussion_r199204120 --- Diff: docs/dev/table/sql.md --- @@ -176,9 +181,20 @@ groupItem: | ROLLUP '(' expression [, expression ]* ')' | GROUPING SETS '(' groupItem [

[jira] [Updated] (FLINK-9521) Add shade plugin executions to package table example jar

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9521: -- Labels: pull-request-available (was: ) > Add shade plugin executions to package table example

[jira] [Commented] (FLINK-9521) Add shade plugin executions to package table example jar

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527886#comment-16527886 ] ASF GitHub Bot commented on FLINK-9521: --- Github user tillrohrmann commented on the

[GitHub] flink pull request #6226: [FLINK-8650] Tests for WINDOW clause and documenta...

2018-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/6226#discussion_r199205419 --- Diff: docs/dev/table/sql.md --- @@ -176,9 +181,20 @@ groupItem: | ROLLUP '(' expression [, expression ]* ')' | GROUPING SETS '(' groupItem [

[GitHub] flink pull request #6226: [FLINK-8650] Tests for WINDOW clause and documenta...

2018-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/6226#discussion_r199209179 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/OverWindowTest.scala --- @@ -44,7 +44,26 @@ class OverWindowTest

[jira] [Commented] (FLINK-8650) Add tests and documentation for WINDOW clause

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527889#comment-16527889 ] ASF GitHub Bot commented on FLINK-8650: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8650) Add tests and documentation for WINDOW clause

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527891#comment-16527891 ] ASF GitHub Bot commented on FLINK-8650: --- Github user fhueske commented on a diff in

[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...

2018-06-29 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/6123 Thanks for opening the PR @yanghua. I would need some input from @twalthr or @fhueske whether it already makes sense to include the Flink table example programs in Flink's binary distribution.

[jira] [Assigned] (FLINK-4582) Allow FlinkKinesisConsumer to adapt for AWS DynamoDB Streams

2018-06-29 Thread Mingdao Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingdao Yang reassigned FLINK-4582: --- Assignee: (was: Mingdao Yang) > Allow FlinkKinesisConsumer to adapt for AWS DynamoDB Str

[jira] [Commented] (FLINK-9666) short-circuit logic should be used in boolean contexts

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527857#comment-16527857 ] ASF GitHub Bot commented on FLINK-9666: --- Github user tillrohrmann commented on the

[GitHub] flink issue #6212: [FLINK-9666] short-circuit logic should be used in boolea...

2018-06-29 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/6212 Not sure where this comes from. But I've merged your commit into the master. See da37daa8ba. ---

[jira] [Commented] (FLINK-9662) Task manager isolation for jobs

2018-06-29 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527851#comment-16527851 ] Till Rohrmann commented on FLINK-9662: -- Thanks for updating the design document [~li

[jira] [Commented] (FLINK-9672) Fail fatally if we cannot submit job on added JobGraph signal

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527832#comment-16527832 ] ASF GitHub Bot commented on FLINK-9672: --- Github user tillrohrmann commented on the

[GitHub] flink issue #6213: [FLINK-9672] Fail fatally if job submission fails on adde...

2018-06-29 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/6213 Thanks for the review @GJL. Merging this PR into master and `release-1.5` branch. ---

[GitHub] flink pull request #6203: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6203#discussion_r199197307 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/JobSubmitHandlerTest.java --- @@ -47,8 +65,30 @@ */ public c

[jira] [Commented] (FLINK-9280) Extend JobSubmitHandler to accept jar files

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527808#comment-16527808 ] ASF GitHub Bot commented on FLINK-9280: --- Github user tillrohrmann commented on a di

[GitHub] flink pull request #6203: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6203#discussion_r199181211 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -315,36 +315,58 @@ public JobSubmissionResult

[GitHub] flink pull request #6203: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6203#discussion_r199178551 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -315,36 +315,58 @@ public JobSubmissionResult

[jira] [Commented] (FLINK-9280) Extend JobSubmitHandler to accept jar files

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527825#comment-16527825 ] ASF GitHub Bot commented on FLINK-9280: --- Github user tillrohrmann commented on a di

[jira] [Commented] (FLINK-9280) Extend JobSubmitHandler to accept jar files

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527821#comment-16527821 ] ASF GitHub Bot commented on FLINK-9280: --- Github user tillrohrmann commented on a di

[jira] [Commented] (FLINK-9280) Extend JobSubmitHandler to accept jar files

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527814#comment-16527814 ] ASF GitHub Bot commented on FLINK-9280: --- Github user tillrohrmann commented on a di

[jira] [Commented] (FLINK-9280) Extend JobSubmitHandler to accept jar files

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527811#comment-16527811 ] ASF GitHub Bot commented on FLINK-9280: --- Github user tillrohrmann commented on a di

[jira] [Commented] (FLINK-9280) Extend JobSubmitHandler to accept jar files

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527830#comment-16527830 ] ASF GitHub Bot commented on FLINK-9280: --- Github user tillrohrmann commented on a di

[jira] [Commented] (FLINK-9280) Extend JobSubmitHandler to accept jar files

2018-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527819#comment-16527819 ] ASF GitHub Bot commented on FLINK-9280: --- Github user tillrohrmann commented on a di

[GitHub] flink pull request #6203: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6203#discussion_r199187606 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobSubmitHandler.java --- @@ -34,38 +40,137 @@ import javax.

[GitHub] flink pull request #6203: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6203#discussion_r199187175 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobSubmitHandler.java --- @@ -34,38 +40,137 @@ import javax.

[GitHub] flink pull request #6203: [FLINK-9280][rest] Rework JobSubmitHandler to acce...

2018-06-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6203#discussion_r199177926 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -315,36 +315,58 @@ public JobSubmissionResult

  1   2   3   >