[GitHub] yanghua commented on a change in pull request #6850: [FLINK-10252] Handle oversized metric messges

2018-11-02 Thread GitBox
yanghua commented on a change in pull request #6850: [FLINK-10252] Handle oversized metric messges URL: https://github.com/apache/flink/pull/6850#discussion_r230349763 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricQueryService.java

[jira] [Commented] (FLINK-10757) TaskManagerProcessFailureStreamingRecoveryITCase failed to initialize the cluster entrypoint StandaloneSessionClusterEntrypoint.

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673010#comment-16673010 ] ASF GitHub Bot commented on FLINK-10757: TisonKun commented on issue #6998: [FLINK-10757]

[GitHub] TisonKun commented on issue #6998: [FLINK-10757] [tests] Avoid port conflicts in AbstractTaskManagerProc…

2018-11-02 Thread GitBox
TisonKun commented on issue #6998: [FLINK-10757] [tests] Avoid port conflicts in AbstractTaskManagerProc… URL: https://github.com/apache/flink/pull/6998#issuecomment-435355135 Travis doesn't start for over six hours, manually re-trigger.

[jira] [Assigned] (FLINK-10750) SocketClientSinkTest.testRetry fails on Travis

2018-11-02 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-10750: Assignee: Chesnay Schepler > SocketClientSinkTest.testRetry fails on Travis >

[jira] [Commented] (FLINK-10742) Let Netty use Flink's buffers directly in credit-based mode

2018-11-02 Thread Yun Gao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672963#comment-16672963 ] Yun Gao commented on FLINK-10742: - Ok,I got it,I will consider the credit-based implementation first.

[jira] [Commented] (FLINK-10715) E2e tests fail with ConcurrentModificationException in MetricRegistryImpl

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672959#comment-16672959 ] ASF GitHub Bot commented on FLINK-10715: zentol commented on a change in pull request #6996:

[jira] [Commented] (FLINK-10715) E2e tests fail with ConcurrentModificationException in MetricRegistryImpl

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672958#comment-16672958 ] ASF GitHub Bot commented on FLINK-10715: zentol commented on a change in pull request #6996:

[GitHub] zentol commented on a change in pull request #6996: [FLINK-10715] Change reporter log level

2018-11-02 Thread GitBox
zentol commented on a change in pull request #6996: [FLINK-10715] Change reporter log level URL: https://github.com/apache/flink/pull/6996#discussion_r230341614 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java ## @@

[GitHub] zentol commented on a change in pull request #6996: [FLINK-10715] Change reporter log level

2018-11-02 Thread GitBox
zentol commented on a change in pull request #6996: [FLINK-10715] Change reporter log level URL: https://github.com/apache/flink/pull/6996#discussion_r230341614 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java ## @@

[jira] [Commented] (FLINK-10633) End-to-end test: Prometheus reporter

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672949#comment-16672949 ] ASF GitHub Bot commented on FLINK-10633: dawidwys commented on a change in pull request #7003:

[GitHub] dawidwys commented on a change in pull request #7003: [FLINK-10633][prometheus] Add E2E test

2018-11-02 Thread GitBox
dawidwys commented on a change in pull request #7003: [FLINK-10633][prometheus] Add E2E test URL: https://github.com/apache/flink/pull/7003#discussion_r230339434 ## File path:

[jira] [Commented] (FLINK-10633) End-to-end test: Prometheus reporter

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672943#comment-16672943 ] ASF GitHub Bot commented on FLINK-10633: zentol commented on a change in pull request #7003:

[GitHub] zentol commented on a change in pull request #7003: [FLINK-10633][prometheus] Add E2E test

2018-11-02 Thread GitBox
zentol commented on a change in pull request #7003: [FLINK-10633][prometheus] Add E2E test URL: https://github.com/apache/flink/pull/7003#discussion_r230338568 ## File path:

[jira] [Commented] (FLINK-10715) E2e tests fail with ConcurrentModificationException in MetricRegistryImpl

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672939#comment-16672939 ] ASF GitHub Bot commented on FLINK-10715: tillrohrmann commented on a change in pull request

[GitHub] tillrohrmann commented on a change in pull request #6996: [FLINK-10715] Change reporter log level

2018-11-02 Thread GitBox
tillrohrmann commented on a change in pull request #6996: [FLINK-10715] Change reporter log level URL: https://github.com/apache/flink/pull/6996#discussion_r230337879 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java ## @@

[jira] [Commented] (FLINK-10633) End-to-end test: Prometheus reporter

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672935#comment-16672935 ] ASF GitHub Bot commented on FLINK-10633: zentol commented on a change in pull request #7003:

[GitHub] zentol commented on a change in pull request #7003: [FLINK-10633][prometheus] Add E2E test

2018-11-02 Thread GitBox
zentol commented on a change in pull request #7003: [FLINK-10633][prometheus] Add E2E test URL: https://github.com/apache/flink/pull/7003#discussion_r230337516 ## File path:

[jira] [Commented] (FLINK-10633) End-to-end test: Prometheus reporter

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672933#comment-16672933 ] ASF GitHub Bot commented on FLINK-10633: zentol commented on a change in pull request #7003:

[GitHub] zentol commented on a change in pull request #7003: [FLINK-10633][prometheus] Add E2E test

2018-11-02 Thread GitBox
zentol commented on a change in pull request #7003: [FLINK-10633][prometheus] Add E2E test URL: https://github.com/apache/flink/pull/7003#discussion_r230337203 ## File path:

[jira] [Updated] (FLINK-10751) Checkpoints should be retained when job reaches suspended state

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10751: --- Labels: pull-request-available (was: ) > Checkpoints should be retained when job reaches

[jira] [Commented] (FLINK-10751) Checkpoints should be retained when job reaches suspended state

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672931#comment-16672931 ] ASF GitHub Bot commented on FLINK-10751: uce opened a new pull request #7006: [FLINK-10751]

[GitHub] uce opened a new pull request #7006: [FLINK-10751] [runtime] Retain checkpoints on suspension

2018-11-02 Thread GitBox
uce opened a new pull request #7006: [FLINK-10751] [runtime] Retain checkpoints on suspension URL: https://github.com/apache/flink/pull/7006 ## What is the purpose of the change Retain checkpoints in case of terminal job status `SUSPENDED`. Note that this does **not actually

[jira] [Commented] (FLINK-10715) E2e tests fail with ConcurrentModificationException in MetricRegistryImpl

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672928#comment-16672928 ] ASF GitHub Bot commented on FLINK-10715: zentol commented on a change in pull request #6996:

[GitHub] zentol commented on a change in pull request #6996: [FLINK-10715] Change reporter log level

2018-11-02 Thread GitBox
zentol commented on a change in pull request #6996: [FLINK-10715] Change reporter log level URL: https://github.com/apache/flink/pull/6996#discussion_r230336292 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java ## @@

[jira] [Commented] (FLINK-10655) RemoteRpcInvocation not overwriting ObjectInputStream's ClassNotFoundException

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672926#comment-16672926 ] ASF GitHub Bot commented on FLINK-10655: NicoK opened a new pull request #7005:

[GitHub] NicoK opened a new pull request #7005: [FLINK-10655][rpc] fix RemoteRpcInvocation not overwriting ObjectInputStream's ClassNotFoundException

2018-11-02 Thread GitBox
NicoK opened a new pull request #7005: [FLINK-10655][rpc] fix RemoteRpcInvocation not overwriting ObjectInputStream's ClassNotFoundException URL: https://github.com/apache/flink/pull/7005 ## What is the purpose of the change `RemoteRpcInvocation` tries to give a more detailed

[jira] [Commented] (FLINK-10655) RemoteRpcInvocation not overwriting ObjectInputStream's ClassNotFoundException

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672921#comment-16672921 ] ASF GitHub Bot commented on FLINK-10655: tillrohrmann commented on issue #6920:

[jira] [Commented] (FLINK-10633) End-to-end test: Prometheus reporter

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672920#comment-16672920 ] ASF GitHub Bot commented on FLINK-10633: dawidwys commented on a change in pull request #7003:

[GitHub] tillrohrmann commented on issue #6920: [FLINK-10655][rpc] fix RemoteRpcInvocation not overwriting ObjectInputStream's ClassNotFoundException

2018-11-02 Thread GitBox
tillrohrmann commented on issue #6920: [FLINK-10655][rpc] fix RemoteRpcInvocation not overwriting ObjectInputStream's ClassNotFoundException URL: https://github.com/apache/flink/pull/6920#issuecomment-435341118 This PR is based against `release-1.6`. Please mark this PR as a backport and

[jira] [Commented] (FLINK-10368) 'Kerberized YARN on Docker test' instable

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672919#comment-16672919 ] ASF GitHub Bot commented on FLINK-10368: tillrohrmann commented on issue #6965:

[GitHub] dawidwys commented on a change in pull request #7003: [FLINK-10633][prometheus] Add E2E test

2018-11-02 Thread GitBox
dawidwys commented on a change in pull request #7003: [FLINK-10633][prometheus] Add E2E test URL: https://github.com/apache/flink/pull/7003#discussion_r230334487 ## File path:

[GitHub] tillrohrmann commented on issue #6965: [FLINK-10368][e2e] Hardened kerberized yarn e2e test

2018-11-02 Thread GitBox
tillrohrmann commented on issue #6965: [FLINK-10368][e2e] Hardened kerberized yarn e2e test URL: https://github.com/apache/flink/pull/6965#issuecomment-435340617 Would it work to retry the deployment logic and fail if we could not deploy the cluster after several attempts?

[jira] [Commented] (FLINK-10747) CoGroupConnectedComponentsITCase deadlocked on Travis

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672917#comment-16672917 ] ASF GitHub Bot commented on FLINK-10747: NicoK commented on a change in pull request #6992:

[GitHub] NicoK commented on a change in pull request #6992: [FLINK-10747] Update SingleInputGate#requestedPartitionsFlag under lock

2018-11-02 Thread GitBox
NicoK commented on a change in pull request #6992: [FLINK-10747] Update SingleInputGate#requestedPartitionsFlag under lock URL: https://github.com/apache/flink/pull/6992#discussion_r230332580 ## File path:

[jira] [Commented] (FLINK-10743) Use 0 processExitCode for ApplicationStatus.CANCELED

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672915#comment-16672915 ] ASF GitHub Bot commented on FLINK-10743: uce opened a new pull request #7004: [FLINK-10743]

[jira] [Updated] (FLINK-10743) Use 0 processExitCode for ApplicationStatus.CANCELED

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10743: --- Labels: pull-request-available (was: ) > Use 0 processExitCode for

[GitHub] uce opened a new pull request #7004: [FLINK-10743] [runtime] Use 0 processExitCode for ApplicationStatus.CANCELED

2018-11-02 Thread GitBox
uce opened a new pull request #7004: [FLINK-10743] [runtime] Use 0 processExitCode for ApplicationStatus.CANCELED URL: https://github.com/apache/flink/pull/7004 ## What is the purpose of the change This pull request changes the process exit code of `ApplicationStatus.CANCELED` to

[jira] [Commented] (FLINK-10685) Support history server on YARN

2018-11-02 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672907#comment-16672907 ] Till Rohrmann commented on FLINK-10685: --- Thanks for the clarification [~yanghua]. > Support

[jira] [Commented] (FLINK-10750) SocketClientSinkTest.testRetry fails on Travis

2018-11-02 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672910#comment-16672910 ] Till Rohrmann commented on FLINK-10750: --- Yes, I think this is a good idea how to harden the test

[jira] [Commented] (FLINK-10752) Result of AbstractYarnClusterDescriptor#validateClusterResources is ignored

2018-11-02 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672911#comment-16672911 ] Dawid Wysakowicz commented on FLINK-10752: -- Fixed in master via:

[jira] [Closed] (FLINK-10752) Result of AbstractYarnClusterDescriptor#validateClusterResources is ignored

2018-11-02 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-10752. Resolution: Fixed Fix Version/s: 1.6.3 1.5.6 > Result of

[jira] [Reopened] (FLINK-10752) Result of AbstractYarnClusterDescriptor#validateClusterResources is ignored

2018-11-02 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz reopened FLINK-10752: -- > Result of AbstractYarnClusterDescriptor#validateClusterResources is ignored >

[jira] [Commented] (FLINK-10715) E2e tests fail with ConcurrentModificationException in MetricRegistryImpl

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672906#comment-16672906 ] ASF GitHub Bot commented on FLINK-10715: tillrohrmann commented on a change in pull request

[jira] [Closed] (FLINK-10581) YarnConfigurationITCase.testFlinkContainerMemory test instability

2018-11-02 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-10581. Resolution: Fixed Fix Version/s: 1.6.3 1.5.6 >

[jira] [Commented] (FLINK-10715) E2e tests fail with ConcurrentModificationException in MetricRegistryImpl

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672905#comment-16672905 ] ASF GitHub Bot commented on FLINK-10715: tillrohrmann commented on a change in pull request

[jira] [Commented] (FLINK-10581) YarnConfigurationITCase.testFlinkContainerMemory test instability

2018-11-02 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672904#comment-16672904 ] Dawid Wysakowicz commented on FLINK-10581: -- Fixed in master via:

[GitHub] tillrohrmann commented on a change in pull request #6996: [FLINK-10715] Change reporter log level

2018-11-02 Thread GitBox
tillrohrmann commented on a change in pull request #6996: [FLINK-10715] Change reporter log level URL: https://github.com/apache/flink/pull/6996#discussion_r230332712 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java ## @@

[GitHub] tillrohrmann commented on a change in pull request #6996: [FLINK-10715] Change reporter log level

2018-11-02 Thread GitBox
tillrohrmann commented on a change in pull request #6996: [FLINK-10715] Change reporter log level URL: https://github.com/apache/flink/pull/6996#discussion_r230332712 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java ## @@

[jira] [Reopened] (FLINK-10581) YarnConfigurationITCase.testFlinkContainerMemory test instability

2018-11-02 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz reopened FLINK-10581: -- > YarnConfigurationITCase.testFlinkContainerMemory test instability >

[jira] [Commented] (FLINK-10727) Remove unnecessary synchronization in SingleInputGate#requestPartitions()

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672901#comment-16672901 ] ASF GitHub Bot commented on FLINK-10727: tillrohrmann commented on issue #6974:

[GitHub] tillrohrmann commented on issue #6974: [FLINK-10727][network] remove unnecessary synchronization in SingleInputGate#requestPartitions()

2018-11-02 Thread GitBox
tillrohrmann commented on issue #6974: [FLINK-10727][network] remove unnecessary synchronization in SingleInputGate#requestPartitions() URL: https://github.com/apache/flink/pull/6974#issuecomment-435338126 I think making `requestedPartitionsFlag` volatile won't solve the problem.

[jira] [Closed] (FLINK-10581) YarnConfigurationITCase.testFlinkContainerMemory test instability

2018-11-02 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-10581. Resolution: Fixed Fix Version/s: 1.7.0 >

[GitHub] dawidwys closed pull request #6990: [FLINK-10581][yarn] Increased the threshold for memory verification in YarnConfigurationITCase.testFlinkContainerMemory

2018-11-02 Thread GitBox
dawidwys closed pull request #6990: [FLINK-10581][yarn] Increased the threshold for memory verification in YarnConfigurationITCase.testFlinkContainerMemory URL: https://github.com/apache/flink/pull/6990 This is a PR merged from a forked repository. As GitHub hides the original diff on

[jira] [Commented] (FLINK-10581) YarnConfigurationITCase.testFlinkContainerMemory test instability

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672897#comment-16672897 ] ASF GitHub Bot commented on FLINK-10581: dawidwys closed pull request #6990: [FLINK-10581][yarn]

[jira] [Commented] (FLINK-10754) Update Jepsen tests to run with activated local recovery

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672894#comment-16672894 ] ASF GitHub Bot commented on FLINK-10754: tillrohrmann closed pull request #6995: [FLINK-10754]

[jira] [Closed] (FLINK-10754) Update Jepsen tests to run with activated local recovery

2018-11-02 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-10754. - Resolution: Fixed Fixed via

[GitHub] tillrohrmann closed pull request #6995: [FLINK-10754] Enable local recovery for Jepsen based tests

2018-11-02 Thread GitBox
tillrohrmann closed pull request #6995: [FLINK-10754] Enable local recovery for Jepsen based tests URL: https://github.com/apache/flink/pull/6995 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] zentol commented on a change in pull request #6850: [FLINK-10252] Handle oversized metric messges

2018-11-02 Thread GitBox
zentol commented on a change in pull request #6850: [FLINK-10252] Handle oversized metric messges URL: https://github.com/apache/flink/pull/6850#discussion_r230328817 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricQueryService.java

[jira] [Commented] (FLINK-10252) Handle oversized metric messges

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672892#comment-16672892 ] ASF GitHub Bot commented on FLINK-10252: zentol commented on a change in pull request #6850:

[jira] [Commented] (FLINK-10742) Let Netty use Flink's buffers directly in credit-based mode

2018-11-02 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672891#comment-16672891 ] Nico Kruber commented on FLINK-10742: - [~gaoyunhaii] thanks for taking care of this - I didn't have

[jira] [Commented] (FLINK-10715) E2e tests fail with ConcurrentModificationException in MetricRegistryImpl

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672881#comment-16672881 ] ASF GitHub Bot commented on FLINK-10715: zentol commented on issue #6996: [FLINK-10715] Change

[GitHub] NicoK edited a comment on issue #6974: [FLINK-10727][network] remove unnecessary synchronization in SingleInputGate#requestPartitions()

2018-11-02 Thread GitBox
NicoK edited a comment on issue #6974: [FLINK-10727][network] remove unnecessary synchronization in SingleInputGate#requestPartitions() URL: https://github.com/apache/flink/pull/6974#issuecomment-435335043 Hi @tillrohrmann, sorry for missing this one use: there are two options now: 1)

[jira] [Commented] (FLINK-10727) Remove unnecessary synchronization in SingleInputGate#requestPartitions()

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672882#comment-16672882 ] ASF GitHub Bot commented on FLINK-10727: NicoK edited a comment on issue #6974:

[jira] [Commented] (FLINK-10727) Remove unnecessary synchronization in SingleInputGate#requestPartitions()

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672880#comment-16672880 ] ASF GitHub Bot commented on FLINK-10727: NicoK commented on issue #6974: [FLINK-10727][network]

[GitHub] NicoK commented on issue #6974: [FLINK-10727][network] remove unnecessary synchronization in SingleInputGate#requestPartitions()

2018-11-02 Thread GitBox
NicoK commented on issue #6974: [FLINK-10727][network] remove unnecessary synchronization in SingleInputGate#requestPartitions() URL: https://github.com/apache/flink/pull/6974#issuecomment-435335043 Hi Till, sorry for missing this one use: there are two options now: 1) revert the

[GitHub] zentol commented on issue #6996: [FLINK-10715] Change reporter log level

2018-11-02 Thread GitBox
zentol commented on issue #6996: [FLINK-10715] Change reporter log level URL: https://github.com/apache/flink/pull/6996#issuecomment-435335044 @igalshilman You can also re-open this PR. This is an automated message from the

[jira] [Commented] (FLINK-10251) Handle oversized response messages in AkkaRpcActor

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672878#comment-16672878 ] ASF GitHub Bot commented on FLINK-10251: tillrohrmann commented on issue #6876: [FLINK-10251]

[jira] [Commented] (FLINK-10715) E2e tests fail with ConcurrentModificationException in MetricRegistryImpl

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672877#comment-16672877 ] ASF GitHub Bot commented on FLINK-10715: zentol commented on a change in pull request #6996:

[GitHub] zentol commented on a change in pull request #6996: [FLINK-10715] Change reporter log level

2018-11-02 Thread GitBox
zentol commented on a change in pull request #6996: [FLINK-10715] Change reporter log level URL: https://github.com/apache/flink/pull/6996#discussion_r230327489 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java ## @@

[GitHub] tillrohrmann commented on issue #6876: [FLINK-10251] Handle oversized response messages in AkkaRpcActor

2018-11-02 Thread GitBox
tillrohrmann commented on issue #6876: [FLINK-10251] Handle oversized response messages in AkkaRpcActor URL: https://github.com/apache/flink/pull/6876#issuecomment-435334669 Hi @yanghua sorry for my unresponsiveness. I think this fix won't make it into the 1.7 release anymore. But we will

[jira] [Commented] (FLINK-6944) Introduce DefaultTypeSerializerConfigSnapshot as a base implementation for serializer compatibility checks

2018-11-02 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672874#comment-16672874 ] Till Rohrmann commented on FLINK-6944: -- Is this issue still relevant for the reworked state

[jira] [Commented] (FLINK-10715) E2e tests fail with ConcurrentModificationException in MetricRegistryImpl

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672872#comment-16672872 ] ASF GitHub Bot commented on FLINK-10715: igalshilman commented on issue #6996: [FLINK-10715]

[GitHub] igalshilman commented on issue #6996: [FLINK-10715] Change reporter log level

2018-11-02 Thread GitBox
igalshilman commented on issue #6996: [FLINK-10715] Change reporter log level URL: https://github.com/apache/flink/pull/6996#issuecomment-435333511 Thanks for the review @tillrohrmann , I will address your comments and create a new PR, I've closed this accidentally. @kl0u - as far

[jira] [Commented] (FLINK-10552) Provide RichAsyncFunction for scala API

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672865#comment-16672865 ] ASF GitHub Bot commented on FLINK-10552: tillrohrmann commented on issue #6878:

[GitHub] tillrohrmann commented on issue #6878: [FLINK-10552][DataStream API]Add supports for RichAsyncFunction in Scala API

2018-11-02 Thread GitBox
tillrohrmann commented on issue #6878: [FLINK-10552][DataStream API]Add supports for RichAsyncFunction in Scala API URL: https://github.com/apache/flink/pull/6878#issuecomment-435332579 Thanks for opening this PR @Clark. We are currently in the release testing phase. Thus, I will need

[jira] [Commented] (FLINK-10715) E2e tests fail with ConcurrentModificationException in MetricRegistryImpl

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672864#comment-16672864 ] ASF GitHub Bot commented on FLINK-10715: kl0u commented on issue #6996: [FLINK-10715] Change

[GitHub] kl0u commented on issue #6996: [FLINK-10715] Change reporter log level

2018-11-02 Thread GitBox
kl0u commented on issue #6996: [FLINK-10715] Change reporter log level URL: https://github.com/apache/flink/pull/6996#issuecomment-435332294 The functionality can be valid but I am not sure if the attached JIRA is solved by this PR. Or at least the two do not seem to be related. This seems

[jira] [Commented] (FLINK-10715) E2e tests fail with ConcurrentModificationException in MetricRegistryImpl

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672857#comment-16672857 ] ASF GitHub Bot commented on FLINK-10715: tillrohrmann commented on issue #6996: [FLINK-10715]

[GitHub] tillrohrmann commented on issue #6996: [FLINK-10715] Change reporter log level

2018-11-02 Thread GitBox
tillrohrmann commented on issue #6996: [FLINK-10715] Change reporter log level URL: https://github.com/apache/flink/pull/6996#issuecomment-435330790 I think the PR fixes a valid problem which is the logging of a non-critical issue in a way that it seems to affect the proper functioning of

[jira] [Commented] (FLINK-10715) E2e tests fail with ConcurrentModificationException in MetricRegistryImpl

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672848#comment-16672848 ] ASF GitHub Bot commented on FLINK-10715: tillrohrmann commented on a change in pull request

[GitHub] tillrohrmann commented on a change in pull request #6996: [FLINK-10715] Change reporter log level

2018-11-02 Thread GitBox
tillrohrmann commented on a change in pull request #6996: [FLINK-10715] Change reporter log level URL: https://github.com/apache/flink/pull/6996#discussion_r230312915 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java ## @@

[GitHub] tillrohrmann commented on issue #6996: [FLINK-10715] Change reporter log level

2018-11-02 Thread GitBox
tillrohrmann commented on issue #6996: [FLINK-10715] Change reporter log level URL: https://github.com/apache/flink/pull/6996#issuecomment-435330002 Why did you close this PR @igalshilman? This is an automated message from

[jira] [Commented] (FLINK-10715) E2e tests fail with ConcurrentModificationException in MetricRegistryImpl

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672849#comment-16672849 ] ASF GitHub Bot commented on FLINK-10715: tillrohrmann commented on a change in pull request

[GitHub] tillrohrmann commented on a change in pull request #6996: [FLINK-10715] Change reporter log level

2018-11-02 Thread GitBox
tillrohrmann commented on a change in pull request #6996: [FLINK-10715] Change reporter log level URL: https://github.com/apache/flink/pull/6996#discussion_r230312787 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java ## @@

[jira] [Commented] (FLINK-10715) E2e tests fail with ConcurrentModificationException in MetricRegistryImpl

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672846#comment-16672846 ] ASF GitHub Bot commented on FLINK-10715: tillrohrmann commented on issue #6996: [FLINK-10715]

[jira] [Commented] (FLINK-10715) E2e tests fail with ConcurrentModificationException in MetricRegistryImpl

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672850#comment-16672850 ] ASF GitHub Bot commented on FLINK-10715: tillrohrmann commented on a change in pull request

[GitHub] tillrohrmann commented on a change in pull request #6996: [FLINK-10715] Change reporter log level

2018-11-02 Thread GitBox
tillrohrmann commented on a change in pull request #6996: [FLINK-10715] Change reporter log level URL: https://github.com/apache/flink/pull/6996#discussion_r230313024 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java ## @@

[jira] [Assigned] (FLINK-10191) WindowCheckpointingITCase.testAggregatingSlidingProcessingTimeWindow

2018-11-02 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz reassigned FLINK-10191: Assignee: Dawid Wysakowicz >

[jira] [Commented] (FLINK-10455) Potential Kafka producer leak in case of failures

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672828#comment-16672828 ] ASF GitHub Bot commented on FLINK-10455: azagrebin commented on issue #6989: [FLINK-10455][Kafka

[GitHub] azagrebin commented on issue #6989: [FLINK-10455][Kafka Tx] Close transactional producers in case of failure and termination

2018-11-02 Thread GitBox
azagrebin commented on issue #6989: [FLINK-10455][Kafka Tx] Close transactional producers in case of failure and termination URL: https://github.com/apache/flink/pull/6989#issuecomment-435324449 Yes, could be, I am looking into it.

[jira] [Commented] (FLINK-10715) E2e tests fail with ConcurrentModificationException in MetricRegistryImpl

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672815#comment-16672815 ] ASF GitHub Bot commented on FLINK-10715: igalshilman closed pull request #6996: [FLINK-10715]

[GitHub] igalshilman closed pull request #6996: [FLINK-10715] Change reporter log level

2018-11-02 Thread GitBox
igalshilman closed pull request #6996: [FLINK-10715] Change reporter log level URL: https://github.com/apache/flink/pull/6996 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[jira] [Commented] (FLINK-10455) Potential Kafka producer leak in case of failures

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672806#comment-16672806 ] ASF GitHub Bot commented on FLINK-10455: StefanRRichter commented on issue #6989:

[GitHub] StefanRRichter commented on issue #6989: [FLINK-10455][Kafka Tx] Close transactional producers in case of failure and termination

2018-11-02 Thread GitBox
StefanRRichter commented on issue #6989: [FLINK-10455][Kafka Tx] Close transactional producers in case of failure and termination URL: https://github.com/apache/flink/pull/6989#issuecomment-435316786 The travis build shows problems that look related to the PR.

[jira] [Commented] (FLINK-10689) Port UDFs in Table API extension points to flink-table-common

2018-11-02 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672801#comment-16672801 ] Timo Walther commented on FLINK-10689: -- This method must be removed from {{ScalaFunction}} but an

[jira] [Commented] (FLINK-10473) State TTL incremental cleanup using Heap backend key iterator

2018-11-02 Thread Andrey Zagrebin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672800#comment-16672800 ] Andrey Zagrebin commented on FLINK-10473: - Hi, I have added > State TTL incremental cleanup

[jira] [Updated] (FLINK-10473) State TTL incremental cleanup using Heap backend key iterator

2018-11-02 Thread Andrey Zagrebin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Zagrebin updated FLINK-10473: Description: This feature enables lazy background cleanup of state with time-to-live in

[GitHub] StefanRRichter commented on issue #6992: [FLINK-10747] Update SingleInputGate#requestedPartitionsFlag under lock

2018-11-02 Thread GitBox
StefanRRichter commented on issue #6992: [FLINK-10747] Update SingleInputGate#requestedPartitionsFlag under lock URL: https://github.com/apache/flink/pull/6992#issuecomment-435315473 Fix looks good to me  This is an

[jira] [Commented] (FLINK-10747) CoGroupConnectedComponentsITCase deadlocked on Travis

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672799#comment-16672799 ] ASF GitHub Bot commented on FLINK-10747: StefanRRichter commented on issue #6992: [FLINK-10747]

[jira] [Commented] (FLINK-10720) Add stress deployment end-to-end test

2018-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672792#comment-16672792 ] ASF GitHub Bot commented on FLINK-10720: StefanRRichter commented on issue #6994:

<    1   2   3   4   5   >