[jira] [Updated] (FLINK-11411) Failover regions number of RestartPipelinedRegionStrategy not show in LOG due to incorrect parameter

2019-01-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11411: --- Labels: pull-request-available (was: ) > Failover regions number of RestartPipelinedRegionS

[GitHub] eaglewatcherwb opened a new pull request #7561: [FLINK-11411][log] show correct failover region number

2019-01-22 Thread GitBox
eaglewatcherwb opened a new pull request #7561: [FLINK-11411][log] show correct failover region number URL: https://github.com/apache/flink/pull/7561 Change-Id: I118b7ea28d36edccbb3007fdf946b197b9f88865 ## What is the purpose of the change show correct failover region

[jira] [Created] (FLINK-11411) Failover regions number of RestartPipelinedRegionStrategy not show in LOG due to incorrect parameter

2019-01-22 Thread BoWang (JIRA)
BoWang created FLINK-11411: -- Summary: Failover regions number of RestartPipelinedRegionStrategy not show in LOG due to incorrect parameter Key: FLINK-11411 URL: https://issues.apache.org/jira/browse/FLINK-11411

[GitHub] eaglewatcherwb opened a new pull request #7560: [FLINK-11344][webfrontend] display all execution attempts on web

2019-01-22 Thread GitBox
eaglewatcherwb opened a new pull request #7560: [FLINK-11344][webfrontend] display all execution attempts on web URL: https://github.com/apache/flink/pull/7560 dashboard Change-Id: I859cf593ca567006778330b5a22f3b8af5acc965 ## What is the purpose of the change di

[GitHub] eaglewatcherwb closed pull request #7503: [FLINK-11344][webfrontend] display all execution attempts on web

2019-01-22 Thread GitBox
eaglewatcherwb closed pull request #7503: [FLINK-11344][webfrontend] display all execution attempts on web URL: https://github.com/apache/flink/pull/7503 This is an automated message from the Apache Git Service. To respond t

[jira] [Commented] (FLINK-11336) Flink HA didn't remove ZK metadata

2019-01-22 Thread shengjk1 (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749548#comment-16749548 ] shengjk1 commented on FLINK-11336: -- Yarn (per job or as a session) > Flink HA didn't r

[jira] [Comment Edited] (FLINK-11336) Flink HA didn't remove ZK metadata

2019-01-22 Thread shengjk1 (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749548#comment-16749548 ] shengjk1 edited comment on FLINK-11336 at 1/23/19 5:53 AM: --- Ya

[GitHub] zhijiangW commented on issue #7438: [FLINK-11282][network] Merge StreamRecordWriter into RecordWriter

2019-01-22 Thread GitBox
zhijiangW commented on issue #7438: [FLINK-11282][network] Merge StreamRecordWriter into RecordWriter URL: https://github.com/apache/flink/pull/7438#issuecomment-456673652 @pnowojski , I have updated the codes for addressing the comment. :)

[GitHub] zhijiangW commented on a change in pull request #7438: [FLINK-11282][network] Merge StreamRecordWriter into RecordWriter

2019-01-22 Thread GitBox
zhijiangW commented on a change in pull request #7438: [FLINK-11282][network] Merge StreamRecordWriter into RecordWriter URL: https://github.com/apache/flink/pull/7438#discussion_r250035752 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/bench

[GitHub] allenxwang commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers

2019-01-22 Thread GitBox
allenxwang commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers URL: https://github.com/apache/flink/pull/6615#discussion_r250026480 ## File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/

[GitHub] hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249800524 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] KurtYoung commented on a change in pull request #6873: [hotfix] Add Review Progress section to PR description template.

2019-01-22 Thread GitBox
KurtYoung commented on a change in pull request #6873: [hotfix] Add Review Progress section to PR description template. URL: https://github.com/apache/flink/pull/6873#discussion_r250022810 ## File path: .github/PULL_REQUEST_TEMPLATE.md ## @@ -70,3 +70,15 @@ This change add

[GitHub] tweise opened a new pull request #7559: [FLINK-11048] Mark new RemoteStreamEnvironment constructor PublicEvolving

2019-01-22 Thread GitBox
tweise opened a new pull request #7559: [FLINK-11048] Mark new RemoteStreamEnvironment constructor PublicEvolving URL: https://github.com/apache/flink/pull/7559 Trivial follow-up for #7249 to not lock down this constructor, in case we want to add any more settings. ## What i

[jira] [Closed] (FLINK-11410) Kubernetes Setup page gives incorrect url of Flink UI

2019-01-22 Thread Frank Huang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frank Huang closed FLINK-11410. --- Resolution: Invalid > Kubernetes Setup page gives incorrect url of Flink UI > --

[jira] [Commented] (FLINK-11402) User code can fail with an UnsatisfiedLinkError in the presence of multiple classloaders

2019-01-22 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749170#comment-16749170 ] Chesnay Schepler commented on FLINK-11402: -- [~uce] What happens if snappy-java

[GitHub] casidiablo opened a new pull request #7558: Fix typo in RocksDB error

2019-01-22 Thread GitBox
casidiablo opened a new pull request #7558: Fix typo in RocksDB error URL: https://github.com/apache/flink/pull/7558 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub an

[jira] [Created] (FLINK-11410) Kubernetes Setup page gives incorrect url of Flink UI

2019-01-22 Thread Frank Huang (JIRA)
Frank Huang created FLINK-11410: --- Summary: Kubernetes Setup page gives incorrect url of Flink UI Key: FLINK-11410 URL: https://issues.apache.org/jira/browse/FLINK-11410 Project: Flink Issue Typ

[jira] [Created] (FLINK-11409) Make `ProcessFunction`, `ProcessWindowFunction` and etc. pure interfaces

2019-01-22 Thread Kezhu Wang (JIRA)
Kezhu Wang created FLINK-11409: -- Summary: Make `ProcessFunction`, `ProcessWindowFunction` and etc. pure interfaces Key: FLINK-11409 URL: https://issues.apache.org/jira/browse/FLINK-11409 Project: Flink

[GitHub] TisonKun closed pull request #7528: [hotfix] [utils] Implement utils without cost of "enum"

2019-01-22 Thread GitBox
TisonKun closed pull request #7528: [hotfix] [utils] Implement utils without cost of "enum" URL: https://github.com/apache/flink/pull/7528 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] TisonKun commented on issue #7529: [hotfix] [blob] Generalize usage of NoOpTransientBlobService

2019-01-22 Thread GitBox
TisonKun commented on issue #7529: [hotfix] [blob] Generalize usage of NoOpTransientBlobService URL: https://github.com/apache/flink/pull/7529#issuecomment-456481455 @GJL alright we can defer such a `generalization` when we actually want to use it somewhere else. For using `enum` as a stra

[GitHub] TisonKun closed pull request #7529: [hotfix] [blob] Generalize usage of NoOpTransientBlobService

2019-01-22 Thread GitBox
TisonKun closed pull request #7529: [hotfix] [blob] Generalize usage of NoOpTransientBlobService URL: https://github.com/apache/flink/pull/7529 This is an automated message from the Apache Git Service. To respond to the mess

[jira] [Updated] (FLINK-11406) Return TypeSerializerSchemaCompatibility.incompatible() when arity of nested serializers don't match in CompositeTypeSerializerSnapshot's compatibility check

2019-01-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11406: --- Labels: pull-request-available (was: ) > Return TypeSerializerSchemaCompatibility.incompati

[GitHub] tzulitai opened a new pull request #7557: [FLINK-11406] [core] Return INCOMPATIBLE when nested serializers arity don't match in CompositeTypeSerializerSnapshot

2019-01-22 Thread GitBox
tzulitai opened a new pull request #7557: [FLINK-11406] [core] Return INCOMPATIBLE when nested serializers arity don't match in CompositeTypeSerializerSnapshot URL: https://github.com/apache/flink/pull/7557 ## What is the purpose of the change Right now, in `CompositeTypeSerializer

[GitHub] GJL edited a comment on issue #7529: [hotfix] [blob] Generalize usage of NoOpTransientBlobService

2019-01-22 Thread GitBox
GJL edited a comment on issue #7529: [hotfix] [blob] Generalize usage of NoOpTransientBlobService URL: https://github.com/apache/flink/pull/7529#issuecomment-456470455 Are you planning to use the `NoOpTransientBlobService` somewhere else? If not, I would not like to merge this PR. I find i

[GitHub] GJL commented on issue #7529: [hotfix] [blob] Generalize usage of NoOpTransientBlobService

2019-01-22 Thread GitBox
GJL commented on issue #7529: [hotfix] [blob] Generalize usage of NoOpTransientBlobService URL: https://github.com/apache/flink/pull/7529#issuecomment-456470455 Are you planning to use the `NoOpTransientBlobService` somewhere else? If not, I would not like to merge this PR. I find it hard

[GitHub] pnowojski edited a comment on issue #7405: [FLINK-11249] FlinkKafkaProducer011 can not be migrated to FlinkKafkaProducer

2019-01-22 Thread GitBox
pnowojski edited a comment on issue #7405: [FLINK-11249] FlinkKafkaProducer011 can not be migrated to FlinkKafkaProducer URL: https://github.com/apache/flink/pull/7405#issuecomment-456466692 Thanks for showing the interest @tvielgouarin in this topic! > But for migration tests of un

[GitHub] pnowojski edited a comment on issue #7405: [FLINK-11249] FlinkKafkaProducer011 can not be migrated to FlinkKafkaProducer

2019-01-22 Thread GitBox
pnowojski edited a comment on issue #7405: [FLINK-11249] FlinkKafkaProducer011 can not be migrated to FlinkKafkaProducer URL: https://github.com/apache/flink/pull/7405#issuecomment-456466692 Thanks for showing the interest @tvielgouarin in this topic! > But for migration tests of un

[GitHub] pnowojski commented on issue #7405: [FLINK-11249] FlinkKafkaProducer011 can not be migrated to FlinkKafkaProducer

2019-01-22 Thread GitBox
pnowojski commented on issue #7405: [FLINK-11249] FlinkKafkaProducer011 can not be migrated to FlinkKafkaProducer URL: https://github.com/apache/flink/pull/7405#issuecomment-456466692 Thanks for showing the interest @tvielgouarin in this topic! > But for migration tests of universal

[jira] [Created] (FLINK-11408) ContinuousProcessingTimeTrigger: NPE on clear() and state is lost on merge

2019-01-22 Thread Cristian (JIRA)
Cristian created FLINK-11408: Summary: ContinuousProcessingTimeTrigger: NPE on clear() and state is lost on merge Key: FLINK-11408 URL: https://issues.apache.org/jira/browse/FLINK-11408 Project: Flink

[GitHub] tzulitai commented on issue #7553: [FLINK-11328] [core] Migrate all parameterless serializers to use new serialization compatibility API

2019-01-22 Thread GitBox
tzulitai commented on issue #7553: [FLINK-11328] [core] Migrate all parameterless serializers to use new serialization compatibility API URL: https://github.com/apache/flink/pull/7553#issuecomment-456460449 Thanks! Will merge after Travis confirms green .. -

[jira] [Created] (FLINK-11407) Allow providing reason messages for TypeSerializerSchemaCompatibility.incompatible()

2019-01-22 Thread Tzu-Li (Gordon) Tai (JIRA)
Tzu-Li (Gordon) Tai created FLINK-11407: --- Summary: Allow providing reason messages for TypeSerializerSchemaCompatibility.incompatible() Key: FLINK-11407 URL: https://issues.apache.org/jira/browse/FLINK-11407

[GitHub] dawidwys commented on issue #7553: [FLINK-11328] [core] Migrate all parameterless serializers to use new serialization compatibility API

2019-01-22 Thread GitBox
dawidwys commented on issue #7553: [FLINK-11328] [core] Migrate all parameterless serializers to use new serialization compatibility API URL: https://github.com/apache/flink/pull/7553#issuecomment-456450150 Thanks @tzulitai for the update. It looks good for me now. +1 -

[jira] [Commented] (FLINK-11336) Flink HA didn't remove ZK metadata

2019-01-22 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748851#comment-16748851 ] Stephan Ewen commented on FLINK-11336: -- What way did you start Flink? - standalo

[jira] [Created] (FLINK-11406) Return TypeSerializerSchemaCompatibility.incompatible() when arity of nested serializers don't match in CompositeTypeSerializerSnapshot's compatibility check

2019-01-22 Thread Tzu-Li (Gordon) Tai (JIRA)
Tzu-Li (Gordon) Tai created FLINK-11406: --- Summary: Return TypeSerializerSchemaCompatibility.incompatible() when arity of nested serializers don't match in CompositeTypeSerializerSnapshot's compatibility check Key: FLINK-114

[GitHub] tzulitai commented on issue #7553: [FLINK-11328] [core] Migrate all parameterless serializers to use new serialization compatibility API

2019-01-22 Thread GitBox
tzulitai commented on issue #7553: [FLINK-11328] [core] Migrate all parameterless serializers to use new serialization compatibility API URL: https://github.com/apache/flink/pull/7553#issuecomment-456445785 @dawidwys I've addressed your comments in fixup commit 6c7a3fe. Could you take a

[GitHub] StephanEwen commented on a change in pull request #7313: [FLINK-11116][fs-connector] Removed randomness from HDFS and Local fs writers.

2019-01-22 Thread GitBox
StephanEwen commented on a change in pull request #7313: [FLINK-6][fs-connector] Removed randomness from HDFS and Local fs writers. URL: https://github.com/apache/flink/pull/7313#discussion_r249832214 ## File path: flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flin

[GitHub] azagrebin commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers

2019-01-22 Thread GitBox
azagrebin commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers URL: https://github.com/apache/flink/pull/6615#discussion_r249829200 ## File path: flink-connectors/flink-connector-kafka-0.8/src/main/java/org/ap

[GitHub] tvielgouarin edited a comment on issue #7405: [FLINK-11249] FlinkKafkaProducer011 can not be migrated to FlinkKafkaProducer

2019-01-22 Thread GitBox
tvielgouarin edited a comment on issue #7405: [FLINK-11249] FlinkKafkaProducer011 can not be migrated to FlinkKafkaProducer URL: https://github.com/apache/flink/pull/7405#issuecomment-456391275 hi @pnowojski , @yanghua , I come from @cjolif 's team and I am currently working on the imple

[GitHub] fhueske commented on issue #6873: [hotfix] Add Review Progress section to PR description template.

2019-01-22 Thread GitBox
fhueske commented on issue #6873: [hotfix] Add Review Progress section to PR description template. URL: https://github.com/apache/flink/pull/6873#issuecomment-456436978 Sorry, did not read your comment before I sent out the mail. You can just reply to the thread. Maybe, we can even leav

[GitHub] tvielgouarin edited a comment on issue #7405: [FLINK-11249] FlinkKafkaProducer011 can not be migrated to FlinkKafkaProducer

2019-01-22 Thread GitBox
tvielgouarin edited a comment on issue #7405: [FLINK-11249] FlinkKafkaProducer011 can not be migrated to FlinkKafkaProducer URL: https://github.com/apache/flink/pull/7405#issuecomment-456391275 hi @pnowojski , @yanghua , I come from @cjolif 's team and I am currently working on the imple

[GitHub] tvielgouarin edited a comment on issue #7405: [FLINK-11249] FlinkKafkaProducer011 can not be migrated to FlinkKafkaProducer

2019-01-22 Thread GitBox
tvielgouarin edited a comment on issue #7405: [FLINK-11249] FlinkKafkaProducer011 can not be migrated to FlinkKafkaProducer URL: https://github.com/apache/flink/pull/7405#issuecomment-456391275 hi @pnowojski , @yanghua , I come from @cjolif 's team and I am currently working on the imple

[jira] [Commented] (FLINK-11401) Allow compression on ParquetBulkWriter

2019-01-22 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748795#comment-16748795 ] Stephan Ewen commented on FLINK-11401: -- I can see that being useful. Please bear i

[GitHub] kezhuw opened a new pull request #7556: [hotfix][javadocs] Fix typos in javadoc

2019-01-22 Thread GitBox
kezhuw opened a new pull request #7556: [hotfix][javadocs] Fix typos in javadoc URL: https://github.com/apache/flink/pull/7556 Multiple typo fixes since I read Flink docs. This is an automated message from the Apache Git Servi

[GitHub] alexeyt820 commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers

2019-01-22 Thread GitBox
alexeyt820 commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers URL: https://github.com/apache/flink/pull/6615#discussion_r249798168 ## File path: flink-connectors/flink-connector-kafka-0.8/src/main/java/org/a

[GitHub] alexeyt820 commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers

2019-01-22 Thread GitBox
alexeyt820 commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers URL: https://github.com/apache/flink/pull/6615#discussion_r249798168 ## File path: flink-connectors/flink-connector-kafka-0.8/src/main/java/org/a

[GitHub] rmetzger commented on issue #6873: [hotfix] Add Review Progress section to PR description template.

2019-01-22 Thread GitBox
rmetzger commented on issue #6873: [hotfix] Add Review Progress section to PR description template. URL: https://github.com/apache/flink/pull/6873#issuecomment-456420688 Nice. I'm almost done with the bot (famous last words in software engineering). I might be able to finish it till tom

[GitHub] hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249801381 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249795484 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249800524 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249797875 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249795484 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] fhueske commented on issue #6873: [hotfix] Add Review Progress section to PR description template.

2019-01-22 Thread GitBox
fhueske commented on issue #6873: [hotfix] Add Review Progress section to PR description template. URL: https://github.com/apache/flink/pull/6873#issuecomment-456417079 I've updated the PR. Before merging I'll post to the dev mailing list to remind everybody about the upcoming chang

[GitHub] alexeyt820 commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers

2019-01-22 Thread GitBox
alexeyt820 commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers URL: https://github.com/apache/flink/pull/6615#discussion_r249798168 ## File path: flink-connectors/flink-connector-kafka-0.8/src/main/java/org/a

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249790833 ## File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/a

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249788943 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249790503 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249786791 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] GJL commented on a change in pull request #7524: [FLINK-11351][tests] Port JobManagerCleanupITCase to new code base

2019-01-22 Thread GitBox
GJL commented on a change in pull request #7524: [FLINK-11351][tests] Port JobManagerCleanupITCase to new code base URL: https://github.com/apache/flink/pull/7524#discussion_r249786009 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/BlobsCleanupITCase

[GitHub] alexeyt820 commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers

2019-01-22 Thread GitBox
alexeyt820 commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers URL: https://github.com/apache/flink/pull/6615#discussion_r249787929 ## File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/

[GitHub] dawidwys commented on issue #7553: [FLINK-11328] [core] Migrate all parameterless serializers to use new serialization compatibility API

2019-01-22 Thread GitBox
dawidwys commented on issue #7553: [FLINK-11328] [core] Migrate all parameterless serializers to use new serialization compatibility API URL: https://github.com/apache/flink/pull/7553#issuecomment-456406468 Hi @tzulitai I had a look just at the commit you linked. I've put some suggestions.

[GitHub] hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249770611 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249775473 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249775396 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] tvielgouarin edited a comment on issue #7405: [FLINK-11249] FlinkKafkaProducer011 can not be migrated to FlinkKafkaProducer

2019-01-22 Thread GitBox
tvielgouarin edited a comment on issue #7405: [FLINK-11249] FlinkKafkaProducer011 can not be migrated to FlinkKafkaProducer URL: https://github.com/apache/flink/pull/7405#issuecomment-456391275 hi @pnowojski , @yanghua , I come from @cjolif 's team and I am currently working on the imple

[GitHub] hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249770611 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] tvielgouarin commented on issue #7405: [FLINK-11249] FlinkKafkaProducer011 can not be migrated to FlinkKafkaProducer

2019-01-22 Thread GitBox
tvielgouarin commented on issue #7405: [FLINK-11249] FlinkKafkaProducer011 can not be migrated to FlinkKafkaProducer URL: https://github.com/apache/flink/pull/7405#issuecomment-456391275 hi @pnowojski , @yanghua , I come from @cjolif 's team and I am currently working on the implementati

[GitHub] hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249762211 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249760569 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249759883 ## File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/a

[jira] [Updated] (FLINK-11373) CliFrontend cuts off reason for error messages

2019-01-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11373: --- Labels: pull-request-available starter (was: starter) > CliFrontend cuts off reason for err

[GitHub] leesf opened a new pull request #7555: [FLINK-11373] CliFrontend cuts off reason for error messages

2019-01-22 Thread GitBox
leesf opened a new pull request #7555: [FLINK-11373] CliFrontend cuts off reason for error messages URL: https://github.com/apache/flink/pull/7555 ## What is the purpose of the change Show error message of CliArgsException in CliFrontend. ## Brief change log Cha

[GitHub] pnowojski commented on a change in pull request #7438: [FLINK-11282][network] Merge StreamRecordWriter into RecordWriter

2019-01-22 Thread GitBox
pnowojski commented on a change in pull request #7438: [FLINK-11282][network] Merge StreamRecordWriter into RecordWriter URL: https://github.com/apache/flink/pull/7438#discussion_r249741465 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/bench

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249726595 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249729097 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249729279 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249735236 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249728531 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249735123 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249729068 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249731317 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249728818 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249726595 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249727908 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249725951 ## File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/a

[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249728417 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[jira] [Updated] (FLINK-11357) Check and port LeaderChangeJobRecoveryTest to new code base if necessary

2019-01-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11357: --- Labels: pull-request-available (was: ) > Check and port LeaderChangeJobRecoveryTest to new

[GitHub] jinglining opened a new pull request #7554: [FLINK-11357][test]Check and port LeaderChangeJobRecoveryTest to new …

2019-01-22 Thread GitBox
jinglining opened a new pull request #7554: [FLINK-11357][test]Check and port LeaderChangeJobRecoveryTest to new … URL: https://github.com/apache/flink/pull/7554 ## What is the purpose of the change Port `LeaderChangeJobRecoveryTest` to new code base. See code this test is still nec

[GitHub] tzulitai commented on issue #7553: [FLINK-11328] [core] Migrate all parameterless serializers to use new serialization compatibility API

2019-01-22 Thread GitBox
tzulitai commented on issue #7553: [FLINK-11328] [core] Migrate all parameterless serializers to use new serialization compatibility API URL: https://github.com/apache/flink/pull/7553#issuecomment-456357940 @dawidwys Regarding the changes to the CEP serializers, could you take a look at

[jira] [Updated] (FLINK-11328) Migrate all parameterless serializers / TypeSerializerSingleton's to use new serializer snapshot abstractions

2019-01-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11328: --- Labels: pull-request-available (was: ) > Migrate all parameterless serializers / TypeSerial

[GitHub] tzulitai opened a new pull request #7553: [FLINK-11328] [core] Migrate all parameterless serializers to use new serialization compatibility API

2019-01-22 Thread GitBox
tzulitai opened a new pull request #7553: [FLINK-11328] [core] Migrate all parameterless serializers to use new serialization compatibility API URL: https://github.com/apache/flink/pull/7553 ## What is the purpose of the change This PR migrates all parameterless serializers (in Flink

[GitHub] GJL commented on issue #7486: [FLINK-11316] [tests] Drop JarFileCreator

2019-01-22 Thread GitBox
GJL commented on issue #7486: [FLINK-11316] [tests] Drop JarFileCreator URL: https://github.com/apache/flink/pull/7486#issuecomment-456354600 @aljoscha `ClassLoaderUtilsTest#testWithURLClassLoader` passes with Java 9. If you think this PR is fine, please merge. ---

[GitHub] GJL edited a comment on issue #7486: [FLINK-11316] [tests] Drop JarFileCreator

2019-01-22 Thread GitBox
GJL edited a comment on issue #7486: [FLINK-11316] [tests] Drop JarFileCreator URL: https://github.com/apache/flink/pull/7486#issuecomment-456354600 @aljoscha `ClassLoaderUtilsTest#testWithURLClassLoader` passes with Java 9 now. If you think this PR is fine, please merge.

[GitHub] hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-01-22 Thread GitBox
hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r249725255 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[GitHub] GJL commented on a change in pull request #7541: [FLINK-11356][tests] Port JobManagerStartupTest to new code base

2019-01-22 Thread GitBox
GJL commented on a change in pull request #7541: [FLINK-11356][tests] Port JobManagerStartupTest to new code base URL: https://github.com/apache/flink/pull/7541#discussion_r249718882 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobServerTest.java ##

[GitHub] GJL commented on a change in pull request #7541: [FLINK-11356][tests] Port JobManagerStartupTest to new code base

2019-01-22 Thread GitBox
GJL commented on a change in pull request #7541: [FLINK-11356][tests] Port JobManagerStartupTest to new code base URL: https://github.com/apache/flink/pull/7541#discussion_r249714551 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/BootstrapToolsT

[jira] [Commented] (FLINK-10819) The instability problem of CI, JobManagerHAProcessFailureRecoveryITCase.testDispatcherProcessFailure test fail.

2019-01-22 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748563#comment-16748563 ] Gary Yao commented on FLINK-10819: -- It happened again: https://api.travis-ci.org/v3/job

[GitHub] twalthr commented on issue #6445: [FLINK-8302] [table] Add SHIFT_LEFT and SHIFT_RIGHT

2019-01-22 Thread GitBox
twalthr commented on issue #6445: [FLINK-8302] [table] Add SHIFT_LEFT and SHIFT_RIGHT URL: https://github.com/apache/flink/pull/6445#issuecomment-456328423 Thanks for updating the PR @xueyumusic and @pnowojski. I will take a final look today and merge it if everything is ok. -

[jira] [Updated] (FLINK-11405) rest api can see task and task attempt exception by start end time filter

2019-01-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11405: --- Labels: pull-request-available (was: ) > rest api can see task and task attempt exception b

[jira] [Comment Edited] (FLINK-11374) See more failover and can filter by time range

2019-01-22 Thread lining (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748362#comment-16748362 ] lining edited comment on FLINK-11374 at 1/22/19 9:03 AM: - Hi, [~

[GitHub] jinglining opened a new pull request #7552: [FLINK-11405][rest]can see task and task attempt exception by start e…

2019-01-22 Thread GitBox
jinglining opened a new pull request #7552: [FLINK-11405][rest]can see task and task attempt exception by start e… URL: https://github.com/apache/flink/pull/7552 ## What is the purpose of the change - This pull request makes rest api JobExceptionsHandler can see more exception messa

  1   2   >