[GitHub] [flink] hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-11 Thread GitBox
hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274780674 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/expressions/Column

[GitHub] [flink] hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-11 Thread GitBox
hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274779381 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/expressions/Planne

[GitHub] [flink] hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-11 Thread GitBox
hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274779381 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/expressions/Planne

[jira] [Closed] (FLINK-12120) Support e2e SortAggregate and HashAggregate operator run in batch mode

2019-04-11 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-12120. -- Resolution: Fixed Fix Version/s: 1.9.0 fixed in 76841beb72eb095c3615653439effd43f3594a6f > Sup

[GitHub] [flink] KurtYoung merged pull request #8120: [FLINK-12120][table-planner-blink] Support e2e SortAggregate and HashAggregate operator run in batch mode

2019-04-11 Thread GitBox
KurtYoung merged pull request #8120: [FLINK-12120][table-planner-blink] Support e2e SortAggregate and HashAggregate operator run in batch mode URL: https://github.com/apache/flink/pull/8120 This is an automated message from

[GitHub] [flink] StefanRRichter commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-11 Thread GitBox
StefanRRichter commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#discussion_r274775151 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/netwo

[GitHub] [flink] hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-11 Thread GitBox
hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274774904 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/tableImpl.scal

[jira] [Commented] (FLINK-12113) User code passing to fromCollection(Iterator, Class) not cleaned

2019-04-11 Thread yankai zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816008#comment-16816008 ] yankai zhang commented on FLINK-12113: -- I'm not quite familiar with flink project d

[GitHub] [flink] hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-11 Thread GitBox
hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274773927 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/tableImpl.scal

[GitHub] [flink] wuchong commented on issue #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-11 Thread GitBox
wuchong commented on issue #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#issuecomment-482454071 Hi @sunjincheng121 , @xuefuz , @bowenli86 Regarding to the `listTables()`, I'm fine with current app

[GitHub] [flink] sunhaibotb commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-11 Thread GitBox
sunhaibotb commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#discussion_r274742418 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/p

[GitHub] [flink] hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-11 Thread GitBox
hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274752419 ## File path: docs/dev/table/functions.md ## @@ -5800,3 +5800,284 @@ For Table API, please us

[GitHub] [flink] bowenli86 commented on issue #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-11 Thread GitBox
bowenli86 commented on issue #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#issuecomment-482446954 Re Jark's comment, I agree with Jincheng. My point is that catalog APIs should be a super set of SQL, eac

[GitHub] [flink] yanghua commented on a change in pull request #7470: [FLINK-11283] Accessing the key when processing connected keyed stream

2019-04-11 Thread GitBox
yanghua commented on a change in pull request #7470: [FLINK-11283] Accessing the key when processing connected keyed stream URL: https://github.com/apache/flink/pull/7470#discussion_r274761831 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators

[GitHub] [flink] yanghua commented on a change in pull request #7470: [FLINK-11283] Accessing the key when processing connected keyed stream

2019-04-11 Thread GitBox
yanghua commented on a change in pull request #7470: [FLINK-11283] Accessing the key when processing connected keyed stream URL: https://github.com/apache/flink/pull/7470#discussion_r274761725 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions

[GitHub] [flink] sunhaibotb commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-11 Thread GitBox
sunhaibotb commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#discussion_r274757561 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/run

[GitHub] [flink] sunhaibotb commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-11 Thread GitBox
sunhaibotb commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#discussion_r274757561 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/run

[GitHub] [flink] sunjincheng121 commented on issue #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-11 Thread GitBox
sunjincheng121 commented on issue #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#issuecomment-482432502 Thank for the comments and reply @wuchong @dawidwys @xuefuz @bowenli86 :-) I agree that catal

[jira] [Commented] (FLINK-11107) [state] Avoid memory stateBackend to create arbitrary folders under HA path when no checkpoint path configured

2019-04-11 Thread Yun Tang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815949#comment-16815949 ] Yun Tang commented on FLINK-11107: -- [~ykt836] This is the issue which would created a l

[GitHub] [flink] hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-11 Thread GitBox
hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274752419 ## File path: docs/dev/table/functions.md ## @@ -5800,3 +5800,284 @@ For Table API, please us

[jira] [Commented] (FLINK-11619) Make ScheduleMode configurable via user code or configuration file

2019-04-11 Thread yuqi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815938#comment-16815938 ] yuqi commented on FLINK-11619: -- [~tianchen92] Right, in some scenario, Resource are very pr

[jira] [Closed] (FLINK-12140) Support e2e sort merge join operator in batch mode

2019-04-11 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-12140. -- Resolution: Fixed Fix Version/s: 1.9.0 fixed in c2e3bdc1f891c16682863c84cdc06528fa83b3f9 > Sup

[GitHub] [flink] KurtYoung merged pull request #8127: [FLINK-12140][table-planner-blink] Support e2e sort merge join operator in batch mode

2019-04-11 Thread GitBox
KurtYoung merged pull request #8127: [FLINK-12140][table-planner-blink] Support e2e sort merge join operator in batch mode URL: https://github.com/apache/flink/pull/8127 This is an automated message from the Apache Git Servi

[GitHub] [flink] yanghua commented on a change in pull request #7470: [FLINK-11283] Accessing the key when processing connected keyed stream

2019-04-11 Thread GitBox
yanghua commented on a change in pull request #7470: [FLINK-11283] Accessing the key when processing connected keyed stream URL: https://github.com/apache/flink/pull/7470#discussion_r274748632 ## File path: flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/SideOutpu

[GitHub] [flink] sunhaibotb commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-11 Thread GitBox
sunhaibotb commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#discussion_r274742831 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/p

[GitHub] [flink] sunhaibotb commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-11 Thread GitBox
sunhaibotb commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#discussion_r274742418 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/p

[jira] [Commented] (FLINK-12167) ClusterClient doesn't unset the context class loader after program run

2019-04-11 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815890#comment-16815890 ] vinoyang commented on FLINK-12167: -- [~zorro] Feel free to open a pr for this issue. I c

[jira] [Assigned] (FLINK-12167) ClusterClient doesn't unset the context class loader after program run

2019-04-11 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-12167: Assignee: (was: vinoyang) > ClusterClient doesn't unset the context class loader after progra

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-11 Thread GitBox
sunjincheng121 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274732538 ## File path: docs/dev/table/functions.md ## @@ -5800,3 +5800,284 @@ For Table API, plea

[GitHub] [flink] flinkbot commented on issue #8154: [Flink-12167] Reset context classloader in run and getOptimizedPlan methods

2019-04-11 Thread GitBox
flinkbot commented on issue #8154: [Flink-12167] Reset context classloader in run and getOptimizedPlan methods URL: https://github.com/apache/flink/pull/8154#issuecomment-482401577 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] zorro786 opened a new pull request #8154: [Flink-12167] Reset context classloader in run and getOptimizedPlan methods

2019-04-11 Thread GitBox
zorro786 opened a new pull request #8154: [Flink-12167] Reset context classloader in run and getOptimizedPlan methods URL: https://github.com/apache/flink/pull/8154 ## What is the purpose of the change This pull request fixes the bug where ClusterClient doesn't reset context cla

[jira] [Commented] (FLINK-12167) ClusterClient doesn't unset the context class loader after program run

2019-04-11 Thread Abdul Qadeer (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815887#comment-16815887 ] Abdul Qadeer commented on FLINK-12167: -- [~yanghua] Can you please assign it to me?

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-11 Thread GitBox
sunjincheng121 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274732538 ## File path: docs/dev/table/functions.md ## @@ -5800,3 +5800,284 @@ For Table API, plea

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi

2019-04-11 Thread GitBox
sunjincheng121 commented on a change in pull request #8087: [FLINK-12029][table] Add column operations for TableApi URL: https://github.com/apache/flink/pull/8087#discussion_r274732538 ## File path: docs/dev/table/functions.md ## @@ -5800,3 +5800,284 @@ For Table API, plea

[jira] [Assigned] (FLINK-12167) ClusterClient doesn't unset the context class loader after program run

2019-04-11 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-12167: Assignee: vinoyang > ClusterClient doesn't unset the context class loader after program run > ---

[jira] [Commented] (FLINK-11974) Introduce StreamOperatorSubstitutor to help table perform the whole Operator CodeGen

2019-04-11 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815885#comment-16815885 ] Kurt Young commented on FLINK-11974: [~pnowojski] Regarding to #1, my gut feeling i

[jira] [Created] (FLINK-12167) ClusterClient doesn't unset the context class loader after program run

2019-04-11 Thread Abdul Qadeer (JIRA)
Abdul Qadeer created FLINK-12167: Summary: ClusterClient doesn't unset the context class loader after program run Key: FLINK-12167 URL: https://issues.apache.org/jira/browse/FLINK-12167 Project: Flink

[jira] [Commented] (FLINK-2787) Prevent explicit use of RemoteEnvironment when running a job through the command line

2019-04-11 Thread Abdul Qadeer (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815881#comment-16815881 ] Abdul Qadeer commented on FLINK-2787: - [~StephanEwen] Is there a problem if RemoteEnv

[GitHub] [flink] flinkbot commented on issue #8153: Update metrics.md

2019-04-11 Thread GitBox
flinkbot commented on issue #8153: Update metrics.md URL: https://github.com/apache/flink/pull/8153#issuecomment-482310827 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to trac

[GitHub] [flink] kbohinski opened a new pull request #8153: Update metrics.md

2019-04-11 Thread GitBox
kbohinski opened a new pull request #8153: Update metrics.md URL: https://github.com/apache/flink/pull/8153 Small typo in docs This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Updated] (FLINK-12166) env.java.opts not taken into account on Windows

2019-04-11 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-12166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michał Jedynak updated FLINK-12166: --- Description: When flink cluster is started on Windows with start-cluster.bat any config in f

[jira] [Updated] (FLINK-12166) env.java.opts not taken into account on Windows

2019-04-11 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-12166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michał Jedynak updated FLINK-12166: --- Description: When flink cluster is started on Windows with start-cluster.bat any config in f

[jira] [Updated] (FLINK-12166) env.java.opts not taken into account on Windows

2019-04-11 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-12166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michał Jedynak updated FLINK-12166: --- Description: When flink cluster is started on Windows with start-cluster.bat any config in f

[jira] [Created] (FLINK-12166) env.java.opts not taken into account on Windows

2019-04-11 Thread JIRA
Michał Jedynak created FLINK-12166: -- Summary: env.java.opts not taken into account on Windows Key: FLINK-12166 URL: https://issues.apache.org/jira/browse/FLINK-12166 Project: Flink Issue Typ

[GitHub] [flink] xuefuz commented on issue #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-11 Thread GitBox
xuefuz commented on issue #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#issuecomment-482270351 > Sorry to jump into the discussion. I find this PR has been discussed for a few days and we have some diver

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-11 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r274576469 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-11 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r274574995 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-11 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r274575160 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-11 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r274572859 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/

[GitHub] [flink] xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other …

2019-04-11 Thread GitBox
xuefuz commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r274569242 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/

[jira] [Closed] (FLINK-12105) TUMBLE INTERVAL value errors out for 100 or more value

2019-04-11 Thread Vinod Mehra (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Mehra closed FLINK-12105. --- Resolution: Not A Bug Closing this as it works as designed. Good to know about the precisions. Thank

[jira] [Commented] (FLINK-11935) Remove DateTimeUtils pull-in and fix datetime casting problem

2019-04-11 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815625#comment-16815625 ] Julian Hyde commented on FLINK-11935: - I think you need to update your tests. Perhap

[GitHub] [flink] StefanRRichter commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-11 Thread GitBox
StefanRRichter commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#discussion_r274514210 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming

[GitHub] [flink] StefanRRichter commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-11 Thread GitBox
StefanRRichter commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#discussion_r274513851 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming

[GitHub] [flink] StefanRRichter commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-11 Thread GitBox
StefanRRichter commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#discussion_r274513130 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming

[GitHub] [flink] StefanRRichter commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-11 Thread GitBox
StefanRRichter commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#discussion_r274513217 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming

[GitHub] [flink] StefanRRichter commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-11 Thread GitBox
StefanRRichter commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#discussion_r274511867 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming

[GitHub] [flink] StefanRRichter commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-11 Thread GitBox
StefanRRichter commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#discussion_r274509343 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/netwo

[GitHub] [flink] StefanRRichter commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-11 Thread GitBox
StefanRRichter commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#discussion_r274509143 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/netwo

[GitHub] [flink] StefanRRichter commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-11 Thread GitBox
StefanRRichter commented on a change in pull request #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#discussion_r274505107 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming

[jira] [Commented] (FLINK-11974) Introduce StreamOperatorSubstitutor to help table perform the whole Operator CodeGen

2019-04-11 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815546#comment-16815546 ] Piotr Nowojski commented on FLINK-11974: Thanks for the more detailed explanatio

[jira] [Closed] (FLINK-12156) Remove legacy FlinkActor

2019-04-11 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-12156. Resolution: Fixed master: a2f59a1b8aadf46b564798c540b8a551cdbced54 > Remove legacy FlinkA

[jira] [Closed] (FLINK-12100) Kafka 0.10/0.11 tests fail on Java 9

2019-04-11 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-12100. Resolution: Fixed master: ed4a9e0adc3b827155bf0e4cbbc4e3e290d669d4 > Kafka 0.10/0.11 test

[jira] [Commented] (FLINK-11936) Remove AuxiliaryConverter pull-in from calcite and fix auxiliary converter issue.

2019-04-11 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815489#comment-16815489 ] Rong Rong commented on FLINK-11936: --- After some investigation. seems like our code is

[jira] [Closed] (FLINK-12157) Update maven download links to point to mvn central

2019-04-11 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-12157. Resolution: Fixed merged on asf-site in 353d738b9373709b7be33f698660da02993c921f > Update

[jira] [Closed] (FLINK-12151) Drop Elasticsearch 1 connector

2019-04-11 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-12151. Resolution: Fixed Release Note: The Elasticsearch 1 connector has been dropped and wi

[jira] [Assigned] (FLINK-12102) FlinkILoopTest fails on Java 9

2019-04-11 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-12102: Assignee: Chesnay Schepler (was: Liya Fan) > FlinkILoopTest fails on Java 9 > --

[GitHub] [flink] flinkbot commented on issue #8152: [FLINK-11761] Update FlinkKafkaConsumerBaseMigrationTest for 1.8

2019-04-11 Thread GitBox
flinkbot commented on issue #8152: [FLINK-11761] Update FlinkKafkaConsumerBaseMigrationTest for 1.8 URL: https://github.com/apache/flink/pull/8152#issuecomment-482103362 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review you

[jira] [Updated] (FLINK-11761) Update FlinkKafkaConsumerBaseMigrationTest for 1.8

2019-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11761: --- Labels: pull-request-available (was: ) > Update FlinkKafkaConsumerBaseMigrationTest for 1.8

[GitHub] [flink] yanghua opened a new pull request #8152: [FLINK-11761] Update FlinkKafkaConsumerBaseMigrationTest for 1.8

2019-04-11 Thread GitBox
yanghua opened a new pull request #8152: [FLINK-11761] Update FlinkKafkaConsumerBaseMigrationTest for 1.8 URL: https://github.com/apache/flink/pull/8152 ## What is the purpose of the change *This pull request updates FlinkKafkaConsumerBaseMigrationTest for 1.8* ## Brie

[GitHub] [flink] dawidwys commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces

2019-04-11 Thread GitBox
dawidwys commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces URL: https://github.com/apache/flink/pull/8050#discussion_r274406998 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/rules/dat

[GitHub] [flink] dawidwys commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces

2019-04-11 Thread GitBox
dawidwys commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces URL: https://github.com/apache/flink/pull/8050#discussion_r274406052 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableConfi

[GitHub] [flink] dawidwys commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces

2019-04-11 Thread GitBox
dawidwys commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces URL: https://github.com/apache/flink/pull/8050#discussion_r274383474 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/calcite/Defaul

[GitHub] [flink] dawidwys commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces

2019-04-11 Thread GitBox
dawidwys commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces URL: https://github.com/apache/flink/pull/8050#discussion_r274402496 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/calcite/Defaul

[GitHub] [flink] dawidwys commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces

2019-04-11 Thread GitBox
dawidwys commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces URL: https://github.com/apache/flink/pull/8050#discussion_r274405374 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/PlannerCon

[GitHub] [flink] dawidwys commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces

2019-04-11 Thread GitBox
dawidwys commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces URL: https://github.com/apache/flink/pull/8050#discussion_r274405907 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableConfi

[jira] [Assigned] (FLINK-12130) Apply command line options to configuration before installing security modules

2019-04-11 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reassigned FLINK-12130: Assignee: Victor Wong > Apply command line options to configuration before instal

[jira] [Commented] (FLINK-12130) Apply command line options to configuration before installing security modules

2019-04-11 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815395#comment-16815395 ] Aljoscha Krettek commented on FLINK-12130: -- [~victor-wong] Yes, please do that.

[GitHub] [flink] flinkbot commented on issue #8151: [FLINK-12102][tests] Fix FlinkILoopTest on Java 9

2019-04-11 Thread GitBox
flinkbot commented on issue #8151: [FLINK-12102][tests] Fix FlinkILoopTest on Java 9 URL: https://github.com/apache/flink/pull/8151#issuecomment-482096964 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request.

[jira] [Updated] (FLINK-12102) FlinkILoopTest fails on Java 9

2019-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12102: --- Labels: pull-request-available (was: ) > FlinkILoopTest fails on Java 9 > -

[GitHub] [flink] zentol opened a new pull request #8151: [FLINK-12102][tests] Fix FlinkILoopTest on Java 9

2019-04-11 Thread GitBox
zentol opened a new pull request #8151: [FLINK-12102][tests] Fix FlinkILoopTest on Java 9 URL: https://github.com/apache/flink/pull/8151 ## What is the purpose of the change Fixes an issue in the FlinkILoopTest where the test failed on Java 9. From my understanding, powermock

[jira] [Commented] (FLINK-11813) Standby per job mode Dispatchers don't know job's JobSchedulingStatus

2019-04-11 Thread Zhu Zhu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815380#comment-16815380 ] Zhu Zhu commented on FLINK-11813: - Thanks Till for the very detailed explanation. With c

[GitHub] [flink] StefanRRichter edited a comment on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-11 Thread GitBox
StefanRRichter edited a comment on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#issuecomment-482094384 You can rebase this branch on the branch of your previous PR, force push the rebased branch wi

[GitHub] [flink] StefanRRichter commented on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-11 Thread GitBox
StefanRRichter commented on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#issuecomment-482094384 You can rebase this branch on the branch of your previous PR, force push the rebased branch with all

[jira] [Updated] (FLINK-12131) Resetting ExecutionVertex in region failover may cause inconsistency of IntermediateResult status

2019-04-11 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-12131: -- Issue Type: Sub-task (was: Bug) Parent: FLINK-4256 > Resetting ExecutionVertex in reg

[jira] [Commented] (FLINK-12131) Resetting ExecutionVertex in region failover may cause inconsistency of IntermediateResult status

2019-04-11 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815375#comment-16815375 ] Till Rohrmann commented on FLINK-12131: --- Thanks for reporting this issue [~zhuzh].

[jira] [Commented] (FLINK-11974) Introduce StreamOperatorSubstitutor to help table perform the whole Operator CodeGen

2019-04-11 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815374#comment-16815374 ] Kurt Young commented on FLINK-11974: Yeah, you are right, I forgot that we change th

[jira] [Commented] (FLINK-11159) Allow configuration whether to fall back to savepoints for restore

2019-04-11 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815368#comment-16815368 ] Stephan Ewen commented on FLINK-11159: -- There has been a separate discussion whethe

[jira] [Commented] (FLINK-9542) ExEnv#registerCachedFile should accept Path

2019-04-11 Thread Ji Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815362#comment-16815362 ] Ji Liu commented on FLINK-9542: --- [~Zentol] Is this issue still open? I quickly looked into

[jira] [Commented] (FLINK-12162) Build error in flink-table-planner

2019-04-11 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815361#comment-16815361 ] Liya Fan commented on FLINK-12162: -- Hi [~dawidwys], thanks for your comments. This prob

[GitHub] [flink] sunhaibotb edited a comment on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-11 Thread GitBox
sunhaibotb edited a comment on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#issuecomment-482072413 Oh, I didn't know that before. How can I do that now? Let this PR rebase the previous pull reques

[jira] [Comment Edited] (FLINK-11974) Introduce StreamOperatorSubstitutor to help table perform the whole Operator CodeGen

2019-04-11 Thread Jingsong Lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815329#comment-16815329 ] Jingsong Lee edited comment on FLINK-11974 at 4/11/19 11:22 AM: --

[GitHub] [flink] sunhaibotb edited a comment on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-11 Thread GitBox
sunhaibotb edited a comment on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#issuecomment-482072413 Oh, I didn't know that before. How can I do that now? @StefanRRichter --

[GitHub] [flink] sunhaibotb edited a comment on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-11 Thread GitBox
sunhaibotb edited a comment on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#issuecomment-482072413 I didn't know that before. How can I do that now? @StefanRRichter --

[jira] [Commented] (FLINK-11974) Introduce StreamOperatorSubstitutor to help table perform the whole Operator CodeGen

2019-04-11 Thread Jingsong Lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815329#comment-16815329 ] Jingsong Lee commented on FLINK-11974: -- [~ykt836] StreamOperator needs to be wrappe

[GitHub] [flink] sunhaibotb commented on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-11 Thread GitBox
sunhaibotb commented on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#issuecomment-482072413 I didn't know that before. How can I do that now? --

[jira] [Commented] (FLINK-11974) Introduce StreamOperatorSubstitutor to help table perform the whole Operator CodeGen

2019-04-11 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815323#comment-16815323 ] Kurt Young commented on FLINK-11974: [~lzljs3620320] In you second example, OneInput

[GitHub] [flink] liyafan82 commented on issue #8150: [FLINK-12162][Table SQL]Fix build error in flink-table-planner

2019-04-11 Thread GitBox
liyafan82 commented on issue #8150: [FLINK-12162][Table SQL]Fix build error in flink-table-planner URL: https://github.com/apache/flink/pull/8150#issuecomment-482064425 > -1, it works both for me locally and in travis. Also this change does not make much sense for me. It might be some bug

[GitHub] [flink] StefanRRichter commented on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-11 Thread GitBox
StefanRRichter commented on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#issuecomment-482062487 In that case, why not have this PR sit on top of your previous PR? You can do that even if it is not

[GitHub] [flink] sunhaibotb edited a comment on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-04-11 Thread GitBox
sunhaibotb edited a comment on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#issuecomment-482060191 > @sunhaibotb this PR has dependency problems that need to be resolved first. This also makes the

  1   2   >