[GitHub] [flink] dianfu commented on a change in pull request #8474: [FLINK-12409][python] Adds from_elements in TableEnvironment

2019-05-28 Thread GitBox
dianfu commented on a change in pull request #8474: [FLINK-12409][python] Adds from_elements in TableEnvironment URL: https://github.com/apache/flink/pull/8474#discussion_r288399465 ## File path: flink-python/pyflink/table/table_environment.py ## @@ -379,13 +383,97 @@ def

[GitHub] [flink] dianfu commented on a change in pull request #8474: [FLINK-12409][python] Adds from_elements in TableEnvironment

2019-05-28 Thread GitBox
dianfu commented on a change in pull request #8474: [FLINK-12409][python] Adds from_elements in TableEnvironment URL: https://github.com/apache/flink/pull/8474#discussion_r288398143 ## File path: flink-python/pyflink/table/table_environment.py ## @@ -379,13 +383,97 @@ def

[GitHub] [flink] lirui-apache commented on issue #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables

2019-05-28 Thread GitBox
lirui-apache commented on issue #8536: [FLINK-12568][hive] Implement OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#issuecomment-496789599 I have removed the TableSink implementation and updated unit test accordingly. @KurtYoung @xuefuz @bowenli86

[jira] [Comment Edited] (FLINK-12568) Implement OutputFormat to write Hive tables

2019-05-28 Thread Rui Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850513#comment-16850513 ] Rui Li edited comment on FLINK-12568 at 5/29/19 5:22 AM: - Since

[jira] [Created] (FLINK-12664) Implement TableSink to write Hive tables

2019-05-28 Thread Rui Li (JIRA)
Rui Li created FLINK-12664: -- Summary: Implement TableSink to write Hive tables Key: FLINK-12664 URL: https://issues.apache.org/jira/browse/FLINK-12664 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-12568) Implement OutputFormat to write Hive tables

2019-05-28 Thread Rui Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850513#comment-16850513 ] Rui Li commented on FLINK-12568: Since {{BatchTableSink}} interface hasn't been finalized, we have

[jira] [Updated] (FLINK-12568) Implement OutputFormat to write Hive tables

2019-05-28 Thread Rui Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Li updated FLINK-12568: --- Summary: Implement OutputFormat to write Hive tables (was: Implement TableSink and OutputFormat to write

[jira] [Commented] (FLINK-11947) Support MapState key / value schema evolution for RocksDB

2019-05-28 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850506#comment-16850506 ] Tzu-Li (Gordon) Tai commented on FLINK-11947: - Thanks Congxian! I've assigned you to this

[jira] [Assigned] (FLINK-11947) Support MapState key / value schema evolution for RocksDB

2019-05-28 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai reassigned FLINK-11947: --- Assignee: Congxian Qiu(klion26) > Support MapState key / value schema

[jira] [Updated] (FLINK-11947) Support MapState value schema evolution for RocksDB

2019-05-28 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-11947: Summary: Support MapState value schema evolution for RocksDB (was: Support

[jira] [Commented] (FLINK-11947) Support MapState key / value schema evolution for RocksDB

2019-05-28 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850497#comment-16850497 ] Congxian Qiu(klion26) commented on FLINK-11947: --- [~cresny] I'm interested in this issue,

[jira] [Commented] (FLINK-12296) Data loss silently in RocksDBStateBackend when more than one operator(has states) chained in a single task

2019-05-28 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850490#comment-16850490 ] Congxian Qiu(klion26) commented on FLINK-12296: --- Thanks for the reminder [~sunjincheng121]

[GitHub] [flink] zhijiangW commented on a change in pull request #7549: [FLINK-11403][network] Introduce ResultPartitionWithConsumableNotifier in task for notifying consumable result partition

2019-05-28 Thread GitBox
zhijiangW commented on a change in pull request #7549: [FLINK-11403][network] Introduce ResultPartitionWithConsumableNotifier in task for notifying consumable result partition URL: https://github.com/apache/flink/pull/7549#discussion_r288389643 ## File path:

[GitHub] [flink] zhijiangW edited a comment on issue #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods

2019-05-28 Thread GitBox
zhijiangW edited a comment on issue #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods URL: https://github.com/apache/flink/pull/8529#issuecomment-496776930 Thanks for the reviews and good suggestions @azagrebin ! Yes, we still rely on some

[GitHub] [flink] zhijiangW commented on issue #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods

2019-05-28 Thread GitBox
zhijiangW commented on issue #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods URL: https://github.com/apache/flink/pull/8529#issuecomment-496776930 Thanks for the reviews and good suggestions @azagrebin ! Yes, we still rely on some network

[GitHub] [flink] liyafan82 commented on issue #8408: [FLINK-12223][Runtime]HeapMemorySegment.getArray should return null a…

2019-05-28 Thread GitBox
liyafan82 commented on issue #8408: [FLINK-12223][Runtime]HeapMemorySegment.getArray should return null a… URL: https://github.com/apache/flink/pull/8408#issuecomment-496774101 Hi @zentol , would you please take a look at this PR?

[GitHub] [flink] tweise commented on a change in pull request #8517: [FLINK-10921] [kinesis] Shard watermark synchronization in Kinesis consumer

2019-05-28 Thread GitBox
tweise commented on a change in pull request #8517: [FLINK-10921] [kinesis] Shard watermark synchronization in Kinesis consumer URL: https://github.com/apache/flink/pull/8517#discussion_r288382291 ## File path:

[jira] [Assigned] (FLINK-12237) Support Hive table stats related operations in HiveCatalog

2019-05-28 Thread zjuwangg (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zjuwangg reassigned FLINK-12237: Assignee: zjuwangg > Support Hive table stats related operations in HiveCatalog >

[jira] [Commented] (FLINK-12296) Data loss silently in RocksDBStateBackend when more than one operator(has states) chained in a single task

2019-05-28 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850421#comment-16850421 ] sunjincheng commented on FLINK-12296: - Thanks for double check this JIRA, and close it. :) > Data

[GitHub] [flink] zhijiangW commented on a change in pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods

2019-05-28 Thread GitBox
zhijiangW commented on a change in pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods URL: https://github.com/apache/flink/pull/8529#discussion_r288380985 ## File path:

[GitHub] [flink] zhuzhurk commented on a change in pull request #8498: [FLINK-12413] [runtime] Implement ExecutionFailureHandler

2019-05-28 Thread GitBox
zhuzhurk commented on a change in pull request #8498: [FLINK-12413] [runtime] Implement ExecutionFailureHandler URL: https://github.com/apache/flink/pull/8498#discussion_r287908868 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods

2019-05-28 Thread GitBox
zhijiangW commented on a change in pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods URL: https://github.com/apache/flink/pull/8529#discussion_r288375567 ## File path:

[jira] [Updated] (FLINK-12572) Implement HiveInputFormat to read Hive tables

2019-05-28 Thread zjuwangg (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zjuwangg updated FLINK-12572: - Summary: Implement HiveInputFormat to read Hive tables (was: Implement TableSource and InputFormat to

[GitHub] [flink] sunhaibotb commented on issue #8484: [FLINK-12547] Add connection and socket timeouts for the blob client

2019-05-28 Thread GitBox
sunhaibotb commented on issue #8484: [FLINK-12547] Add connection and socket timeouts for the blob client URL: https://github.com/apache/flink/pull/8484#issuecomment-496761878 Two timeout defaults have been modified. Please check them, thanks. @tillrohrmann

[jira] [Created] (FLINK-12663) Implement HiveTableSource to read Hive tables

2019-05-28 Thread zjuwangg (JIRA)
zjuwangg created FLINK-12663: Summary: Implement HiveTableSource to read Hive tables Key: FLINK-12663 URL: https://issues.apache.org/jira/browse/FLINK-12663 Project: Flink Issue Type: Sub-task

[jira] [Assigned] (FLINK-12663) Implement HiveTableSource to read Hive tables

2019-05-28 Thread zjuwangg (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zjuwangg reassigned FLINK-12663: Assignee: zjuwangg > Implement HiveTableSource to read Hive tables >

[jira] [Comment Edited] (FLINK-12296) Data loss silently in RocksDBStateBackend when more than one operator(has states) chained in a single task

2019-05-28 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850320#comment-16850320 ] Congxian Qiu(klion26) edited comment on FLINK-12296 at 5/29/19 2:42 AM:

[jira] [Resolved] (FLINK-12296) Data loss silently in RocksDBStateBackend when more than one operator(has states) chained in a single task

2019-05-28 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Congxian Qiu(klion26) resolved FLINK-12296. --- Resolution: Fixed Since the commits have been merged in master,

[GitHub] [flink] zjuwangg commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables

2019-05-28 Thread GitBox
zjuwangg commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r288372767 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -58,6

[jira] [Closed] (FLINK-9172) Support catalogs in SQL-Client yaml config file

2019-05-28 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-9172. --- Resolution: Fixed Fix Version/s: 1.9.0 merged in 1.9.0: d3e5bf69c3d3f105c1ebe7c46bd4a74e5407137f >

[jira] [Assigned] (FLINK-12583) Add all format support align with the Java Table API

2019-05-28 Thread Wei Zhong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zhong reassigned FLINK-12583: - Assignee: Wei Zhong > Add all format support align with the Java Table API >

[GitHub] [flink] bowenli86 closed pull request #7393: [FLINK-9172][table][sql-client] - Support external catalogs in SQL-Client

2019-05-28 Thread GitBox
bowenli86 closed pull request #7393: [FLINK-9172][table][sql-client] - Support external catalogs in SQL-Client URL: https://github.com/apache/flink/pull/7393 This is an automated message from the Apache Git Service. To

[GitHub] [flink] zhijiangW commented on a change in pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods

2019-05-28 Thread GitBox
zhijiangW commented on a change in pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods URL: https://github.com/apache/flink/pull/8529#discussion_r288370752 ## File path:

[jira] [Comment Edited] (FLINK-12662) Flink how jobs for failover in history server as well

2019-05-28 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850308#comment-16850308 ] vinoyang edited comment on FLINK-12662 at 5/29/19 2:20 AM: --- I think this

[jira] [Commented] (FLINK-12662) Flink how jobs for failover in history server as well

2019-05-28 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850308#comment-16850308 ] vinoyang commented on FLINK-12662: -- I think this proposal is valuable. > Flink how jobs for failover

[GitHub] [flink] zhijiangW commented on issue #8496: [FLINK-12571][network] Make NetworkEnvironment#start() return the binded data port

2019-05-28 Thread GitBox
zhijiangW commented on issue #8496: [FLINK-12571][network] Make NetworkEnvironment#start() return the binded data port URL: https://github.com/apache/flink/pull/8496#issuecomment-496757292 Thanks for reviews @azagrebin ! I pushed the fixup commit for adding doc comments and also

[jira] [Commented] (FLINK-12620) Deadlock in task deserialization

2019-05-28 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850307#comment-16850307 ] Liya Fan commented on FLINK-12620: -- [~mikekap], thanks for the clarification. Would you please give

[GitHub] [flink] dianfu commented on issue #8474: [FLINK-12409][python] Adds from_elements in TableEnvironment

2019-05-28 Thread GitBox
dianfu commented on issue #8474: [FLINK-12409][python] Adds from_elements in TableEnvironment URL: https://github.com/apache/flink/pull/8474#issuecomment-496756510 Sounds good. I will rebase the PR. This is an automated

[GitHub] [flink] sunjincheng121 commented on issue #8474: [FLINK-12409][python] Adds from_elements in TableEnvironment

2019-05-28 Thread GitBox
sunjincheng121 commented on issue #8474: [FLINK-12409][python] Adds from_elements in TableEnvironment URL: https://github.com/apache/flink/pull/8474#issuecomment-496754379 Thanks for the reply @aljoscha! As we(@aljoscha @dianfu and me) discussed offline, we got a consistent

[GitHub] [flink] sunjincheng121 commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API

2019-05-28 Thread GitBox
sunjincheng121 commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API URL: https://github.com/apache/flink/pull/8532#issuecomment-496751857 @flinkbot attention @tillrohrmann @zentol

[jira] [Created] (FLINK-12662) Flink how jobs for failover in history server as well

2019-05-28 Thread Su Ralph (JIRA)
Su Ralph created FLINK-12662: Summary: Flink how jobs for failover in history server as well Key: FLINK-12662 URL: https://issues.apache.org/jira/browse/FLINK-12662 Project: Flink Issue Type:

[GitHub] [flink] tweise commented on a change in pull request #8517: [FLINK-10921] [kinesis] Shard watermark synchronization in Kinesis consumer

2019-05-28 Thread GitBox
tweise commented on a change in pull request #8517: [FLINK-10921] [kinesis] Shard watermark synchronization in Kinesis consumer URL: https://github.com/apache/flink/pull/8517#discussion_r288360078 ## File path:

[GitHub] [flink] asfgit closed pull request #8541: [FLINK-9172][sql-client] Support catalogs in SQL-Client yaml config file

2019-05-28 Thread GitBox
asfgit closed pull request #8541: [FLINK-9172][sql-client] Support catalogs in SQL-Client yaml config file URL: https://github.com/apache/flink/pull/8541 This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] bowenli86 commented on issue #8541: [FLINK-9172][sql-client] Support catalogs in SQL-Client yaml config file

2019-05-28 Thread GitBox
bowenli86 commented on issue #8541: [FLINK-9172][sql-client] Support catalogs in SQL-Client yaml config file URL: https://github.com/apache/flink/pull/8541#issuecomment-496715854 The CI failure is due to flink-runtime is broken. Merging

[jira] [Created] (FLINK-12661) test failure: RestAPIStabilityTest.testDispatcherRestAPIStability

2019-05-28 Thread Bowen Li (JIRA)
Bowen Li created FLINK-12661: Summary: test failure: RestAPIStabilityTest.testDispatcherRestAPIStability Key: FLINK-12661 URL: https://issues.apache.org/jira/browse/FLINK-12661 Project: Flink

[jira] [Commented] (FLINK-12620) Deadlock in task deserialization

2019-05-28 Thread Mike Kaplinskiy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850165#comment-16850165 ] Mike Kaplinskiy commented on FLINK-12620: - With the patch, I'm expecting class initialization to

[GitHub] [flink] tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment

2019-05-28 Thread GitBox
tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463#discussion_r288287665 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment

2019-05-28 Thread GitBox
tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463#discussion_r288290783 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment

2019-05-28 Thread GitBox
tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463#discussion_r288283528 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment

2019-05-28 Thread GitBox
tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463#discussion_r288288062 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment

2019-05-28 Thread GitBox
tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463#discussion_r288283226 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment

2019-05-28 Thread GitBox
tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463#discussion_r288287374 ## File path:

[GitHub] [flink] walterddr edited a comment on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-05-28 Thread GitBox
walterddr edited a comment on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#issuecomment-496663881 @danny0405 hmm. I think that's probably a good idea Considering the light-weighted changes I did for this PR. I suggest we

[GitHub] [flink] walterddr commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-05-28 Thread GitBox
walterddr commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#issuecomment-496663881 @danny0405 hmm. I think that's probably a good idea Considering the light-weighted changes I did for this PR. I suggest we commit

[GitHub] [flink] 1u0 commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox)

2019-05-28 Thread GitBox
1u0 commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox) URL: https://github.com/apache/flink/pull/8523#discussion_r288273753 ## File path:

[jira] [Closed] (FLINK-12418) Add input/output format and SerDeLib information when creating Hive table in HiveCatalog

2019-05-28 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-12418. Resolution: Fixed merged in 1.9.0: 97510aaa8444895a0cc4df7461889fb66d5ffc01 > Add input/output format

[GitHub] [flink] 1u0 commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox)

2019-05-28 Thread GitBox
1u0 commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox) URL: https://github.com/apache/flink/pull/8523#discussion_r288254960 ## File path:

[GitHub] [flink] 1u0 commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox)

2019-05-28 Thread GitBox
1u0 commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox) URL: https://github.com/apache/flink/pull/8523#discussion_r288258556 ## File path:

[GitHub] [flink] 1u0 commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox)

2019-05-28 Thread GitBox
1u0 commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox) URL: https://github.com/apache/flink/pull/8523#discussion_r288242715 ## File path:

[GitHub] [flink] 1u0 commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox)

2019-05-28 Thread GitBox
1u0 commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox) URL: https://github.com/apache/flink/pull/8523#discussion_r288254960 ## File path:

[jira] [Commented] (FLINK-9050) Expose operator IO counter metrics

2019-05-28 Thread Fabian Wollert (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850033#comment-16850033 ] Fabian Wollert commented on FLINK-9050: --- any updates on this? > Expose operator IO counter metrics

[jira] [Comment Edited] (FLINK-10707) Improve Cluster Overview in Flink Dashboard

2019-05-28 Thread Fabian Wollert (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850022#comment-16850022 ] Fabian Wollert edited comment on FLINK-10707 at 5/28/19 6:47 PM: -

[jira] [Comment Edited] (FLINK-10707) Improve Cluster Overview in Flink Dashboard

2019-05-28 Thread Fabian Wollert (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850022#comment-16850022 ] Fabian Wollert edited comment on FLINK-10707 at 5/28/19 6:46 PM: -

[jira] [Comment Edited] (FLINK-10707) Improve Cluster Overview in Flink Dashboard

2019-05-28 Thread Fabian Wollert (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850022#comment-16850022 ] Fabian Wollert edited comment on FLINK-10707 at 5/28/19 6:41 PM: - okay,

[jira] [Comment Edited] (FLINK-10707) Improve Cluster Overview in Flink Dashboard

2019-05-28 Thread Fabian Wollert (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850022#comment-16850022 ] Fabian Wollert edited comment on FLINK-10707 at 5/28/19 6:40 PM: - okay,

[jira] [Comment Edited] (FLINK-10707) Improve Cluster Overview in Flink Dashboard

2019-05-28 Thread Fabian Wollert (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850022#comment-16850022 ] Fabian Wollert edited comment on FLINK-10707 at 5/28/19 6:40 PM: - okay,

[jira] [Comment Edited] (FLINK-10707) Improve Cluster Overview in Flink Dashboard

2019-05-28 Thread Fabian Wollert (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850022#comment-16850022 ] Fabian Wollert edited comment on FLINK-10707 at 5/28/19 6:40 PM: - okay,

[jira] [Commented] (FLINK-10707) Improve Cluster Overview in Flink Dashboard

2019-05-28 Thread Fabian Wollert (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850022#comment-16850022 ] Fabian Wollert commented on FLINK-10707: okay, i got the code now to show what i wanted:      

[jira] [Updated] (FLINK-10707) Improve Cluster Overview in Flink Dashboard

2019-05-28 Thread Fabian Wollert (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Wollert updated FLINK-10707: --- Attachment: image-2019-05-28-20-38-00-761.png > Improve Cluster Overview in Flink Dashboard

[GitHub] [flink] xuefuz commented on a change in pull request #8548: [FLINK-6962] [table] Add a create table SQL DDL

2019-05-28 Thread GitBox
xuefuz commented on a change in pull request #8548: [FLINK-6962] [table] Add a create table SQL DDL URL: https://github.com/apache/flink/pull/8548#discussion_r288246045 ## File path: flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl ## @@ -0,0 +1,347

[GitHub] [flink] 1u0 commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox)

2019-05-28 Thread GitBox
1u0 commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox) URL: https://github.com/apache/flink/pull/8523#discussion_r288242715 ## File path:

[jira] [Commented] (FLINK-12607) Introduce a REST API that returns the maxParallelism of a job

2019-05-28 Thread Akshay Kanfade (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850007#comment-16850007 ] Akshay Kanfade commented on FLINK-12607: [~klion26] Sorry, I misread your comment earlier. I

[GitHub] [flink] 1u0 commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox)

2019-05-28 Thread GitBox
1u0 commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox) URL: https://github.com/apache/flink/pull/8523#discussion_r288239644 ## File path:

[GitHub] [flink] 1u0 commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox)

2019-05-28 Thread GitBox
1u0 commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox) URL: https://github.com/apache/flink/pull/8523#discussion_r288239644 ## File path:

[GitHub] [flink] 1u0 commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox)

2019-05-28 Thread GitBox
1u0 commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox) URL: https://github.com/apache/flink/pull/8523#discussion_r288235811 ## File path:

[jira] [Commented] (FLINK-12607) Introduce a REST API that returns the maxParallelism of a job

2019-05-28 Thread Akshay Kanfade (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849983#comment-16849983 ] Akshay Kanfade commented on FLINK-12607: [~till.rohrmann]. Yes, I will be happy to work on it

[GitHub] [flink] azagrebin commented on a change in pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods

2019-05-28 Thread GitBox
azagrebin commented on a change in pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods URL: https://github.com/apache/flink/pull/8529#discussion_r288210117 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods

2019-05-28 Thread GitBox
azagrebin commented on a change in pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods URL: https://github.com/apache/flink/pull/8529#discussion_r288210167 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods

2019-05-28 Thread GitBox
azagrebin commented on a change in pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods URL: https://github.com/apache/flink/pull/8529#discussion_r288212692 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods

2019-05-28 Thread GitBox
azagrebin commented on a change in pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods URL: https://github.com/apache/flink/pull/8529#discussion_r288209939 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods

2019-05-28 Thread GitBox
azagrebin commented on a change in pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods URL: https://github.com/apache/flink/pull/8529#discussion_r288223427 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods

2019-05-28 Thread GitBox
azagrebin commented on a change in pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods URL: https://github.com/apache/flink/pull/8529#discussion_r288210019 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods

2019-05-28 Thread GitBox
azagrebin commented on a change in pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods URL: https://github.com/apache/flink/pull/8529#discussion_r288218530 ## File path:

[GitHub] [flink] flinkbot commented on issue #8560: [hotfix][hive] make hive-metastore dependency scope to 'provided'

2019-05-28 Thread GitBox
flinkbot commented on issue #8560: [hotfix][hive] make hive-metastore dependency scope to 'provided' URL: https://github.com/apache/flink/pull/8560#issuecomment-496612504 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] bowenli86 opened a new pull request #8560: [hotfix][hive] make hive-metastore dependency scope to 'provided'

2019-05-28 Thread GitBox
bowenli86 opened a new pull request #8560: [hotfix][hive] make hive-metastore dependency scope to 'provided' URL: https://github.com/apache/flink/pull/8560 ## What is the purpose of the change This PR converts hive-metastore jar dependency scope from 'compile' to 'provide', so that

[jira] [Commented] (FLINK-12653) Keyed state backend fails to restore during rescaling

2019-05-28 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849943#comment-16849943 ] Maximilian Michels commented on FLINK-12653: Some more information, these are the involved

[jira] [Comment Edited] (FLINK-12653) Keyed state backend fails to restore during rescaling

2019-05-28 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849943#comment-16849943 ] Maximilian Michels edited comment on FLINK-12653 at 5/28/19 5:15 PM: -

[GitHub] [flink] asfgit closed pull request #8553: [FLINK-12418][hive] Add input/output format and SerDeLib information when creating Hive table in HiveCatalog

2019-05-28 Thread GitBox
asfgit closed pull request #8553: [FLINK-12418][hive] Add input/output format and SerDeLib information when creating Hive table in HiveCatalog URL: https://github.com/apache/flink/pull/8553 This is an automated message from

[jira] [Closed] (FLINK-12635) REST API stability test does not cover jar upload

2019-05-28 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-12635. Resolution: Fixed master: 3558bac8b2cd9609642414a0bf96d622653d144f > REST API stability

[jira] [Closed] (FLINK-12636) REST API stability test does not fail on compatible modifications

2019-05-28 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-12636. Resolution: Fixed master: 4fe936dc8f65d57645eea908337653c76d83f400 > REST API stability

[jira] [Commented] (FLINK-12653) Keyed state backend fails to restore during rescaling

2019-05-28 Thread aitozi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849932#comment-16849932 ] aitozi commented on FLINK-12653: Thanks for the detail information, I will try look into this problem.

[GitHub] [flink] zentol merged pull request #8554: [FLINK-12635][rest] Cover jar upload in stability test

2019-05-28 Thread GitBox
zentol merged pull request #8554: [FLINK-12635][rest] Cover jar upload in stability test URL: https://github.com/apache/flink/pull/8554 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] bowenli86 commented on issue #8553: [FLINK-12418][hive] Add input/output format and SerDeLib information when creating Hive table in HiveCatalog

2019-05-28 Thread GitBox
bowenli86 commented on issue #8553: [FLINK-12418][hive] Add input/output format and SerDeLib information when creating Hive table in HiveCatalog URL: https://github.com/apache/flink/pull/8553#issuecomment-496603114 LGTM. As we discussed yesterday, we will make the dependency as 'provided'

[GitHub] [flink] Aitozi commented on issue #8559: [FLINK-12576]Take localInputChannel into account when complute inputQueueLength

2019-05-28 Thread GitBox
Aitozi commented on issue #8559: [FLINK-12576]Take localInputChannel into account when complute inputQueueLength URL: https://github.com/apache/flink/pull/8559#issuecomment-496601763 @flinkbot attention @pnowojski This is

[GitHub] [flink] flinkbot commented on issue #8559: [FLINK-12576]Take localInputChannel into account when complute inputQueueLength

2019-05-28 Thread GitBox
flinkbot commented on issue #8559: [FLINK-12576]Take localInputChannel into account when complute inputQueueLength URL: https://github.com/apache/flink/pull/8559#issuecomment-496601374 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[jira] [Updated] (FLINK-12576) inputQueueLength metric does not work for LocalInputChannels

2019-05-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12576: --- Labels: pull-request-available (was: ) > inputQueueLength metric does not work for

[GitHub] [flink] Aitozi opened a new pull request #8559: [FLINK-12576]Take localInputChannel into account when complute inputQueueLength

2019-05-28 Thread GitBox
Aitozi opened a new pull request #8559: [FLINK-12576]Take localInputChannel into account when complute inputQueueLength URL: https://github.com/apache/flink/pull/8559 ## What is the purpose of the change Take localInputChannel into account when complute inputQueueLength. ##

[jira] [Commented] (FLINK-12621) Use MiniCluster instead of JobExecutor

2019-05-28 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849920#comment-16849920 ] Till Rohrmann commented on FLINK-12621: --- Before starting implementing a solution [~zjffdu], let's

[jira] [Updated] (FLINK-12653) Keyed state backend fails to restore during rescaling

2019-05-28 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-12653: --- Environment: Beam 2.12.0 or any other Beam version Flink >= 1.6 Heap/Filesystem

[jira] [Updated] (FLINK-12653) Keyed state backend fails to restore during rescaling

2019-05-28 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-12653: --- Environment: Beam 2.12.0 or any other Beam version Flink >= 1.6 Filesystem state

  1   2   3   >