[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy

2019-06-07 Thread GitBox
eaglewatcherwb commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy URL: https://github.com/apache/flink/pull/8573#discussion_r291796364 ## File path: flink-core/src/main/java/org/apache/flink/configuration/RestartBacko

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy

2019-06-07 Thread GitBox
eaglewatcherwb commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy URL: https://github.com/apache/flink/pull/8573#discussion_r291796293 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy

2019-06-07 Thread GitBox
eaglewatcherwb commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy URL: https://github.com/apache/flink/pull/8573#discussion_r291796274 ## File path: flink-core/src/main/java/org/apache/flink/configuration/RestartBacko

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy

2019-06-07 Thread GitBox
eaglewatcherwb commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy URL: https://github.com/apache/flink/pull/8573#discussion_r291796255 ## File path: docs/_includes/generated/restart_backoff_time_strategy_configuration

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy

2019-06-07 Thread GitBox
eaglewatcherwb commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy URL: https://github.com/apache/flink/pull/8573#discussion_r291796236 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy

2019-06-07 Thread GitBox
eaglewatcherwb commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy URL: https://github.com/apache/flink/pull/8573#discussion_r291796011 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy

2019-06-07 Thread GitBox
eaglewatcherwb commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy URL: https://github.com/apache/flink/pull/8573#discussion_r291795939 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/

[jira] [Closed] (FLINK-12677) Add descriptor, validator, and factory for HiveCatalog

2019-06-07 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-12677. Resolution: Fixed merged in 1.9.0: 80d62e2d7c96b0ec65b01d525f3eb48e58446576 > Add descriptor, validator,

[jira] [Updated] (FLINK-12625) Support catalogs in SQL Client

2019-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12625: --- Labels: pull-request-available (was: ) > Support catalogs in SQL Client > -

[GitHub] [flink] asfgit closed pull request #8589: [FLINK-12625][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog

2019-06-07 Thread GitBox
asfgit closed pull request #8589: [FLINK-12625][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog URL: https://github.com/apache/flink/pull/8589 This is an automated message from the Apache Git Service

[GitHub] [flink] bowenli86 commented on issue #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog

2019-06-07 Thread GitBox
bowenli86 commented on issue #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog URL: https://github.com/apache/flink/pull/8589#issuecomment-500072991 Thanks. Merging This is an autom

[jira] [Commented] (FLINK-11105) Add a new implementation of the HighAvailabilityServices using etcd

2019-06-07 Thread Nathan Howell (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859030#comment-16859030 ] Nathan Howell commented on FLINK-11105: --- Regarding Kubernetes support, managed Kub

[jira] [Updated] (FLINK-12781) REST handler should return full stack trace instead of just error msg

2019-06-07 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated FLINK-12781: --- Summary: REST handler should return full stack trace instead of just error msg (was: run jo

[GitHub] [flink] xuefuz commented on a change in pull request #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog

2019-06-07 Thread GitBox
xuefuz commented on a change in pull request #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog URL: https://github.com/apache/flink/pull/8589#discussion_r291770702 ## File path: flink-connectors/flink-connector-hive/src/test/java/org/apa

[jira] [Commented] (FLINK-12646) Fix broken tests of RestClientTest

2019-06-07 Thread Victor Wong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859022#comment-16859022 ] Victor Wong commented on FLINK-12646: - I'd love to, [https://github.com/apache/flink

[GitHub] [flink] xuefuz commented on a change in pull request #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog

2019-06-07 Thread GitBox
xuefuz commented on a change in pull request #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog URL: https://github.com/apache/flink/pull/8589#discussion_r291770433 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apa

[GitHub] [flink] flinkbot commented on issue #8663: [FLINK-12646][runtime] Change the test IP of RestClientTest to 240.0.0.0

2019-06-07 Thread GitBox
flinkbot commented on issue #8663: [FLINK-12646][runtime] Change the test IP of RestClientTest to 240.0.0.0 URL: https://github.com/apache/flink/pull/8663#issuecomment-500056494 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to re

[jira] [Updated] (FLINK-12646) Fix broken tests of RestClientTest

2019-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12646: --- Labels: pull-request-available (was: ) > Fix broken tests of RestClientTest > -

[GitHub] [flink] jiasheng55 opened a new pull request #8663: [FLINK-12646][runtime] Change the test IP of RestClientTest to 240.0.0.0

2019-06-07 Thread GitBox
jiasheng55 opened a new pull request #8663: [FLINK-12646][runtime] Change the test IP of RestClientTest to 240.0.0.0 URL: https://github.com/apache/flink/pull/8663 ## What is the purpose of the change Fix broken tests of RestClientTest ## Brief change log Change the

[GitHub] [flink] xuefuz commented on a change in pull request #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog

2019-06-07 Thread GitBox
xuefuz commented on a change in pull request #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog URL: https://github.com/apache/flink/pull/8589#discussion_r291769731 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apa

[jira] [Updated] (FLINK-12781) run job REST api doesn't return complete stack trace for start job failure

2019-06-07 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated FLINK-12781: --- Description: We use REST api to start a job in Flink cluster. https://ci.apache.org/projects

[GitHub] [flink] jiasheng55 commented on issue #8650: [hotfix][runtime] Fix the typo issue

2019-06-07 Thread GitBox
jiasheng55 commented on issue #8650: [hotfix][runtime] Fix the typo issue URL: https://github.com/apache/flink/pull/8650#issuecomment-500053157 Thanks, I'll pay attention to that next time. This is an automated message from th

[jira] [Updated] (FLINK-12781) run job REST api doesn't return complete stack trace for start job failure

2019-06-07 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated FLINK-12781: --- Description: We use REST api to start a job in Flink cluster. https://ci.apache.org/projects

[jira] [Created] (FLINK-12782) Show formatted timestamp in Watermark Tab of JM Web UI

2019-06-07 Thread JIRA
Felix Wollschläger created FLINK-12782: -- Summary: Show formatted timestamp in Watermark Tab of JM Web UI Key: FLINK-12782 URL: https://issues.apache.org/jira/browse/FLINK-12782 Project: Flink

[jira] [Updated] (FLINK-12781) run job REST api doesn't return complete stack trace for start job failure

2019-06-07 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated FLINK-12781: --- Description: We use REST api to start a job in Flink cluster. https://ci.apache.org/projects

[jira] [Updated] (FLINK-12781) run job REST api doesn't return complete stack trace for start job failure

2019-06-07 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated FLINK-12781: --- Description: We use REST api to start a job in Flink cluster. [https://ci.apache.org/projec

[jira] [Updated] (FLINK-12781) run job REST api doesn't return complete stack trace for start job failure

2019-06-07 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated FLINK-12781: --- Description: We use REST api to start a job in Flink cluster. https://ci.apache.org/projects

[jira] [Created] (FLINK-12781) run job REST api doesn't return complete stack trace for start job failure

2019-06-07 Thread Steven Zhen Wu (JIRA)
Steven Zhen Wu created FLINK-12781: -- Summary: run job REST api doesn't return complete stack trace for start job failure Key: FLINK-12781 URL: https://issues.apache.org/jira/browse/FLINK-12781 Projec

[GitHub] [flink] bowenli86 commented on issue #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema

2019-06-07 Thread GitBox
bowenli86 commented on issue #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema URL: https://github.com/apache/flink/pull/8214#issuecomment-500043829 closing this as it's merge as part of https://github.com/apache/flink/pull/8404

[GitHub] [flink] bowenli86 closed pull request #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema

2019-06-07 Thread GitBox
bowenli86 closed pull request #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema URL: https://github.com/apache/flink/pull/8214 This is an automated message from the

[GitHub] [flink] asfgit closed pull request #8650: [hotfix][runtime] Fix the typo issue

2019-06-07 Thread GitBox
asfgit closed pull request #8650: [hotfix][runtime] Fix the typo issue URL: https://github.com/apache/flink/pull/8650 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [flink] bowenli86 commented on issue #8650: [hotfix][runtime] Fix the typo issue

2019-06-07 Thread GitBox
bowenli86 commented on issue #8650: [hotfix][runtime] Fix the typo issue URL: https://github.com/apache/flink/pull/8650#issuecomment-500042428 Thanks @jiasheng55 for your contribution. LGTM, but please have more detailed PR title and commit message next time, e.g. "fix typo in javadoc of S

[GitHub] [flink] bowenli86 commented on issue #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog

2019-06-07 Thread GitBox
bowenli86 commented on issue #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog URL: https://github.com/apache/flink/pull/8589#issuecomment-500023058 @xuefuz as we discussed offline, I kept only one public constructor and a protected constructor f

[GitHub] [flink] bowenli86 commented on a change in pull request #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog

2019-06-07 Thread GitBox
bowenli86 commented on a change in pull request #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog URL: https://github.com/apache/flink/pull/8589#discussion_r291738275 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/

[GitHub] [flink] bowenli86 commented on a change in pull request #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog

2019-06-07 Thread GitBox
bowenli86 commented on a change in pull request #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog URL: https://github.com/apache/flink/pull/8589#discussion_r291396450 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/

[GitHub] [flink] bowenli86 commented on a change in pull request #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog

2019-06-07 Thread GitBox
bowenli86 commented on a change in pull request #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog URL: https://github.com/apache/flink/pull/8589#discussion_r291396683 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/

[jira] [Assigned] (FLINK-12660) Integrate Flink with Hive GenericUDAFResolver and GenericUDAFResolver2

2019-06-07 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li reassigned FLINK-12660: Assignee: Bowen Li > Integrate Flink with Hive GenericUDAFResolver and GenericUDAFResolver2 > ---

[jira] [Assigned] (FLINK-12658) Integrate Flink with Hive GenericUDF

2019-06-07 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li reassigned FLINK-12658: Assignee: Bowen Li > Integrate Flink with Hive GenericUDF >

[jira] [Assigned] (FLINK-12657) Integrate Flink with Hive UDF

2019-06-07 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li reassigned FLINK-12657: Assignee: Bowen Li > Integrate Flink with Hive UDF > - > >

[jira] [Assigned] (FLINK-12659) Integrate Flink with Hive GenericUDTF

2019-06-07 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li reassigned FLINK-12659: Assignee: Bowen Li > Integrate Flink with Hive GenericUDTF >

[GitHub] [flink] flinkbot commented on issue #8662: [FLINK-12780][hive] use Flink's LogicalTypeRoot for type comparison in HiveTypeUtil

2019-06-07 Thread GitBox
flinkbot commented on issue #8662: [FLINK-12780][hive] use Flink's LogicalTypeRoot for type comparison in HiveTypeUtil URL: https://github.com/apache/flink/pull/8662#issuecomment-48159 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the communi

[jira] [Updated] (FLINK-12780) use Flink's LogicalTypeRoot for type comparison in HiveTypeUtil

2019-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12780: --- Labels: pull-request-available (was: ) > use Flink's LogicalTypeRoot for type comparison in

[GitHub] [flink] bowenli86 commented on issue #8662: [FLINK-12780][hive] use Flink's LogicalTypeRoot for type comparison in HiveTypeUtil

2019-06-07 Thread GitBox
bowenli86 commented on issue #8662: [FLINK-12780][hive] use Flink's LogicalTypeRoot for type comparison in HiveTypeUtil URL: https://github.com/apache/flink/pull/8662#issuecomment-47839 cc @xuefuz @lirui-apache @zjuwangg

[GitHub] [flink] bowenli86 opened a new pull request #8662: [FLINK-12780][hive] use Flink's LogicalTypeRoot for type comparison in HiveTypeUtil

2019-06-07 Thread GitBox
bowenli86 opened a new pull request #8662: [FLINK-12780][hive] use Flink's LogicalTypeRoot for type comparison in HiveTypeUtil URL: https://github.com/apache/flink/pull/8662 ## What is the purpose of the change This PR changes type comparisons in `HiveTypeUtil` to use `LogicalTypeRoo

[GitHub] [flink] lamber-ken commented on issue #8583: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null

2019-06-07 Thread GitBox
lamber-ken commented on issue #8583: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null URL: https://github.com/apache/flink/pull/8583#issuecomment-47592 > Scratch that, I don't think we can do this. Our Kafka consumer silently swallows null value

[jira] [Updated] (FLINK-12780) use Flink's LogicalTypeRoot for type comparison in HiveTypeUtil

2019-06-07 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-12780: - Summary: use Flink's LogicalTypeRoot for type comparison in HiveTypeUtil (was: use LogicalTypeRoot for

[jira] [Created] (FLINK-12780) use LogicalTypeRoot for type comparison

2019-06-07 Thread Bowen Li (JIRA)
Bowen Li created FLINK-12780: Summary: use LogicalTypeRoot for type comparison Key: FLINK-12780 URL: https://issues.apache.org/jira/browse/FLINK-12780 Project: Flink Issue Type: Sub-task

[GitHub] [flink] walterddr closed pull request #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-06-07 Thread GitBox
walterddr closed pull request #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] walterddr commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-06-07 Thread GitBox
walterddr commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#issuecomment-499967458 close this pull request and recreate new one once calcite 1.20 releases Thi

[jira] [Commented] (FLINK-11921) Upgrade Calcite dependency to 1.20

2019-06-07 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858835#comment-16858835 ] Rong Rong commented on FLINK-11921: --- changed title as discussed: we will skip 1.19, di

[jira] [Updated] (FLINK-11921) Upgrade Calcite dependency to 1.20

2019-06-07 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rong Rong updated FLINK-11921: -- Description: Umbrella issue for all tasks related to the next Calcite upgrade to 1.20.x release We w

[jira] [Updated] (FLINK-11921) Upgrade Calcite dependency to 1.20

2019-06-07 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rong Rong updated FLINK-11921: -- Summary: Upgrade Calcite dependency to 1.20 (was: Upgrade Calcite dependency to 1.19) > Upgrade Calc

[GitHub] [flink] lamber-ken edited a comment on issue #8583: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null

2019-06-07 Thread GitBox
lamber-ken edited a comment on issue #8583: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null URL: https://github.com/apache/flink/pull/8583#issuecomment-499957988 hi, thanks for your commnet @aljoscha. here is detail stackstrace, flink-version: 1.6.

[GitHub] [flink] lamber-ken edited a comment on issue #8583: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null

2019-06-07 Thread GitBox
lamber-ken edited a comment on issue #8583: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null URL: https://github.com/apache/flink/pull/8583#issuecomment-499957988 hi, thanks for your commnet @aljoscha. here is detail stackstrace ``` Caused by:

[GitHub] [flink] bowenli86 commented on a change in pull request #8645: [FLINK-12386] Support mapping BinaryType, VarBinaryType, CharType, VarCharType, and DecimalType between Flink and Hive in HiveCa

2019-06-07 Thread GitBox
bowenli86 commented on a change in pull request #8645: [FLINK-12386] Support mapping BinaryType, VarBinaryType, CharType, VarCharType, and DecimalType between Flink and Hive in HiveCatalog URL: https://github.com/apache/flink/pull/8645#discussion_r291674279 ## File path: flink-con

[GitHub] [flink] fhueske commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary

2019-06-07 Thread GitBox
fhueske commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary URL: https://github.com/apache/flink/pull/8607#discussion_r291628201 ## File path: docs/concepts/glossary.md ## @@ -0,0 +1,166 @@ +--- +title: Glossary +nav-p

[GitHub] [flink] fhueske commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary

2019-06-07 Thread GitBox
fhueske commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary URL: https://github.com/apache/flink/pull/8607#discussion_r291672843 ## File path: docs/concepts/glossary.md ## @@ -0,0 +1,166 @@ +--- +title: Glossary +nav-p

[GitHub] [flink] fhueske commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary

2019-06-07 Thread GitBox
fhueske commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary URL: https://github.com/apache/flink/pull/8607#discussion_r291672090 ## File path: docs/concepts/glossary.md ## @@ -0,0 +1,166 @@ +--- +title: Glossary +nav-p

[GitHub] [flink] fhueske commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary

2019-06-07 Thread GitBox
fhueske commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary URL: https://github.com/apache/flink/pull/8607#discussion_r291673345 ## File path: docs/concepts/glossary.md ## @@ -0,0 +1,140 @@ +--- +title: Glossary +nav-p

[GitHub] [flink] fhueske commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary

2019-06-07 Thread GitBox
fhueske commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary URL: https://github.com/apache/flink/pull/8607#discussion_r291672539 ## File path: docs/concepts/glossary.md ## @@ -0,0 +1,166 @@ +--- +title: Glossary +nav-p

[GitHub] [flink] fhueske commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary

2019-06-07 Thread GitBox
fhueske commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary URL: https://github.com/apache/flink/pull/8607#discussion_r291671831 ## File path: docs/concepts/glossary.md ## @@ -0,0 +1,166 @@ +--- +title: Glossary +nav-p

[GitHub] [flink] fhueske commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary

2019-06-07 Thread GitBox
fhueske commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary URL: https://github.com/apache/flink/pull/8607#discussion_r291630616 ## File path: docs/concepts/glossary.md ## @@ -0,0 +1,166 @@ +--- +title: Glossary +nav-p

[GitHub] [flink] lamber-ken commented on issue #8583: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null

2019-06-07 Thread GitBox
lamber-ken commented on issue #8583: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null URL: https://github.com/apache/flink/pull/8583#issuecomment-499957988 hi, thanks for your commnet @aljoscha. here is detail stackstrace ``` Caused by: java.la

[jira] [Created] (FLINK-12779) Avoid field conflicts when generate field names for non-composite Typeinformation

2019-06-07 Thread Hequn Cheng (JIRA)
Hequn Cheng created FLINK-12779: --- Summary: Avoid field conflicts when generate field names for non-composite Typeinformation Key: FLINK-12779 URL: https://issues.apache.org/jira/browse/FLINK-12779 Proje

[GitHub] [flink] flinkbot commented on issue #8661: [FLINK-12711][table] Separate function implementation and definition

2019-06-07 Thread GitBox
flinkbot commented on issue #8661: [FLINK-12711][table] Separate function implementation and definition URL: https://github.com/apache/flink/pull/8661#issuecomment-499937163 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revie

[jira] [Updated] (FLINK-12711) Separate function implementation and definition

2019-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12711: --- Labels: pull-request-available (was: ) > Separate function implementation and definition >

[GitHub] [flink] twalthr opened a new pull request #8661: [FLINK-12711][table] Separate function implementation and definition

2019-06-07 Thread GitBox
twalthr opened a new pull request #8661: [FLINK-12711][table] Separate function implementation and definition URL: https://github.com/apache/flink/pull/8661 ## What is the purpose of the change This PR is a first step toward unified expression stacks. It uncouples runtime implement

[jira] [Commented] (FLINK-12619) Support TERMINATE/SUSPEND Job with Checkpoint

2019-06-07 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858747#comment-16858747 ] Yu Li commented on FLINK-12619: --- Thanks for the clarification about your thoughts [~aljosc

[jira] [Updated] (FLINK-12513) Improve end-to-end (bash based) tests

2019-06-07 Thread Alex (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex updated FLINK-12513: - Description: Tests in {{flink-end-to-end-tests/test-scripts}} directory are re-using the same Flink directory t

[jira] [Commented] (FLINK-12662) show jobs failover in history server as well

2019-06-07 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858733#comment-16858733 ] vinoyang commented on FLINK-12662: -- Hi [~till.rohrmann] , My original thought is that y

[GitHub] [flink] wisgood commented on issue #8621: [FLINK-12682][connectors] StringWriter support custom row delimiter

2019-06-07 Thread GitBox
wisgood commented on issue #8621: [FLINK-12682][connectors] StringWriter support custom row delimiter URL: https://github.com/apache/flink/pull/8621#issuecomment-499920683 thanks for your explanation! This is an automated mes

[GitHub] [flink] aljoscha edited a comment on issue #8583: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null

2019-06-07 Thread GitBox
aljoscha edited a comment on issue #8583: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null URL: https://github.com/apache/flink/pull/8583#issuecomment-499919264 Scratch that, I don't think we can do this. Our Kafka consumer silently swallows null va

[GitHub] [flink] aljoscha commented on issue #8583: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null

2019-06-07 Thread GitBox
aljoscha commented on issue #8583: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null URL: https://github.com/apache/flink/pull/8583#issuecomment-499919264 Scratch that, I don't think we can do this. Our Kafka consumer silently swallows null values:

[GitHub] [flink] fhueske commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary

2019-06-07 Thread GitBox
fhueske commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary URL: https://github.com/apache/flink/pull/8607#discussion_r291627017 ## File path: docs/concepts/glossary.md ## @@ -0,0 +1,166 @@ +--- +title: Glossary +nav-p

[GitHub] [flink] azagrebin commented on issue #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API

2019-06-07 Thread GitBox
azagrebin commented on issue #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API URL: https://github.com/apache/flink/pull/8485#issuecomment-499913877 Thanks for the reviews @zentol @zhijiangW, I've addressed comments This PR is now based on #8608 which I t

[GitHub] [flink] azagrebin commented on a change in pull request #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API

2019-06-07 Thread GitBox
azagrebin commented on a change in pull request #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API URL: https://github.com/apache/flink/pull/8485#discussion_r291622614 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Tas

[GitHub] [flink] aljoscha commented on issue #8583: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null

2019-06-07 Thread GitBox
aljoscha commented on issue #8583: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null URL: https://github.com/apache/flink/pull/8583#issuecomment-499911130 Yes, I think this should work. +1 -

[jira] [Created] (FLINK-12778) Fix deriveTableAggRowType bug for non-composite types

2019-06-07 Thread Hequn Cheng (JIRA)
Hequn Cheng created FLINK-12778: --- Summary: Fix deriveTableAggRowType bug for non-composite types Key: FLINK-12778 URL: https://issues.apache.org/jira/browse/FLINK-12778 Project: Flink Issue Typ

[GitHub] [flink] azagrebin commented on issue #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

2019-06-07 Thread GitBox
azagrebin commented on issue #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#issuecomment-499890156 Thanks for the review @tillrohrmann, I've pushed the final version with the last changes including yours. ---

[GitHub] [flink] tillrohrmann commented on a change in pull request #8552: [FLINK-12631]:Check if proper JAR file in JobWithJars

2019-06-07 Thread GitBox
tillrohrmann commented on a change in pull request #8552: [FLINK-12631]:Check if proper JAR file in JobWithJars URL: https://github.com/apache/flink/pull/8552#discussion_r291582520 ## File path: flink-clients/src/main/java/org/apache/flink/client/program/JobWithJars.java #

[GitHub] [flink] flinkbot commented on issue #8660: [FLINK-12143]

2019-06-07 Thread GitBox
flinkbot commented on issue #8660: [FLINK-12143] URL: https://github.com/apache/flink/pull/8660#issuecomment-499876516 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track th

[jira] [Updated] (FLINK-12143) Mechanism to ship plugin jars in the cluster

2019-06-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12143: --- Labels: pull-request-available (was: ) > Mechanism to ship plugin jars in the cluster > ---

[GitHub] [flink] 1u0 opened a new pull request #8660: [FLINK-12143]

2019-06-07 Thread GitBox
1u0 opened a new pull request #8660: [FLINK-12143] URL: https://github.com/apache/flink/pull/8660 ## What is the purpose of the change This PR changes Flink distribution's starter scripts: defines new configuration environment parameter for plugins dir and passes the configuration t

[jira] [Updated] (FLINK-12637) Add metrics for floatingBufferUsage and exclusiveBufferUsage for credit based mode

2019-06-07 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-12637: -- Summary: Add metrics for floatingBufferUsage and exclusiveBufferUsage for credit based mode (

[jira] [Commented] (FLINK-12640) mvn install flink-shaded-hadoop2-uber: Error creating shaded jar: null

2019-06-07 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858609#comment-16858609 ] Till Rohrmann commented on FLINK-12640: --- The build seems to work for me. What mave

[jira] [Commented] (FLINK-12646) Fix broken tests of RestClientTest

2019-06-07 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858607#comment-16858607 ] Till Rohrmann commented on FLINK-12646: --- Sounds like a good idea to me [~victor-wo

[jira] [Closed] (FLINK-12661) test failure: RestAPIStabilityTest.testDispatcherRestAPIStability

2019-06-07 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-12661. - Resolution: Cannot Reproduce Fix Version/s: (was: 1.9.0) Could not reproduce the prob

[jira] [Updated] (FLINK-12655) SlotCountExceedingParallelismTest failed on Travis

2019-06-07 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-12655: -- Priority: Critical (was: Major) > SlotCountExceedingParallelismTest failed on Travis > --

[jira] [Updated] (FLINK-12655) SlotCountExceedingParallelismTest failed on Travis

2019-06-07 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-12655: -- Labels: test-stability (was: ) > SlotCountExceedingParallelismTest failed on Travis > ---

[jira] [Updated] (FLINK-12661) test failure: RestAPIStabilityTest.testDispatcherRestAPIStability

2019-06-07 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-12661: -- Labels: test-stability (was: ) > test failure: RestAPIStabilityTest.testDispatcherRestAPIStab

[jira] [Updated] (FLINK-12661) test failure: RestAPIStabilityTest.testDispatcherRestAPIStability

2019-06-07 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-12661: -- Priority: Critical (was: Major) > test failure: RestAPIStabilityTest.testDispatcherRestAPISta

[jira] [Commented] (FLINK-12662) show jobs failover in history server as well

2019-06-07 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858597#comment-16858597 ] Till Rohrmann commented on FLINK-12662: --- Could it be enough to keep a history of {

[jira] [Assigned] (FLINK-12706) Introduce ShuffleService interface and its configuration

2019-06-07 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-12706: - Assignee: Andrey Zagrebin > Introduce ShuffleService interface and its configuration >

[jira] [Updated] (FLINK-12707) Close minicluster will cause memory leak when there are StreamTask closed abnormal

2019-06-07 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-12707: -- Issue Type: Bug (was: Improvement) > Close minicluster will cause memory leak when there are

[jira] [Commented] (FLINK-12707) Close minicluster will cause memory leak when there are StreamTask closed abnormal

2019-06-07 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858593#comment-16858593 ] Till Rohrmann commented on FLINK-12707: --- Could this be caused by FLINK-11630? It s

[jira] [Closed] (FLINK-12513) Improve end-to-end (bash based) tests

2019-06-07 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-12513. -- Resolution: Fixed Merged to master as a0cf2054cc4ab9ea2a6cce3f60ec0b2dc8a59b27..29f4e523600e8

[GitHub] [flink] pnowojski commented on issue #8451: [FLINK-12513][e2e] Improve end-to-end (bash based) tests

2019-06-07 Thread GitBox
pnowojski commented on issue #8451: [FLINK-12513][e2e] Improve end-to-end (bash based) tests URL: https://github.com/apache/flink/pull/8451#issuecomment-499870527 Ok :) Merging This is an automated message from the Apache Git

[GitHub] [flink] tillrohrmann closed pull request #8595: [FLINK-12707]Close minicluster will cause memory leak when there are StreamTask closed abnormal

2019-06-07 Thread GitBox
tillrohrmann closed pull request #8595: [FLINK-12707]Close minicluster will cause memory leak when there are StreamTask closed abnormal URL: https://github.com/apache/flink/pull/8595 This is an automated message from the Ap

[GitHub] [flink] pnowojski merged pull request #8451: [FLINK-12513][e2e] Improve end-to-end (bash based) tests

2019-06-07 Thread GitBox
pnowojski merged pull request #8451: [FLINK-12513][e2e] Improve end-to-end (bash based) tests URL: https://github.com/apache/flink/pull/8451 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [flink] tillrohrmann commented on issue #8595: [FLINK-12707]Close minicluster will cause memory leak when there are StreamTask closed abnormal

2019-06-07 Thread GitBox
tillrohrmann commented on issue #8595: [FLINK-12707]Close minicluster will cause memory leak when there are StreamTask closed abnormal URL: https://github.com/apache/flink/pull/8595#issuecomment-499870633 Thanks for opening this PR @liu-zhaokun. I'm not sure whether this solves the under

  1   2   >