[jira] [Commented] (FLINK-17545) Resource leak JDBCUpsertOutputFormat

2020-05-16 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108985#comment-17108985 ] Roman Khachatryan commented on FLINK-17545: --- Thanks a lot [~johnlon]! I think it can be just

[GitHub] [flink] godfreyhe commented on a change in pull request #12188: [FLINK-17728] [sql-client] sql client supports parser statements via sql parser

2020-05-16 Thread GitBox
godfreyhe commented on a change in pull request #12188: URL: https://github.com/apache/flink/pull/12188#discussion_r426140762 ## File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/utils/ParserUtils.java ## @@ -0,0 +1,52 @@ +/* + * Licensed

[GitHub] [flink] flinkbot edited a comment on pull request #12169: [FLINK-17495][metrics][prometheus]Add custom labels on PrometheusReporter like PrometheusPushGatewayReporter's groupingKey

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12169: URL: https://github.com/apache/flink/pull/12169#issuecomment-629195529 ## CI report: * 9e55eae7a9819ab59c05e4c27d3d4992246b75f4 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12184: [FLINK-17027] Introduce a new Elasticsearch 7 connector with new property keys

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12184: URL: https://github.com/apache/flink/pull/12184#issuecomment-629425634 ## CI report: * 93f46cc0d8572f70b238640b6dbfe0b207f8c1aa Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12172: URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668 ## CI report: * 53535b6bfbf308d4a5e1d209a11ce8cac6265a13 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12133: [FLINK-17526][avro] Support AVRO serialization and deseriazation sche…

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12133: URL: https://github.com/apache/flink/pull/12133#issuecomment-628151482 ## CI report: * 80bdfcb3ca8d21a3b9908d089bc3514e4ff5e807 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12029: URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739 ## CI report: * 9405ea4470dc022ffb514f603396fc6bb2582835 UNKNOWN * 0ea67ded38cbd339a5f67656b50b874625a911b9 Azure:

[GitHub] [flink] godfreyhe commented on a change in pull request #12188: [FLINK-17728] [sql-client] sql client supports parser statements via sql parser

2020-05-16 Thread GitBox
godfreyhe commented on a change in pull request #12188: URL: https://github.com/apache/flink/pull/12188#discussion_r426140607 ## File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/SqlCommandParser.java ## @@ -34,29 +58,131 @@ private

[GitHub] [flink] flinkbot edited a comment on pull request #12168: [WIP][FLINK-14255][hive] Integrate hive to streaming file sink

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12168: URL: https://github.com/apache/flink/pull/12168#issuecomment-629179735 ## CI report: * 2c97f52f8d206393ab06a555d3510392b2638015 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12162: [FLINK-17718][avro] Integrate avro to file system connector

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12162: URL: https://github.com/apache/flink/pull/12162#issuecomment-629084825 ## CI report: * d19294c341e31db854dfa19436f8e9a990336e59 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12108: [FLINK-17448][sql-parser][table-api-java][table-planner-blink][hive] Implement table DDLs for Hive dialect part2

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12108: URL: https://github.com/apache/flink/pull/12108#issuecomment-627804642 ## CI report: * 66bbeb2e19f810744287740e7a691da17ebb8b0c Azure:

[GitHub] [flink] JingsongLi commented on pull request #12133: [FLINK-17526][avro] Support AVRO serialization and deseriazation sche…

2020-05-16 Thread GitBox
JingsongLi commented on pull request #12133: URL: https://github.com/apache/flink/pull/12133#issuecomment-629623472 Thanks @libenchao for your contribution, and thanks @wuchong and @danny0405 for review, merging... This is

[GitHub] [flink] flinkbot edited a comment on pull request #12135: [FLINK-16999][table-runtime-blink] Add converters for all data types and classes

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12135: URL: https://github.com/apache/flink/pull/12135#issuecomment-628176758 ## CI report: * d0cd31f2786ee776579dcb1b1aa90c3e27c1b67e Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12145: [FLINK-17428] [table-planner-blink] supports projection push down on new table source interface in blink planner

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12145: URL: https://github.com/apache/flink/pull/12145#issuecomment-628490262 ## CI report: * ba9ee6228cf9eea60df403e37b41b907fef21a28 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12056: [FLINK-17502] [flink-connector-rabbitmq] RMQSource refactor

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12056: URL: https://github.com/apache/flink/pull/12056#issuecomment-626167900 ## CI report: * 553e00e2aec0d9e515c8baa137ff7143d3ab114a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12120: [FLINK-17547] Support unaligned checkpoints for records spilled to files

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12120: URL: https://github.com/apache/flink/pull/12120#issuecomment-628150581 ## CI report: * 4b453c84b4823034f4118e24191339851096097e Azure:

[GitHub] [flink] godfreyhe commented on a change in pull request #12188: [FLINK-17728] [sql-client] sql client supports parser statements via sql parser

2020-05-16 Thread GitBox
godfreyhe commented on a change in pull request #12188: URL: https://github.com/apache/flink/pull/12188#discussion_r426140506 ## File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/SqlCommandParser.java ## @@ -34,29 +58,131 @@ private

[GitHub] [flink] flinkbot edited a comment on pull request #11109: [FLINK-15758][MemManager] Release segment and its unsafe memory in GC Cleaner

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #11109: URL: https://github.com/apache/flink/pull/11109#issuecomment-586932050 ## CI report: * 13d545aca4b423ff424dd52bde946aef10acdaf9 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162397442) Azure:

[GitHub] [flink] godfreyhe commented on a change in pull request #12188: [FLINK-17728] [sql-client] sql client supports parser statements via sql parser

2020-05-16 Thread GitBox
godfreyhe commented on a change in pull request #12188: URL: https://github.com/apache/flink/pull/12188#discussion_r426140427 ## File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/SqlCommandParser.java ## @@ -207,6 +301,10 @@ public String

[GitHub] [flink] curcur commented on a change in pull request #11725: [FLINK-15670][API] Provide a Kafka Source/Sink pair as KafkaShuffle

2020-05-16 Thread GitBox
curcur commented on a change in pull request #11725: URL: https://github.com/apache/flink/pull/11725#discussion_r426140306 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaShuffleFetcher.java ## @@

[GitHub] [flink] dianfu commented on a change in pull request #12165: [FLINK-17700][python] The callback client of JavaGatewayServer should…

2020-05-16 Thread GitBox
dianfu commented on a change in pull request #12165: URL: https://github.com/apache/flink/pull/12165#discussion_r426139537 ## File path: flink-python/src/main/java/org/apache/flink/client/python/PythonDriver.java ## @@ -95,23 +104,36 @@ public static void main(String[] args)

[GitHub] [flink] curcur commented on a change in pull request #11725: [FLINK-15670][API] Provide a Kafka Source/Sink pair as KafkaShuffle

2020-05-16 Thread GitBox
curcur commented on a change in pull request #11725: URL: https://github.com/apache/flink/pull/11725#discussion_r426139686 ## File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java ## @@

[GitHub] [flink] dianfu commented on a change in pull request #12165: [FLINK-17700][python] The callback client of JavaGatewayServer should…

2020-05-16 Thread GitBox
dianfu commented on a change in pull request #12165: URL: https://github.com/apache/flink/pull/12165#discussion_r426139537 ## File path: flink-python/src/main/java/org/apache/flink/client/python/PythonDriver.java ## @@ -95,23 +104,36 @@ public static void main(String[] args)

[GitHub] [flink] flinkbot edited a comment on pull request #12168: [WIP][FLINK-14255][hive] Integrate hive to streaming file sink

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12168: URL: https://github.com/apache/flink/pull/12168#issuecomment-629179735 ## CI report: * 2c97f52f8d206393ab06a555d3510392b2638015 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12172: [FLINK-17656][tests] Migrate docker e2e tests to flink-docker

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12172: URL: https://github.com/apache/flink/pull/12172#issuecomment-629230668 ## CI report: * 53535b6bfbf308d4a5e1d209a11ce8cac6265a13 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12133: [FLINK-17526][avro] Support AVRO serialization and deseriazation sche…

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12133: URL: https://github.com/apache/flink/pull/12133#issuecomment-628151482 ## CI report: * 80bdfcb3ca8d21a3b9908d089bc3514e4ff5e807 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12145: [FLINK-17428] [table-planner-blink] supports projection push down on new table source interface in blink planner

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12145: URL: https://github.com/apache/flink/pull/12145#issuecomment-628490262 ## CI report: * ba9ee6228cf9eea60df403e37b41b907fef21a28 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12135: [FLINK-16999][table-runtime-blink] Add converters for all data types and classes

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12135: URL: https://github.com/apache/flink/pull/12135#issuecomment-628176758 ## CI report: * d0cd31f2786ee776579dcb1b1aa90c3e27c1b67e Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12120: [FLINK-17547] Support unaligned checkpoints for records spilled to files

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12120: URL: https://github.com/apache/flink/pull/12120#issuecomment-628150581 ## CI report: * 4b453c84b4823034f4118e24191339851096097e Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12108: [FLINK-17448][sql-parser][table-api-java][table-planner-blink][hive] Implement table DDLs for Hive dialect part2

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12108: URL: https://github.com/apache/flink/pull/12108#issuecomment-627804642 ## CI report: * 66bbeb2e19f810744287740e7a691da17ebb8b0c Azure:

[GitHub] [flink] rkhachatryan commented on a change in pull request #12120: [FLINK-17547] Support unaligned checkpoints for records spilled to files

2020-05-16 Thread GitBox
rkhachatryan commented on a change in pull request #12120: URL: https://github.com/apache/flink/pull/12120#discussion_r426139079 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/FileBasedBufferIterator.java ## @@ -85,6 +90,6 @@ private int

[GitHub] [flink] lirui-apache commented on pull request #12108: [FLINK-17448][sql-parser][table-api-java][table-planner-blink][hive] Implement table DDLs for Hive dialect part2

2020-05-16 Thread GitBox
lirui-apache commented on pull request #12108: URL: https://github.com/apache/flink/pull/12108#issuecomment-629620248 I have updated the PR to add operations for the ALTER COLUMNS statements, so that we don't have to store column types as table properties. With this approach, we

[GitHub] [flink] flinkbot edited a comment on pull request #11109: [FLINK-15758][MemManager] Release segment and its unsafe memory in GC Cleaner

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #11109: URL: https://github.com/apache/flink/pull/11109#issuecomment-586932050 ## CI report: * 13d545aca4b423ff424dd52bde946aef10acdaf9 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162397442) Azure:

[GitHub] [flink] wuchong commented on a change in pull request #12176: [FLINK-17029][jdbc]Introduce a new JDBC connector with new property keys

2020-05-16 Thread GitBox
wuchong commented on a change in pull request #12176: URL: https://github.com/apache/flink/pull/12176#discussion_r426133850 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java ## @@ -0,0 +1,162 @@

[GitHub] [flink] wangyang0918 commented on pull request #12015: [FLINK-17416] Bump okhttp version to 3.12.11 and 3.14.8

2020-05-16 Thread GitBox
wangyang0918 commented on pull request #12015: URL: https://github.com/apache/flink/pull/12015#issuecomment-629619187 Close this PR since this is not the root cause of FLINK-17416. This is an automated message from the

[GitHub] [flink] wangyang0918 closed pull request #12015: [FLINK-17416] Bump okhttp version to 3.12.11 and 3.14.8

2020-05-16 Thread GitBox
wangyang0918 closed pull request #12015: URL: https://github.com/apache/flink/pull/12015 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] manbuyun commented on pull request #12169: [FLINK-17495][metrics][prometheus]Add custom labels on PrometheusReporter like PrometheusPushGatewayReporter's groupingKey

2020-05-16 Thread GitBox
manbuyun commented on pull request #12169: URL: https://github.com/apache/flink/pull/12169#issuecomment-629618713 @flinkbot run travis This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (FLINK-17743) Python e2e failed by Cannot run program "venv.zip/.conda/bin/python"

2020-05-16 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108964#comment-17108964 ] Dian Fu commented on FLINK-17743: - [~lzljs3620320] Thanks for reporting this issue. It is duplicate with

[jira] [Closed] (FLINK-17743) Python e2e failed by Cannot run program "venv.zip/.conda/bin/python"

2020-05-16 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-17743. --- Resolution: Duplicate > Python e2e failed by Cannot run program "venv.zip/.conda/bin/python" >

[jira] [Closed] (FLINK-17734) Add specialized collecting sink function

2020-05-16 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-17734. -- Assignee: Caizhi Weng Resolution: Fixed master: 7c6251ede2e164ce29749088a4cd0903f6a486aa > Add

[GitHub] [flink] KurtYoung closed pull request #12069: [FLINK-17734][streaming] Add specialized collecting sink function

2020-05-16 Thread GitBox
KurtYoung closed pull request #12069: URL: https://github.com/apache/flink/pull/12069 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (FLINK-17753) watermark defined in ddl does not work in Table api

2020-05-16 Thread godfrey he (Jira)
godfrey he created FLINK-17753: -- Summary: watermark defined in ddl does not work in Table api Key: FLINK-17753 URL: https://issues.apache.org/jira/browse/FLINK-17753 Project: Flink Issue Type:

[jira] [Commented] (FLINK-17752) Align the timestamp format with Flink SQL types in JSON format

2020-05-16 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108950#comment-17108950 ] Dawid Wysakowicz commented on FLINK-17752: -- Just to add a few more issues with time handling in

[jira] [Created] (FLINK-17752) Align the timestamp format with Flink SQL types in JSON format

2020-05-16 Thread Jark Wu (Jira)
Jark Wu created FLINK-17752: --- Summary: Align the timestamp format with Flink SQL types in JSON format Key: FLINK-17752 URL: https://issues.apache.org/jira/browse/FLINK-17752 Project: Flink Issue

[GitHub] [flink] flinkbot edited a comment on pull request #12186: [FLINK-16383][task] Do not relay notifyCheckpointComplete to closed operators

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12186: URL: https://github.com/apache/flink/pull/12186#issuecomment-629492236 ## CI report: * a3129c8853f1b9af6ceb3a1f8749a70a7dc2f9f2 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12069: [FLINK-17734][streaming] Add specialized collecting sink function

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12069: URL: https://github.com/apache/flink/pull/12069#issuecomment-626515528 ## CI report: * 731dff0812f1abb16193f7a2fe6f54b3ef65ae2d UNKNOWN * 3b2df3e55d6137b0acfc5746ca97ac164a08ad27 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #12056: [FLINK-17502] [flink-connector-rabbitmq] RMQSource refactor

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12056: URL: https://github.com/apache/flink/pull/12056#issuecomment-626167900 ## CI report: * cddd8835721c3ad590706c0db218cdca6fa323ae Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12135: [FLINK-16999][table-runtime-blink] Add converters for all data types and classes

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12135: URL: https://github.com/apache/flink/pull/12135#issuecomment-628176758 ## CI report: * d0cd31f2786ee776579dcb1b1aa90c3e27c1b67e Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12184: [FLINK-17027] Introduce a new Elasticsearch 7 connector with new property keys

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12184: URL: https://github.com/apache/flink/pull/12184#issuecomment-629425634 ## CI report: * 99bd627fe8cffe7f4f4417be049b0eb94ec4db79 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11854: [FLINK-17407] Introduce external resource framework

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #11854: URL: https://github.com/apache/flink/pull/11854#issuecomment-617586491 ## CI report: * bddb0e274da11bbe99d15c6e0bb55e8d8c0e658a UNKNOWN * dc7a9c5c7d1fac82518815b9277809dfb82ddaac UNKNOWN *

[GitHub] [flink] leonardBang commented on a change in pull request #12176: [FLINK-17029][jdbc]Introduce a new JDBC connector with new property keys

2020-05-16 Thread GitBox
leonardBang commented on a change in pull request #12176: URL: https://github.com/apache/flink/pull/12176#discussion_r426135776 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicInputFormat.java ## @@ -0,0

[GitHub] [flink] lirui-apache commented on a change in pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…

2020-05-16 Thread GitBox
lirui-apache commented on a change in pull request #12029: URL: https://github.com/apache/flink/pull/12029#discussion_r426135660 ## File path: flink-table/flink-sql-parser-hive/src/test/java/org/apache/flink/sql/parser/hive/FlinkHiveSqlParserImplTest.java ## @@ -221,4 +221,49

[jira] [Created] (FLINK-17751) proctime defined in ddl can't work with over window in Table api

2020-05-16 Thread godfrey he (Jira)
godfrey he created FLINK-17751: -- Summary: proctime defined in ddl can't work with over window in Table api Key: FLINK-17751 URL: https://issues.apache.org/jira/browse/FLINK-17751 Project: Flink

[jira] [Commented] (FLINK-15649) Support mounting volumes

2020-05-16 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108939#comment-17108939 ] Yang Wang commented on FLINK-15649: --- Maybe we need to increase the priority for this feature.

[GitHub] [flink] flinkbot edited a comment on pull request #12184: [FLINK-17027] Introduce a new Elasticsearch 7 connector with new property keys

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12184: URL: https://github.com/apache/flink/pull/12184#issuecomment-629425634 ## CI report: * 99bd627fe8cffe7f4f4417be049b0eb94ec4db79 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12186: [FLINK-16383][task] Do not relay notifyCheckpointComplete to closed operators

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12186: URL: https://github.com/apache/flink/pull/12186#issuecomment-629492236 ## CI report: * a3129c8853f1b9af6ceb3a1f8749a70a7dc2f9f2 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12171: [FLINK-17715][sql client] Supports function DDLs in SQL-CLI

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12171: URL: https://github.com/apache/flink/pull/12171#issuecomment-629218919 ## CI report: * 2d508f776da68adffc61555a5bea2fe6a1b4d3e9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12168: [WIP][FLINK-14255][hive] Integrate hive to streaming file sink

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12168: URL: https://github.com/apache/flink/pull/12168#issuecomment-629179735 ## CI report: * 2c97f52f8d206393ab06a555d3510392b2638015 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12135: [FLINK-16999][table-runtime-blink] Add converters for all data types and classes

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12135: URL: https://github.com/apache/flink/pull/12135#issuecomment-628176758 ## CI report: * d0cd31f2786ee776579dcb1b1aa90c3e27c1b67e Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12056: [FLINK-17502] [flink-connector-rabbitmq] RMQSource refactor

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12056: URL: https://github.com/apache/flink/pull/12056#issuecomment-626167900 ## CI report: * cddd8835721c3ad590706c0db218cdca6fa323ae Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12069: [FLINK-17734][streaming] Add specialized collecting sink function

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12069: URL: https://github.com/apache/flink/pull/12069#issuecomment-626515528 ## CI report: * 731dff0812f1abb16193f7a2fe6f54b3ef65ae2d UNKNOWN * 3b2df3e55d6137b0acfc5746ca97ac164a08ad27 UNKNOWN *

[GitHub] [flink] danny0405 commented on a change in pull request #12188: [FLINK-17728] [sql-client] sql client supports parser statements via sql parser

2020-05-16 Thread GitBox
danny0405 commented on a change in pull request #12188: URL: https://github.com/apache/flink/pull/12188#discussion_r426133545 ## File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/SqlCommandParser.java ## @@ -194,6 +283,11 @@ private

[GitHub] [flink] flinkbot edited a comment on pull request #11725: [FLINK-15670][API] Provide a Kafka Source/Sink pair as KafkaShuffle

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #11725: URL: https://github.com/apache/flink/pull/11725#issuecomment-613252882 ## CI report: * 066795205734add3b142a92c687c98b25253985e UNKNOWN * 6c24e114e622b0130e921d6994aad9a48aa2318b Azure:

[GitHub] [flink] mghildiy commented on pull request #11976: FIX-17376:Deprecated methods and associated code removed

2020-05-16 Thread GitBox
mghildiy commented on pull request #11976: URL: https://github.com/apache/flink/pull/11976#issuecomment-629612339 Closing this PR. Would make another one. This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] mghildiy closed pull request #11976: FIX-17376:Deprecated methods and associated code removed

2020-05-16 Thread GitBox
mghildiy closed pull request #11976: URL: https://github.com/apache/flink/pull/11976 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Closed] (FLINK-17719) Provide ChannelStateReader#hasStates for hints of reading channel states

2020-05-16 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-17719. -- Fix Version/s: 1.11.0 Resolution: Fixed Merged to master as 2b42209dd6 > Provide

[GitHub] [flink] pnowojski commented on pull request #12163: [FLINK-17719][task][checkpointing] Provide ChannelStateReader#hasStates for hints of reading channel states

2020-05-16 Thread GitBox
pnowojski commented on pull request #12163: URL: https://github.com/apache/flink/pull/12163#issuecomment-629611014 Private azure build succeeded https://dev.azure.com/pnowojski/Flink/_build/results?buildId=35=results % unrelated known issue

[GitHub] [flink] pnowojski merged pull request #12163: [FLINK-17719][task][checkpointing] Provide ChannelStateReader#hasStates for hints of reading channel states

2020-05-16 Thread GitBox
pnowojski merged pull request #12163: URL: https://github.com/apache/flink/pull/12163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] wuchong commented on a change in pull request #12176: [FLINK-17029][jdbc]Introduce a new JDBC connector with new property keys

2020-05-16 Thread GitBox
wuchong commented on a change in pull request #12176: URL: https://github.com/apache/flink/pull/12176#discussion_r426125630 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicInputFormat.java ## @@ -0,0 +1,402 @@

[GitHub] [flink] pnowojski commented on a change in pull request #12186: [FLINK-16383][task] Do not relay notifyCheckpointComplete to closed operators

2020-05-16 Thread GitBox
pnowojski commented on a change in pull request #12186: URL: https://github.com/apache/flink/pull/12186#discussion_r426133280 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ## @@ -269,16 +284,18

[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12181: URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595 ## CI report: * a7df4077fb5715e0a9ce097b773f49a197eb27dd Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12171: [FLINK-17715][sql client] Supports function DDLs in SQL-CLI

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12171: URL: https://github.com/apache/flink/pull/12171#issuecomment-629218919 ## CI report: * 2d508f776da68adffc61555a5bea2fe6a1b4d3e9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12069: [FLINK-17734][streaming] Add specialized collecting sink function

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12069: URL: https://github.com/apache/flink/pull/12069#issuecomment-626515528 ## CI report: * 731dff0812f1abb16193f7a2fe6f54b3ef65ae2d UNKNOWN * 3b2df3e55d6137b0acfc5746ca97ac164a08ad27 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #12090: [FLINK-17622][connectors / jdbc] Remove useless switch for decimal in PostgresCatalog

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12090: URL: https://github.com/apache/flink/pull/12090#issuecomment-626999634 ## CI report: * 46e40339d114c04bdefa7d296f79193c6156c165 Azure:

[GitHub] [flink] JingsongLi commented on a change in pull request #12133: [FLINK-17526][avro] Support AVRO serialization and deseriazation sche…

2020-05-16 Thread GitBox
JingsongLi commented on a change in pull request #12133: URL: https://github.com/apache/flink/pull/12133#discussion_r426131440 ## File path: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroSchemaConverter.java ## @@ -157,4 +166,118 @@

[jira] [Closed] (FLINK-17350) StreamTask should always fail immediately on failures in synchronous part of a checkpoint

2020-05-16 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-17350. -- Release Note: Failures in synchronous part of checkpointing (like an exceptions thrown by an

[GitHub] [flink] KurtYoung commented on a change in pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…

2020-05-16 Thread GitBox
KurtYoung commented on a change in pull request #12029: URL: https://github.com/apache/flink/pull/12029#discussion_r426130612 ## File path: flink-table/flink-sql-parser-hive/src/test/java/org/apache/flink/sql/parser/hive/FlinkHiveSqlParserImplTest.java ## @@ -221,4 +221,49 @@

[GitHub] [flink] pnowojski merged pull request #12101: [FLINK-17350][task] StreamTask should always fail immediately on failures in synchronous part of a checkpoint

2020-05-16 Thread GitBox
pnowojski merged pull request #12101: URL: https://github.com/apache/flink/pull/12101 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] pnowojski commented on pull request #12101: [FLINK-17350][task] StreamTask should always fail immediately on failures in synchronous part of a checkpoint

2020-05-16 Thread GitBox
pnowojski commented on pull request #12101: URL: https://github.com/apache/flink/pull/12101#issuecomment-629606450 Thanks for the review @AHeise merging This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] pnowojski commented on a change in pull request #12101: [FLINK-17350][task] StreamTask should always fail immediately on failures in synchronous part of a checkpoint

2020-05-16 Thread GitBox
pnowojski commented on a change in pull request #12101: URL: https://github.com/apache/flink/pull/12101#discussion_r426130049 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/TaskCheckpointingBehaviourTest.java ## @@ -141,13 +141,18 @@

[GitHub] [flink] flinkbot edited a comment on pull request #12185: [FLINK-7267][connectors/rabbitmq] Allow overriding RMQ connection setup

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12185: URL: https://github.com/apache/flink/pull/12185#issuecomment-629434033 ## CI report: * f2c27e8d19db94e6c57ed5437db3dda01d3fd143 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12090: [FLINK-17622][connectors / jdbc] Remove useless switch for decimal in PostgresCatalog

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12090: URL: https://github.com/apache/flink/pull/12090#issuecomment-626999634 ## CI report: * 46e40339d114c04bdefa7d296f79193c6156c165 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12168: [WIP][FLINK-14255][hive] Integrate hive to streaming file sink

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12168: URL: https://github.com/apache/flink/pull/12168#issuecomment-629179735 ## CI report: * 2c97f52f8d206393ab06a555d3510392b2638015 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12188: [FLINK-17728] [sql-client] sql client supports parser statements via sql parser

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12188: URL: https://github.com/apache/flink/pull/12188#issuecomment-629595773 ## CI report: * 7111bcfcc655d8d6b0ee5f9ff66e80e732f7272e Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12181: URL: https://github.com/apache/flink/pull/12181#issuecomment-629344595 ## CI report: * a7df4077fb5715e0a9ce097b773f49a197eb27dd Azure:

[GitHub] [flink] guoweiM commented on pull request #12132: [FLINK-17593][Connectors/FileSystem] Support arbitrary recovery mechanism for PartFileWriter

2020-05-16 Thread GitBox
guoweiM commented on pull request #12132: URL: https://github.com/apache/flink/pull/12132#issuecomment-629604823 Hi, @kl0u thanks for your review. 1. You are right. We could rename the `PartFileWriter` to `InProgressFileWriter`. 2. You are very careful. We should remove the

[GitHub] [flink] JingsongLi commented on a change in pull request #12133: [FLINK-17526][avro] Support AVRO serialization and deseriazation sche…

2020-05-16 Thread GitBox
JingsongLi commented on a change in pull request #12133: URL: https://github.com/apache/flink/pull/12133#discussion_r426129667 ## File path: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroSchemaConverter.java ## @@ -157,4 +166,118 @@

[GitHub] [flink] curcur commented on a change in pull request #11725: [FLINK-15670][API] Provide a Kafka Source/Sink pair as KafkaShuffle

2020-05-16 Thread GitBox
curcur commented on a change in pull request #11725: URL: https://github.com/apache/flink/pull/11725#discussion_r426129684 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaFetcher.java ## @@ -192,6

[GitHub] [flink] becketqin commented on a change in pull request #12137: [FLINK-16177][FLINK-16357][checkpointing] Complete / improve checkpointing for OperatorCoordinators

2020-05-16 Thread GitBox
becketqin commented on a change in pull request #12137: URL: https://github.com/apache/flink/pull/12137#discussion_r426112436 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/metadata/MetadataV2V3SerializerBase.java ## @@ -468,6 +468,7 @@ public

[GitHub] [flink] JingsongLi commented on a change in pull request #12133: [FLINK-17526][avro] Support AVRO serialization and deseriazation sche…

2020-05-16 Thread GitBox
JingsongLi commented on a change in pull request #12133: URL: https://github.com/apache/flink/pull/12133#discussion_r426129528 ## File path: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroSchemaConverter.java ## @@ -157,4 +166,118 @@

[GitHub] [flink] fpompermaier commented on pull request #11900: [FLINK-17284][jdbc][postgres] Support serial fields

2020-05-16 Thread GitBox
fpompermaier commented on pull request #11900: URL: https://github.com/apache/flink/pull/11900#issuecomment-629603964 > Hi @fpompermaier , yes, your understanding in your email is right, and #12090 LGTM. Can you rebase the PR and revert the decimal part? I'll do it after the merge

[GitHub] [flink] JingsongLi commented on a change in pull request #12133: [FLINK-17526][avro] Support AVRO serialization and deseriazation sche…

2020-05-16 Thread GitBox
JingsongLi commented on a change in pull request #12133: URL: https://github.com/apache/flink/pull/12133#discussion_r426129250 ## File path: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroSchemaConverter.java ## @@ -157,4 +166,118 @@

[GitHub] [flink] AHeise commented on a change in pull request #12186: [FLINK-16383][task] Do not relay notifyCheckpointComplete to closed operators

2020-05-16 Thread GitBox
AHeise commented on a change in pull request #12186: URL: https://github.com/apache/flink/pull/12186#discussion_r426129194 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ## @@ -174,7 +174,9 @@

[GitHub] [flink] wanglijie95 commented on pull request #12181: [FLINK-17645][runtime] Fix SafetyNetCloseableRegistry constructor bug.

2020-05-16 Thread GitBox
wanglijie95 commented on pull request #12181: URL: https://github.com/apache/flink/pull/12181#issuecomment-629603673 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] AHeise commented on a change in pull request #12186: [FLINK-16383][task] Do not relay notifyCheckpointComplete to closed operators

2020-05-16 Thread GitBox
AHeise commented on a change in pull request #12186: URL: https://github.com/apache/flink/pull/12186#discussion_r426129194 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ## @@ -174,7 +174,9 @@

[GitHub] [flink] AHeise commented on a change in pull request #12101: [FLINK-17350][task] StreamTask should always fail immediately on failures in synchronous part of a checkpoint

2020-05-16 Thread GitBox
AHeise commented on a change in pull request #12101: URL: https://github.com/apache/flink/pull/12101#discussion_r426129028 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/TaskCheckpointingBehaviourTest.java ## @@ -141,13 +141,18 @@

[GitHub] [flink] flinkbot edited a comment on pull request #12168: [WIP][FLINK-14255][hive] Integrate hive to streaming file sink

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12168: URL: https://github.com/apache/flink/pull/12168#issuecomment-629179735 ## CI report: * 2c97f52f8d206393ab06a555d3510392b2638015 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12133: [FLINK-17526][avro] Support AVRO serialization and deseriazation sche…

2020-05-16 Thread GitBox
flinkbot edited a comment on pull request #12133: URL: https://github.com/apache/flink/pull/12133#issuecomment-628151482 ## CI report: * 80bdfcb3ca8d21a3b9908d089bc3514e4ff5e807 Azure:

[GitHub] [flink] danny0405 commented on a change in pull request #12133: [FLINK-17526][avro] Support AVRO serialization and deseriazation sche…

2020-05-16 Thread GitBox
danny0405 commented on a change in pull request #12133: URL: https://github.com/apache/flink/pull/12133#discussion_r426128815 ## File path: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowDataDeserializationSchema.java ## @@ -0,0 +1,371 @@ +/* + *

[jira] [Commented] (FLINK-17737) KeyedStateCheckpointingITCase fails in UnalignedCheckpoint mode

2020-05-16 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108902#comment-17108902 ] Piotr Nowojski commented on FLINK-17737: [~complone] it's UnalignedCheckpoint mode FLINK-14551.

<    1   2   3   4   5   6   >