dalongliu created FLINK-19207:
-
Summary: TtlListState#IteratorWithCleanup support remove method
Key: FLINK-19207
URL: https://issues.apache.org/jira/browse/FLINK-19207
Project: Flink
Issue Type:
[
https://issues.apache.org/jira/browse/FLINK-19207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dalongliu updated FLINK-19207:
--
Description: In [Minibatch Group Agg support state ttl
|https://issues.apache.org/jira/browse/FLINK-17
[
https://issues.apache.org/jira/browse/FLINK-19207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dalongliu updated FLINK-19207:
--
Description: In Minibatch Group Agg support state ttl , we are using TTL
State refactor group Agg func
[
https://issues.apache.org/jira/browse/FLINK-19207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dalongliu updated FLINK-19207:
--
Description: In [ Minibatch Group Agg support state
ttl|https://issues.apache.org/jira/browse/FLINK-17
[
https://issues.apache.org/jira/browse/FLINK-19207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dalongliu updated FLINK-19207:
--
Description: In
[Flink-17096|https://issues.apache.org/jira/browse/FLINK-17096] , we are using
TTL St
[
https://issues.apache.org/jira/browse/FLINK-19207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dalongliu updated FLINK-19207:
--
Description: In Flink-17096 , we are using TTL State refactor group Agg
function state expiration impl
[
https://issues.apache.org/jira/browse/FLINK-19198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17194648#comment-17194648
]
Paul Lin commented on FLINK-19198:
--
cc [~lzljs3620320]
> Invalid default value for con
[
https://issues.apache.org/jira/browse/FLINK-19207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17194649#comment-17194649
]
dalongliu edited comment on FLINK-19207 at 9/12/20, 7:58 AM:
-
[
https://issues.apache.org/jira/browse/FLINK-19207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17194649#comment-17194649
]
dalongliu commented on FLINK-19207:
---
[~jark] after study the source code of IteratorWi
[
https://issues.apache.org/jira/browse/FLINK-19207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17194649#comment-17194649
]
dalongliu edited comment on FLINK-19207 at 9/12/20, 7:59 AM:
-
zjffdu closed pull request #6236:
URL: https://github.com/apache/flink/pull/6236
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
zjffdu closed pull request #7214:
URL: https://github.com/apache/flink/pull/7214
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
zjffdu closed pull request #6245:
URL: https://github.com/apache/flink/pull/6245
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
darion yaphet created FLINK-19208:
-
Summary: Refine the tuple's equals
Key: FLINK-19208
URL: https://issues.apache.org/jira/browse/FLINK-19208
Project: Flink
Issue Type: Improvement
darionyaphet opened a new pull request #13376:
URL: https://github.com/apache/flink/pull/13376
## What is the purpose of the change
When we check the tuple is equal,
`f0 != null ? !f0.equals(tuple.f0) : tuple.f0 != null` could refine to
`!Objects.equals(f0, tuple.f0)
[
https://issues.apache.org/jira/browse/FLINK-19208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-19208:
---
Labels: pull-request-available (was: )
> Refine the tuple's equals
> --
[
https://issues.apache.org/jira/browse/FLINK-19208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
darion yaphet updated FLINK-19208:
--
Description: When we check the tuple is equal, f0 != null ?
!f0.equals(tuple.f0) : tuple.f0 !=
flinkbot commented on pull request #13376:
URL: https://github.com/apache/flink/pull/13376#issuecomment-691477620
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review your pull request. We will use this comment to track the pro
flinkbot commented on pull request #13376:
URL: https://github.com/apache/flink/pull/13376#issuecomment-691478919
## CI report:
* 15baf19e3d6e62a81412c905a530b000db40a425 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot r
flinkbot edited a comment on pull request #13376:
URL: https://github.com/apache/flink/pull/13376#issuecomment-691478919
## CI report:
* 15baf19e3d6e62a81412c905a530b000db40a425 Azure:
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
flinkbot edited a comment on pull request #13376:
URL: https://github.com/apache/flink/pull/13376#issuecomment-691478919
## CI report:
* 15baf19e3d6e62a81412c905a530b000db40a425 Azure:
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
flinkbot edited a comment on pull request #13376:
URL: https://github.com/apache/flink/pull/13376#issuecomment-691478919
## CI report:
* 15baf19e3d6e62a81412c905a530b000db40a425 Azure:
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
flinkbot edited a comment on pull request #13376:
URL: https://github.com/apache/flink/pull/13376#issuecomment-691478919
## CI report:
* 15baf19e3d6e62a81412c905a530b000db40a425 Azure:
[CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul
flinkbot edited a comment on pull request #13376:
URL: https://github.com/apache/flink/pull/13376#issuecomment-691478919
## CI report:
* 54ac1f6aaa65726837d3cfa362759aca9a275fa8 Azure:
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
walterddr commented on a change in pull request #13356:
URL: https://github.com/apache/flink/pull/13356#discussion_r487432460
##
File path: docs/_includes/generated/execution_config_configuration.html
##
@@ -106,6 +100,12 @@
Boolean
Whether to compress
walterddr commented on a change in pull request #13356:
URL: https://github.com/apache/flink/pull/13356#discussion_r487432527
##
File path: docs/_includes/generated/jmx_server_configuration.html
##
@@ -0,0 +1,18 @@
+
Review comment:
this is actually due to the fact that
flinkbot edited a comment on pull request #13356:
URL: https://github.com/apache/flink/pull/13356#issuecomment-688955548
## CI report:
* 656789f8c2f1288e3b9cf369f82d0698b249f179 Azure:
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
flinkbot edited a comment on pull request #13356:
URL: https://github.com/apache/flink/pull/13356#issuecomment-688955548
## CI report:
* 656789f8c2f1288e3b9cf369f82d0698b249f179 Azure:
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
[
https://issues.apache.org/jira/browse/FLINK-19176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17194832#comment-17194832
]
Galen Warren commented on FLINK-19176:
--
Hi [~igal] - I've forked the project and ta
pnowojski commented on a change in pull request #13228:
URL: https://github.com/apache/flink/pull/13228#discussion_r487038327
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##
@@ -167,23 +171,46 @@ private boo
dawidwys commented on a change in pull request #13373:
URL: https://github.com/apache/flink/pull/13373#discussion_r487027309
##
File path:
flink-formats/flink-avro/src/test/java/org/apache/flink/table/runtime/batch/AvroTypesITCase.java
##
@@ -58,7 +55,7 @@
@RunWith(Parameteri
flinkbot edited a comment on pull request #13360:
URL: https://github.com/apache/flink/pull/13360#issuecomment-689414065
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
morsapaes commented on a change in pull request #16:
URL: https://github.com/apache/flink-playgrounds/pull/16#discussion_r486966065
##
File path: pyflink-walkthrough/payment_msg_proccessing.py
##
@@ -0,0 +1,93 @@
+
dawidwys commented on a change in pull request #13360:
URL: https://github.com/apache/flink/pull/13360#discussion_r486946393
##
File path: docs/dev/connectors/kafka.md
##
@@ -466,12 +445,12 @@ Through the producer record you can:
### Kafka Producers and Fault Tolerance
-
-
zhuzhurk commented on pull request #13284:
URL: https://github.com/apache/flink/pull/13284#issuecomment-691124551
Thanks for reviewing! @azagrebin
Merging.
This is an automated message from the Apache Git Service.
To resp
flinkbot edited a comment on pull request #13356:
URL: https://github.com/apache/flink/pull/13356#issuecomment-688955548
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
rmetzger commented on pull request #6689:
URL: https://github.com/apache/flink/pull/6689#issuecomment-690992858
I have the feeling that this ticket is stale. I will close it for now. If
you or somebody else wants to work on it, please reopen or re-submit it.
--
flinkbot edited a comment on pull request #13374:
URL: https://github.com/apache/flink/pull/13374#issuecomment-691175789
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
zjffdu closed pull request #6245:
URL: https://github.com/apache/flink/pull/6245
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
xintongsong commented on pull request #378:
URL: https://github.com/apache/flink-web/pull/378#issuecomment-690824584
Thanks for the reminder @zhuzhurk, and thanks for the pointer @morsapaes
(Marta!)
PR updated.
This is an
zhuzhurk merged pull request #13284:
URL: https://github.com/apache/flink/pull/13284
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
flinkbot edited a comment on pull request #13376:
URL: https://github.com/apache/flink/pull/13376#issuecomment-691478919
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
flinkbot edited a comment on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674957571
## CI report:
* 32e7196f7eb7474982fa0e4e6489403316575099 Azure:
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
flinkbot commented on pull request #13373:
URL: https://github.com/apache/flink/pull/13373#issuecomment-691077759
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
flinkbot edited a comment on pull request #13375:
URL: https://github.com/apache/flink/pull/13375#issuecomment-691410175
## CI report:
* c10af2d6ed4136ff9a8ae30ab0841343635bf0f4 Azure:
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result
rmetzger closed pull request #6689:
URL: https://github.com/apache/flink/pull/6689
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
aljoscha commented on pull request #13343:
URL: https://github.com/apache/flink/pull/13343#issuecomment-691149771
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
sjwiesman commented on a change in pull request #147:
URL: https://github.com/apache/flink-statefun/pull/147#discussion_r487120168
##
File path: docs/sdk/java.md
##
@@ -364,6 +364,43 @@ PersistedTable table =
PersistedTable.of("my-table", String.cla
PersistedAppendingBuffer b
aljoscha commented on pull request #13360:
URL: https://github.com/apache/flink/pull/13360#issuecomment-691176913
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dawidwys commented on pull request #13373:
URL: https://github.com/apache/flink/pull/13373#issuecomment-691240195
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
flinkbot commented on pull request #13375:
URL: https://github.com/apache/flink/pull/13375#issuecomment-691408906
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
flinkbot edited a comment on pull request #13373:
URL: https://github.com/apache/flink/pull/13373#issuecomment-691085636
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
flinkbot edited a comment on pull request #13372:
URL: https://github.com/apache/flink/pull/13372#issuecomment-691076967
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
zjffdu closed pull request #6236:
URL: https://github.com/apache/flink/pull/6236
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
kezhuw commented on pull request #13375:
URL: https://github.com/apache/flink/pull/13375#issuecomment-691409015
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
twalthr commented on a change in pull request #13373:
URL: https://github.com/apache/flink/pull/13373#discussion_r487029161
##
File path:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoComparator.java
##
@@ -176,14 +181,25 @@ public void getFlatCompar
walterddr commented on a change in pull request #13356:
URL: https://github.com/apache/flink/pull/13356#discussion_r487432460
##
File path: docs/_includes/generated/execution_config_configuration.html
##
@@ -106,6 +100,12 @@
Boolean
Whether to compress
zjffdu closed pull request #7214:
URL: https://github.com/apache/flink/pull/7214
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
zhuzhurk commented on pull request #378:
URL: https://github.com/apache/flink-web/pull/378#issuecomment-691131606
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
sjwiesman closed pull request #149:
URL: https://github.com/apache/flink-statefun/pull/149
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
flinkbot commented on pull request #13374:
URL: https://github.com/apache/flink/pull/13374#issuecomment-691168441
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
aljoscha commented on a change in pull request #13360:
URL: https://github.com/apache/flink/pull/13360#discussion_r487121698
##
File path: docs/dev/connectors/kafka.md
##
@@ -405,8 +385,7 @@ Consider setting appropriate [idelness timeouts]({{
site.baseurl }}/dev/event_ti
#
flinkbot edited a comment on pull request #13228:
URL: https://github.com/apache/flink/pull/13228#issuecomment-679099456
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
zhuzhurk edited a comment on pull request #378:
URL: https://github.com/apache/flink-web/pull/378#issuecomment-691136281
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
flinkbot commented on pull request #13376:
URL: https://github.com/apache/flink/pull/13376#issuecomment-691477620
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
flinkbot commented on pull request #13372:
URL: https://github.com/apache/flink/pull/13372#issuecomment-691067862
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
flinkbot edited a comment on pull request #13344:
URL: https://github.com/apache/flink/pull/13344#issuecomment-688495541
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
sjwiesman commented on a change in pull request #147:
URL: https://github.com/apache/flink-statefun/pull/147#discussion_r487120168
##
File path: docs/sdk/java.md
##
@@ -364,6 +364,43 @@ PersistedTable table =
PersistedTable.of("my-table", String.cla
PersistedAppendingBuffer b
pnowojski commented on a change in pull request #13228:
URL: https://github.com/apache/flink/pull/13228#discussion_r487038327
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##
@@ -167,23 +171,46 @@ private boo
dawidwys commented on a change in pull request #13373:
URL: https://github.com/apache/flink/pull/13373#discussion_r487027309
##
File path:
flink-formats/flink-avro/src/test/java/org/apache/flink/table/runtime/batch/AvroTypesITCase.java
##
@@ -58,7 +55,7 @@
@RunWith(Parameteri
flinkbot edited a comment on pull request #13360:
URL: https://github.com/apache/flink/pull/13360#issuecomment-689414065
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
morsapaes commented on a change in pull request #16:
URL: https://github.com/apache/flink-playgrounds/pull/16#discussion_r486966065
##
File path: pyflink-walkthrough/payment_msg_proccessing.py
##
@@ -0,0 +1,93 @@
+
dawidwys commented on a change in pull request #13360:
URL: https://github.com/apache/flink/pull/13360#discussion_r486946393
##
File path: docs/dev/connectors/kafka.md
##
@@ -466,12 +445,12 @@ Through the producer record you can:
### Kafka Producers and Fault Tolerance
-
-
zhuzhurk commented on pull request #13284:
URL: https://github.com/apache/flink/pull/13284#issuecomment-691124551
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
flinkbot edited a comment on pull request #13356:
URL: https://github.com/apache/flink/pull/13356#issuecomment-688955548
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
rmetzger commented on pull request #6689:
URL: https://github.com/apache/flink/pull/6689#issuecomment-690992858
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
zjffdu closed pull request #6245:
URL: https://github.com/apache/flink/pull/6245
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
flinkbot edited a comment on pull request #13374:
URL: https://github.com/apache/flink/pull/13374#issuecomment-691175789
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
zhuzhurk merged pull request #13284:
URL: https://github.com/apache/flink/pull/13284
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
flinkbot edited a comment on pull request #13376:
URL: https://github.com/apache/flink/pull/13376#issuecomment-691478919
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
flinkbot edited a comment on pull request #13375:
URL: https://github.com/apache/flink/pull/13375#issuecomment-691410175
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
rmetzger closed pull request #6689:
URL: https://github.com/apache/flink/pull/6689
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
flinkbot commented on pull request #13373:
URL: https://github.com/apache/flink/pull/13373#issuecomment-691077759
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
aljoscha commented on pull request #13343:
URL: https://github.com/apache/flink/pull/13343#issuecomment-691149771
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dawidwys commented on pull request #13373:
URL: https://github.com/apache/flink/pull/13373#issuecomment-691240195
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
aljoscha commented on pull request #13360:
URL: https://github.com/apache/flink/pull/13360#issuecomment-691176913
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
flinkbot commented on pull request #13375:
URL: https://github.com/apache/flink/pull/13375#issuecomment-691408906
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
flinkbot edited a comment on pull request #13373:
URL: https://github.com/apache/flink/pull/13373#issuecomment-691085636
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
flinkbot edited a comment on pull request #13372:
URL: https://github.com/apache/flink/pull/13372#issuecomment-691076967
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
zjffdu closed pull request #6236:
URL: https://github.com/apache/flink/pull/6236
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
kezhuw commented on pull request #13375:
URL: https://github.com/apache/flink/pull/13375#issuecomment-691409015
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
twalthr commented on a change in pull request #13373:
URL: https://github.com/apache/flink/pull/13373#discussion_r487029161
##
File path:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoComparator.java
##
@@ -176,14 +181,25 @@ public void getFlatCompar
walterddr commented on a change in pull request #13356:
URL: https://github.com/apache/flink/pull/13356#discussion_r487432460
##
File path: docs/_includes/generated/execution_config_configuration.html
##
@@ -106,6 +100,12 @@
Boolean
Whether to compress
zjffdu closed pull request #7214:
URL: https://github.com/apache/flink/pull/7214
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
pnowojski commented on a change in pull request #13228:
URL: https://github.com/apache/flink/pull/13228#discussion_r487038327
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##
@@ -167,23 +171,46 @@ private boo
dawidwys commented on a change in pull request #13373:
URL: https://github.com/apache/flink/pull/13373#discussion_r487027309
##
File path:
flink-formats/flink-avro/src/test/java/org/apache/flink/table/runtime/batch/AvroTypesITCase.java
##
@@ -58,7 +55,7 @@
@RunWith(Parameteri
flinkbot edited a comment on pull request #13360:
URL: https://github.com/apache/flink/pull/13360#issuecomment-689414065
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
dawidwys commented on a change in pull request #13360:
URL: https://github.com/apache/flink/pull/13360#discussion_r486946393
##
File path: docs/dev/connectors/kafka.md
##
@@ -466,12 +445,12 @@ Through the producer record you can:
### Kafka Producers and Fault Tolerance
-
-
morsapaes commented on a change in pull request #16:
URL: https://github.com/apache/flink-playgrounds/pull/16#discussion_r486966065
##
File path: pyflink-walkthrough/payment_msg_proccessing.py
##
@@ -0,0 +1,93 @@
+
zhuzhurk commented on pull request #13284:
URL: https://github.com/apache/flink/pull/13284#issuecomment-691124551
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
1 - 100 of 128 matches
Mail list logo
