[GitHub] [flink] flinkbot commented on pull request #13989: [FLINK-19448][connector/common] Synchronize fetchers.isEmpty status to SourceReaderBase using elementsQueue.notifyAvailable()

2020-11-08 Thread GitBox
flinkbot commented on pull request #13989: URL: https://github.com/apache/flink/pull/13989#issuecomment-723704219 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] becketqin commented on pull request #13574: [FLINK-18323] Add a Kafka source implementation based on FLIP-27.

2020-11-08 Thread GitBox
becketqin commented on pull request #13574: URL: https://github.com/apache/flink/pull/13574#issuecomment-723704072 @tillrohrmann Sorry for breaking the master. And thanks for the quick fix. I should have run the CI tests again after rebasing on the master even if there is no conflicts...

[jira] [Updated] (FLINK-19448) CoordinatedSourceITCase.testEnumeratorReaderCommunication hangs

2020-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-19448: --- Labels: pull-request-available test-stability (was: test-stability) >

[GitHub] [flink] kezhuw opened a new pull request #13989: [FLINK-19448][connector/common] Synchronize fetchers.isEmpty status to SourceReaderBase using elementsQueue.notifyAvailable()

2020-11-08 Thread GitBox
kezhuw opened a new pull request #13989: URL: https://github.com/apache/flink/pull/13989 ## What is the purpose of the change Synchronize `fetchers.isEmpty` status to `SourceReaderBase` using `elementsQueue.notifyAvailable()`. ## Brief change log * Add test case to fail empty

[GitHub] [flink] flinkbot edited a comment on pull request #13988: [FLINK-19265][FLINK-20049][core] Source API final adjustments

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13988: URL: https://github.com/apache/flink/pull/13988#issuecomment-723691966 ## CI report: * 1d621a3f57b64dbbd9f645347267aef8b245ca74 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13893: [FLINK-19933][DataStream] Execute and collect with limit fails on bounded datastream jobs

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13893: URL: https://github.com/apache/flink/pull/13893#issuecomment-720680334 ## CI report: * 1d72f03211d2273bc2586d5fc413cbe9a75e695e Azure:

[GitHub] [flink] flinkbot commented on pull request #13988: [FLINK-19265][FLINK-20049][core] Source API final adjustments

2020-11-08 Thread GitBox
flinkbot commented on pull request #13988: URL: https://github.com/apache/flink/pull/13988#issuecomment-723691966 ## CI report: * 1d621a3f57b64dbbd9f645347267aef8b245ca74 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #13988: [FLINK-19265][FLINK-20049][core] Source API final adjustments

2020-11-08 Thread GitBox
flinkbot commented on pull request #13988: URL: https://github.com/apache/flink/pull/13988#issuecomment-723687968 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-19265) Simplify handling of 'NoMoreSplitsEvent'

2020-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-19265: --- Labels: pull-request-available (was: ) > Simplify handling of 'NoMoreSplitsEvent' >

[GitHub] [flink] StephanEwen opened a new pull request #13988: [FLINK-19265][FLINK-20049][core] Source API final adjustments

2020-11-08 Thread GitBox
StephanEwen opened a new pull request #13988: URL: https://github.com/apache/flink/pull/13988 ## Purpose / Brief change log This adds convenience methods for the common actions around split requesting, rather than requiring every source to implement the event handling themselves.

[jira] [Created] (FLINK-20049) Simplify handling of "request split".

2020-11-08 Thread Stephan Ewen (Jira)
Stephan Ewen created FLINK-20049: Summary: Simplify handling of "request split". Key: FLINK-20049 URL: https://issues.apache.org/jira/browse/FLINK-20049 Project: Flink Issue Type:

[GitHub] [flink] flinkbot edited a comment on pull request #13987: [FLINK-14482][rocksdb] Bump FRocksDB version to 6.10.2-ververica-1.0

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13987: URL: https://github.com/apache/flink/pull/13987#issuecomment-723653653 ## CI report: * c618e021cde8ee0a6dce56b5df97b7cf00d77d06 Azure:

[jira] [Closed] (FLINK-19804) Make FileSource class generic with respect to split types

2020-11-08 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-19804. > Make FileSource class generic with respect to split types >

[jira] [Commented] (FLINK-20044) Disposal of RocksDB could last forever

2020-11-08 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228297#comment-17228297 ] Stephan Ewen commented on FLINK-20044: -- [~wind_ljy] The TaskManagers should kill the process after

[GitHub] [flink] flinkbot edited a comment on pull request #13985: [FLINK-19697] Make the Committer/GlobalCommitter retry-able

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13985: URL: https://github.com/apache/flink/pull/13985#issuecomment-723646083 ## CI report: * 9917da1cba5acff13ee14a68fa58763f2b430c75 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13776: [FLINK-19717][connectors/common] Fix spurious InputStatus.END_OF_INPUT from SourceReaderBase.pollNext caused by split reader exceptio

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13776: URL: https://github.com/apache/flink/pull/13776#issuecomment-715417467 ## CI report: * 89580c411718035563019a64bbf178dcb6b739e8 UNKNOWN * c138c988f40fa5f328f5560750a5ccab744ce279 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13893: [FLINK-19933][DataStream] Execute and collect with limit fails on bounded datastream jobs

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13893: URL: https://github.com/apache/flink/pull/13893#issuecomment-720680334 ## CI report: * 1366e3a9dab39c4a7bfc41b9ded3b6dc258e499d Azure:

[GitHub] [flink] StephanEwen edited a comment on pull request #13920: [FLINK-19743] Add metric definitions in FLIP-33 and report some of them by default.

2020-11-08 Thread GitBox
StephanEwen edited a comment on pull request #13920: URL: https://github.com/apache/flink/pull/13920#issuecomment-723639969 ## On Volatile Reads and Performance Considerations I think the `volatile` read assumption is not completely correct. There is a common interpretation that

[GitHub] [flink] flinkbot edited a comment on pull request #13893: [FLINK-19933][DataStream] Execute and collect with limit fails on bounded datastream jobs

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13893: URL: https://github.com/apache/flink/pull/13893#issuecomment-720680334 ## CI report: * 1366e3a9dab39c4a7bfc41b9ded3b6dc258e499d Azure:

[GitHub] [flink] StephanEwen edited a comment on pull request #13920: [FLINK-19743] Add metric definitions in FLIP-33 and report some of them by default.

2020-11-08 Thread GitBox
StephanEwen edited a comment on pull request #13920: URL: https://github.com/apache/flink/pull/13920#issuecomment-723639969 ## On Volatile Reads and Performance Considerations I think the `volatile` read assumption is not completely correct. There is a common interpretation that

[GitHub] [flink] StephanEwen edited a comment on pull request #13920: [FLINK-19743] Add metric definitions in FLIP-33 and report some of them by default.

2020-11-08 Thread GitBox
StephanEwen edited a comment on pull request #13920: URL: https://github.com/apache/flink/pull/13920#issuecomment-723639969 ## On Volatile Reads and Performance Considerations I think the `volatile` read assumption is not completely correct. There is a common interpretation that

[GitHub] [flink] StephanEwen edited a comment on pull request #13920: [FLINK-19743] Add metric definitions in FLIP-33 and report some of them by default.

2020-11-08 Thread GitBox
StephanEwen edited a comment on pull request #13920: URL: https://github.com/apache/flink/pull/13920#issuecomment-723639969 ## On Volatile Reads and Performance Considerations I think `volatile` read assumption is not completely correct. There is a common interpretation that this

[GitHub] [flink] sjwiesman commented on pull request #13893: [FLINK-19933][DataStream] Execute and collect with limit fails on bounded datastream jobs

2020-11-08 Thread GitBox
sjwiesman commented on pull request #13893: URL: https://github.com/apache/flink/pull/13893#issuecomment-723661794 @aljoscha thanks for catching that. I removed the mini-cluster, it's certainly slower but the "job" is so trivial and fast that I don't think its prohibitive as an IT case.

[jira] [Commented] (FLINK-19882) E2E: SQLClientHBaseITCase crash

2020-11-08 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228282#comment-17228282 ] Robert Metzger commented on FLINK-19882: I'll look into this one, since I'm looking already into

[jira] [Assigned] (FLINK-19882) E2E: SQLClientHBaseITCase crash

2020-11-08 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-19882: -- Assignee: Robert Metzger > E2E: SQLClientHBaseITCase crash >

[jira] [Commented] (FLINK-19882) E2E: SQLClientHBaseITCase crash

2020-11-08 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228281#comment-17228281 ] Robert Metzger commented on FLINK-19882:

[jira] [Commented] (FLINK-20011) PageRankITCase.testPrintWithRMatGraph hangs

2020-11-08 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228280#comment-17228280 ] Robert Metzger commented on FLINK-20011:

[GitHub] [flink] flinkbot edited a comment on pull request #13986: [FLINK-20016][python] Support TimestampAssigner and WatermarkGenerator for Python DataStream API.

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13986: URL: https://github.com/apache/flink/pull/13986#issuecomment-723648682 ## CI report: * 6afd298cd5356502822e36537d7a1c8ba67052b5 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13987: [FLINK-14482][rocksdb] Bump FRocksDB version to 6.10.2-ververica-1.0

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13987: URL: https://github.com/apache/flink/pull/13987#issuecomment-723653653 ## CI report: * c618e021cde8ee0a6dce56b5df97b7cf00d77d06 Azure:

[GitHub] [flink] rmetzger commented on pull request #13930: [FLINK-19974][python][e2e] Fix the bug that kafka related services are not teardown properly after tests finished

2020-11-08 Thread GitBox
rmetzger commented on pull request #13930: URL: https://github.com/apache/flink/pull/13930#issuecomment-723654331 sometimes the cibot is a bit buggy :/ This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] flinkbot commented on pull request #13987: [FLINK-14482][rocksdb] Bump FRocksDB version to 6.10.2-ververica-1.0

2020-11-08 Thread GitBox
flinkbot commented on pull request #13987: URL: https://github.com/apache/flink/pull/13987#issuecomment-723653653 ## CI report: * c618e021cde8ee0a6dce56b5df97b7cf00d77d06 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #13987: [FLINK-14482][rocksdb] Bump FRocksDB version to 6.10.2-ververica-1.0

2020-11-08 Thread GitBox
flinkbot commented on pull request #13987: URL: https://github.com/apache/flink/pull/13987#issuecomment-723652392 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] rmetzger commented on pull request #13574: [FLINK-18323] Add a Kafka source implementation based on FLIP-27.

2020-11-08 Thread GitBox
rmetzger commented on pull request #13574: URL: https://github.com/apache/flink/pull/13574#issuecomment-723652419 @tillrohrmann Thanks a lot for keeping an eye on master stability! This is an automated message from the

[GitHub] [flink] Myasuka opened a new pull request #13987: [FLINK-14482][rocksdb] Bump FRocksDB version to 6.10.2-ververica-1.0

2020-11-08 Thread GitBox
Myasuka opened a new pull request #13987: URL: https://github.com/apache/flink/pull/13987 ## What is the purpose of the change Bump version of FRocksDB. Currently, this PR still use my temp jar package and we will move to ververica based jar package once we publish that.

[GitHub] [flink] flinkbot edited a comment on pull request #13986: [FLINK-20016][python] Support TimestampAssigner and WatermarkGenerator for Python DataStream API.

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13986: URL: https://github.com/apache/flink/pull/13986#issuecomment-723648682 ## CI report: * 6afd298cd5356502822e36537d7a1c8ba67052b5 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13776: [FLINK-19717][connectors/common] Fix spurious InputStatus.END_OF_INPUT from SourceReaderBase.pollNext caused by split reader exceptio

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13776: URL: https://github.com/apache/flink/pull/13776#issuecomment-715417467 ## CI report: * 34137c2a23fa01e836a8e990c7094ab7359b37fd Azure:

[jira] [Assigned] (FLINK-19697) Make the committer retry-able

2020-11-08 Thread Kostas Kloudas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas reassigned FLINK-19697: -- Assignee: Guowei Ma > Make the committer retry-able > -

[jira] [Commented] (FLINK-19448) CoordinatedSourceITCase.testEnumeratorReaderCommunication hangs

2020-11-08 Thread Kezhu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228271#comment-17228271 ] Kezhu Wang commented on FLINK-19448: [~sewen] Yes. Returning {{MORE_AVAILABLE}} is better than

[jira] [Updated] (FLINK-19697) Make the committer retry-able

2020-11-08 Thread Kostas Kloudas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-19697: --- Affects Version/s: 1.12.0 > Make the committer retry-able > - >

[GitHub] [flink] flinkbot commented on pull request #13986: [FLINK-20016][python] Support TimestampAssigner and WatermarkGenerator for Python DataStream API.

2020-11-08 Thread GitBox
flinkbot commented on pull request #13986: URL: https://github.com/apache/flink/pull/13986#issuecomment-723648682 ## CI report: * 6afd298cd5356502822e36537d7a1c8ba67052b5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #13985: [FLINK-19697] Make the Committer/GlobalCommitter retry-able

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13985: URL: https://github.com/apache/flink/pull/13985#issuecomment-723646083 ## CI report: * 9917da1cba5acff13ee14a68fa58763f2b430c75 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13776: [FLINK-19717][connectors/common] Fix spurious InputStatus.END_OF_INPUT from SourceReaderBase.pollNext caused by split reader exceptio

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13776: URL: https://github.com/apache/flink/pull/13776#issuecomment-715417467 ## CI report: * 34137c2a23fa01e836a8e990c7094ab7359b37fd Azure:

[GitHub] [flink] flinkbot commented on pull request #13986: [FLINK-20016][python] Support TimestampAssigner and WatermarkGenerator for Python DataStream API.

2020-11-08 Thread GitBox
flinkbot commented on pull request #13986: URL: https://github.com/apache/flink/pull/13986#issuecomment-723646454 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot commented on pull request #13985: [FLINK-19697] Make the Committer/GlobalCommitter retry-able

2020-11-08 Thread GitBox
flinkbot commented on pull request #13985: URL: https://github.com/apache/flink/pull/13985#issuecomment-723646083 ## CI report: * 9917da1cba5acff13ee14a68fa58763f2b430c75 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[jira] [Updated] (FLINK-20016) Support TimestampAssigner and WatermarkGenerator for Python DataStream API.

2020-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-20016: --- Labels: pull-request-available (was: ) > Support TimestampAssigner and WatermarkGenerator

[GitHub] [flink] shuiqiangchen opened a new pull request #13986: [FLINK-20016][python] Support TimestampAssigner and WatermarkGenerator for Python DataStream API.

2020-11-08 Thread GitBox
shuiqiangchen opened a new pull request #13986: URL: https://github.com/apache/flink/pull/13986 ## What is the purpose of the change Support TimestampAssigner and WatermarkGenerator for Python DataStream API. ## Brief change log - added new interfaces

[GitHub] [flink] flinkbot edited a comment on pull request #13984: [FLINK-20030][checkpointing] Revert adding barrier announcements

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13984: URL: https://github.com/apache/flink/pull/13984#issuecomment-723579025 ## CI report: * ea343966d3a21779482fe4e42bcc6acfa51da891 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13776: [FLINK-19717][connectors/common] Fix spurious InputStatus.END_OF_INPUT from SourceReaderBase.pollNext caused by split reader exceptio

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13776: URL: https://github.com/apache/flink/pull/13776#issuecomment-715417467 ## CI report: * 34137c2a23fa01e836a8e990c7094ab7359b37fd Azure:

[GitHub] [flink] stevenzwu commented on pull request #13574: [FLINK-18323] Add a Kafka source implementation based on FLIP-27.

2020-11-08 Thread GitBox
stevenzwu commented on pull request #13574: URL: https://github.com/apache/flink/pull/13574#issuecomment-723643763 @tillrohrmann thx a lot for fixing it. looks like a race condition btw two commits that we didn't catch with individual CI builds.

[GitHub] [flink] flinkbot commented on pull request #13985: [FLINK-19697] Make the Committer/GlobalCommitter retry-able

2020-11-08 Thread GitBox
flinkbot commented on pull request #13985: URL: https://github.com/apache/flink/pull/13985#issuecomment-723643160 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Closed] (FLINK-19693) Scheduler Change for Approximate Local Recovery to Restart Downstream of a Failed Task

2020-11-08 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-19693. - Fix Version/s: 1.12.0 Resolution: Fixed Fixed via

[jira] [Updated] (FLINK-19697) Make the committer retry-able

2020-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-19697: --- Labels: pull-request-available (was: ) > Make the committer retry-able >

[jira] [Commented] (FLINK-19693) Scheduler Change for Approximate Local Recovery to Restart Downstream of a Failed Task

2020-11-08 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228262#comment-17228262 ] Till Rohrmann commented on FLINK-19693: --- Thanks for your comments [~jinxing6...@126.com]. I will

[GitHub] [flink] guoweiM opened a new pull request #13985: [FLINK-19697] Make the Committer/GlobalCommitter retry-able

2020-11-08 Thread GitBox
guoweiM opened a new pull request #13985: URL: https://github.com/apache/flink/pull/13985 ## What is the purpose of the change Make the Committer/GlobalCommitter retry-able. ## Brief change log - *Introduce SinkUtils::commit for retry-commit* - *Make

[GitHub] [flink] tillrohrmann closed pull request #13880: [FLINK-19693][runtime] Downstream Failover for Approximate Local Recovery

2020-11-08 Thread GitBox
tillrohrmann closed pull request #13880: URL: https://github.com/apache/flink/pull/13880 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] tillrohrmann commented on pull request #13880: [FLINK-19693][runtime] Downstream Failover for Approximate Local Recovery

2020-11-08 Thread GitBox
tillrohrmann commented on pull request #13880: URL: https://github.com/apache/flink/pull/13880#issuecomment-723642811 Merged via 0b3f15ee598aa2b55706a4c3a30e2e529ac8f651 This is an automated message from the Apache Git

[jira] [Updated] (FLINK-19697) Make the committer retry-able

2020-11-08 Thread Guowei Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guowei Ma updated FLINK-19697: -- Summary: Make the committer retry-able (was: Make the streaming committer retry-able) > Make the

[GitHub] [flink] flinkbot edited a comment on pull request #13972: [FLINK-19912][json] Fix JSON format fails to serialize map value with…

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13972: URL: https://github.com/apache/flink/pull/13972#issuecomment-723244452 ## CI report: * 18bd1620f55d1363b4d3173dc2e9c14e83ba859b UNKNOWN * 951191135eee7d3f7fddea2a5e296dbd36716dd3 Azure:

[GitHub] [flink] StephanEwen commented on pull request #13920: [FLINK-19743] Add metric definitions in FLIP-33 and report some of them by default.

2020-11-08 Thread GitBox
StephanEwen commented on pull request #13920: URL: https://github.com/apache/flink/pull/13920#issuecomment-723639969 ## On Volatile Reads and Performance Considerations I think `volatile` read assumption is completely correct. There is a common interpretation that this just means

[GitHub] [flink] tillrohrmann commented on pull request #13574: [FLINK-18323] Add a Kafka source implementation based on FLIP-27.

2020-11-08 Thread GitBox
tillrohrmann commented on pull request #13574: URL: https://github.com/apache/flink/pull/13574#issuecomment-723639551 I've fixed the problem with a1ec69a75f7e3512b8de698619d53f5d89897973 This is an automated message from the

[GitHub] [flink] tillrohrmann commented on pull request #13955: [FLINK-19934][Connector] Add a new API: SplitEnumeratorContext.runInC…

2020-11-08 Thread GitBox
tillrohrmann commented on pull request #13955: URL: https://github.com/apache/flink/pull/13955#issuecomment-723639578 I've fixed the problem with a1ec69a75f7e3512b8de698619d53f5d89897973 This is an automated message from the

[GitHub] [flink] flinkbot edited a comment on pull request #13776: [FLINK-19717][connectors/common] Fix spurious InputStatus.END_OF_INPUT from SourceReaderBase.pollNext caused by split reader exceptio

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13776: URL: https://github.com/apache/flink/pull/13776#issuecomment-715417467 ## CI report: * 34137c2a23fa01e836a8e990c7094ab7359b37fd Azure:

[GitHub] [flink] tillrohrmann commented on pull request #13955: [FLINK-19934][Connector] Add a new API: SplitEnumeratorContext.runInC…

2020-11-08 Thread GitBox
tillrohrmann commented on pull request #13955: URL: https://github.com/apache/flink/pull/13955#issuecomment-723636810 Sorry I think the problem was introduced with #13574. This is an automated message from the Apache Git

[GitHub] [flink] tillrohrmann commented on pull request #13574: [FLINK-18323] Add a Kafka source implementation based on FLIP-27.

2020-11-08 Thread GitBox
tillrohrmann commented on pull request #13574: URL: https://github.com/apache/flink/pull/13574#issuecomment-723637114 I think this PR breaks the master @becketqin because `MockSplitEnumeratorContext` does not implement `SplitEnumeratorContext.runInCoordinatorThread`

[GitHub] [flink] tillrohrmann commented on pull request #13955: [FLINK-19934][Connector] Add a new API: SplitEnumeratorContext.runInC…

2020-11-08 Thread GitBox
tillrohrmann commented on pull request #13955: URL: https://github.com/apache/flink/pull/13955#issuecomment-723634268 I think this PR breaks the master @StephanEwen because `MockSplitEnumeratorContext` does not implement `SplitEnumeratorContext.runInCoordinatorThread`.

[GitHub] [flink] flinkbot edited a comment on pull request #13776: [FLINK-19717][connectors/common] Fix spurious InputStatus.END_OF_INPUT from SourceReaderBase.pollNext caused by split reader exceptio

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13776: URL: https://github.com/apache/flink/pull/13776#issuecomment-715417467 ## CI report: * 100b67ca171766bec1ff561a66688471b24745be Azure:

[GitHub] [flink] tillrohrmann commented on a change in pull request #13880: [FLINK-19693][runtime] Downstream Failover for Approximate Local Recovery

2020-11-08 Thread GitBox
tillrohrmann commented on a change in pull request #13880: URL: https://github.com/apache/flink/pull/13880#discussion_r519445776 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerComponentsFactoryTest.java ## @@ -67,9 +72,56 @@

[GitHub] [flink] flinkbot edited a comment on pull request #13880: [FLINK-19693][runtime] Downstream Failover for Approximate Local Recovery

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13880: URL: https://github.com/apache/flink/pull/13880#issuecomment-720433086 ## CI report: * aab0707fbff82e09fdfc6eda215fc66867b666e2 UNKNOWN * 1f68be3eedb92658f2909c4597cbd7df1ebcab96 UNKNOWN *

[GitHub] [flink] kezhuw commented on pull request #13776: [FLINK-19717][connectors/common] Fix spurious InputStatus.END_OF_INPUT from SourceReaderBase.pollNext caused by split reader exception

2020-11-08 Thread GitBox
kezhuw commented on pull request #13776: URL: https://github.com/apache/flink/pull/13776#issuecomment-723619395 @becketqin Sorry for ping you. Seems that https://github.com/apache/flink/pull/13574 does not compile on https://github.com/apache/flink/pull/13955 due to missing

[jira] [Updated] (FLINK-20048) Make Approximate Local Recovery Compatible With PipelinedRegionSchedulingStrategy

2020-11-08 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-20048: -- Fix Version/s: 1.13.0 > Make Approximate Local Recovery Compatible With >

[jira] [Updated] (FLINK-20048) Make Approximate Local Recovery Compatible With PipelinedRegionSchedulingStrategy

2020-11-08 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-20048: -- Component/s: Runtime / Coordination > Make Approximate Local Recovery Compatible With >

[jira] [Updated] (FLINK-20048) Make Approximate Local Recovery Compatible With PipelinedRegionSchedulingStrategy

2020-11-08 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-20048: -- Affects Version/s: 1.12.0 > Make Approximate Local Recovery Compatible With >

[jira] [Commented] (FLINK-19802) Let BulkFormat createReader and restoreReader methods accept Splits directly

2020-11-08 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228018#comment-17228018 ] Stephan Ewen commented on FLINK-19802: -- I don't think we'll have the time to investigate this for

[jira] [Commented] (FLINK-19985) job went into zombie state after ZK session timeout

2020-11-08 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228017#comment-17228017 ] Till Rohrmann commented on FLINK-19985: --- Thanks for reporting this issue [~qqibrow]. From the logs

[GitHub] [flink] kezhuw commented on a change in pull request #13776: [FLINK-19717][connectors/common] Fix spurious InputStatus.END_OF_INPUT from SourceReaderBase.pollNext caused by split reader excep

2020-11-08 Thread GitBox
kezhuw commented on a change in pull request #13776: URL: https://github.com/apache/flink/pull/13776#discussion_r519442839 ## File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManager.java ## @@

[jira] [Commented] (FLINK-19717) SourceReaderBase.pollNext may return END_OF_INPUT if SplitReader.fetch throws

2020-11-08 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228016#comment-17228016 ] Stephan Ewen commented on FLINK-19717: -- We are about to merge this. There is consensus on problem

[jira] [Commented] (FLINK-19448) CoordinatedSourceITCase.testEnumeratorReaderCommunication hangs

2020-11-08 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228015#comment-17228015 ] Stephan Ewen commented on FLINK-19448: -- [~kezhuw] Sounds good, I am assigning this to you. Should

[jira] [Updated] (FLINK-19448) CoordinatedSourceITCase.testEnumeratorReaderCommunication hangs

2020-11-08 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen updated FLINK-19448: - Fix Version/s: 1.12.0 > CoordinatedSourceITCase.testEnumeratorReaderCommunication hangs >

[jira] [Updated] (FLINK-19448) CoordinatedSourceITCase.testEnumeratorReaderCommunication hangs

2020-11-08 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen updated FLINK-19448: - Priority: Critical (was: Major) > CoordinatedSourceITCase.testEnumeratorReaderCommunication

[jira] [Assigned] (FLINK-19448) CoordinatedSourceITCase.testEnumeratorReaderCommunication hangs

2020-11-08 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen reassigned FLINK-19448: Assignee: Kezhu Wang > CoordinatedSourceITCase.testEnumeratorReaderCommunication hangs >

[jira] [Closed] (FLINK-19934) [FLIP-27 source] add new API: SplitEnumeratorContext.runInCoordinatorThread(Runnable)

2020-11-08 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-19934. > [FLIP-27 source] add new API: > SplitEnumeratorContext.runInCoordinatorThread(Runnable) >

[jira] [Resolved] (FLINK-19934) [FLIP-27 source] add new API: SplitEnumeratorContext.runInCoordinatorThread(Runnable)

2020-11-08 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-19934. -- Fix Version/s: 1.12.0 Assignee: Steven Zhen Wu Resolution: Fixed Fixed in

[GitHub] [flink] StephanEwen commented on pull request #13776: [FLINK-19717][connectors/common] Fix spurious InputStatus.END_OF_INPUT from SourceReaderBase.pollNext caused by split reader exception

2020-11-08 Thread GitBox
StephanEwen commented on pull request #13776: URL: https://github.com/apache/flink/pull/13776#issuecomment-723593388 +1 to merge this from my side. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] StephanEwen commented on a change in pull request #13776: [FLINK-19717][connectors/common] Fix spurious InputStatus.END_OF_INPUT from SourceReaderBase.pollNext caused by split reader

2020-11-08 Thread GitBox
StephanEwen commented on a change in pull request #13776: URL: https://github.com/apache/flink/pull/13776#discussion_r519436157 ## File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManager.java ##

[GitHub] [flink] kezhuw commented on a change in pull request #13776: [FLINK-19717][connectors/common] Fix spurious InputStatus.END_OF_INPUT from SourceReaderBase.pollNext caused by split reader excep

2020-11-08 Thread GitBox
kezhuw commented on a change in pull request #13776: URL: https://github.com/apache/flink/pull/13776#discussion_r519434803 ## File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManager.java ## @@

[GitHub] [flink] StephanEwen commented on a change in pull request #13776: [FLINK-19717][connectors/common] Fix spurious InputStatus.END_OF_INPUT from SourceReaderBase.pollNext caused by split reader

2020-11-08 Thread GitBox
StephanEwen commented on a change in pull request #13776: URL: https://github.com/apache/flink/pull/13776#discussion_r519434849 ## File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManager.java ##

[jira] [Resolved] (FLINK-18323) Implement a Kafka Source based on new Source API

2020-11-08 Thread Jiangjie Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin resolved FLINK-18323. -- Fix Version/s: 1.12.0 Resolution: Implemented Patch merged to master.

[GitHub] [flink] becketqin closed pull request #13574: [FLINK-18323] Add a Kafka source implementation based on FLIP-27.

2020-11-08 Thread GitBox
becketqin closed pull request #13574: URL: https://github.com/apache/flink/pull/13574 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] becketqin commented on pull request #13574: [FLINK-18323] Add a Kafka source implementation based on FLIP-27.

2020-11-08 Thread GitBox
becketqin commented on pull request #13574: URL: https://github.com/apache/flink/pull/13574#issuecomment-723590220 Merged to master. 80c040fcf3118a52053ffcd00ca4e063e6f52c97 This is an automated message from the Apache

[GitHub] [flink] flinkbot edited a comment on pull request #13981: [FLINK-19937][Connectors / FileSystem]Support sink parallelism config…

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13981: URL: https://github.com/apache/flink/pull/13981#issuecomment-723548422 ## CI report: * 79cad8661d915b15d8c23e42d1999a893283dfb5 Azure:

[GitHub] [flink] asfgit closed pull request #13955: [FLINK-19934][Connector] Add a new API: SplitEnumeratorContext.runInC…

2020-11-08 Thread GitBox
asfgit closed pull request #13955: URL: https://github.com/apache/flink/pull/13955 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] becketqin commented on a change in pull request #13776: [FLINK-19717][connectors/common] Fix spurious InputStatus.END_OF_INPUT from SourceReaderBase.pollNext caused by split reader ex

2020-11-08 Thread GitBox
becketqin commented on a change in pull request #13776: URL: https://github.com/apache/flink/pull/13776#discussion_r519419886 ## File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManager.java ## @@

[GitHub] [flink] flinkbot edited a comment on pull request #13972: [FLINK-19912][json] Fix JSON format fails to serialize map value with…

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13972: URL: https://github.com/apache/flink/pull/13972#issuecomment-723244452 ## CI report: * 51a6d2c307caa087518945825fb72ac1921c1a50 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13972: [FLINK-19912][json] Fix JSON format fails to serialize map value with…

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13972: URL: https://github.com/apache/flink/pull/13972#issuecomment-723244452 ## CI report: * 51a6d2c307caa087518945825fb72ac1921c1a50 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13983: [FLINK-19989][python] Add collect operation in Python DataStream API

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13983: URL: https://github.com/apache/flink/pull/13983#issuecomment-723574143 ## CI report: * a4b291d58c664776ac81ace1f3b020239993f893 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13880: [FLINK-19693][runtime] Downstream Failover for Approximate Local Recovery

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13880: URL: https://github.com/apache/flink/pull/13880#issuecomment-720433086 ## CI report: * aab0707fbff82e09fdfc6eda215fc66867b666e2 UNKNOWN * 1f68be3eedb92658f2909c4597cbd7df1ebcab96 UNKNOWN * Unknown: [CANCELED](TBD) *

[GitHub] [flink] flinkbot edited a comment on pull request #13984: [FLINK-20030][checkpointing] Revert adding barrier announcements

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13984: URL: https://github.com/apache/flink/pull/13984#issuecomment-723579025 ## CI report: * ea343966d3a21779482fe4e42bcc6acfa51da891 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13972: [FLINK-19912][json] Fix JSON format fails to serialize map value with…

2020-11-08 Thread GitBox
flinkbot edited a comment on pull request #13972: URL: https://github.com/apache/flink/pull/13972#issuecomment-723244452 ## CI report: * 51a6d2c307caa087518945825fb72ac1921c1a50 Azure:

[jira] [Commented] (FLINK-20048) Make Approximate Local Recovery Compatible With PipelinedRegionSchedulingStrategy

2020-11-08 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227996#comment-17227996 ] Yuan Mei commented on FLINK-20048: -- This should have higher priority since it blocks engine team to

[jira] [Updated] (FLINK-20048) Make Approximate Local Recovery Compatible With PipelinedRegionSchedulingStrategy

2020-11-08 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Mei updated FLINK-20048: - Description: in the case where approximate_failover is enabled, *only source task* is scheduled to be

<    1   2   3   >