[GitHub] [flink] flinkbot commented on pull request #14973: [FLINK-21412][python] Fix Decimal type which doesn't work in UDAF and expression DSL

2021-02-19 Thread GitBox
flinkbot commented on pull request #14973: URL: https://github.com/apache/flink/pull/14973#issuecomment-782582396 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-21412) pyflink DataTypes.DECIMAL is not available

2021-02-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21412: --- Labels: pull-request-available (was: ) > pyflink DataTypes.DECIMAL is not available >

[GitHub] [flink] dianfu opened a new pull request #14973: [FLINK-21412][python] Fix Decimal type which doesn't work in UDAF and expression DSL

2021-02-19 Thread GitBox
dianfu opened a new pull request #14973: URL: https://github.com/apache/flink/pull/14973 ## What is the purpose of the change *This pull request fixes the bug that Decimal type which doesn't work in UDAF and expression DSL* ## Verifying this change This change

[jira] [Assigned] (FLINK-21412) pyflink DataTypes.DECIMAL is not available

2021-02-19 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reassigned FLINK-21412: --- Assignee: Dian Fu > pyflink DataTypes.DECIMAL is not available >

[GitHub] [flink] flinkbot commented on pull request #14972: [FLINK-20536][tests] Update migration tests in master to cover migration from release-1.12

2021-02-19 Thread GitBox
flinkbot commented on pull request #14972: URL: https://github.com/apache/flink/pull/14972#issuecomment-782581149 ## CI report: * f8b2ed1dc83642f1e241470e8630c2890a09fa6d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #14971: [FLINK-20536][tests] Update migration tests in master to cover migration from release-1.12

2021-02-19 Thread GitBox
flinkbot commented on pull request #14971: URL: https://github.com/apache/flink/pull/14971#issuecomment-782581091 ## CI report: * 250b424bb564a0a787d32afcb30bed2e2b2a4b91 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] rkhachatryan commented on a change in pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-02-19 Thread GitBox
rkhachatryan commented on a change in pull request #14740: URL: https://github.com/apache/flink/pull/14740#discussion_r579616439 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/DefaultCheckpointPlanCalculator.java ## @@ -0,0 +1,329 @@ +/* + *

[GitHub] [flink] flinkbot commented on pull request #14972: [FLINK-20536][tests] Update migration tests in master to cover migration from release-1.12

2021-02-19 Thread GitBox
flinkbot commented on pull request #14972: URL: https://github.com/apache/flink/pull/14972#issuecomment-782578819 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot commented on pull request #14971: [FLINK-20536][tests] Update migration tests in master to cover migration from release-1.12

2021-02-19 Thread GitBox
flinkbot commented on pull request #14971: URL: https://github.com/apache/flink/pull/14971#issuecomment-782578640 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot edited a comment on pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14789: URL: https://github.com/apache/flink/pull/14789#issuecomment-768901340 ## CI report: * a508ee50d86b2ea1cdabaf0bc3eac9dc3b5ebc87 Azure:

[GitHub] [flink] dianfu opened a new pull request #14972: [FLINK-20536][tests] Update migration tests in master to cover migration from release-1.12

2021-02-19 Thread GitBox
dianfu opened a new pull request #14972: URL: https://github.com/apache/flink/pull/14972 ## What is the purpose of the change *This pull request updates migration tests in master to cover migration from release-1.12* ## Verifying this change This change is a test

[jira] [Updated] (FLINK-20536) Update migration tests in master to cover migration from release-1.12

2021-02-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-20536: --- Labels: pull-request-available (was: ) > Update migration tests in master to cover

[GitHub] [flink] dianfu opened a new pull request #14971: [FLINK-20536][tests] Update migration tests in master to cover migration from release-1.12

2021-02-19 Thread GitBox
dianfu opened a new pull request #14971: URL: https://github.com/apache/flink/pull/14971 ## What is the purpose of the change *This pull request updates migration tests in master to cover migration from release-1.12* ## Verifying this change This change is a

[GitHub] [flink-web] carp84 commented on a change in pull request #418: Add Apache Flink 1.12.2 release

2021-02-19 Thread GitBox
carp84 commented on a change in pull request #418: URL: https://github.com/apache/flink-web/pull/418#discussion_r579613323 ## File path: _posts/2021-02-16-release-1.12.2.md ## @@ -0,0 +1,205 @@ +--- +layout: post +title: "Apache Flink 1.12.2 Released" +date: 2021-02-16

[jira] [Commented] (FLINK-21213) e2e test fail with 'As task is already not running, no longer decline checkpoint'

2021-02-19 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287551#comment-17287551 ] Yun Tang commented on FLINK-21213: -- merged master: 32ed58254303aaec6290a1adb0402279ac5ee7d1

[jira] [Resolved] (FLINK-21213) e2e test fail with 'As task is already not running, no longer decline checkpoint'

2021-02-19 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-21213. -- Resolution: Fixed > e2e test fail with 'As task is already not running, no longer decline >

[jira] [Commented] (FLINK-21413) TtlMapState and TtlListState cannot be clean completely with Filesystem StateBackend

2021-02-19 Thread Yu Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287550#comment-17287550 ] Yu Li commented on FLINK-21413: --- Indeed, thanks for reporting the issue [~wind_ljy]. Would you like to

[jira] [Commented] (FLINK-21213) e2e test fail with 'As task is already not running, no longer decline checkpoint'

2021-02-19 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287549#comment-17287549 ] Yun Tang commented on FLINK-21213: -- Only degrade to INFO level is not enough, and my PR also remove the

[GitHub] [flink] Myasuka merged pull request #14835: [FLINK-21213][task] Degrade log level to INFO when ignore to decline checkpoint as task not running

2021-02-19 Thread GitBox
Myasuka merged pull request #14835: URL: https://github.com/apache/flink/pull/14835 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] xintongsong commented on pull request #14966: [FLINK-21417][core] Separate type-specific memory segments.

2021-02-19 Thread GitBox
xintongsong commented on pull request #14966: URL: https://github.com/apache/flink/pull/14966#issuecomment-782567022 cc @tillrohrmann This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] flinkbot edited a comment on pull request #14962: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14962: URL: https://github.com/apache/flink/pull/14962#issuecomment-781306516 ## CI report: * fda5571674ea74fb5c104180e3790d45c600fbea Azure:

[jira] [Created] (FLINK-21423) PartitionNotFoundException when job run on 2 taskmanager with standalone cluster mode

2021-02-19 Thread Sheng Zhang (Jira)
Sheng Zhang created FLINK-21423: --- Summary: PartitionNotFoundException when job run on 2 taskmanager with standalone cluster mode Key: FLINK-21423 URL: https://issues.apache.org/jira/browse/FLINK-21423

[GitHub] [flink-web] xintongsong commented on a change in pull request #418: Add Apache Flink 1.12.2 release

2021-02-19 Thread GitBox
xintongsong commented on a change in pull request #418: URL: https://github.com/apache/flink-web/pull/418#discussion_r579595671 ## File path: _posts/2021-02-16-release-1.12.2.md ## @@ -0,0 +1,205 @@ +--- +layout: post +title: "Apache Flink 1.12.2 Released" +date: 2021-02-16

[GitHub] [flink] Sunt-ing commented on pull request #14812: [hotfix][javadoc] fix syntax error for PlannerContext.java: from "be overwrite" to "be overwritten"

2021-02-19 Thread GitBox
Sunt-ing commented on pull request #14812: URL: https://github.com/apache/flink/pull/14812#issuecomment-782559546 @wuchong Hi, hope you have a great Spring Festival! This PR has been created for a long time. It's merely for a simple syntax error. Could you please review it after have a

[GitHub] [flink] xintongsong commented on a change in pull request #14629: [FLINK-15656][k8s] Support pod template for native kubernetes integration

2021-02-19 Thread GitBox
xintongsong commented on a change in pull request #14629: URL: https://github.com/apache/flink/pull/14629#discussion_r579053748 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesParameters.java ## @@ -107,4 +107,7 @@

[GitHub] [flink] flinkbot edited a comment on pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14789: URL: https://github.com/apache/flink/pull/14789#issuecomment-768901340 ## CI report: * 0ba04e69639fdc9ec208421163413b9a711c8d31 Azure:

[GitHub] [flink] PatrickRen commented on pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits

2021-02-19 Thread GitBox
PatrickRen commented on pull request #14789: URL: https://github.com/apache/flink/pull/14789#issuecomment-782547796 @becketqin Thank you~ I changed my implementation and made another commit. Now ```NoMoreSplitsEvent``` will be sent in ```addReader()``` so all readers will be

[GitHub] [flink] flinkbot edited a comment on pull request #14962: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14962: URL: https://github.com/apache/flink/pull/14962#issuecomment-781306516 ## CI report: * fda5571674ea74fb5c104180e3790d45c600fbea Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14789: URL: https://github.com/apache/flink/pull/14789#issuecomment-768901340 ## CI report: * 0ba04e69639fdc9ec208421163413b9a711c8d31 Azure:

[GitHub] [flink] leonardBang commented on pull request #14863: [FLINK-21203]Don’t collect -U&+U Row When they are equals In the LastRowFunction

2021-02-19 Thread GitBox
leonardBang commented on pull request #14863: URL: https://github.com/apache/flink/pull/14863#issuecomment-782545558 > Hi @leonardBang could you help to review this pr. 3Q Sorry for the late response because Spring Festival vocation, I'll review this soon

[GitHub] [flink] leonardBang commented on pull request #14084: [FLINK-15867][table-planner-blink] Support time-related types for FIRST_VALUE and LAST_VALUE aggregate functions

2021-02-19 Thread GitBox
leonardBang commented on pull request #14084: URL: https://github.com/apache/flink/pull/14084#issuecomment-782545283 > @leonardBang Sorry for the late response, I kind of lost sight of this PR :( I can't seem to find the test comment you mentioned, where would I find that? I missed

[GitHub] [flink] flinkbot edited a comment on pull request #14965: [FLINK-21415][Connectors / JDBC] JDBC does not query data, and the cache will store an ArrayList without data

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14965: URL: https://github.com/apache/flink/pull/14965#issuecomment-781920857 ## CI report: * b11a94330b6d09fe636a8ea1e6898f588d2aa828 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14962: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14962: URL: https://github.com/apache/flink/pull/14962#issuecomment-781306516 ## CI report: * fda5571674ea74fb5c104180e3790d45c600fbea Azure:

[GitHub] [flink] fsk119 commented on pull request #14962: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client

2021-02-19 Thread GitBox
fsk119 commented on pull request #14962: URL: https://github.com/apache/flink/pull/14962#issuecomment-782526641 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] flinkbot edited a comment on pull request #14965: [FLINK-21415][Connectors / JDBC] JDBC does not query data, and the cache will store an ArrayList without data

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14965: URL: https://github.com/apache/flink/pull/14965#issuecomment-781920857 ## CI report: * c33f15924135c357ad4358243558322ee1098ee8 Azure:

[jira] [Commented] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-19 Thread Jiangjie Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287451#comment-17287451 ] Jiangjie Qin commented on FLINK-21133: -- [~pnowojski] I might get a little confused about what

[GitHub] [flink] flinkbot edited a comment on pull request #14965: [FLINK-21415][Connectors / JDBC] JDBC does not query data, and the cache will store an ArrayList without data

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14965: URL: https://github.com/apache/flink/pull/14965#issuecomment-781920857 ## CI report: * c33f15924135c357ad4358243558322ee1098ee8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14953: [FLINK-21351][checkpointing] Don't subsume last checkpoint

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14953: URL: https://github.com/apache/flink/pull/14953#issuecomment-780752668 ## CI report: * 941374ecdd03b5ceb9245e4d8a8370671b691a34 UNKNOWN * 494f9fe80a0b2f1d7bb2559e2cba3283d5e2d89d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14970: [FLINK-21390] Rename DeclarativeScheduler to AdaptiveScheduler

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14970: URL: https://github.com/apache/flink/pull/14970#issuecomment-782244636 ## CI report: * c12ff62506a06a4316876810bd96cd2a144fcc26 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14969: [FLINK-21402] Introduce SlotPoolServiceSchedulerFactory to bundle SlotPoolService and Scheduler factories

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14969: URL: https://github.com/apache/flink/pull/14969#issuecomment-782223904 ## CI report: * 210d106621b94b14e90cfca736e07500eb452455 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14968: [FLINK-21028][task] Do not interrupt the source thread on stop with savepoint

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14968: URL: https://github.com/apache/flink/pull/14968#issuecomment-782213577 ## CI report: * 3e4a0af8525142046d8a5862b00d7862e60db92d Azure:

[GitHub] [flink] rkhachatryan commented on a change in pull request #14968: [FLINK-21028][task] Do not interrupt the source thread on stop with savepoint

2021-02-19 Thread GitBox
rkhachatryan commented on a change in pull request #14968: URL: https://github.com/apache/flink/pull/14968#discussion_r579455378 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTaskTest.java ## @@ -856,4 +887,41 @@ private

[GitHub] [flink] rkhachatryan commented on a change in pull request #14968: [FLINK-21028][task] Do not interrupt the source thread on stop with savepoint

2021-02-19 Thread GitBox
rkhachatryan commented on a change in pull request #14968: URL: https://github.com/apache/flink/pull/14968#discussion_r579453364 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTaskTest.java ## @@ -856,4 +887,41 @@ private

[GitHub] [flink] rkhachatryan commented on a change in pull request #14968: [FLINK-21028][task] Do not interrupt the source thread on stop with savepoint

2021-02-19 Thread GitBox
rkhachatryan commented on a change in pull request #14968: URL: https://github.com/apache/flink/pull/14968#discussion_r579453364 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTaskTest.java ## @@ -856,4 +887,41 @@ private

[GitHub] [flink] flinkbot edited a comment on pull request #14950: [FLINK-21347][coordination] Extract interface from ExecutionGraph

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14950: URL: https://github.com/apache/flink/pull/14950#issuecomment-780431068 ## CI report: * 1b43a411d22af19f12f14a79c1094c8dc5cfeb42 UNKNOWN * 44ee00afbd5ab0c81c53ed5787e7c0701b711e41 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14847: URL: https://github.com/apache/flink/pull/14847#issuecomment-772387941 ## CI report: * 9a2ea20ce0803e48edfc3ab7bcc02078b7410fbf UNKNOWN * 4aecfae5f4889de59c7f1d71d39647b6ee6f9ad8 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14798: URL: https://github.com/apache/flink/pull/14798#issuecomment-769223911 ## CI report: * af8de65a4905ae47ab704a75acfcd1b2e897d915 UNKNOWN * 772e076ed9d773e16713236c942f4e30b659d6eb UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #14953: [FLINK-21351][checkpointing] Don't subsume last checkpoint

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14953: URL: https://github.com/apache/flink/pull/14953#issuecomment-780752668 ## CI report: * 941374ecdd03b5ceb9245e4d8a8370671b691a34 UNKNOWN * ad5716b04e19c6eee71ed9007f789d53c2b8301c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14953: [FLINK-21351][checkpointing] Don't subsume last checkpoint

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14953: URL: https://github.com/apache/flink/pull/14953#issuecomment-780752668 ## CI report: * 941374ecdd03b5ceb9245e4d8a8370671b691a34 UNKNOWN * ad5716b04e19c6eee71ed9007f789d53c2b8301c Azure:

[jira] [Updated] (FLINK-21422) Migrate StateFun docs to hugo

2021-02-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21422: --- Labels: pull-request-available (was: ) > Migrate StateFun docs to hugo >

[GitHub] [flink-statefun] sjwiesman opened a new pull request #200: [FLINK-21422][docs] Migrate docs to Hugo

2021-02-19 Thread GitBox
sjwiesman opened a new pull request #200: URL: https://github.com/apache/flink-statefun/pull/200 This PR migrates statefun documentation to Hugo from Jekyll. No rush on the review, just opening it since I had time for the migration today. While we will be doing a major revamp of

[jira] [Commented] (FLINK-21359) CompatibilityResult issues with Flink 1.9.0

2021-02-19 Thread Siva (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287294#comment-17287294 ] Siva commented on FLINK-21359: -- We are getting the same error for all the versions above Flink 1.7.0 and we

[GitHub] [flink] flinkbot edited a comment on pull request #14953: [FLINK-21351][checkpointing] Don't subsume last checkpoint

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14953: URL: https://github.com/apache/flink/pull/14953#issuecomment-780752668 ## CI report: * 941374ecdd03b5ceb9245e4d8a8370671b691a34 UNKNOWN * ad5716b04e19c6eee71ed9007f789d53c2b8301c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14970: [FLINK-21390] Rename DeclarativeScheduler to AdaptiveScheduler

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14970: URL: https://github.com/apache/flink/pull/14970#issuecomment-782244636 ## CI report: * c12ff62506a06a4316876810bd96cd2a144fcc26 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14953: [FLINK-21351][checkpointing] Don't subsume last checkpoint

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14953: URL: https://github.com/apache/flink/pull/14953#issuecomment-780752668 ## CI report: * 941374ecdd03b5ceb9245e4d8a8370671b691a34 UNKNOWN * 07d008483dd496a4b89fe34e799511e3e2670fb8 Azure:

[GitHub] [flink] rkhachatryan commented on pull request #14953: [FLINK-21351][checkpointing] Don't subsume last checkpoint

2021-02-19 Thread GitBox
rkhachatryan commented on pull request #14953: URL: https://github.com/apache/flink/pull/14953#issuecomment-782255709 Thanks for the review @pnowojski, I've addressed all your comments. > What's the problem with the original suggestion to just ignore savepoints? My main

[GitHub] [flink] flinkbot edited a comment on pull request #14822: [FLINK-21005][table-api] Introduce new provider for unified Sink API and implement in planner

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14822: URL: https://github.com/apache/flink/pull/14822#issuecomment-770394744 ## CI report: * f1f95cd2649c7c2d75292ebc06d38ec7febcdad3 Azure:

[GitHub] [flink] flinkbot commented on pull request #14970: [FLINK-21390] Rename DeclarativeScheduler to AdaptiveScheduler

2021-02-19 Thread GitBox
flinkbot commented on pull request #14970: URL: https://github.com/apache/flink/pull/14970#issuecomment-782244636 ## CI report: * c12ff62506a06a4316876810bd96cd2a144fcc26 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #14967: [FLINK-21101][Azure] Add nightly profile to run all tests with the declarative scheduler

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14967: URL: https://github.com/apache/flink/pull/14967#issuecomment-782064802 ## CI report: * 515974e5646078ee2c3ea9c51984b2c2957dfcaf Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14969: [FLINK-21402] Introduce SlotPoolServiceSchedulerFactory to bundle SlotPoolService and Scheduler factories

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14969: URL: https://github.com/apache/flink/pull/14969#issuecomment-782223904 ## CI report: * 210d106621b94b14e90cfca736e07500eb452455 Azure:

[jira] [Updated] (FLINK-21422) Migrate StateFun docs to hugo

2021-02-19 Thread Seth Wiesman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Wiesman updated FLINK-21422: - Fix Version/s: statefun-3.0.0 > Migrate StateFun docs to hugo > --

[jira] [Created] (FLINK-21422) Migrate StateFun docs to hugo

2021-02-19 Thread Seth Wiesman (Jira)
Seth Wiesman created FLINK-21422: Summary: Migrate StateFun docs to hugo Key: FLINK-21422 URL: https://issues.apache.org/jira/browse/FLINK-21422 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-21421) Add coMapWithState to ConnectedStreams

2021-02-19 Thread Aris Koliopoulos (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aris Koliopoulos updated FLINK-21421: - Description: Currently there is no syntactic sugar for stateful functions in

[GitHub] [flink] flinkbot commented on pull request #14970: [FLINK-21390] Rename DeclarativeScheduler to AdaptiveScheduler

2021-02-19 Thread GitBox
flinkbot commented on pull request #14970: URL: https://github.com/apache/flink/pull/14970#issuecomment-782224653 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot commented on pull request #14969: [FLINK-21402] Introduce SlotPoolServiceSchedulerFactory to bundle SlotPoolService and Scheduler factories

2021-02-19 Thread GitBox
flinkbot commented on pull request #14969: URL: https://github.com/apache/flink/pull/14969#issuecomment-782223904 ## CI report: * 210d106621b94b14e90cfca736e07500eb452455 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #14968: [FLINK-21028][task] Do not interrupt the source thread on stop with savepoint

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14968: URL: https://github.com/apache/flink/pull/14968#issuecomment-782213577 ## CI report: * 3e4a0af8525142046d8a5862b00d7862e60db92d Azure:

[jira] [Updated] (FLINK-21390) Rename DeclarativeScheduler to AdaptiveScheduler

2021-02-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21390: --- Labels: pull-request-available (was: ) > Rename DeclarativeScheduler to AdaptiveScheduler

[GitHub] [flink] tillrohrmann opened a new pull request #14970: [FLINK-21390] Rename DeclarativeScheduler to AdaptiveScheduler

2021-02-19 Thread GitBox
tillrohrmann opened a new pull request #14970: URL: https://github.com/apache/flink/pull/14970 Renames the `DeclarativeScheduler` into `AdaptiveScheduler`. Note that this commit also changes the system property to enable the adaptive scheduler from

[jira] [Commented] (FLINK-21390) Rename DeclarativeScheduler to AdaptiveScheduler

2021-02-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287243#comment-17287243 ] Till Rohrmann commented on FLINK-21390: --- I like the name {{AdaptiveScheduler}}. > Rename

[GitHub] [flink] flinkbot commented on pull request #14968: [FLINK-21028][task] Do not interrupt the source thread on stop with savepoint

2021-02-19 Thread GitBox
flinkbot commented on pull request #14968: URL: https://github.com/apache/flink/pull/14968#issuecomment-782213577 ## CI report: * 3e4a0af8525142046d8a5862b00d7862e60db92d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[jira] [Comment Edited] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-19 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287105#comment-17287105 ] Piotr Nowojski edited comment on FLINK-21133 at 2/19/21, 5:14 PM: --

[jira] [Comment Edited] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-19 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287105#comment-17287105 ] Piotr Nowojski edited comment on FLINK-21133 at 2/19/21, 5:11 PM: --

[GitHub] [flink] flinkbot commented on pull request #14969: [FLINK-21402] Introduce SlotPoolServiceSchedulerFactory to bundle SlotPoolService and Scheduler factories

2021-02-19 Thread GitBox
flinkbot commented on pull request #14969: URL: https://github.com/apache/flink/pull/14969#issuecomment-782210938 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Assigned] (FLINK-21390) Rename DeclarativeScheduler to AdaptiveScheduler

2021-02-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-21390: - Assignee: Till Rohrmann > Rename DeclarativeScheduler to AdaptiveScheduler >

[jira] [Updated] (FLINK-21402) Consolidate Scheduler/SlotPool factories

2021-02-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21402: --- Labels: pull-request-available (was: ) > Consolidate Scheduler/SlotPool factories >

[GitHub] [flink] tillrohrmann opened a new pull request #14969: [FLINK-21402] Introduce SlotPoolServiceSchedulerFactory to bundle SlotPoolService and Scheduler factories

2021-02-19 Thread GitBox
tillrohrmann opened a new pull request #14969: URL: https://github.com/apache/flink/pull/14969 The SlotPoolServiceSchedulerFactory bundles the SlotPoolServiceFactory and SchedulerNGFactory to make sure that we only instantiate valid SlotPoolService and SchedulerNG combinations.

[jira] [Updated] (FLINK-21421) Add coMapWithState to ConnectedStreams

2021-02-19 Thread Aris Koliopoulos (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aris Koliopoulos updated FLINK-21421: - Summary: Add coMapWithState to ConnectedStreams (was: Add coMapWithState to

[jira] [Created] (FLINK-21421) Add coMapWithState to ConnnectedStreams

2021-02-19 Thread Aris Koliopoulos (Jira)
Aris Koliopoulos created FLINK-21421: Summary: Add coMapWithState to ConnnectedStreams Key: FLINK-21421 URL: https://issues.apache.org/jira/browse/FLINK-21421 Project: Flink Issue Type:

[jira] [Reopened] (FLINK-21084) Allows tasks to report operator subtask finish state

2021-02-19 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Gao reopened FLINK-21084: - Since we would holding the upstream tasks till the downstream tasks has finished processing the remaining

[jira] [Assigned] (FLINK-21028) Streaming application didn't stop properly

2021-02-19 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-21028: -- Assignee: Piotr Nowojski > Streaming application didn't stop properly >

[GitHub] [flink] flinkbot commented on pull request #14968: [FLINK-21028][task] Do not interrupt the source thread on stop with savepoint

2021-02-19 Thread GitBox
flinkbot commented on pull request #14968: URL: https://github.com/apache/flink/pull/14968#issuecomment-782201069 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-21028) Streaming application didn't stop properly

2021-02-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21028: --- Labels: pull-request-available (was: ) > Streaming application didn't stop properly >

[GitHub] [flink] pnowojski opened a new pull request #14968: [FLINK-21028][task] Do not interrupt the source thread on stop with savepoint

2021-02-19 Thread GitBox
pnowojski opened a new pull request #14968: URL: https://github.com/apache/flink/pull/14968 Currently stop with savepoint relies on the EndOfPartitionEvents propagation and performs clean shutdown after the stop with savepoint (which can produce some records to process after the

[GitHub] [flink] flinkbot edited a comment on pull request #14966: [FLINK-21417][core] Separate type-specific memory segments.

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14966: URL: https://github.com/apache/flink/pull/14966#issuecomment-781952312 ## CI report: * 8ca7a5eb4c4b076438663f4105e51be69bad29f9 Azure:

[GitHub] [flink] zentol commented on a change in pull request #14963: [FLINK-21362][coordination] Move State.onEnter() logic into constructor

2021-02-19 Thread GitBox
zentol commented on a change in pull request #14963: URL: https://github.com/apache/flink/pull/14963#discussion_r579316566 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/declarative/DeclarativeScheduler.java ## @@ -907,20 +909,37 @@ public void

[GitHub] [flink] zentol commented on a change in pull request #14963: [FLINK-21362][coordination] Move State.onEnter() logic into constructor

2021-02-19 Thread GitBox
zentol commented on a change in pull request #14963: URL: https://github.com/apache/flink/pull/14963#discussion_r579315352 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/declarative/DeclarativeScheduler.java ## @@ -907,20 +909,37 @@ public void

[GitHub] [flink] rkhachatryan commented on a change in pull request #14953: [FLINK-21351][checkpointing] Don't subsume last checkpoint

2021-02-19 Thread GitBox
rkhachatryan commented on a change in pull request #14953: URL: https://github.com/apache/flink/pull/14953#discussion_r579314524 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointSubsumeHelper.java ## @@ -0,0 +1,47 @@ +/* + * Licensed to

[GitHub] [flink] rkhachatryan commented on a change in pull request #14953: [FLINK-21351][checkpointing] Don't subsume last checkpoint

2021-02-19 Thread GitBox
rkhachatryan commented on a change in pull request #14953: URL: https://github.com/apache/flink/pull/14953#discussion_r579303380 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointSubsumeHelper.java ## @@ -0,0 +1,47 @@ +/* + * Licensed to

[jira] [Assigned] (FLINK-21402) Consolidate Scheduler/SlotPool factories

2021-02-19 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-21402: - Assignee: Till Rohrmann > Consolidate Scheduler/SlotPool factories >

[GitHub] [flink] flinkbot edited a comment on pull request #14967: [FLINK-21101][Azure] Add nightly profile to run all tests with the declarative scheduler

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14967: URL: https://github.com/apache/flink/pull/14967#issuecomment-782064802 ## CI report: * bbeabb0fad5bdef8e62ef30cfec1ccab552e4da8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14798: URL: https://github.com/apache/flink/pull/14798#issuecomment-769223911 ## CI report: * af8de65a4905ae47ab704a75acfcd1b2e897d915 UNKNOWN * 772e076ed9d773e16713236c942f4e30b659d6eb UNKNOWN *

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

2021-02-19 Thread GitBox
XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r579298421 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/StopWithSavepointTerminationHandlerImpl.java ## @@ -0,0 +1,258 @@ +/* + *

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

2021-02-19 Thread GitBox
XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r579292914 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/StopWithSavepointTerminationHandlerImplTest.java ## @@ -0,0 +1,330 @@ +/* + *

[GitHub] [flink] rmetzger commented on a change in pull request #14963: [FLINK-21362][coordination] Move State.onEnter() logic into constructor

2021-02-19 Thread GitBox
rmetzger commented on a change in pull request #14963: URL: https://github.com/apache/flink/pull/14963#discussion_r579285044 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/declarative/DeclarativeScheduler.java ## @@ -907,20 +909,37 @@ public void

[GitHub] [flink] flinkbot edited a comment on pull request #14967: [FLINK-21101][Azure] Add nightly profile to run all tests with the declarative scheduler

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14967: URL: https://github.com/apache/flink/pull/14967#issuecomment-782064802 ## CI report: * bbeabb0fad5bdef8e62ef30cfec1ccab552e4da8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14950: [FLINK-21347][coordination] Extract interface from ExecutionGraph

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14950: URL: https://github.com/apache/flink/pull/14950#issuecomment-780431068 ## CI report: * 1b43a411d22af19f12f14a79c1094c8dc5cfeb42 UNKNOWN * a8191e6800961467c726695c8ef7575d157a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14847: URL: https://github.com/apache/flink/pull/14847#issuecomment-772387941 ## CI report: * 9a2ea20ce0803e48edfc3ab7bcc02078b7410fbf UNKNOWN * 4aecfae5f4889de59c7f1d71d39647b6ee6f9ad8 UNKNOWN *

[jira] [Closed] (FLINK-21410) Document checkpoint interval trade-offs

2021-02-19 Thread Seth Wiesman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Wiesman closed FLINK-21410. Resolution: Fixed > Document checkpoint interval trade-offs >

[GitHub] [flink] flinkbot edited a comment on pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-19 Thread GitBox
flinkbot edited a comment on pull request #14798: URL: https://github.com/apache/flink/pull/14798#issuecomment-769223911 ## CI report: * af8de65a4905ae47ab704a75acfcd1b2e897d915 UNKNOWN * 772e076ed9d773e16713236c942f4e30b659d6eb UNKNOWN *

[jira] [Commented] (FLINK-21410) Document checkpoint interval trade-offs

2021-02-19 Thread Seth Wiesman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287138#comment-17287138 ] Seth Wiesman commented on FLINK-21410: -- fixed in master: 7f03e1357ee18660112578cd544ae8864f1bc241

  1   2   3   >