[GitHub] [flink] flinkbot edited a comment on pull request #18314: [FLINK-24228][connectors/firehose] - Unified Async Sink for Kinesis Firehose

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18314: URL: https://github.com/apache/flink/pull/18314#issuecomment-1008761781 ## CI report: * 826fd84d3f61953a127829be78708c6d54de3244 UNKNOWN * 26aa7ccebd039dfa7f890d9d927e93c22ca58a0f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18314: [FLINK-24228][connectors/firehose] - Unified Async Sink for Kinesis Firehose

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18314: URL: https://github.com/apache/flink/pull/18314#issuecomment-1008761781 ## CI report: * 826fd84d3f61953a127829be78708c6d54de3244 UNKNOWN * 26aa7ccebd039dfa7f890d9d927e93c22ca58a0f Azure:

[jira] [Updated] (FLINK-25793) Kinesis Data Streams sink is not limiting throughput to the destination and therefore exceeding rate limits

2022-01-24 Thread Zichen Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zichen Liu updated FLINK-25793: --- Description: h2. Bug: Kinesis Data Streams sink is not limiting throughput to the destination and

[jira] [Created] (FLINK-25793) Kinesis Data Streams sink is not limiting throughput to the destination and therefore exceeding rate limits

2022-01-24 Thread Zichen Liu (Jira)
Zichen Liu created FLINK-25793: -- Summary: Kinesis Data Streams sink is not limiting throughput to the destination and therefore exceeding rate limits Key: FLINK-25793 URL:

[GitHub] [flink] flinkbot edited a comment on pull request #18314: [FLINK-24228][connectors/firehose] - Unified Async Sink for Kinesis Firehose

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18314: URL: https://github.com/apache/flink/pull/18314#issuecomment-1008761781 ## CI report: * 826fd84d3f61953a127829be78708c6d54de3244 UNKNOWN * 26aa7ccebd039dfa7f890d9d927e93c22ca58a0f Azure:

[jira] [Updated] (FLINK-25792) Async Sink Base is too being flushed too frequently resulting in backpressure even when buffer is near empty

2022-01-24 Thread Zichen Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zichen Liu updated FLINK-25792: --- Issue Type: Bug (was: New Feature) > Async Sink Base is too being flushed too frequently resulting

[jira] [Updated] (FLINK-25792) Async Sink Base is too being flushed too frequently resulting in backpressure even when buffer is near empty

2022-01-24 Thread Zichen Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zichen Liu updated FLINK-25792: --- Description: h2. Bug: Async Sink Base is too being flushed too frequently resulting in

[GitHub] [flink] tillrohrmann commented on a change in pull request #17485: [FLINK-24038] Add support for single leader election per JobManager process

2022-01-24 Thread GitBox
tillrohrmann commented on a change in pull request #17485: URL: https://github.com/apache/flink/pull/17485#discussion_r791068399 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/zookeeper/ZooKeeperMultipleComponentLeaderElectionHaServices.java

[jira] [Updated] (FLINK-25792) Async Sink Base is too being flushed too frequently resulting in backpressure even when buffer is near empty

2022-01-24 Thread Zichen Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zichen Liu updated FLINK-25792: --- Description: h2. Bug:   was: h2. Motivation *User stories:* As a Flink user, I’d like to use

[jira] [Created] (FLINK-25792) Async Sink Base is too being flushed too frequently resulting in backpressure even when buffer is near empty

2022-01-24 Thread Zichen Liu (Jira)
Zichen Liu created FLINK-25792: -- Summary: Async Sink Base is too being flushed too frequently resulting in backpressure even when buffer is near empty Key: FLINK-25792 URL:

[GitHub] [flink] flinkbot edited a comment on pull request #18314: [FLINK-24228][connectors/firehose] - Unified Async Sink for Kinesis Firehose

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18314: URL: https://github.com/apache/flink/pull/18314#issuecomment-1008761781 ## CI report: * 826fd84d3f61953a127829be78708c6d54de3244 UNKNOWN * 26aa7ccebd039dfa7f890d9d927e93c22ca58a0f Azure:

[GitHub] [flink] tillrohrmann commented on a change in pull request #17485: [FLINK-24038] Add support for single leader election per JobManager process

2022-01-24 Thread GitBox
tillrohrmann commented on a change in pull request #17485: URL: https://github.com/apache/flink/pull/17485#discussion_r791067168 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/zookeeper/ZooKeeperMultipleComponentLeaderElectionHaServices.java

[GitHub] [flink] fapaul edited a comment on pull request #18412: [FLINK-25696][datastream] Introduce MetadataPublisher interface to SinkWriter

2022-01-24 Thread GitBox
fapaul edited a comment on pull request #18412: URL: https://github.com/apache/flink/pull/18412#issuecomment-1020262180 > I don't think we need to put it inside the mailbox, it would be very performance intensive, it's a per record operation. A callback consumer, which I think has

[GitHub] [flink] tillrohrmann commented on a change in pull request #17485: [FLINK-24038] Add support for single leader election per JobManager process

2022-01-24 Thread GitBox
tillrohrmann commented on a change in pull request #17485: URL: https://github.com/apache/flink/pull/17485#discussion_r791066490 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultMultipleComponentLeaderElectionServiceTest.java ## @@ -0,0

[GitHub] [flink] tillrohrmann commented on a change in pull request #17485: [FLINK-24038] Add support for single leader election per JobManager process

2022-01-24 Thread GitBox
tillrohrmann commented on a change in pull request #17485: URL: https://github.com/apache/flink/pull/17485#discussion_r791063719 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultMultipleComponentLeaderElectionServiceTest.java ## @@ -0,0

[GitHub] [flink] flinkbot edited a comment on pull request #18470: [FLINK-25774][network] Restrict the maximum number of buffers can be used per result partition for sort-shuffle

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18470: URL: https://github.com/apache/flink/pull/18470#issuecomment-1020036276 ## CI report: * 81fd95e0d9942254e15904701ade5a9143da127c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18314: [FLINK-24228][connectors/firehose] - Unified Async Sink for Kinesis Firehose

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18314: URL: https://github.com/apache/flink/pull/18314#issuecomment-1008761781 ## CI report: * 826fd84d3f61953a127829be78708c6d54de3244 UNKNOWN * 26aa7ccebd039dfa7f890d9d927e93c22ca58a0f Azure:

[GitHub] [flink] tillrohrmann commented on a change in pull request #17485: [FLINK-24038] Add support for single leader election per JobManager process

2022-01-24 Thread GitBox
tillrohrmann commented on a change in pull request #17485: URL: https://github.com/apache/flink/pull/17485#discussion_r791061384 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultMultipleComponentLeaderElectionServiceTest.java ## @@ -0,0

[GitHub] [flink] tillrohrmann commented on a change in pull request #17485: [FLINK-24038] Add support for single leader election per JobManager process

2022-01-24 Thread GitBox
tillrohrmann commented on a change in pull request #17485: URL: https://github.com/apache/flink/pull/17485#discussion_r791060408 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingMultipleComponentLeaderElectionDriver.java ## @@ -0,0

[GitHub] [flink] tillrohrmann commented on a change in pull request #17485: [FLINK-24038] Add support for single leader election per JobManager process

2022-01-24 Thread GitBox
tillrohrmann commented on a change in pull request #17485: URL: https://github.com/apache/flink/pull/17485#discussion_r791060660 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultMultipleComponentLeaderElectionServiceTest.java ## @@ -0,0

[GitHub] [flink] tillrohrmann commented on a change in pull request #17485: [FLINK-24038] Add support for single leader election per JobManager process

2022-01-24 Thread GitBox
tillrohrmann commented on a change in pull request #17485: URL: https://github.com/apache/flink/pull/17485#discussion_r791059723 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingMultipleComponentLeaderElectionDriver.java ## @@ -0,0

[GitHub] [flink] tillrohrmann commented on a change in pull request #17485: [FLINK-24038] Add support for single leader election per JobManager process

2022-01-24 Thread GitBox
tillrohrmann commented on a change in pull request #17485: URL: https://github.com/apache/flink/pull/17485#discussion_r791059052 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultMultipleComponentLeaderElectionService.java ## @@ -0,0

[GitHub] [flink] tillrohrmann commented on a change in pull request #17485: [FLINK-24038] Add support for single leader election per JobManager process

2022-01-24 Thread GitBox
tillrohrmann commented on a change in pull request #17485: URL: https://github.com/apache/flink/pull/17485#discussion_r791058539 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/MultipleComponentLeaderElectionDriver.java ## @@ -0,0 +1,87 @@

[GitHub] [flink] tillrohrmann commented on a change in pull request #17485: [FLINK-24038] Add support for single leader election per JobManager process

2022-01-24 Thread GitBox
tillrohrmann commented on a change in pull request #17485: URL: https://github.com/apache/flink/pull/17485#discussion_r791058030 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/MultipleComponentLeaderElectionDriverFactory.java ## @@ -0,0

[GitHub] [flink] flinkbot edited a comment on pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18324: URL: https://github.com/apache/flink/pull/18324#issuecomment-1009752905 ## CI report: * e3cf1d9fc4e3cdfab655c15732c07ab5ee9b7935 Azure:

[GitHub] [flink] tillrohrmann commented on a change in pull request #17485: [FLINK-24038] Add support for single leader election per JobManager process

2022-01-24 Thread GitBox
tillrohrmann commented on a change in pull request #17485: URL: https://github.com/apache/flink/pull/17485#discussion_r791055913 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultMultipleComponentLeaderElectionService.java ## @@ -0,0

[GitHub] [flink] tillrohrmann commented on a change in pull request #17485: [FLINK-24038] Add support for single leader election per JobManager process

2022-01-24 Thread GitBox
tillrohrmann commented on a change in pull request #17485: URL: https://github.com/apache/flink/pull/17485#discussion_r791055384 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultMultipleComponentLeaderElectionService.java ## @@ -0,0

[GitHub] [flink] tillrohrmann commented on a change in pull request #17485: [FLINK-24038] Add support for single leader election per JobManager process

2022-01-24 Thread GitBox
tillrohrmann commented on a change in pull request #17485: URL: https://github.com/apache/flink/pull/17485#discussion_r791054858 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultMultipleComponentLeaderElectionService.java ## @@ -0,0

[GitHub] [flink] tillrohrmann commented on a change in pull request #17485: [FLINK-24038] Add support for single leader election per JobManager process

2022-01-24 Thread GitBox
tillrohrmann commented on a change in pull request #17485: URL: https://github.com/apache/flink/pull/17485#discussion_r791053696 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultMultipleComponentLeaderElectionService.java ## @@ -0,0

[GitHub] [flink] flinkbot edited a comment on pull request #18483: [FLINK-24041][connectors] Removed public setter for elementConverter in As…

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18483: URL: https://github.com/apache/flink/pull/18483#issuecomment-1020286441 ## CI report: * eec2f51db2ed6c4862959336f6edf6bdfc16b251 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18314: [FLINK-24228][connectors/firehose] - Unified Async Sink for Kinesis Firehose

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18314: URL: https://github.com/apache/flink/pull/18314#issuecomment-1008761781 ## CI report: * 826fd84d3f61953a127829be78708c6d54de3244 UNKNOWN * 26aa7ccebd039dfa7f890d9d927e93c22ca58a0f Azure:

[GitHub] [flink] tillrohrmann commented on a change in pull request #17485: [FLINK-24038] Add support for single leader election per JobManager process

2022-01-24 Thread GitBox
tillrohrmann commented on a change in pull request #17485: URL: https://github.com/apache/flink/pull/17485#discussion_r791048308 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/MultipleComponentLeaderElectionService.java ## @@ -0,0 +1,76 @@

[GitHub] [flink] flinkbot edited a comment on pull request #18483: [FLINK-24041][connectors] Removed public setter for elementConverter in As…

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18483: URL: https://github.com/apache/flink/pull/18483#issuecomment-1020286441 ## CI report: * eec2f51db2ed6c4862959336f6edf6bdfc16b251 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18469: [FLINK-25485][connector/jdbc] Append default JDBC URL option of batch writing in MySQL.

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18469: URL: https://github.com/apache/flink/pull/18469#issuecomment-1020006904 ## CI report: * 632576add507798e8df4a4e3c968661b1fdb3911 Azure:

[GitHub] [flink] tillrohrmann commented on a change in pull request #17485: [FLINK-24038] Add support for single leader election per JobManager process

2022-01-24 Thread GitBox
tillrohrmann commented on a change in pull request #17485: URL: https://github.com/apache/flink/pull/17485#discussion_r791046741 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultMultipleComponentLeaderElectionService.java ## @@ -0,0

[GitHub] [flink] flinkbot edited a comment on pull request #18314: [FLINK-24228][connectors/firehose] - Unified Async Sink for Kinesis Firehose

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18314: URL: https://github.com/apache/flink/pull/18314#issuecomment-1008761781 ## CI report: * 826fd84d3f61953a127829be78708c6d54de3244 UNKNOWN * 26aa7ccebd039dfa7f890d9d927e93c22ca58a0f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18483: [FLINK-24041][connectors] Removed public setter for elementConverter in As…

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18483: URL: https://github.com/apache/flink/pull/18483#issuecomment-1020286441 ## CI report: * eec2f51db2ed6c4862959336f6edf6bdfc16b251 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18466: [FLINK-25016][build] Upgrade to Netty 4.1.70

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18466: URL: https://github.com/apache/flink/pull/18466#issuecomment-1019948477 ## CI report: * fb9cbe4ac95ec5291023532499aa478fedc10199 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18465: [FLINK-24978][build] Upgrade ASM to 9.2

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18465: URL: https://github.com/apache/flink/pull/18465#issuecomment-1019940899 ## CI report: * e065b40facb2f2dfbf0477b16145aef1e646c916 Azure:

[GitHub] [flink] JingGe commented on a change in pull request #18397: [FLINK-25702][Kafka] Use the configure feature provided by the kafka Serializer/Deserializer.

2022-01-24 Thread GitBox
JingGe commented on a change in pull request #18397: URL: https://github.com/apache/flink/pull/18397#discussion_r790939938 ## File path:

[GitHub] [flink] flinkbot edited a comment on pull request #18483: [FLINK-24041][connectors] Removed public setter for elementConverter in As…

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18483: URL: https://github.com/apache/flink/pull/18483#issuecomment-1020286441 ## CI report: * eec2f51db2ed6c4862959336f6edf6bdfc16b251 Azure:

[GitHub] [flink] XComp edited a comment on pull request #17819: [FLINK-15816][k8s] Prevent labels using kubernetes.cluster-id to exceed the limit of 63 characters

2022-01-24 Thread GitBox
XComp edited a comment on pull request #17819: URL: https://github.com/apache/flink/pull/17819#issuecomment-1020406101 Ok, then I misinterpreted the ticket. Essentially, the issue is not that we have to guess the right value for this configuration parameter but that the validation never

[GitHub] [flink] flinkbot edited a comment on pull request #18397: [FLINK-25702][Kafka] Use the configure feature provided by the kafka Serializer/Deserializer.

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18397: URL: https://github.com/apache/flink/pull/18397#issuecomment-1015848205 ## CI report: * 3e1198a17fea03035bc621268a39ea3b386809a4 Azure:

[GitHub] [flink] XComp commented on pull request #17819: [FLINK-15816][k8s] Prevent labels using kubernetes.cluster-id to exceed the limit of 63 characters

2022-01-24 Thread GitBox
XComp commented on pull request #17819: URL: https://github.com/apache/flink/pull/17819#issuecomment-1020406101 Ok, then I misinterpreted the ticket. Essentially, the issue is not that we have to guess the right value for this configuration parameter but that the validation never happens

[GitHub] [flink] flinkbot edited a comment on pull request #18488: [FLINK-24041][connector] Fixing reversed insertion of failed requests

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18488: URL: https://github.com/apache/flink/pull/18488#issuecomment-1020394995 ## CI report: * 78e08b716545affbb0d76bfbd836332a3d2a7e96 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18483: [FLINK-24041][connectors] Removed public setter for elementConverter in As…

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18483: URL: https://github.com/apache/flink/pull/18483#issuecomment-1020286441 ## CI report: * eec2f51db2ed6c4862959336f6edf6bdfc16b251 Azure:

[GitHub] [flink] flinkbot commented on pull request #18488: [FLINK-24041][connector] Fixing reversed insertion of failed requests

2022-01-24 Thread GitBox
flinkbot commented on pull request #18488: URL: https://github.com/apache/flink/pull/18488#issuecomment-1020395301 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot commented on pull request #18488: [FLINK-24041][connector] Fixing reversed insertion of failed requests

2022-01-24 Thread GitBox
flinkbot commented on pull request #18488: URL: https://github.com/apache/flink/pull/18488#issuecomment-1020394995 ## CI report: * 78e08b716545affbb0d76bfbd836332a3d2a7e96 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #18483: [FLINK-24041][connectors] Removed public setter for elementConverter in As…

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18483: URL: https://github.com/apache/flink/pull/18483#issuecomment-1020286441 ## CI report: * eec2f51db2ed6c4862959336f6edf6bdfc16b251 Azure:

[GitHub] [flink] vahmed-hamdy opened a new pull request #18488: [FLINK-24041][connector] Fixing reversed insertion of failed requests

2022-01-24 Thread GitBox
vahmed-hamdy opened a new pull request #18488: URL: https://github.com/apache/flink/pull/18488 ## What is the purpose of the change Fixing reversed insertion of failed requests in `AsyncSinkBase`. ## Brief change log - fixed implementation of

[GitHub] [flink] flinkbot edited a comment on pull request #18483: [FLINK-24041][connectors] Removed public setter for elementConverter in As…

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18483: URL: https://github.com/apache/flink/pull/18483#issuecomment-1020286441 ## CI report: * eec2f51db2ed6c4862959336f6edf6bdfc16b251 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18483: [FLINK-24041][connectors] Removed public setter for elementConverter in As…

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18483: URL: https://github.com/apache/flink/pull/18483#issuecomment-1020286441 ## CI report: * eec2f51db2ed6c4862959336f6edf6bdfc16b251 Azure:

[GitHub] [flink] galenwarren commented on pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues

2022-01-24 Thread GitBox
galenwarren commented on pull request #18452: URL: https://github.com/apache/flink/pull/18452#issuecomment-1020380245 Sounds good - thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18427: [FLINK-25386][table] Harden table persisted plan

2022-01-24 Thread GitBox
slinkydeveloper commented on a change in pull request #18427: URL: https://github.com/apache/flink/pull/18427#discussion_r791014794 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/ContextResolvedTableJsonSerializer.java

[GitHub] [flink] tillrohrmann closed pull request #18484: [FLINK-25758] Fix license issue with flink-gs-fs-hadoop

2022-01-24 Thread GitBox
tillrohrmann closed pull request #18484: URL: https://github.com/apache/flink/pull/18484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] tillrohrmann commented on pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues

2022-01-24 Thread GitBox
tillrohrmann commented on pull request #18452: URL: https://github.com/apache/flink/pull/18452#issuecomment-1020379351 I will merge this PR once AZP gives green light. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] tillrohrmann commented on pull request #18484: [FLINK-25758] Fix license issue with flink-gs-fs-hadoop

2022-01-24 Thread GitBox
tillrohrmann commented on pull request #18484: URL: https://github.com/apache/flink/pull/18484#issuecomment-1020379787 Subsumed by original PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18427: [FLINK-25386][table] Harden table persisted plan

2022-01-24 Thread GitBox
slinkydeveloper commented on a change in pull request #18427: URL: https://github.com/apache/flink/pull/18427#discussion_r791013866 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/ResolvedCatalogTableJsonSerializer.java

[GitHub] [flink] syhily commented on a change in pull request #17452: [FLINK-20732][connector/pulsar] Introduction of Pulsar Sink

2022-01-24 Thread GitBox
syhily commented on a change in pull request #17452: URL: https://github.com/apache/flink/pull/17452#discussion_r791013062 ## File path: flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/sink/config/SinkConfiguration.java ## @@ -0,0 +1,59

[GitHub] [flink] syhily commented on a change in pull request #17452: [FLINK-20732][connector/pulsar] Introduction of Pulsar Sink

2022-01-24 Thread GitBox
syhily commented on a change in pull request #17452: URL: https://github.com/apache/flink/pull/17452#discussion_r791011231 ## File path: flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/sink/config/PulsarSinkConfigUtils.java ## @@ -0,0

[GitHub] [flink] flinkbot edited a comment on pull request #18487: [FLINK-25788][Table SQL / API] Add show connectors command

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18487: URL: https://github.com/apache/flink/pull/18487#issuecomment-1020369201 ## CI report: * f21ff12e6f34e59cc11d951088135d9e017ce9b8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18483: [FLINK-24041][connectors] Removed public setter for elementConverter in As…

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18483: URL: https://github.com/apache/flink/pull/18483#issuecomment-1020286441 ## CI report: * eec2f51db2ed6c4862959336f6edf6bdfc16b251 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18468: [FLINK-24905][connector/kinesis]Adding Kinesis data streams sql uber-jar and end to end test.

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18468: URL: https://github.com/apache/flink/pull/18468#issuecomment-1019969068 ## CI report: * 4c5b4e65b42382c17bd98884f18e441e5a881e83 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18397: [FLINK-25702][Kafka] Use the configure feature provided by the kafka Serializer/Deserializer.

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18397: URL: https://github.com/apache/flink/pull/18397#issuecomment-1015848205 ## CI report: * 5b2d44dfea90aa64e7f9c2e65307604abb5ad556 Azure:

[GitHub] [flink] flinkbot commented on pull request #18487: [FLINK-25788][Table SQL / API] Add show connectors command

2022-01-24 Thread GitBox
flinkbot commented on pull request #18487: URL: https://github.com/apache/flink/pull/18487#issuecomment-1020369201 ## CI report: * f21ff12e6f34e59cc11d951088135d9e017ce9b8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #18483: [FLINK-24041][connectors] Removed public setter for elementConverter in As…

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18483: URL: https://github.com/apache/flink/pull/18483#issuecomment-1020286441 ## CI report: * eec2f51db2ed6c4862959336f6edf6bdfc16b251 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18397: [FLINK-25702][Kafka] Use the configure feature provided by the kafka Serializer/Deserializer.

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18397: URL: https://github.com/apache/flink/pull/18397#issuecomment-1015848205 ## CI report: * 5b2d44dfea90aa64e7f9c2e65307604abb5ad556 Azure:

[GitHub] [flink] JingGe commented on a change in pull request #18397: [FLINK-25702][Kafka] Use the configure feature provided by the kafka Serializer/Deserializer.

2022-01-24 Thread GitBox
JingGe commented on a change in pull request #18397: URL: https://github.com/apache/flink/pull/18397#discussion_r790964213 ## File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchemaBuilderTest.java

[GitHub] [flink] JingGe commented on a change in pull request #18397: [FLINK-25702][Kafka] Use the configure feature provided by the kafka Serializer/Deserializer.

2022-01-24 Thread GitBox
JingGe commented on a change in pull request #18397: URL: https://github.com/apache/flink/pull/18397#discussion_r790964213 ## File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchemaBuilderTest.java

[GitHub] [flink] JingGe commented on a change in pull request #18397: [FLINK-25702][Kafka] Use the configure feature provided by the kafka Serializer/Deserializer.

2022-01-24 Thread GitBox
JingGe commented on a change in pull request #18397: URL: https://github.com/apache/flink/pull/18397#discussion_r790964213 ## File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchemaBuilderTest.java

[GitHub] [flink] flinkbot commented on pull request #18487: [FLINK-25788][Table SQL / API] Add show connectors command

2022-01-24 Thread GitBox
flinkbot commented on pull request #18487: URL: https://github.com/apache/flink/pull/18487#issuecomment-1020364211 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot edited a comment on pull request #18486: [Test Only] Checks the memory usage for flink-table/flink-table-planner ci pipeline

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18486: URL: https://github.com/apache/flink/pull/18486#issuecomment-1020338268 ## CI report: * 54126b0e8379955ad9ea97da4377bf7be490a1b0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18485: [FLINK-25791][table-planner] Compact ObjectIdentifier json representation

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18485: URL: https://github.com/apache/flink/pull/18485#issuecomment-1020338030 ## CI report: * cea34e5e3bb33d04c0564286514f879ce4046b1d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18483: [FLINK-24041][connectors] Removed public setter for elementConverter in As…

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18483: URL: https://github.com/apache/flink/pull/18483#issuecomment-1020286441 ## CI report: * eec2f51db2ed6c4862959336f6edf6bdfc16b251 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18463: [FLINK-25773][build] Upgrade to flink-shaded 15.0

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18463: URL: https://github.com/apache/flink/pull/18463#issuecomment-1019934385 ## CI report: * 0ed995b5a9caca2afdc63c146b90c20784ece313 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18452: URL: https://github.com/apache/flink/pull/18452#issuecomment-1019527627 ## CI report: * ee587b4878f90d9af7eb00b2236901d95146fa00 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18382: [FLINK-25524] Fix ChangelogStateBackend.notifyCheckpointComplete

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18382: URL: https://github.com/apache/flink/pull/18382#issuecomment-1014709963 ## CI report: * ac5235e16ec43f58d558472e9f2bc6f8512336eb Azure:

[jira] [Updated] (FLINK-25788) Add show connectors command

2022-01-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-25788: --- Labels: pull-request-available (was: ) > Add show connectors command >

[GitHub] [flink] flinkbot edited a comment on pull request #17452: [FLINK-20732][connector/pulsar] Introduction of Pulsar Sink

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #17452: URL: https://github.com/apache/flink/pull/17452#issuecomment-940136217 ## CI report: * c8820e335d23677ffb548b0d1fa8771fa7c1bce1 Azure:

[GitHub] [flink] snuyanzin opened a new pull request #18487: [FLINK-25788][Table SQL / API] Add show connectors command

2022-01-24 Thread GitBox
snuyanzin opened a new pull request #18487: URL: https://github.com/apache/flink/pull/18487 ## What is the purpose of the change This PR introduces a command `SHOW CONNECTORS` ## Brief change log - Added support `SHOW CONNECTORS` in parser, converter - Make

[GitHub] [flink] dannycranmer commented on a change in pull request #18483: [FLINK-24041][connectors] Removed public setter for elementConverter in As…

2022-01-24 Thread GitBox
dannycranmer commented on a change in pull request #18483: URL: https://github.com/apache/flink/pull/18483#discussion_r790986281 ## File path:

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18483: [FLINK-24041][connectors] Removed public setter for elementConverter in As…

2022-01-24 Thread GitBox
CrynetLogistics commented on a change in pull request #18483: URL: https://github.com/apache/flink/pull/18483#discussion_r790985252 ## File path:

[GitHub] [flink] dannycranmer commented on pull request #18483: [FLINK-24041][connectors] Removed public setter for elementConverter in As…

2022-01-24 Thread GitBox
dannycranmer commented on pull request #18483: URL: https://github.com/apache/flink/pull/18483#issuecomment-1020343924 @CrynetLogistics as discussed, please: - Tag the Jira in the commit - Add the `cn` documentation - Clean out the other `@Experimental` annotations -- This is

[GitHub] [flink] dannycranmer commented on a change in pull request #18483: [FLINK-24041][connectors] Removed public setter for elementConverter in As…

2022-01-24 Thread GitBox
dannycranmer commented on a change in pull request #18483: URL: https://github.com/apache/flink/pull/18483#discussion_r790971239 ## File path:

[GitHub] [flink] JingGe commented on a change in pull request #18397: [FLINK-25702][Kafka] Use the configure feature provided by the kafka Serializer/Deserializer.

2022-01-24 Thread GitBox
JingGe commented on a change in pull request #18397: URL: https://github.com/apache/flink/pull/18397#discussion_r790939938 ## File path:

[GitHub] [flink] flinkbot commented on pull request #18486: [Test Only] Checks the memory usage for flink-table/flink-table-planner ci pipeline

2022-01-24 Thread GitBox
flinkbot commented on pull request #18486: URL: https://github.com/apache/flink/pull/18486#issuecomment-1020338268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #18485: [FLINK-25791][table-planner] Compact ObjectIdentifier json representation

2022-01-24 Thread GitBox
flinkbot commented on pull request #18485: URL: https://github.com/apache/flink/pull/18485#issuecomment-1020338030 ## CI report: * cea34e5e3bb33d04c0564286514f879ce4046b1d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #18484: [FLINK-25758] Fix license issue with flink-gs-fs-hadoop

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18484: URL: https://github.com/apache/flink/pull/18484#issuecomment-1020330227 ## CI report: * 78de540db06fde47d11bc13a4d026c4aac68eba3 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18452: URL: https://github.com/apache/flink/pull/18452#issuecomment-1019527627 ## CI report: * ee587b4878f90d9af7eb00b2236901d95146fa00 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17452: [FLINK-20732][connector/pulsar] Introduction of Pulsar Sink

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #17452: URL: https://github.com/apache/flink/pull/17452#issuecomment-940136217 ## CI report: * c8820e335d23677ffb548b0d1fa8771fa7c1bce1 Azure:

[GitHub] [flink] flinkbot commented on pull request #18485: [FLINK-25791][table-planner] Compact ObjectIdentifier json representation

2022-01-24 Thread GitBox
flinkbot commented on pull request #18485: URL: https://github.com/apache/flink/pull/18485#issuecomment-1020331589 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot commented on pull request #18484: [FLINK-25758] Fix license issue with flink-gs-fs-hadoop

2022-01-24 Thread GitBox
flinkbot commented on pull request #18484: URL: https://github.com/apache/flink/pull/18484#issuecomment-1020330227 ## CI report: * 78de540db06fde47d11bc13a4d026c4aac68eba3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] galenwarren commented on a change in pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues

2022-01-24 Thread GitBox
galenwarren commented on a change in pull request #18452: URL: https://github.com/apache/flink/pull/18452#discussion_r790971234 ## File path: flink-filesystems/flink-gs-fs-hadoop/pom.xml ## @@ -214,6 +214,8 @@ under the License.

[GitHub] [flink] flinkbot edited a comment on pull request #18467: [FLINK-25776][build] Sync netty versions

2022-01-24 Thread GitBox
flinkbot edited a comment on pull request #18467: URL: https://github.com/apache/flink/pull/18467#issuecomment-1019955976 ## CI report: * 84723426f04af40985a9fbc3a5e2b94704039e53 Azure:

[GitHub] [flink] flinkbot commented on pull request #18484: [FLINK-25758] Fix license issue with flink-gs-fs-hadoop

2022-01-24 Thread GitBox
flinkbot commented on pull request #18484: URL: https://github.com/apache/flink/pull/18484#issuecomment-1020327959 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-25791) Make ObjectIdentifier json representation simpler

2022-01-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-25791: --- Labels: pull-request-available (was: ) > Make ObjectIdentifier json representation simpler

[GitHub] [flink] slinkydeveloper opened a new pull request #18485: [FLINK-25791][table-planner] Compact ObjectIdentifier json representation

2022-01-24 Thread GitBox
slinkydeveloper opened a new pull request #18485: URL: https://github.com/apache/flink/pull/18485 ## What is the purpose of the change Make the `ObjectIdentifier` representation more compact ## Brief change log * Make the `ObjectIdentifier` representation more compact

[GitHub] [flink] tillrohrmann commented on a change in pull request #18452: [FLINK-25758][flink-gs-fs-hadoop] Fix licensing issues

2022-01-24 Thread GitBox
tillrohrmann commented on a change in pull request #18452: URL: https://github.com/apache/flink/pull/18452#discussion_r790965666 ## File path: flink-filesystems/flink-gs-fs-hadoop/pom.xml ## @@ -214,6 +214,8 @@ under the License.

[GitHub] [flink] tillrohrmann opened a new pull request #18484: [FLINK-25758] Fix license issue with flink-gs-fs-hadoop

2022-01-24 Thread GitBox
tillrohrmann opened a new pull request #18484: URL: https://github.com/apache/flink/pull/18484 This PR is based on #18452. It adds a fix up commit to exclude the `javax.annotation-api` dependency. cc @galenwarren -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] JingGe commented on a change in pull request #18397: [FLINK-25702][Kafka] Use the configure feature provided by the kafka Serializer/Deserializer.

2022-01-24 Thread GitBox
JingGe commented on a change in pull request #18397: URL: https://github.com/apache/flink/pull/18397#discussion_r790964213 ## File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchemaBuilderTest.java

<    1   2   3   4   5   6   7   8   9   10   >