[GitHub] [flink] zentol commented on a diff in pull request #18986: [FLINK-26496][flink-yarn-test] [JUnit5 Migration] Module: flink-yarn-test

2022-05-02 Thread GitBox
zentol commented on code in PR #18986: URL: https://github.com/apache/flink/pull/18986#discussion_r863517259 ## flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionCapacitySchedulerITCase.java: ## @@ -445,39 +444,51 @@ private static Map getFlinkConfig(final String

[jira] [Commented] (FLINK-26584) State Processor API fails to write savepoints exceeding 5MB

2022-05-02 Thread Matthias Schwalbe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531066#comment-17531066 ] Matthias Schwalbe commented on FLINK-26584: --- Goedemorgen [~MartijnVisser] , I

[jira] [Closed] (FLINK-27066) Reintroduce e2e tests in ES as Java tests.

2022-05-02 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul closed FLINK-27066. --- > Reintroduce e2e tests in ES as Java tests. > -- > >

[jira] [Resolved] (FLINK-27066) Reintroduce e2e tests in ES as Java tests.

2022-05-02 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul resolved FLINK-27066. - Fix Version/s: 1.16.0 Resolution: Fixed > Reintroduce e2e tests in ES as Java tests. > --

[jira] [Updated] (FLINK-27066) Reintroduce e2e tests in ES as Java tests.

2022-05-02 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul updated FLINK-27066: Affects Version/s: 1.16.0 > Reintroduce e2e tests in ES as Java tests. > -

[jira] [Updated] (FLINK-27066) Reintroduce e2e tests in ES as Java tests.

2022-05-02 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul updated FLINK-27066: Component/s: Connectors / ElasticSearch > Reintroduce e2e tests in ES as Java tests. > ---

[jira] [Commented] (FLINK-27066) Reintroduce e2e tests in ES as Java tests.

2022-05-02 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531065#comment-17531065 ] Fabian Paul commented on FLINK-27066: - Merged in master: 7f887a96626c94ce21db4b27bb7

[GitHub] [flink] fapaul merged pull request #19405: [FLINK-27066] Reintroduce e2e tests in ES as Java tests.

2022-05-02 Thread GitBox
fapaul merged PR #19405: URL: https://github.com/apache/flink/pull/19405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink-web] infoverload commented on a diff in pull request #516: Tidying up snapshots

2022-05-02 Thread GitBox
infoverload commented on code in PR #516: URL: https://github.com/apache/flink-web/pull/516#discussion_r863513403 ## _posts/2022-04-01-tidying-snapshots-up.md: ## @@ -0,0 +1,213 @@ +--- +layout: post +title: "Tidying up snapshots" +date: 2022-04-01T00:00:00.000Z Review Comme

[GitHub] [flink] alpreu commented on a diff in pull request #19552: [FLINK-27185][connectors][formats] Convert formats and connectors modules to assertj

2022-05-02 Thread GitBox
alpreu commented on code in PR #19552: URL: https://github.com/apache/flink/pull/19552#discussion_r863507040 ## flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvRowDataSerDeSchemaTest.java: ## @@ -61,11 +61,9 @@ import static org.apache.flink.table.data.Str

[GitHub] [flink] alpreu commented on a diff in pull request #19552: [FLINK-27185][connectors][formats] Convert formats and connectors modules to assertj

2022-05-02 Thread GitBox
alpreu commented on code in PR #19552: URL: https://github.com/apache/flink/pull/19552#discussion_r863505977 ## flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvRowDataSerDeSchemaTest.java: ## @@ -358,12 +354,8 @@ public void testSerializationWithTypesMismat

[jira] [Commented] (FLINK-27468) Observing JobManager deployment. Previous status: MISSING

2022-05-02 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531058#comment-17531058 ] Gyula Fora commented on FLINK-27468: First of all I think we need to send an event i

[GitHub] [flink] snuyanzin commented on pull request #17677: [FLINK-24766][table] Ceiling/flooring dates to day returns wrong results

2022-05-02 Thread GitBox
snuyanzin commented on PR #17677: URL: https://github.com/apache/flink/pull/17677#issuecomment-1115773186 Hi @matriv thanks for your feedback, I added tests at `flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java` Also notice

[jira] [Updated] (FLINK-27478) datastream.print() failed by uncertain cause

2022-05-02 Thread teeguo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] teeguo updated FLINK-27478: --- Description:   source data format like : {"r0": "test_r0", "r1": "test_r1", "r2": "test_r2"} I can print

[jira] [Commented] (FLINK-27318) KafkaSink: when init transaction, it take too long to get a producerId with epoch=0

2022-05-02 Thread Zhengqi Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531056#comment-17531056 ] Zhengqi Zhang commented on FLINK-27318: --- I understand the rationale for this part

[jira] [Updated] (FLINK-27478) datastream.print() failed by uncertain cause

2022-05-02 Thread teeguo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] teeguo updated FLINK-27478: --- Description:   source data format like : {"r0": "test_r0", "r1": "test_r1", "r2": "test_r2"} I can print

[jira] [Updated] (FLINK-27478) datastream.print() failed by uncertain cause

2022-05-02 Thread teeguo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] teeguo updated FLINK-27478: --- Description:   source data format like : {"r0": "test_r0", "r1": "test_r1", "r2": "test_r2"} I can print

[jira] [Updated] (FLINK-27478) datastream.print() failed by uncertain cause

2022-05-02 Thread teeguo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] teeguo updated FLINK-27478: --- Summary: datastream.print() failed by uncertain cause (was: failed job by uncertain cause ) > datastream.p

[jira] [Updated] (FLINK-27478) failed job by uncertain cause

2022-05-02 Thread teeguo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] teeguo updated FLINK-27478: --- Description: For the following job: {code:java} // from pyflink.common.serialization import JsonRowDeseriali

[GitHub] [flink] tweise commented on pull request #19627: [FLINK-27465] Handle conversion of negative long to timestamp in AvroRowDeserializationSchema

2022-05-02 Thread GitBox
tweise commented on PR #19627: URL: https://github.com/apache/flink/pull/19627#issuecomment-1115746710 @matriv PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [flink] flinkbot commented on pull request #19627: [FLINK-27465] Handle conversion of negative long to timestamp in AvroRowDeserializationSchema

2022-05-02 Thread GitBox
flinkbot commented on PR #19627: URL: https://github.com/apache/flink/pull/19627#issuecomment-1115743844 ## CI report: * 9ecdc5fa10caf671c6fa823bff9c00b3a2dd1500 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-27420) Suspended SlotManager fail to reregister metrics when started again

2022-05-02 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531039#comment-17531039 ] Yun Gao commented on FLINK-27420: - Hi, I'll first revert the commits on 1.15 and 1.14 si

[jira] [Updated] (FLINK-27465) AvroRowDeserializationSchema.convertToTimestamp fails with negative nano seconds

2022-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27465: --- Labels: pull-request-available (was: ) > AvroRowDeserializationSchema.convertToTimestamp fa

[GitHub] [flink] tweise opened a new pull request, #19627: [FLINK-27465] Handle conversion of negative long to timestamp in AvroRowDeserializationSchema

2022-05-02 Thread GitBox
tweise opened a new pull request, #19627: URL: https://github.com/apache/flink/pull/19627 A small change to (deprecated) AvroRowDeserializationSchema to handle the conversion of a negative micros long value to `java.sql.Timestamp` This was exposed in `AvroRowDeSerializationSchemaTest

[jira] [Commented] (FLINK-26803) Merge small ChannelState file for Unaligned Checkpoint

2022-05-02 Thread fanrui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531034#comment-17531034 ] fanrui commented on FLINK-26803: Hi [~pnowojski] , thanks for your reply. In fact, ther

[jira] [Commented] (FLINK-27465) AvroRowDeserializationSchema.convertToTimestamp fails with negative nano seconds

2022-05-02 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531032#comment-17531032 ] Thomas Weise commented on FLINK-27465: -- https://lists.apache.org/thread/bq8v1vrsq6p

[jira] [Comment Edited] (FLINK-27290) Translate the "Data Type" section of "Data Types" in to Chinese

2022-05-02 Thread Chengkai Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531024#comment-17531024 ] Chengkai Yang edited comment on FLINK-27290 at 5/3/22 4:05 AM: ---

[jira] [Commented] (FLINK-27290) Translate the "Data Type" section of "Data Types" in to Chinese

2022-05-02 Thread Chengkai Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531024#comment-17531024 ] Chengkai Yang commented on FLINK-27290: --- I will work on this after [26588|https:/

[jira] [Updated] (FLINK-27478) failed job by uncertain cause

2022-05-02 Thread teeguo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] teeguo updated FLINK-27478: --- Priority: Blocker (was: Major) > failed job by uncertain cause > -- > >

[GitHub] [flink] artiship commented on pull request #19617: [FLINK-26945][Table SQL/API] Add DATE_SUB supported in SQL & Table API

2022-05-02 Thread GitBox
artiship commented on PR #19617: URL: https://github.com/apache/flink/pull/19617#issuecomment-1115662759 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-27478) failed job by uncertain cause

2022-05-02 Thread teeguo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] teeguo updated FLINK-27478: --- Description: For the following job: {code:java} // from pyflink.common.serialization import JsonRowDeseriali

[jira] [Created] (FLINK-27478) failed job by uncertain cause

2022-05-02 Thread teeguo (Jira)
teeguo created FLINK-27478: -- Summary: failed job by uncertain cause Key: FLINK-27478 URL: https://issues.apache.org/jira/browse/FLINK-27478 Project: Flink Issue Type: Bug Components: API

[GitHub] [flink] ChengkaiYang2022 commented on a diff in pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

2022-05-02 Thread GitBox
ChengkaiYang2022 commented on code in PR #19496: URL: https://github.com/apache/flink/pull/19496#discussion_r863338377 ## docs/content.zh/docs/deployment/metric_reporters.md: ## @@ -237,28 +252,29 @@ metrics.reporter.stsd.port: 8125 metrics.reporter.stsd.interval: 60 SECONDS `

[GitHub] [flink] ChengkaiYang2022 commented on a diff in pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

2022-05-02 Thread GitBox
ChengkaiYang2022 commented on code in PR #19496: URL: https://github.com/apache/flink/pull/19496#discussion_r863338247 ## docs/content.zh/docs/deployment/metric_reporters.md: ## @@ -24,22 +24,24 @@ specific language governing permissions and limitations under the License. -->

[GitHub] [flink] RocMarshal commented on a diff in pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

2022-05-02 Thread GitBox
RocMarshal commented on code in PR #19496: URL: https://github.com/apache/flink/pull/19496#discussion_r863319045 ## docs/content.zh/docs/deployment/metric_reporters.md: ## @@ -24,22 +24,24 @@ specific language governing permissions and limitations under the License. --> + +

[GitHub] [flink] afedulov commented on pull request #19552: [FLINK-27185][connectors][formats] Convert formats and connectors modules to assertj

2022-05-02 Thread GitBox
afedulov commented on PR #19552: URL: https://github.com/apache/flink/pull/19552#issuecomment-1115468523 Please temporarily split the second commit (connectors) into three roughly equal once to ease the review process a bit. -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] afedulov commented on a diff in pull request #19552: [FLINK-27185][connectors][formats] Convert formats and connectors modules to assertj

2022-05-02 Thread GitBox
afedulov commented on code in PR #19552: URL: https://github.com/apache/flink/pull/19552#discussion_r863224050 ## flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvRowDataSerDeSchemaTest.java: ## @@ -374,12 +366,8 @@ public void testDeserializationWithTypesMi

[GitHub] [flink] JingGe commented on a diff in pull request #19377: [FLINK-27048][test] Add ArchUnit rule that connectors should only depend on public API

2022-05-02 Thread GitBox
JingGe commented on code in PR #19377: URL: https://github.com/apache/flink/pull/19377#discussion_r855893792 ## flink-architecture-tests/flink-architecture-tests-production/src/main/java/org/apache/flink/architecture/rules/ConnectorRules.java: ## @@ -0,0 +1,69 @@ +/* + * License

[jira] [Updated] (FLINK-27441) Scrollbar is missing for particular UI elements (Accumulators, Backpressure, Watermarks)

2022-05-02 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-27441: - Fix Version/s: 1.16.0 > Scrollbar is missing for particular UI elements (Accumulators, B

[GitHub] [flink] JingGe commented on a diff in pull request #19624: [FLINK-27476][test] build import option only focuses on maven main class files

2022-05-02 Thread GitBox
JingGe commented on code in PR #19624: URL: https://github.com/apache/flink/pull/19624#discussion_r863152213 ## flink-architecture-tests/flink-architecture-tests-base/src/main/java/org/apache/flink/architecture/common/ImportOptions.java: ## @@ -57,4 +70,19 @@ public boolean incl

[GitHub] [flink] JingGe commented on pull request #19624: [FLINK-27476][test] build import option only focuses on maven main class files

2022-05-02 Thread GitBox
JingGe commented on PR #19624: URL: https://github.com/apache/flink/pull/19624#issuecomment-1115304638 > Could you expand on what concrete issue you're trying to solve? > > There is supposed to be _some_ issue with testcontainers; what exactly is it? The excluding style import

[jira] [Closed] (FLINK-27441) Scrollbar is missing for particular UI elements (Accumulators, Backpressure, Watermarks)

2022-05-02 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-27441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi closed FLINK-27441. -- Resolution: Fixed Fixed via [{{f3d4ceb}}|https://github.com/apache/flink/commit/f3d4cebb6516f

[GitHub] [flink] mbalassi merged pull request #19606: [FLINK-27441][webfrontend] fix "nzScroll" calculations

2022-05-02 Thread GitBox
mbalassi merged PR #19606: URL: https://github.com/apache/flink/pull/19606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Comment Edited] (FLINK-25872) Restoring from non-changelog checkpoint with changelog state-backend enabled in CLAIM mode discards state in use

2022-05-02 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530927#comment-17530927 ] Piotr Nowojski edited comment on FLINK-25872 at 5/2/22 7:47 PM: --

[jira] [Commented] (FLINK-25872) Restoring from non-changelog checkpoint with changelog state-backend enabled in CLAIM mode discards state in use

2022-05-02 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530927#comment-17530927 ] Piotr Nowojski commented on FLINK-25872: I would second [~dwysakowicz] concerns

[GitHub] [flink] snuyanzin commented on pull request #17677: [FLINK-24766][table] Ceiling/flooring dates to day returns wrong results

2022-05-02 Thread GitBox
snuyanzin commented on PR #17677: URL: https://github.com/apache/flink/pull/17677#issuecomment-1115274639 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Commented] (FLINK-26803) Merge small ChannelState file for Unaligned Checkpoint

2022-05-02 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530907#comment-17530907 ] Piotr Nowojski commented on FLINK-26803: {quote} one file for each operator in t

[GitHub] [flink] snuyanzin commented on a diff in pull request #19625: [FLINK-27470][state][tests] Migrate test to JUnit5

2022-05-02 Thread GitBox
snuyanzin commented on code in PR #19625: URL: https://github.com/apache/flink/pull/19625#discussion_r863076876 ## flink-state-backends/flink-statebackend-heap-spillable/src/test/java/org/apache/flink/runtime/state/heap/OnHeapLevelIndexHeaderTest.java: ## @@ -20,65 +20,64 @@

[GitHub] [flink] snuyanzin commented on pull request #17677: [FLINK-24766][table] Ceiling/flooring dates to day returns wrong results

2022-05-02 Thread GitBox
snuyanzin commented on PR #17677: URL: https://github.com/apache/flink/pull/17677#issuecomment-1115210975 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] afedulov commented on pull request #19286: [FLINK-25931] Add projection pushdown support for CsvFormatFactory

2022-05-02 Thread GitBox
afedulov commented on PR #19286: URL: https://github.com/apache/flink/pull/19286#issuecomment-1115147420 Thanks for your feedback @AHeise, I addressed your comments and added the proposed optimization, please take a look. -- This is an automated message from the Apache Git Service. To res

[GitHub] [flink] ChengkaiYang2022 commented on pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

2022-05-02 Thread GitBox
ChengkaiYang2022 commented on PR #19496: URL: https://github.com/apache/flink/pull/19496#issuecomment-1115132533 @RocMarshal, I resolved the conflicts, here is the [link](http://localhost:1313/flink/flink-docs-master/zh/docs/deployment/metric_reporters/#%E5%8F%91%E9%80%81%E5%99%A8) ![S

[GitHub] [flink] flinkbot commented on pull request #19626: [FLINK-27477][yarn][tests] Drop flink-yarn test-jar

2022-05-02 Thread GitBox
flinkbot commented on PR #19626: URL: https://github.com/apache/flink/pull/19626#issuecomment-1115131530 ## CI report: * dea009481fe3ebe6d91ec1dd502bdb5faf1f808f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] zentol commented on a diff in pull request #19626: [FLINK-27477][yarn][tests] Drop flink-yarn test-jar

2022-05-02 Thread GitBox
zentol commented on code in PR #19626: URL: https://github.com/apache/flink/pull/19626#discussion_r863020953 ## flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java: ## @@ -396,11 +397,12 @@ YarnClusterDescriptor createYarnClusterDescriptor( YarnClusterDes

[jira] [Updated] (FLINK-27477) Drop flink-yarn test-jar

2022-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27477: --- Labels: pull-request-available (was: ) > Drop flink-yarn test-jar > ---

[GitHub] [flink] zentol commented on a diff in pull request #19626: [FLINK-27477][yarn][tests] Drop flink-yarn test-jar

2022-05-02 Thread GitBox
zentol commented on code in PR #19626: URL: https://github.com/apache/flink/pull/19626#discussion_r863020366 ## flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnConfigurationITCase.java: ## @@ -91,11 +90,11 @@ public void testFlinkContainerMemory() throws Exception {

[GitHub] [flink] zentol commented on a diff in pull request #19626: [FLINK-27477][yarn][tests] Drop flink-yarn test-jar

2022-05-02 Thread GitBox
zentol commented on code in PR #19626: URL: https://github.com/apache/flink/pull/19626#discussion_r863019882 ## flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnPrioritySchedulingITCase.java: ## @@ -18,26 +18,20 @@ package org.apache.flink.yarn; -import org.apache.h

[jira] [Created] (FLINK-27477) Drop flink-yarn test-jar

2022-05-02 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-27477: Summary: Drop flink-yarn test-jar Key: FLINK-27477 URL: https://issues.apache.org/jira/browse/FLINK-27477 Project: Flink Issue Type: Technical Debt

[GitHub] [flink] flinkbot commented on pull request #19625: [FLINK-27470][state][tests] Migrate test to JUnit5

2022-05-02 Thread GitBox
flinkbot commented on PR #19625: URL: https://github.com/apache/flink/pull/19625#issuecomment-1115120922 ## CI report: * af9a16c05ede67d1bf1cae9a2cc234b6a7205ed5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-27470) [JUnit5 Migration] Module: flink-statebackend-heap-spillable

2022-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27470: --- Labels: pull-request-available (was: ) > [JUnit5 Migration] Module: flink-statebackend-heap

[GitHub] [flink] zentol opened a new pull request, #19625: [FLINK-27470][state][tests] Migrate test to JUnit5

2022-05-02 Thread GitBox
zentol opened a new pull request, #19625: URL: https://github.com/apache/flink/pull/19625 Migrate heap-spillable statebackend tests to junit5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] zentol commented on a diff in pull request #19624: [FLINK-27476][test] build import option only focuses on maven main class files

2022-05-02 Thread GitBox
zentol commented on code in PR #19624: URL: https://github.com/apache/flink/pull/19624#discussion_r863007167 ## flink-architecture-tests/flink-architecture-tests-base/src/main/java/org/apache/flink/architecture/common/ImportOptions.java: ## @@ -57,4 +70,19 @@ public boolean incl

[GitHub] [flink] afedulov commented on a diff in pull request #19286: [FLINK-25931] Add projection pushdown support for CsvFormatFactory

2022-05-02 Thread GitBox
afedulov commented on code in PR #19286: URL: https://github.com/apache/flink/pull/19286#discussion_r862972424 ## flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowDataDeserializationSchema.java: ## @@ -65,13 +65,14 @@ public final class CsvRowDataDeserial

[jira] [Updated] (FLINK-27471) Add ARRAY_DISTINCT supported in SQL & Table API

2022-05-02 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-27471: Component/s: Table SQL / API > Add ARRAY_DISTINCT supported in SQL & Table API > -

[GitHub] [flink] flinkbot commented on pull request #19624: [FLINK-27476][test] build import option only focuses on maven main class files

2022-05-02 Thread GitBox
flinkbot commented on PR #19624: URL: https://github.com/apache/flink/pull/19624#issuecomment-1115029503 ## CI report: * fb0bc6c55a5928446f435eb49932ed478f6adc07 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-27476) Build new import option that only focus on maven main classes

2022-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27476: --- Labels: pull-request-available (was: ) > Build new import option that only focus on maven

[GitHub] [flink] JingGe opened a new pull request, #19624: [FLINK-27476][test] build import option only focuses on maven main class files

2022-05-02 Thread GitBox
JingGe opened a new pull request, #19624: URL: https://github.com/apache/flink/pull/19624 ## What is the purpose of the change ImportOption.DoNotIncludeTests.class used currently has some issue when running test with testContainer. It would be good to define the target class path pre

[jira] [Assigned] (FLINK-27476) Build new import option that only focus on maven main classes

2022-05-02 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge reassigned FLINK-27476: --- Assignee: Jing Ge > Build new import option that only focus on maven main classes > --

[jira] [Created] (FLINK-27476) Build new import option that only focus on maven main classes

2022-05-02 Thread Jing Ge (Jira)
Jing Ge created FLINK-27476: --- Summary: Build new import option that only focus on maven main classes Key: FLINK-27476 URL: https://issues.apache.org/jira/browse/FLINK-27476 Project: Flink Issue T

[GitHub] [flink] artiship commented on pull request #19617: [FLINK-26945][Table SQL/API] Add DATE_SUB supported in SQL & Table API

2022-05-02 Thread GitBox
artiship commented on PR #19617: URL: https://github.com/apache/flink/pull/19617#issuecomment-1114988840 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] artiship commented on pull request #19617: [FLINK-26945][Table SQL/API] Add DATE_SUB supported in SQL & Table API

2022-05-02 Thread GitBox
artiship commented on PR #19617: URL: https://github.com/apache/flink/pull/19617#issuecomment-1114977888 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Closed] (FLINK-27394) Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-05-02 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-27394. -- Fix Version/s: 1.16.0 Resolution: Fixed Documentation on how to add externally hosted c

[GitHub] [flink] MartijnVisser merged pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-05-02 Thread GitBox
MartijnVisser merged PR #19571: URL: https://github.com/apache/flink/pull/19571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[GitHub] [flink] MartijnVisser commented on pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-05-02 Thread GitBox
MartijnVisser commented on PR #19571: URL: https://github.com/apache/flink/pull/19571#issuecomment-1114924878 Build passed locally, most likely the failure was related to a flaky test. Passing build: https://dev.azure.com/martijn0323/Flink/_build/results?buildId=2343&view=results -- This

[GitHub] [flink] RocMarshal commented on a diff in pull request #18986: [FLINK-26496][flink-yarn-test] [JUnit5 Migration] Module: flink-yarn-test

2022-05-02 Thread GitBox
RocMarshal commented on code in PR #18986: URL: https://github.com/apache/flink/pull/18986#discussion_r862828232 ## flink-yarn-tests/src/test/java/org/apache/flink/yarn/CliFrontendRunWithYarnTest.java: ## @@ -43,22 +44,20 @@ * * @see org.apache.flink.client.cli.CliFrontendRu

[jira] [Created] (FLINK-27475) Clean-up unused Maven settings from flink-connector-elasticsearch

2022-05-02 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-27475: -- Summary: Clean-up unused Maven settings from flink-connector-elasticsearch Key: FLINK-27475 URL: https://issues.apache.org/jira/browse/FLINK-27475 Project: Flink

[jira] [Created] (FLINK-27474) Use Hugo build information to derive current branch for externally hosted documentation

2022-05-02 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-27474: -- Summary: Use Hugo build information to derive current branch for externally hosted documentation Key: FLINK-27474 URL: https://issues.apache.org/jira/browse/FLINK-27474

[GitHub] [flink] MartijnVisser commented on a diff in pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-05-02 Thread GitBox
MartijnVisser commented on code in PR #19571: URL: https://github.com/apache/flink/pull/19571#discussion_r862834393 ## docs/setup_docs.sh: ## @@ -0,0 +1,43 @@ +#!/usr/bin/env bash + +# Licensed to t

[GitHub] [flink] echauchot commented on a diff in pull request #19586: [FLINK-26824] Upgrade Flink's supported Cassandra versions to match all Apache Cassandra supported versions

2022-05-02 Thread GitBox
echauchot commented on code in PR #19586: URL: https://github.com/apache/flink/pull/19586#discussion_r862833765 ## flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBase.java: ## @@ -72,6 +74,16 @@ Clos

[GitHub] [flink] echauchot commented on a diff in pull request #19586: [FLINK-26824] Upgrade Flink's supported Cassandra versions to match all Apache Cassandra supported versions

2022-05-02 Thread GitBox
echauchot commented on code in PR #19586: URL: https://github.com/apache/flink/pull/19586#discussion_r862833765 ## flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBase.java: ## @@ -72,6 +74,16 @@ Clos

[GitHub] [flink] matriv commented on pull request #19410: [FLINK-15635][table] Now EnvironmentSettings accepts the user ClassLoader

2022-05-02 Thread GitBox
matriv commented on PR #19410: URL: https://github.com/apache/flink/pull/19410#issuecomment-1114831467 Working on rebasing and reshaping this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Closed] (FLINK-27460) Remove unused notifyPartitionDataAvailable process

2022-05-02 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-27460. Resolution: Fixed master: 05676c4d525f4c9b01c2c048ad263831617c8927 > Remove unused notify

[GitHub] [flink] RocMarshal commented on a diff in pull request #18986: [FLINK-26496][flink-yarn-test] [JUnit5 Migration] Module: flink-yarn-test

2022-05-02 Thread GitBox
RocMarshal commented on code in PR #18986: URL: https://github.com/apache/flink/pull/18986#discussion_r862826136 ## flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionCapacitySchedulerITCase.java: ## @@ -445,39 +444,51 @@ private static Map getFlinkConfig(final Str

[GitHub] [flink] zentol merged pull request #19613: [FLINK-27460][runtime] Remove unused notifyPartitionDataAvailable process

2022-05-02 Thread GitBox
zentol merged PR #19613: URL: https://github.com/apache/flink/pull/19613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink] zentol commented on a diff in pull request #19590: [FLINK-27352][tests] [JUnit5 Migration] Module: flink-json

2022-05-02 Thread GitBox
zentol commented on code in PR #19590: URL: https://github.com/apache/flink/pull/19590#discussion_r862825359 ## flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/ogg/OggJsonSerDeSchemaTest.java: ## @@ -119,18 +116,19 @@ public void testDeserializationWithMetad

[GitHub] [flink] zentol commented on a diff in pull request #19590: [FLINK-27352][tests] [JUnit5 Migration] Module: flink-json

2022-05-02 Thread GitBox
zentol commented on code in PR #19590: URL: https://github.com/apache/flink/pull/19590#discussion_r862825207 ## flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/ogg/OggJsonSerDeSchemaTest.java: ## @@ -119,18 +116,19 @@ public void testDeserializationWithMetad

[GitHub] [flink] zentol commented on a diff in pull request #19590: [FLINK-27352][tests] [JUnit5 Migration] Module: flink-json

2022-05-02 Thread GitBox
zentol commented on code in PR #19590: URL: https://github.com/apache/flink/pull/19590#discussion_r862824854 ## flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/maxwell/MaxwellJsonSerDerTest.java: ## @@ -85,23 +83,23 @@ public void testDeserializationWithMeta

[GitHub] [flink] zentol commented on a diff in pull request #19590: [FLINK-27352][tests] [JUnit5 Migration] Module: flink-json

2022-05-02 Thread GitBox
zentol commented on code in PR #19590: URL: https://github.com/apache/flink/pull/19590#discussion_r862821848 ## flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/JsonBatchFileSystemITCase.java: ## @@ -50,11 +54,27 @@ public String[] formatProperties() { }

[jira] [Created] (FLINK-27473) Capture time that a job spends on initializing tasks

2022-05-02 Thread Jun Qin (Jira)
Jun Qin created FLINK-27473: --- Summary: Capture time that a job spends on initializing tasks Key: FLINK-27473 URL: https://issues.apache.org/jira/browse/FLINK-27473 Project: Flink Issue Type: Improv

[jira] [Assigned] (FLINK-27352) [JUnit5 Migration] Module: flink-json

2022-05-02 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-27352: Assignee: EMing Zhou > [JUnit5 Migration] Module: flink-json > --

[GitHub] [flink] zentol commented on a diff in pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-05-02 Thread GitBox
zentol commented on code in PR #19571: URL: https://github.com/apache/flink/pull/19571#discussion_r862819931 ## docs/setup_docs.sh: ## @@ -0,0 +1,43 @@ +#!/usr/bin/env bash + +# Licensed to the Apac

[GitHub] [flink] zentol commented on a diff in pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-05-02 Thread GitBox
zentol commented on code in PR #19571: URL: https://github.com/apache/flink/pull/19571#discussion_r862819364 ## docs/setup_docs.sh: ## @@ -0,0 +1,50 @@ +#!/usr/bin/env bash + +# Licensed to the Apac

[GitHub] [flink] zentol commented on a diff in pull request #19571: [FLINK-27394] Integrate the Flink Elasticsearch documentation in the Flink documentation

2022-05-02 Thread GitBox
zentol commented on code in PR #19571: URL: https://github.com/apache/flink/pull/19571#discussion_r862818185 ## tools/ci/docs.sh: ## @@ -28,10 +28,11 @@ fi tar -zxvf $HUGO_ARTIFACT git submodule update --init --recursive +# Setup the external documentation modules +source do

[jira] [Closed] (FLINK-27472) Setup flink-connector-redis repository

2022-05-02 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-27472. -- Fix Version/s: 1.16.0 Resolution: Fixed Fixed in main: 62e88dca51e70fffa490c9df6caa72ed

[jira] [Updated] (FLINK-27472) Setup flink-connector-redis repository

2022-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27472: --- Labels: pull-request-available (was: ) > Setup flink-connector-redis repository > -

[GitHub] [flink] MartijnVisser commented on pull request #15487: [FLINK-15571][connector] Redis Stream connector for Flink

2022-05-02 Thread GitBox
MartijnVisser commented on PR #15487: URL: https://github.com/apache/flink/pull/15487#issuecomment-1114769501 @gkorland @chayim Apologies for the slight delay, but the repo is there. You can find it at https://github.com/apache/flink-connector-redis The current best implementation ca

[jira] [Commented] (FLINK-27465) AvroRowDeserializationSchema.convertToTimestamp fails with negative nano seconds

2022-05-02 Thread Marios Trivyzas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530698#comment-17530698 ] Marios Trivyzas commented on FLINK-27465: - Nevermind, I saw the thread in the ma

[jira] [Created] (FLINK-27472) Setup flink-connector-redis repository

2022-05-02 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-27472: -- Summary: Setup flink-connector-redis repository Key: FLINK-27472 URL: https://issues.apache.org/jira/browse/FLINK-27472 Project: Flink Issue Type: New Fe

[jira] [Assigned] (FLINK-27174) Non-null check for bootstrapServers field is incorrect in KafkaSink

2022-05-02 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul reassigned FLINK-27174: --- Assignee: Zhengqi Zhang > Non-null check for bootstrapServers field is incorrect in KafkaSi

[GitHub] [flink] mzuehlke commented on pull request #19586: [FLINK-26824] Upgrade Flink's supported Cassandra versions to match all Apache Cassandra supported versions

2022-05-02 Thread GitBox
mzuehlke commented on PR #19586: URL: https://github.com/apache/flink/pull/19586#issuecomment-1114757318 Great finding that 3.x drivers are still maintained and are supporting Cassandra 4.x 👍 btw. in the meantime version 3.11.2 got released: https://github.com/datastax/java-driver/blo

[GitHub] [flink] RocMarshal commented on pull request #19496: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment"

2022-05-02 Thread GitBox
RocMarshal commented on PR #19496: URL: https://github.com/apache/flink/pull/19496#issuecomment-1114756754 Yes. Your description about the `squish` and `rebase` will work. Feel free go ahead. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

  1   2   >