[GitHub] [flink] snuyanzin commented on pull request #19811: [FLINK-27758][tests][table] Migrate flink-table-runtime to JUnit5

2022-05-24 Thread GitBox
snuyanzin commented on PR #19811: URL: https://github.com/apache/flink/pull/19811#issuecomment-1136752374 The PR is based on commit https://github.com/apache/flink/pull/19780 migrating `TypeSerializerUpgradeTestBase` to JUnit5 -- This is an automated message from the Apache Git

[jira] [Commented] (FLINK-27155) Reduce multiple reads to the same Changelog file in the same taskmanager during restore

2022-05-24 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541827#comment-17541827 ] Feifan Wang commented on FLINK-27155: - Thanks for [~roman] 's explain and sorry for leave so long. I

[GitHub] [flink] flinkbot commented on pull request #19812: [hotfix] [docs] Fix misspelled word...

2022-05-24 Thread GitBox
flinkbot commented on PR #19812: URL: https://github.com/apache/flink/pull/19812#issuecomment-1136710187 ## CI report: * fd022e91a80dd313e74a6c93a507ffa5aef0312b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] leewallen opened a new pull request, #19812: Fix misspelled word...

2022-05-24 Thread GitBox
leewallen opened a new pull request, #19812: URL: https://github.com/apache/flink/pull/19812 unefficient -> inefficient ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That

[GitHub] [flink-kubernetes-operator] bgeng777 commented on a diff in pull request #242: [FLINK-27615] Document how to define namespaceSelector for k8s operator's webhook

2022-05-24 Thread GitBox
bgeng777 commented on code in PR #242: URL: https://github.com/apache/flink-kubernetes-operator/pull/242#discussion_r881193136 ## docs/content/docs/operations/helm.md: ## @@ -107,6 +107,29 @@ The webhook can be disabled during helm install by passing the `--set webhook.cr

[jira] [Created] (FLINK-27761) Add database and table field in canal-json sink

2022-05-24 Thread Zhiwen Sun (Jira)
Zhiwen Sun created FLINK-27761: -- Summary: Add database and table field in canal-json sink Key: FLINK-27761 URL: https://issues.apache.org/jira/browse/FLINK-27761 Project: Flink Issue Type:

[GitHub] [flink-kubernetes-operator] bgeng777 commented on a diff in pull request #242: [FLINK-27615] Document how to define namespaceSelector for k8s operator's webhook

2022-05-24 Thread GitBox
bgeng777 commented on code in PR #242: URL: https://github.com/apache/flink-kubernetes-operator/pull/242#discussion_r881193136 ## docs/content/docs/operations/helm.md: ## @@ -107,6 +107,29 @@ The webhook can be disabled during helm install by passing the `--set webhook.cr

[GitHub] [flink-kubernetes-operator] bgeng777 commented on a diff in pull request #242: [FLINK-27615] Document how to define namespaceSelector for k8s operator's webhook

2022-05-24 Thread GitBox
bgeng777 commented on code in PR #242: URL: https://github.com/apache/flink-kubernetes-operator/pull/242#discussion_r881193025 ## docs/content/docs/operations/helm.md: ## @@ -107,6 +107,28 @@ The webhook can be disabled during helm install by passing the `--set webhook.cr

[jira] [Commented] (FLINK-27579) The param client.timeout can not be set by dynamic properties when stopping the job

2022-05-24 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541809#comment-17541809 ] Yang Wang commented on FLINK-27579: --- The root cause is we do not get the {{clientTimeout}} from

[jira] [Created] (FLINK-27760) NPE is thrown when executing PyFlink jobs in batch mode

2022-05-24 Thread Dian Fu (Jira)
Dian Fu created FLINK-27760: --- Summary: NPE is thrown when executing PyFlink jobs in batch mode Key: FLINK-27760 URL: https://issues.apache.org/jira/browse/FLINK-27760 Project: Flink Issue Type:

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #136: [FLINK-27752] Change 'path' to 'root-path' in table store

2022-05-24 Thread GitBox
LadyForest commented on code in PR #136: URL: https://github.com/apache/flink-table-store/pull/136#discussion_r881192269 ## flink-table-store-connector/src/test/java/org/apache/flink/table/store/connector/TableStoreManagedFactoryTest.java: ## @@ -355,4 +380,42 @@ private static

[jira] [Commented] (FLINK-27639) Flink JOIN uses the now() function when inserting data, resulting in data that cannot be deleted

2022-05-24 Thread lvycc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541808#comment-17541808 ] lvycc commented on FLINK-27639: --- Run  init  sql in Mysql: {code:java} //代码占位符 CREATE TABLE `t_order` (

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #136: [FLINK-27752] Change 'path' to 'root-path' in table store

2022-05-24 Thread GitBox
LadyForest commented on code in PR #136: URL: https://github.com/apache/flink-table-store/pull/136#discussion_r881189824 ## flink-table-store-kafka/src/main/java/org/apache/flink/table/store/kafka/KafkaLogStoreFactory.java: ## @@ -93,6 +96,23 @@ public Set> optionalOptions() {

[GitHub] [flink] dianfu commented on pull request #15491: [FLINK-21966][python]Support Kinesis connector in Python DataStream API

2022-05-24 Thread GitBox
dianfu commented on PR #15491: URL: https://github.com/apache/flink/pull/15491#issuecomment-1136690230 What's the status of this PR? I can help to review if it's updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] CodingCaproni commented on pull request #19783: [FLINK-27616][Table SQL/Planner] Modify the spelling mistakes of the …

2022-05-24 Thread GitBox
CodingCaproni commented on PR #19783: URL: https://github.com/apache/flink/pull/19783#issuecomment-1136687147 @wuchong Can you please review it ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] snuyanzin commented on pull request #19811: [FLINK-27758][tests][table] Migrate flink-table-runtime to JUnit5

2022-05-24 Thread GitBox
snuyanzin commented on PR #19811: URL: https://github.com/apache/flink/pull/19811#issuecomment-1136687056 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #242: [FLINK-27615] Document how to define namespaceSelector for k8s operator's webhook

2022-05-24 Thread GitBox
wangyang0918 commented on code in PR #242: URL: https://github.com/apache/flink-kubernetes-operator/pull/242#discussion_r881185048 ## docs/content/docs/operations/helm.md: ## @@ -107,6 +107,28 @@ The webhook can be disabled during helm install by passing the `--set webhook.cr

[GitHub] [flink-ml] weibozhao commented on a diff in pull request #83: [FLINK-27170] Add Transformer and Estimator for OnlineLogisticRegression

2022-05-24 Thread GitBox
weibozhao commented on code in PR #83: URL: https://github.com/apache/flink-ml/pull/83#discussion_r881173528 ## flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasL2.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [flink-ml] weibozhao commented on a diff in pull request #83: [FLINK-27170] Add Transformer and Estimator for OnlineLogisticRegression

2022-05-24 Thread GitBox
weibozhao commented on code in PR #83: URL: https://github.com/apache/flink-ml/pull/83#discussion_r881173256 ## flink-ml-lib/src/main/java/org/apache/flink/ml/classification/logisticregression/OnlineLogisticRegression.java: ## @@ -0,0 +1,428 @@ +/* + * Licensed to the Apache

[jira] [Comment Edited] (FLINK-27722) Slack: set up auto-updated invitation link

2022-05-24 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541800#comment-17541800 ] Jark Wu edited comment on FLINK-27722 at 5/25/22 2:54 AM: -- Another workaround

[jira] [Comment Edited] (FLINK-27722) Slack: set up auto-updated invitation link

2022-05-24 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541800#comment-17541800 ] Jark Wu edited comment on FLINK-27722 at 5/25/22 2:54 AM: -- Another workaround

[jira] [Commented] (FLINK-27722) Slack: set up auto-updated invitation link

2022-05-24 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541800#comment-17541800 ] Jark Wu commented on FLINK-27722: - Another workaround is using a shorturl + never expired invitation

[jira] [Closed] (FLINK-27747) Flink kubernetes operator helm chart release the Chart.yaml file doesn't have an apache license header

2022-05-24 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang closed FLINK-27747. - Resolution: Fixed Fixed via: main: 710310b76d174526135e30ad236c32f74df45c78 release-1.0:

[jira] [Closed] (FLINK-27746) Flink kubernetes operator docker image could not build with source release

2022-05-24 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang closed FLINK-27746. - Resolution: Fixed Fixed via: main: cf8f99b2c7cd61828ce94228d1b6b31c235d4cb8 release-1.0:

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #136: [FLINK-27752] Change 'path' to 'root-path' in table store

2022-05-24 Thread GitBox
JingsongLi commented on code in PR #136: URL: https://github.com/apache/flink-table-store/pull/136#discussion_r881164055 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStoreManagedFactory.java: ## @@ -0,0 +1,188 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-27759) Rethink how to get the git commit id for docker image in Flink Kubernetes operator

2022-05-24 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541787#comment-17541787 ] Yang Wang commented on FLINK-27759: --- Thanks for the volunteering. I believe this is not in hurry.

[jira] [Assigned] (FLINK-27759) Rethink how to get the git commit id for docker image in Flink Kubernetes operator

2022-05-24 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang reassigned FLINK-27759: - Assignee: Nicholas Jiang > Rethink how to get the git commit id for docker image in Flink

[jira] [Updated] (FLINK-27747) Flink kubernetes operator helm chart release the Chart.yaml file doesn't have an apache license header

2022-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27747: --- Labels: pull-request-available (was: ) > Flink kubernetes operator helm chart release the

[GitHub] [flink-kubernetes-operator] wangyang0918 merged pull request #240: [FLINK-27747] Use tar instead of helm package when creating source release

2022-05-24 Thread GitBox
wangyang0918 merged PR #240: URL: https://github.com/apache/flink-kubernetes-operator/pull/240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-27759) Rethink how to get the git commit id for docker image in Flink Kubernetes operator

2022-05-24 Thread Nicholas Jiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541784#comment-17541784 ] Nicholas Jiang commented on FLINK-27759: [~wangyang0918], I will investigate the better way to

[GitHub] [flink-kubernetes-operator] wangyang0918 merged pull request #243: [FLINK-27746] Flink kubernetes operator docker image could not build with source release

2022-05-24 Thread GitBox
wangyang0918 merged PR #243: URL: https://github.com/apache/flink-kubernetes-operator/pull/243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (FLINK-27759) Rethink how to get the git commit id for docker image in Flink Kubernetes operator

2022-05-24 Thread Yang Wang (Jira)
Yang Wang created FLINK-27759: - Summary: Rethink how to get the git commit id for docker image in Flink Kubernetes operator Key: FLINK-27759 URL: https://issues.apache.org/jira/browse/FLINK-27759

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #243: [FLINK-27746] Flink kubernetes operator docker image could not build with source release

2022-05-24 Thread GitBox
wangyang0918 commented on PR #243: URL: https://github.com/apache/flink-kubernetes-operator/pull/243#issuecomment-1136640871 I have created a new ticket FLINK-27759 to follow the potential improvement. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] Sxnan commented on a diff in pull request #19653: [FLINK-27523] Runtime supports producing and consuming cached intermediate results

2022-05-24 Thread GitBox
Sxnan commented on code in PR #19653: URL: https://github.com/apache/flink/pull/19653#discussion_r879216461 ## flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleMaster.java: ## @@ -84,6 +86,33 @@ CompletableFuture registerPartitionWithProducer(

[GitHub] [flink-kubernetes-operator] Aitozi commented on pull request #239: [FLINK-27714] Migrate to java-operator-sdk v3

2022-05-24 Thread GitBox
Aitozi commented on PR #239: URL: https://github.com/apache/flink-kubernetes-operator/pull/239#issuecomment-1136635601 Thanks @morhidi for this nice work, I'll take a closer look today -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] lsyldliu commented on pull request #19410: [FLINK-15635][table] Now EnvironmentSettings accepts the user ClassLoader

2022-05-24 Thread GitBox
lsyldliu commented on PR #19410: URL: https://github.com/apache/flink/pull/19410#issuecomment-1136633593 > > > > ping @matriv Can you help to complete this work as soon as possible? [FLIP-214](https://cwiki.apache.org/confluence/display/FLINK/FLIP-214+Support+Advanced+Function+DDL)

[GitHub] [flink] yangjunhan commented on a diff in pull request #19712: [FLINK-26207][runtime-web] make web ui's components depend on injected configurable object

2022-05-24 Thread GitBox
yangjunhan commented on code in PR #19712: URL: https://github.com/apache/flink/pull/19712#discussion_r881145686 ## flink-runtime-web/web-dashboard/src/app/pages/job/overview/backpressure/job-overview-drawer-backpressure.component.html: ## @@ -17,14 +17,17 @@ -->

[GitHub] [flink-kubernetes-operator] Aitozi commented on a diff in pull request #242: [FLINK-27615] Document how to define namespaceSelector for k8s operator's webhook

2022-05-24 Thread GitBox
Aitozi commented on code in PR #242: URL: https://github.com/apache/flink-kubernetes-operator/pull/242#discussion_r881142701 ## docs/content/docs/operations/helm.md: ## @@ -107,6 +107,29 @@ The webhook can be disabled during helm install by passing the `--set webhook.cr The

[jira] [Commented] (FLINK-27579) The param client.timeout can not be set by dynamic properties when stopping the job

2022-05-24 Thread Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541780#comment-17541780 ] Liu commented on FLINK-27579: - [~paul8263] Thanks for the pr. We need a flink committer to verify the

[jira] [Closed] (FLINK-27478) datastream.print() failed by uncertain cause

2022-05-24 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-27478. --- Resolution: Not A Problem I'm closing this ticket as I think it don't think this is an issue. It might be

[jira] [Closed] (FLINK-27690) Add Python documentation and examples for Pulsar connector

2022-05-24 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-27690. --- Fix Version/s: 1.16.0 Resolution: Fixed Merged to master via 

[GitHub] [flink] dianfu closed pull request #19775: [FLINK-27690][python][connector/pulsar] Add Python documentation and examples for Pulsar connector

2022-05-24 Thread GitBox
dianfu closed pull request #19775: [FLINK-27690][python][connector/pulsar] Add Python documentation and examples for Pulsar connector URL: https://github.com/apache/flink/pull/19775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (FLINK-22599) Point to `client.timeout` in error messages where it is used for rpc timeout

2022-05-24 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541744#comment-17541744 ] Mason Chen commented on FLINK-22599: +1 for fixing this issue and changing the priority of the

[GitHub] [flink] MartijnVisser commented on pull request #19806: [FLINK-27450][hive] Upgrade default hive version to fix Hive SessionState initialization issue with jdk11

2022-05-24 Thread GitBox
MartijnVisser commented on PR #19806: URL: https://github.com/apache/flink/pull/19806#issuecomment-1136414341 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] flinkbot commented on pull request #19811: [FLINK-27758][tests][table] Migrate flink-table-runtime to JUnit5

2022-05-24 Thread GitBox
flinkbot commented on PR #19811: URL: https://github.com/apache/flink/pull/19811#issuecomment-1136400172 ## CI report: * 55083d6ce49a1e36922d059e19bf463d0a375914 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-27758) [JUnit5 Migration] Module: flink-table-runtime

2022-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27758: --- Labels: pull-request-available (was: ) > [JUnit5 Migration] Module: flink-table-runtime >

[GitHub] [flink] snuyanzin opened a new pull request, #19811: [FLINK-27758][tests][table] Migrate flink-table-runtime to JUnit5

2022-05-24 Thread GitBox
snuyanzin opened a new pull request, #19811: URL: https://github.com/apache/flink/pull/19811 ## What is the purpose of the change Update the flink-table-runtime module to AssertJ and JUnit 5 following the [JUnit 5 Migration

[jira] [Created] (FLINK-27758) [JUnit5 Migration] Module: flink-table-runtime

2022-05-24 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-27758: --- Summary: [JUnit5 Migration] Module: flink-table-runtime Key: FLINK-27758 URL: https://issues.apache.org/jira/browse/FLINK-27758 Project: Flink Issue

[GitHub] [flink] flinkbot commented on pull request #19810: [FLINK-27757][Connector][Elasticsearch] Elasticsearch connector should not use `flink-table-planner` but `flink-table-planner-loader`

2022-05-24 Thread GitBox
flinkbot commented on PR #19810: URL: https://github.com/apache/flink/pull/19810#issuecomment-1136300616 ## CI report: * 6895512a70ccc28846dcb49bc0144f7a10372ef8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] MartijnVisser opened a new pull request, #19810: [FLINK-27757][Connector][Elasticsearch] Elasticsearch connector should not use `flink-table-planner` but `flink-table-planner-loader`

2022-05-24 Thread GitBox
MartijnVisser opened a new pull request, #19810: URL: https://github.com/apache/flink/pull/19810 ## What is the purpose of the change Elasticsearch connector should not use `flink-table-planner` but `flink-table-planner-loader`. We also need to add `flink-table-runtime` to avoid

[jira] [Updated] (FLINK-27757) Elasticsearch connector should not use flink-table-planner but flink-table-planner-loader

2022-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27757: --- Labels: pull-request-available (was: ) > Elasticsearch connector should not use

[GitHub] [flink-connector-elasticsearch] MartijnVisser opened a new pull request, #20: [FLINK-27757][Connector][Elasticsearch] Elasticsearch connector should not use `flink-table-planner` but `flink-t

2022-05-24 Thread GitBox
MartijnVisser opened a new pull request, #20: URL: https://github.com/apache/flink-connector-elasticsearch/pull/20 We also need to add `flink-table-runtime` to avoid ClassNotFoundException on `org.apache.flink.table.shaded.com.jayway.jsonpath.spi.mapper.MappingProvider` -- This is an

[jira] [Created] (FLINK-27757) Elasticsearch connector should not use flink-table-planner but flink-table-planner-loader

2022-05-24 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-27757: -- Summary: Elasticsearch connector should not use flink-table-planner but flink-table-planner-loader Key: FLINK-27757 URL: https://issues.apache.org/jira/browse/FLINK-27757

[GitHub] [flink] rkhachatryan commented on a diff in pull request #19448: [FLINK-25872][state] Support restore from non-changelog checkpoint with changelog enabled in CLAIM mode

2022-05-24 Thread GitBox
rkhachatryan commented on code in PR #19448: URL: https://github.com/apache/flink/pull/19448#discussion_r880787079 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistry.java: ## @@ -57,13 +58,30 @@ public interface SharedStateRegistry extends

[GitHub] [flink] rkhachatryan commented on a diff in pull request #19448: [FLINK-25872][state] Support restore from non-changelog checkpoint with changelog enabled in CLAIM mode

2022-05-24 Thread GitBox
rkhachatryan commented on code in PR #19448: URL: https://github.com/apache/flink/pull/19448#discussion_r880782026 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/OperatorSubtaskState.java: ## @@ -227,6 +229,14 @@ private static void registerSharedState(

[GitHub] [flink] chenqin closed pull request #19779: [FLINK-27726] [Connector-Hive] shade thrift and fb303 in hive connector

2022-05-24 Thread GitBox
chenqin closed pull request #19779: [FLINK-27726] [Connector-Hive] shade thrift and fb303 in hive connector URL: https://github.com/apache/flink/pull/19779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink-kubernetes-operator] tisonkun commented on pull request #243: [FLINK-27746] Flink kubernetes operator docker image could not build with source release

2022-05-24 Thread GitBox
tisonkun commented on PR #243: URL: https://github.com/apache/flink-kubernetes-operator/pull/243#issuecomment-1136209005 @wangyang0918 I'm thinking of `COPY . .` with a `.dockerignore` file. But yes, we can investigate better way after release 1.0.0. -- This is an automated message from

[GitHub] [flink-kubernetes-operator] SteNicholas commented on a diff in pull request #243: [FLINK-27746] Flink kubernetes operator docker image could not build with source release

2022-05-24 Thread GitBox
SteNicholas commented on code in PR #243: URL: https://github.com/apache/flink-kubernetes-operator/pull/243#discussion_r880660035 ## Dockerfile: ## @@ -36,7 +36,7 @@ COPY $DOCS_DIR/pom.xml ./$DOCS_DIR/ COPY $OPERATOR_DIR/src ./$OPERATOR_DIR/src COPY $WEBHOOK_DIR/src

[GitHub] [flink-kubernetes-operator] tisonkun commented on a diff in pull request #243: [FLINK-27746] Flink kubernetes operator docker image could not build with source release

2022-05-24 Thread GitBox
tisonkun commented on code in PR #243: URL: https://github.com/apache/flink-kubernetes-operator/pull/243#discussion_r880657077 ## Dockerfile: ## @@ -36,7 +36,7 @@ COPY $DOCS_DIR/pom.xml ./$DOCS_DIR/ COPY $OPERATOR_DIR/src ./$OPERATOR_DIR/src COPY $WEBHOOK_DIR/src

[GitHub] [flink-kubernetes-operator] tisonkun commented on a diff in pull request #243: [FLINK-27746] Flink kubernetes operator docker image could not build with source release

2022-05-24 Thread GitBox
tisonkun commented on code in PR #243: URL: https://github.com/apache/flink-kubernetes-operator/pull/243#discussion_r880657077 ## Dockerfile: ## @@ -36,7 +36,7 @@ COPY $DOCS_DIR/pom.xml ./$DOCS_DIR/ COPY $OPERATOR_DIR/src ./$OPERATOR_DIR/src COPY $WEBHOOK_DIR/src

[GitHub] [flink-kubernetes-operator] SteNicholas commented on a diff in pull request #243: [FLINK-27746] Flink kubernetes operator docker image could not build with source release

2022-05-24 Thread GitBox
SteNicholas commented on code in PR #243: URL: https://github.com/apache/flink-kubernetes-operator/pull/243#discussion_r880655702 ## Dockerfile: ## @@ -36,7 +36,7 @@ COPY $DOCS_DIR/pom.xml ./$DOCS_DIR/ COPY $OPERATOR_DIR/src ./$OPERATOR_DIR/src COPY $WEBHOOK_DIR/src

[GitHub] [flink-kubernetes-operator] tisonkun closed pull request #241: [FLINK-27746] Replace git-commit-id-maven-plugin with script

2022-05-24 Thread GitBox
tisonkun closed pull request #241: [FLINK-27746] Replace git-commit-id-maven-plugin with script URL: https://github.com/apache/flink-kubernetes-operator/pull/241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink-kubernetes-operator] tisonkun commented on pull request #241: [FLINK-27746] Replace git-commit-id-maven-plugin with script

2022-05-24 Thread GitBox
tisonkun commented on PR #241: URL: https://github.com/apache/flink-kubernetes-operator/pull/241#issuecomment-1136067938 Closed in favor of #243. This patch never builds the image with git props. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink-kubernetes-operator] tisonkun commented on a diff in pull request #243: [FLINK-27746] Flink kubernetes operator docker image could not build with source release

2022-05-24 Thread GitBox
tisonkun commented on code in PR #243: URL: https://github.com/apache/flink-kubernetes-operator/pull/243#discussion_r880649631 ## Dockerfile: ## @@ -36,7 +36,7 @@ COPY $DOCS_DIR/pom.xml ./$DOCS_DIR/ COPY $OPERATOR_DIR/src ./$OPERATOR_DIR/src COPY $WEBHOOK_DIR/src

[GitHub] [flink-kubernetes-operator] SteNicholas opened a new pull request, #243: [FLINK-27746] Flink kubernetes operator docker image could not build with source release

2022-05-24 Thread GitBox
SteNicholas opened a new pull request, #243: URL: https://github.com/apache/flink-kubernetes-operator/pull/243 Flink kubernetes operator docker image could not build with source release at present. The `.git` directory should be copied when the directory exists. -- This is an automated

[GitHub] [flink] flinkbot commented on pull request #19807: [FLINK-27185][connectors] Convert connector-jdbc module to assertj

2022-05-24 Thread GitBox
flinkbot commented on PR #19807: URL: https://github.com/apache/flink/pull/19807#issuecomment-1136037139 ## CI report: * e88da15ad3a8b6e3f431a89ac2dca2d62d28c63c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #19809: [FLINK-27185][connectors] Convert connector-kinesis module to assertj

2022-05-24 Thread GitBox
flinkbot commented on PR #19809: URL: https://github.com/apache/flink/pull/19809#issuecomment-1136037406 ## CI report: * 45950ba3dd1aa8da0a2d980cba7c87c6c6b006f5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #19808: [FLINK-27185][connectors] Convert connector-kafka module to assertj

2022-05-24 Thread GitBox
flinkbot commented on PR #19808: URL: https://github.com/apache/flink/pull/19808#issuecomment-1136037272 ## CI report: * a0e1e050f0325c0eff8386dafee3b4b2cafef7bd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] alpreu closed pull request #19660: [FLINK-27185][connectors] Convert connector modules to assertj

2022-05-24 Thread GitBox
alpreu closed pull request #19660: [FLINK-27185][connectors] Convert connector modules to assertj URL: https://github.com/apache/flink/pull/19660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] alpreu opened a new pull request, #19809: [FLINK-27185][connectors] Convert connector-kinesis module to assertj

2022-05-24 Thread GitBox
alpreu opened a new pull request, #19809: URL: https://github.com/apache/flink/pull/19809 Cherry-picked commits from https://github.com/apache/flink/pull/19660 to get the individual changes merged faster -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] alpreu opened a new pull request, #19808: [FLINK-27185][connectors] Convert connector-kafka module to assertj

2022-05-24 Thread GitBox
alpreu opened a new pull request, #19808: URL: https://github.com/apache/flink/pull/19808 Cherry-picked commits from https://github.com/apache/flink/pull/19660 to get the individual changes merged faster -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] alpreu opened a new pull request, #19807: [FLINK-27185][connectors] Convert connector-jdbc module to assertj

2022-05-24 Thread GitBox
alpreu opened a new pull request, #19807: URL: https://github.com/apache/flink/pull/19807 Cherry-picked commits from https://github.com/apache/flink/pull/19660 to get the individual changes merged faster -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink-kubernetes-operator] tisonkun commented on pull request #241: [FLINK-27746] Replace git-commit-id-maven-plugin with script

2022-05-24 Thread GitBox
tisonkun commented on PR #241: URL: https://github.com/apache/flink-kubernetes-operator/pull/241#issuecomment-1136032335 It happens that I get some spare time to work on this issue. So now I replace git-commit-id-maven-plugin with script and get rid of force dependency on `.git`.

[GitHub] [flink-kubernetes-operator] bgeng777 commented on pull request #242: [FLINK-27615] Document how to define namespaceSelector for k8s operator's webhook

2022-05-24 Thread GitBox
bgeng777 commented on PR #242: URL: https://github.com/apache/flink-kubernetes-operator/pull/242#issuecomment-1136017180 cc @wangyang0918 @Aitozi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] afedulov commented on pull request #19660: [FLINK-27185][connectors] Convert connector modules to assertj

2022-05-24 Thread GitBox
afedulov commented on PR #19660: URL: https://github.com/apache/flink/pull/19660#issuecomment-1136017138 connector-kinesis module looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] afedulov commented on pull request #19660: [FLINK-27185][connectors] Convert connector modules to assertj

2022-05-24 Thread GitBox
afedulov commented on PR #19660: URL: https://github.com/apache/flink/pull/19660#issuecomment-1136015247 connector-kafka module looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] afedulov commented on pull request #19660: [FLINK-27185][connectors] Convert connector modules to assertj

2022-05-24 Thread GitBox
afedulov commented on PR #19660: URL: https://github.com/apache/flink/pull/19660#issuecomment-1136014143 connector-jdbc module looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (FLINK-27722) Slack: set up auto-updated invitation link

2022-05-24 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541494#comment-17541494 ] Martijn Visser commented on FLINK-27722: Currently yes, you'll see a {{Failed! missing_scope}}

[jira] [Commented] (FLINK-27722) Slack: set up auto-updated invitation link

2022-05-24 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541491#comment-17541491 ] Chesnay Schepler commented on FLINK-27722: -- So it is expected that the herokuapp link doesn't

[jira] [Comment Edited] (FLINK-27722) Slack: set up auto-updated invitation link

2022-05-24 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541491#comment-17541491 ] Chesnay Schepler edited comment on FLINK-27722 at 5/24/22 2:22 PM: --- So

[jira] [Commented] (FLINK-27611) ConcurrentModificationException during Flink-Pulsar checkpoint notification

2022-05-24 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541490#comment-17541490 ] Chesnay Schepler commented on FLINK-27611: -- This looks a bit like a basic

[jira] [Commented] (FLINK-27722) Slack: set up auto-updated invitation link

2022-05-24 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541487#comment-17541487 ] Martijn Visser commented on FLINK-27722: I've setup https://apache-flink-slack.herokuapp.com/

[jira] [Commented] (FLINK-27611) ConcurrentModificationException during Flink-Pulsar checkpoint notification

2022-05-24 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541485#comment-17541485 ] Chesnay Schepler commented on FLINK-27611: -- It is an issue on the Flink side. >

[jira] [Commented] (FLINK-27611) ConcurrentModificationException during Flink-Pulsar checkpoint notification

2022-05-24 Thread Jason Kania (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541478#comment-17541478 ] Jason Kania commented on FLINK-27611: - Does the most recent comment mean that it should go to the

[jira] [Assigned] (FLINK-27722) Slack: set up auto-updated invitation link

2022-05-24 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-27722: -- Assignee: Martijn Visser > Slack: set up auto-updated invitation link >

[jira] [Updated] (FLINK-27615) Document how to define namespaceSelector for k8s operator's webhook for different k8s versions

2022-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27615: --- Labels: pull-request-available (was: ) > Document how to define namespaceSelector for k8s

[GitHub] [flink-kubernetes-operator] bgeng777 opened a new pull request, #242: [FLINK-27615] Document how to define namespaceSelector for k8s operator's webhook

2022-05-24 Thread GitBox
bgeng777 opened a new pull request, #242: URL: https://github.com/apache/flink-kubernetes-operator/pull/242 - Improve the documents of `Watching only specific namespaces` part in `helm.md` to introduce how to make webhook work as expected using different k8s versions. -- This is an

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #239: [FLINK-27714] Migrate to java-operator-sdk v3

2022-05-24 Thread GitBox
morhidi commented on PR #239: URL: https://github.com/apache/flink-kubernetes-operator/pull/239#issuecomment-1135863738 Getting the following issue intermittently on submitting the `basic-session-job.yaml` ``` 2022-05-24 14:17:29,863 i.j.o.p.e.ReconciliationDispatcher [ERROR]

[jira] [Resolved] (FLINK-27754) Getting Flink config fails if multiple files in /lib match flink-dist-*

2022-05-24 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer resolved FLINK-27754. --- Resolution: Fixed > Getting Flink config fails if multiple files in /lib match flink-dist-*

[jira] [Commented] (FLINK-27754) Getting Flink config fails if multiple files in /lib match flink-dist-*

2022-05-24 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541447#comment-17541447 ] Danny Cranmer commented on FLINK-27754: --- Merged into master @ [d891509

[GitHub] [flink] dannycranmer merged pull request #19805: [FLINK-27754][shell] Add stderr when 1 flink-dist*.jar cannot be resolved.

2022-05-24 Thread GitBox
dannycranmer merged PR #19805: URL: https://github.com/apache/flink/pull/19805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] dannycranmer commented on pull request #19805: [FLINK-27754][shell] Add stderr when 1 flink-dist*.jar cannot be resolved.

2022-05-24 Thread GitBox
dannycranmer commented on PR #19805: URL: https://github.com/apache/flink/pull/19805#issuecomment-1135860349 CI failed due to flaky test, raise jira for that: https://issues.apache.org/jira/browse/FLINK-27756 CI passed on previous PR, merging. -- This is an automated message from

[GitHub] [flink] JingGe commented on pull request #19799: [Flink-26011][test] backport 1.15 - ArchUnit test for formats test code

2022-05-24 Thread GitBox
JingGe commented on PR #19799: URL: https://github.com/apache/flink/pull/19799#issuecomment-1135830938 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #241: FLINK-27746: Remove COPY .git in dockerfile

2022-05-24 Thread GitBox
wangyang0918 commented on PR #241: URL: https://github.com/apache/flink-kubernetes-operator/pull/241#issuecomment-1135821076 I lean to skip copying the `.git` directory if not exist. Then the version in log will be `UNKNOWN` if building the image with source release. -- This is an

[jira] [Closed] (FLINK-27174) Non-null check for bootstrapServers field is incorrect in KafkaSink

2022-05-24 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul closed FLINK-27174. --- > Non-null check for bootstrapServers field is incorrect in KafkaSink >

[jira] [Updated] (FLINK-27174) Non-null check for bootstrapServers field is incorrect in KafkaSink

2022-05-24 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul updated FLINK-27174: Affects Version/s: 1.15.0 1.16.0 > Non-null check for bootstrapServers

[jira] [Resolved] (FLINK-27174) Non-null check for bootstrapServers field is incorrect in KafkaSink

2022-05-24 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul resolved FLINK-27174. - Fix Version/s: 1.16.0 1.14.5 1.15.1 Resolution:

[GitHub] [flink] simplejason commented on a diff in pull request #19712: [FLINK-26207][runtime-web] make web ui's components depend on injected configurable object

2022-05-24 Thread GitBox
simplejason commented on code in PR #19712: URL: https://github.com/apache/flink/pull/19712#discussion_r880399930 ## flink-runtime-web/web-dashboard/src/app/pages/task-manager/logs/task-manager-logs.component.ts: ## @@ -65,21 +69,13 @@ export class TaskManagerLogsComponent

[GitHub] [flink] simplejason commented on a diff in pull request #19712: [FLINK-26207][runtime-web] make web ui's components depend on injected configurable object

2022-05-24 Thread GitBox
simplejason commented on code in PR #19712: URL: https://github.com/apache/flink/pull/19712#discussion_r880399930 ## flink-runtime-web/web-dashboard/src/app/pages/task-manager/logs/task-manager-logs.component.ts: ## @@ -65,21 +69,13 @@ export class TaskManagerLogsComponent

[jira] [Commented] (FLINK-27174) Non-null check for bootstrapServers field is incorrect in KafkaSink

2022-05-24 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541431#comment-17541431 ] Fabian Paul commented on FLINK-27174: - Merged in release-1.15:

  1   2   3   >