[jira] [Commented] (FLINK-27890) bug of SideOutputExample.java

2022-06-04 Thread CodeRap (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17550160#comment-17550160 ] CodeRap commented on FLINK-27890: - Bug introduced by FLINK-19317 [~aljoscha] It assigns the

[jira] [Updated] (FLINK-27889) Error when the LastReconciledSpec is null

2022-06-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-27889: --- Fix Version/s: kubernetes-operator-1.0.1 > Error when the LastReconciledSpec is null >

[jira] [Updated] (FLINK-27889) Error when the LastReconciledSpec is null

2022-06-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-27889: --- Fix Version/s: kubernetes-operator-1.1.0 > Error when the LastReconciledSpec is null >

[jira] [Commented] (FLINK-27889) Error when the LastReconciledSpec is null

2022-06-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17548884#comment-17548884 ] Gyula Fora commented on FLINK-27889: release-1.0 : 6ce1c6b51241ca2b866816232acb1612e2b18c40 > Error

[jira] [Resolved] (FLINK-27889) Error when the LastReconciledSpec is null

2022-06-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora resolved FLINK-27889. Assignee: Hector Miuler Malpica Gallegos Resolution: Fixed merged to main

[GitHub] [flink-kubernetes-operator] gyfora closed pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-04 Thread GitBox
gyfora closed pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null URL: https://github.com/apache/flink-kubernetes-operator/pull/252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-04 Thread GitBox
gyfora commented on PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#issuecomment-1146654972 Merged this to main manually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-04 Thread GitBox
gyfora commented on code in PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r889595076 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java: ## @@ -229,14 +229,12 @@ private

[GitHub] [flink-ml] yunfengzhou-hub commented on pull request #97: [FLINK-27096] Improve DataCache and KMeans Performance

2022-06-04 Thread GitBox
yunfengzhou-hub commented on PR #97: URL: https://github.com/apache/flink-ml/pull/97#issuecomment-1146612587 Thanks for the comments. I have updated the PR according to the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink-kubernetes-operator] Miuler commented on a diff in pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-04 Thread GitBox
Miuler commented on code in PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r889533284 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java: ## @@ -229,14 +229,12 @@ private

[GitHub] [flink-kubernetes-operator] Miuler commented on a diff in pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-04 Thread GitBox
Miuler commented on code in PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r889533284 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java: ## @@ -229,14 +229,12 @@ private

[GitHub] [flink-kubernetes-operator] Miuler commented on pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-04 Thread GitBox
Miuler commented on PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#issuecomment-1146610360 @gyfora I already revert the commit where I add logs, I only have the doubt of the timeout. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink-kubernetes-operator] Miuler commented on a diff in pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-04 Thread GitBox
Miuler commented on code in PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r889528815 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java: ## @@ -134,6 +135,11 @@ public

[GitHub] [flink-kubernetes-operator] Miuler commented on a diff in pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-04 Thread GitBox
Miuler commented on code in PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r889527423 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentControllerTest.java: ## @@ -274,6 +279,15 @@

[GitHub] [flink-kubernetes-operator] Miuler commented on a diff in pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-04 Thread GitBox
Miuler commented on code in PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r889527238 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java: ## @@ -229,14 +229,12 @@ private

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #97: [FLINK-27096] Improve DataCache and KMeans Performance

2022-06-04 Thread GitBox
yunfengzhou-hub commented on code in PR #97: URL: https://github.com/apache/flink-ml/pull/97#discussion_r888738791 ## flink-ml-iteration/src/main/java/org/apache/flink/iteration/datacache/nonkeyed/MemorySegmentWriter.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-04 Thread GitBox
gyfora commented on code in PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r889524742 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentControllerTest.java: ## @@ -274,6 +279,15 @@

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-04 Thread GitBox
gyfora commented on code in PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r88952 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentControllerTest.java: ## @@ -274,6 +279,15 @@

[GitHub] [flink-kubernetes-operator] Miuler commented on a diff in pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-04 Thread GitBox
Miuler commented on code in PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r889523773 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java: ## @@ -229,14 +229,12 @@ private

[GitHub] [flink-kubernetes-operator] Miuler commented on a diff in pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-04 Thread GitBox
Miuler commented on code in PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r889523760 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentControllerTest.java: ## @@ -274,6 +279,15 @@

[jira] [Created] (FLINK-27897) SearchArgumentToPredicateConverter can not handle partial filters

2022-06-04 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-27897: Summary: SearchArgumentToPredicateConverter can not handle partial filters Key: FLINK-27897 URL: https://issues.apache.org/jira/browse/FLINK-27897 Project: Flink

[GitHub] [flink] dianfu commented on a diff in pull request #19869: [FLINK-21996][python] Support Kinesis connector in Python DataStream API

2022-06-04 Thread GitBox
dianfu commented on code in PR #19869: URL: https://github.com/apache/flink/pull/19869#discussion_r888480774 ## flink-python/pyflink/datastream/connectors/kinesis.py: ## @@ -0,0 +1,368 @@ + +#

[jira] [Commented] (FLINK-27893) Add additionalPrinterColumns for Job Status and Reconciliation Status in CRDs

2022-06-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17547934#comment-17547934 ] Gyula Fora commented on FLINK-27893: I think ReconciliationStatus.State is better because that is

[jira] [Commented] (FLINK-27893) Add additionalPrinterColumns for Job Status and Reconciliation Status in CRDs

2022-06-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17547933#comment-17547933 ] Gyula Fora commented on FLINK-27893: We have to be careful what we expose as not everything is

[jira] [Assigned] (FLINK-27893) Add additionalPrinterColumns for Job Status and Reconciliation Status in CRDs

2022-06-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-27893: -- Assignee: Jeesmon Jacob > Add additionalPrinterColumns for Job Status and Reconciliation

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-04 Thread GitBox
gyfora commented on code in PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r889505556 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java: ## @@ -134,6 +135,11 @@ public

[jira] [Created] (FLINK-27896) Clean up FlinkService#cancelJob implementation

2022-06-04 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-27896: -- Summary: Clean up FlinkService#cancelJob implementation Key: FLINK-27896 URL: https://issues.apache.org/jira/browse/FLINK-27896 Project: Flink Issue Type: