[GitHub] [flink] lincoln-lil commented on a diff in pull request #21219: [FLINK-29849][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan

2022-12-20 Thread GitBox
lincoln-lil commented on code in PR #21219: URL: https://github.com/apache/flink/pull/21219#discussion_r1053067658 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/EventTimeTemporalJoinRewriteRule.java: ## @@ -0,0 +1,484 @@ +/* +

[GitHub] [flink] luoyuxia commented on a diff in pull request #21529: [DO NOT MERGE] Testing CI with Hadoop 3 upgrade

2022-12-20 Thread GitBox
luoyuxia commented on code in PR #21529: URL: https://github.com/apache/flink/pull/21529#discussion_r1053125477 ## flink-connectors/flink-connector-hive/pom.xml: ## @@ -1115,33 +1217,8 @@ under the License. 3.1.3

[GitHub] [flink] flinkbot commented on pull request #21535: [FLINK-30459][sql-client] SQL Client supports "SET 'property'"

2022-12-20 Thread GitBox
flinkbot commented on PR #21535: URL: https://github.com/apache/flink/pull/21535#issuecomment-1359090802 ## CI report: * 5b8816d8e0081613d2e0720c88cb0be34101e469 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] luoyuxia commented on a diff in pull request #21529: [DO NOT MERGE] Testing CI with Hadoop 3 upgrade

2022-12-20 Thread GitBox
luoyuxia commented on code in PR #21529: URL: https://github.com/apache/flink/pull/21529#discussion_r1053110477 ## flink-connectors/flink-connector-hive/pom.xml: ## @@ -1115,33 +1217,8 @@ under the License. 3.1.3

[jira] [Updated] (FLINK-30459) SQL Client supports "SET 'property'"

2022-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30459: --- Labels: pull-request-available (was: ) > SQL Client supports "SET 'property'" > ---

[GitHub] [flink] liuml07 opened a new pull request, #21535: [FLINK-30459][sql-client] SQL Client supports "SET 'property'"

2022-12-20 Thread GitBox
liuml07 opened a new pull request, #21535: URL: https://github.com/apache/flink/pull/21535 ## What is the purpose of the change Currently the SET command in SQL client has two syntax: - `SET;` for listing all config properties - `SET 'key'='value'` for setting a property with

[GitHub] [flink] MartijnVisser commented on pull request #21529: [DO NOT MERGE] Testing CI with Hadoop 3 upgrade

2022-12-20 Thread GitBox
MartijnVisser commented on PR #21529: URL: https://github.com/apache/flink/pull/21529#issuecomment-1359078634 OK so what's currently happening in `master` is the the Hive connector is having a dedicated Hadoop version (that has been removed in this PR). See https://github.com/apache/flink/b

[jira] [Created] (FLINK-30459) SQL Client supports "SET 'property'"

2022-12-20 Thread Mingliang Liu (Jira)
Mingliang Liu created FLINK-30459: - Summary: SQL Client supports "SET 'property'" Key: FLINK-30459 URL: https://issues.apache.org/jira/browse/FLINK-30459 Project: Flink Issue Type: Improvemen

[GitHub] [flink] xintongsong commented on a diff in pull request #21508: [FLINK-30128] Introduce Azure Data Lake Gen2 APIs in the Hadoop Recoverable path

2022-12-20 Thread GitBox
xintongsong commented on code in PR #21508: URL: https://github.com/apache/flink/pull/21508#discussion_r1053073322 ## flink-filesystems/flink-azure-fs-hadoop/pom.xml: ## @@ -185,13 +185,6 @@ under the License.

[GitHub] [flink] xintongsong commented on a diff in pull request #21508: [FLINK-30128] Introduce Azure Data Lake Gen2 APIs in the Hadoop Recoverable path

2022-12-20 Thread GitBox
xintongsong commented on code in PR #21508: URL: https://github.com/apache/flink/pull/21508#discussion_r1053072721 ## flink-filesystems/flink-azure-fs-hadoop/src/main/java/org/apache/flink/fs/azurefs/AzureBlobFsRecoverableDataOutputStream.java: ## @@ -0,0 +1,299 @@ +/* + * Licen

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21498: [FLINK-30392] Replace default thread dump depth to 24

2022-12-20 Thread GitBox
1996fanrui commented on code in PR #21498: URL: https://github.com/apache/flink/pull/21498#discussion_r1053070903 ## docs/layouts/shortcodes/generated/cluster_configuration.html: ## @@ -70,7 +70,7 @@ cluster.thread-dump.stacktrace-max-depth -

[GitHub] [flink] xintongsong commented on a diff in pull request #21419: [FLINK-30233] Hybrid full result partition should also work with speculative execution

2022-12-20 Thread GitBox
xintongsong commented on code in PR #21419: URL: https://github.com/apache/flink/pull/21419#discussion_r1053028752 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchScheduler.java: ## @@ -78,6 +79,8 @@ public class AdaptiveBatchSchedule

[GitHub] [flink] MartijnVisser commented on pull request #21529: [DO NOT MERGE] Testing CI with Hadoop 3 upgrade

2022-12-20 Thread GitBox
MartijnVisser commented on PR #21529: URL: https://github.com/apache/flink/pull/21529#issuecomment-1359028648 My conclusion at the moment is that `hadoop-common` version `2.10.2` contains the `org/apache/hadoop/metrics/Updater` class, while these have been dropped from version 3.x and onwar

[jira] [Updated] (FLINK-30458) Refactor Table Store Documentation

2022-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30458: --- Labels: pull-request-available (was: ) > Refactor Table Store Documentation > -

[GitHub] [flink-table-store] tsreaper opened a new pull request, #443: [FLINK-30458] Refactor Table Store Documentation

2022-12-20 Thread GitBox
tsreaper opened a new pull request, #443: URL: https://github.com/apache/flink-table-store/pull/443 Currently the documents of table store are messy and are lacking basic concepts. This ticket refactors table store documentation and at the mean time adding basic concepts. -- This is an a

[jira] [Created] (FLINK-30458) Refactor Table Store Documentation

2022-12-20 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-30458: --- Summary: Refactor Table Store Documentation Key: FLINK-30458 URL: https://issues.apache.org/jira/browse/FLINK-30458 Project: Flink Issue Type: Improvement

[GitHub] [flink] godfreyhe commented on a diff in pull request #21219: [FLINK-29849][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan

2022-12-20 Thread GitBox
godfreyhe commented on code in PR #21219: URL: https://github.com/apache/flink/pull/21219#discussion_r1052849162 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/EventTimeTemporalJoinRewriteRule.java: ## @@ -0,0 +1,484 @@ +/* + *

[GitHub] [flink-table-store] zjureel commented on pull request #441: [FLINK-30423] Introduce generated codes for CastExecutor

2022-12-20 Thread GitBox
zjureel commented on PR #441: URL: https://github.com/apache/flink-table-store/pull/441#issuecomment-1358991285 Hi @JingsongLi I added generated codes in `CastRule` for `CastExecutor` in table store, please help to review it when you're free, thanks -- This is an automated message from t

[GitHub] [flink] flinkbot commented on pull request #21534: [BP-1.16][FLINK-30299][core] Adds thread dump creation to FatalExitExceptionHandler

2022-12-20 Thread GitBox
flinkbot commented on PR #21534: URL: https://github.com/apache/flink/pull/21534#issuecomment-1358989140 ## CI report: * 06bc21adaa4c6fa85d5b15dfbadb683ea1222f6e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #21533: [BP-1.15][FLINK-30299][core] Adds thread dump creation to FatalExitExceptionHandler

2022-12-20 Thread GitBox
flinkbot commented on PR #21533: URL: https://github.com/apache/flink/pull/21533#issuecomment-1358989006 ## CI report: * 08c2ecebbc242412a92bf891d103a1b334f3fb40 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] XComp opened a new pull request, #21534: [FLINK-30299][core] Adds thread dump creation to FatalExitExceptionHandler

2022-12-20 Thread GitBox
XComp opened a new pull request, #21534: URL: https://github.com/apache/flink/pull/21534 1.16 backport PR for parent PR #21463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] XComp opened a new pull request, #21533: [FLINK-30299][core] Adds thread dump creation to FatalExitExceptionHandler

2022-12-20 Thread GitBox
XComp opened a new pull request, #21533: URL: https://github.com/apache/flink/pull/21533 1.15 backport PR for parent PR #21463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Updated] (FLINK-30299) TaskManagerRunnerTest fails with 239 exit code (i.e. FatalExitExceptionHandler was called)

2022-12-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30299: -- Affects Version/s: 1.17.0 > TaskManagerRunnerTest fails with 239 exit code (i.e. > FatalExitE

[GitHub] [flink] XComp merged pull request #21463: [FLINK-30299][core] Adds thread dump creation to FatalExitExceptionHandler

2022-12-20 Thread GitBox
XComp merged PR #21463: URL: https://github.com/apache/flink/pull/21463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

[jira] [Assigned] (FLINK-30299) TaskManagerRunnerTest fails with 239 exit code (i.e. FatalExitExceptionHandler was called)

2022-12-20 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-30299: -- Assignee: Matthias Pohl > TaskManagerRunnerTest fails with 239 exit code (i.e. > Fat

<    1   2   3