[GitHub] [flink] SinBex commented on pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

2023-01-20 Thread via GitHub
SinBex commented on PR #21695: URL: https://github.com/apache/flink/pull/21695#issuecomment-1399194089 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] hehuiyuan commented on pull request #21731: [FLINK-30679][hive]Fix IndexOutOfBoundsException for Hive lookup join when column pushdown to Hive lookup table source

2023-01-20 Thread via GitHub
hehuiyuan commented on PR #21731: URL: https://github.com/apache/flink/pull/21731#issuecomment-1399180014 @luoyuxia hi,Help to see this compilation failure problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink-table-store] zjureel commented on pull request #489: [FLINK-30038] Fix hive e2e fail

2023-01-20 Thread via GitHub
zjureel commented on PR #489: URL: https://github.com/apache/flink-table-store/pull/489#issuecomment-1399144555 @JingsongLi Please help to review this PR when you're free, THX -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink-table-store] zjureel commented on pull request #489: [FLINK-30038] Fix hive e2e fail

2023-01-20 Thread via GitHub
zjureel commented on PR #489: URL: https://github.com/apache/flink-table-store/pull/489#issuecomment-1399144439 The test fails due to `CompactActionITCase .testBatchCompact` which is a known issue FLINK-30750 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] fsk119 commented on pull request #21717: [FLINK-29945][sql-client] Supports to submit SQL to a embedded SQL Ga…

2023-01-20 Thread via GitHub
fsk119 commented on PR #21717: URL: https://github.com/apache/flink/pull/21717#issuecomment-1399118306 All test passes. It would be nice if you can take a look when you are free. @LadyForest -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] flinkbot commented on pull request #21745: [hotfix] typo in the javadoc of the functions in KeyedStateStore

2023-01-20 Thread via GitHub
flinkbot commented on PR #21745: URL: https://github.com/apache/flink/pull/21745#issuecomment-1399071379 ## CI report: * bad6b25153273923bdacf53d44653f816784be8c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] almogtavor opened a new pull request, #21745: [hotfix] typo in the javadoc of the functions in KeyedStateStore

2023-01-20 Thread via GitHub
almogtavor opened a new pull request, #21745: URL: https://github.com/apache/flink/pull/21745 ## What is the purpose of the change Minor typo hotfix in Javadoc. The typo is that multiple functions have the description of `The descriptor defining the properties of the stats`

[GitHub] [flink] flinkbot commented on pull request #21744: [hotfix] Fix typo DataStream

2023-01-20 Thread via GitHub
flinkbot commented on PR #21744: URL: https://github.com/apache/flink/pull/21744#issuecomment-1398843597 ## CI report: * cc36691ade95321d40c7404f5b3c24e704af7d94 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] liuml07 opened a new pull request, #21744: [hotfix] Fix typo DataStream

2023-01-20 Thread via GitHub
liuml07 opened a new pull request, #21744: URL: https://github.com/apache/flink/pull/21744 There are a few places where DataStream was spelled as DataSteam. It occurs in doc, comment and also operator names. This fixes that. -- This is an automated message from the Apache Git Service.

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

2023-01-20 Thread via GitHub
zhuzhurk commented on code in PR #21695: URL: https://github.com/apache/flink/pull/21695#discussion_r1082948306 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/slowtaskdetector/ExecutionTimeBasedSlowTaskDetectorTest.java: ## @@ -200,6 +204,122 @@ void

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

2023-01-20 Thread via GitHub
zhuzhurk commented on code in PR #21695: URL: https://github.com/apache/flink/pull/21695#discussion_r1082917445 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptivebatch/DefaultVertexParallelismAndInputInfosDeciderTest.java: ## @@ -542,6 +542,12 @@ public

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

2023-01-20 Thread via GitHub
zhuzhurk commented on code in PR #21695: URL: https://github.com/apache/flink/pull/21695#discussion_r1082900221 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/BlockingResultInfo.java: ## @@ -39,6 +40,16 @@ public interface BlockingResultInfo

[GitHub] [flink] flinkbot commented on pull request #21743: [FLINK-15325][coordination] Ignores the input locations of a ConsumePartitionGroup if the corresponding ConsumerVertexGroup is too large

2023-01-20 Thread GitBox
flinkbot commented on PR #21743: URL: https://github.com/apache/flink/pull/21743#issuecomment-1398746472 ## CI report: * 9118095bdfdf184466f83661e8b39661c7075181 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-15325) Input location preference which affects task distribution may make certain job performance worse

2023-01-20 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679249#comment-17679249 ] Zhu Zhu commented on FLINK-15325: - I created a pull request to resolve this problem. For a consumer

[jira] [Updated] (FLINK-15325) Input location preference which affects task distribution may make certain job performance worse

2023-01-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-15325: --- Labels: pull-request-available (was: ) > Input location preference which affects task

[GitHub] [flink] zhuzhurk opened a new pull request, #21743: [FLINK-15325][coordination] Ignores the input locations of a ConsumePartitionGroup if the corresponding ConsumerVertexGroup is too large

2023-01-20 Thread GitBox
zhuzhurk opened a new pull request, #21743: URL: https://github.com/apache/flink/pull/21743 ## What is the purpose of the change This change improves the `DefaultPreferredLocationsRetriever` so that it ignores the input locations of a ConsumePartitionGroup if the corresponding

[jira] [Updated] (FLINK-15325) Input location preference which affects task distribution may make certain job performance worse

2023-01-20 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-15325: Affects Version/s: 1.15.3 1.14.6 1.16.0

[jira] [Assigned] (FLINK-15325) Input location preference which affects task distribution may make certain job performance worse

2023-01-20 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-15325: --- Assignee: Zhu Zhu > Input location preference which affects task distribution may make certain >

[jira] [Updated] (FLINK-15325) Input location preference which affects task distribution may make certain job performance worse

2023-01-20 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-15325: Labels: (was: auto-deprioritized-major auto-deprioritized-minor) > Input location preference which

[jira] [Updated] (FLINK-15325) Input location preference which affects task distribution may make certain job performance worse

2023-01-20 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-15325: Priority: Major (was: Not a Priority) > Input location preference which affects task distribution may

[GitHub] [flink] MartijnVisser commented on pull request #18823: [FLINK-20625][pubsub,e2e] Add PubSubSource connector using FLIP-27

2023-01-20 Thread GitBox
MartijnVisser commented on PR #18823: URL: https://github.com/apache/flink/pull/18823#issuecomment-1398705483 @RyanSkraba It would indeed be nice if we can move this now to the externalized repo. @dchristle it would be great if you can help validate it so we can move it forward. --

[GitHub] [flink] XComp commented on a diff in pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

2023-01-20 Thread GitBox
XComp commented on code in PR #21742: URL: https://github.com/apache/flink/pull/21742#discussion_r1082832944 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -100,6 +100,7 @@ public final void stop() throws

[GitHub] [flink] XComp commented on a diff in pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

2023-01-20 Thread GitBox
XComp commented on code in PR #21742: URL: https://github.com/apache/flink/pull/21742#discussion_r1082832944 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -100,6 +100,7 @@ public final void stop() throws

[jira] [Closed] (FLINK-30764) Include generic delegation token params in the main config page

2023-01-20 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-30764. Fix Version/s: 1.17.0 Resolution: Fixed master:

[jira] [Updated] (FLINK-30764) Include generic delegation token params in the main config page

2023-01-20 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-30764: - Component/s: Documentation > Include generic delegation token params in the main config

[GitHub] [flink] zentol merged pull request #21741: [FLINK-30764][docs] Include generic delegation token params in the main config page

2023-01-20 Thread GitBox
zentol merged PR #21741: URL: https://github.com/apache/flink/pull/21741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] XComp commented on a diff in pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

2023-01-20 Thread GitBox
XComp commented on code in PR #21742: URL: https://github.com/apache/flink/pull/21742#discussion_r1082817072 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -100,6 +100,7 @@ public final void stop() throws

[GitHub] [flink] XComp commented on pull request #21737: [FLINK-30760][runtime] Fixes wrongly used @GuardedBy annotation

2023-01-20 Thread GitBox
XComp commented on PR #21737: URL: https://github.com/apache/flink/pull/21737#issuecomment-1398645766 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] 1996fanrui commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

2023-01-20 Thread GitBox
1996fanrui commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1082757960 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java: ## @@ -280,4 +280,13 @@ public class

[GitHub] [flink] dawidwys commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

2023-01-20 Thread GitBox
dawidwys commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1082743417 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java: ## @@ -280,4 +280,13 @@ public class

[GitHub] [flink] gaborgsomogyi commented on pull request #21741: [FLINK-30764][docs] Include generic delegation token params in the main config page

2023-01-20 Thread GitBox
gaborgsomogyi commented on PR #21741: URL: https://github.com/apache/flink/pull/21741#issuecomment-1398600117 cc @mbalassi @zentol -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-28897) Fail to use udf in added jar when enabling checkpoint

2023-01-20 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679213#comment-17679213 ] Martijn Visser commented on FLINK-28897: Re-opened as explained on the mailing list due to the

[jira] [Reopened] (FLINK-28897) Fail to use udf in added jar when enabling checkpoint

2023-01-20 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reopened FLINK-28897: > Fail to use udf in added jar when enabling checkpoint >

[jira] [Updated] (FLINK-29890) UDFs classloading from JARs in 1.16 is broken

2023-01-20 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-29890: --- Priority: Blocker (was: Critical) > UDFs classloading from JARs in 1.16 is broken >

[jira] [Updated] (FLINK-29890) UDFs classloading from JARs in 1.16 is broken

2023-01-20 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-29890: --- Priority: Major (was: Blocker) > UDFs classloading from JARs in 1.16 is broken >

[jira] [Commented] (FLINK-30721) The confluent schema registry is not compatible with Apicurio schema registry

2023-01-20 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679191#comment-17679191 ] Martijn Visser commented on FLINK-30721: [~pedromazala] It depends on the level of compatibility

[jira] [Commented] (FLINK-26428) Translate "Stateful Stream Processing" to Chinese

2023-01-20 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679182#comment-17679182 ] Martijn Visser commented on FLINK-26428: [~chenhaiyang] I've assigned it to you > Translate

[jira] [Assigned] (FLINK-26428) Translate "Stateful Stream Processing" to Chinese

2023-01-20 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-26428: -- Assignee: chenhaiyang > Translate "Stateful Stream Processing" to Chinese >

[GitHub] [flink] flinkbot commented on pull request #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

2023-01-20 Thread GitBox
flinkbot commented on PR #21742: URL: https://github.com/apache/flink/pull/21742#issuecomment-1398477646 ## CI report: * 9afce3d1052ab18c689e446302a91201c84fadef UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30765) LeaderElectionService.stop should always call revokeLeadership

2023-01-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30765: --- Labels: pull-request-available (was: ) > LeaderElectionService.stop should always call

[GitHub] [flink] XComp opened a new pull request, #21742: [FLINK-30765][runtime] Aligns the LeaderElectionService.stop() contract

2023-01-20 Thread GitBox
XComp opened a new pull request, #21742: URL: https://github.com/apache/flink/pull/21742 ## What is the purpose of the change This PR is about hardening the `LeaderElectionService.stop()` contract. The current implementations of LeaderElectionService do not implement the

[jira] [Commented] (FLINK-30745) Check-pointing with Azure Data Lake Storage

2023-01-20 Thread Dheeraj Panangat (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679166#comment-17679166 ] Dheeraj Panangat commented on FLINK-30745: -- Hi [~surendralilhore] , We were able to get it

[GitHub] [flink] pnowojski commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

2023-01-20 Thread GitBox
pnowojski commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1082600527 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java: ## @@ -280,4 +280,13 @@ public class

[GitHub] [flink] flinkbot commented on pull request #21741: [FLINK-30764][docs] Include generic delegation token params in the main config page

2023-01-20 Thread GitBox
flinkbot commented on PR #21741: URL: https://github.com/apache/flink/pull/21741#issuecomment-1398454630 ## CI report: * 79d653c444716cf88e0b22b08333c2feb50ac872 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] gaborgsomogyi commented on pull request #21732: [FLINK-30754][tests] Fix ExceptionThrowingDelegationTokenProvider/Receiver multi-threaded test issues

2023-01-20 Thread GitBox
gaborgsomogyi commented on PR #21732: URL: https://github.com/apache/flink/pull/21732#issuecomment-1398453852 Resolved the conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] gaborgsomogyi commented on pull request #21741: [FLINK-30764][docs] Include generic delegation token params in the main config page

2023-01-20 Thread GitBox
gaborgsomogyi commented on PR #21741: URL: https://github.com/apache/flink/pull/21741#issuecomment-1398450836 Addressing the [following](https://github.com/apache/flink/pull/21723#issuecomment-1387339515) comment in this PR. -- This is an automated message from the Apache Git Service.

[GitHub] [flink] healchow commented on a diff in pull request #21722: [FLINK-30747][docs]Translate "Window Deduplication" page of "Querys"

2023-01-20 Thread GitBox
healchow commented on code in PR #21722: URL: https://github.com/apache/flink/pull/21722#discussion_r1082589298 ## docs/content.zh/docs/dev/table/sql/queries/window-deduplication.md: ## @@ -101,15 +102,16 @@ Flink SQL> SELECT *

[jira] [Updated] (FLINK-30764) Include generic delegation token params in the main config page

2023-01-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30764: --- Labels: pull-request-available (was: ) > Include generic delegation token params in the

[GitHub] [flink] gaborgsomogyi commented on pull request #21741: [FLINK-30764][docs] Include generic delegation token params in the main config page

2023-01-20 Thread GitBox
gaborgsomogyi commented on PR #21741: URL: https://github.com/apache/flink/pull/21741#issuecomment-1398447229 This is how it looks like: https://user-images.githubusercontent.com/18561820/213716824-489f5eca-ae23-4d20-b496-fdd09dc9457d.png;> -- This is an automated message from the

[GitHub] [flink] gaborgsomogyi opened a new pull request, #21741: [FLINK-30764][docs] Include generic delegation token params in the main config page

2023-01-20 Thread GitBox
gaborgsomogyi opened a new pull request, #21741: URL: https://github.com/apache/flink/pull/21741 ## What is the purpose of the change Until now the generic delegation token params are not shown on the main config page. In this PR I've added them. ## Brief change log

[jira] [Commented] (FLINK-30765) LeaderElectionService.stop should always call revokeLeadership

2023-01-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679155#comment-17679155 ] Matthias Pohl commented on FLINK-30765: --- FLINK-30759 clears things up for the

[jira] [Assigned] (FLINK-30765) LeaderElectionService.stop should always call revokeLeadership

2023-01-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-30765: - Assignee: Matthias Pohl > LeaderElectionService.stop should always call

[jira] [Created] (FLINK-30765) LeaderElectionService.stop should always call revokeLeadership

2023-01-20 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-30765: - Summary: LeaderElectionService.stop should always call revokeLeadership Key: FLINK-30765 URL: https://issues.apache.org/jira/browse/FLINK-30765 Project: Flink

[GitHub] [flink] fsk119 commented on pull request #21717: [FLINK-29945][sql-client] Supports to submit SQL to a embedded SQL Ga…

2023-01-20 Thread GitBox
fsk119 commented on PR #21717: URL: https://github.com/apache/flink/pull/21717#issuecomment-1398397981 > P.S. Wrong cmd will get CLI blocked forever. Thanks for reporting the case. With the commit 0e04c7, the Executor will try to close the Operation in the background when users hit

[GitHub] [flink] XComp commented on a diff in pull request #21740: [FLINK-30759][runtime] Merges DispatcherRunnerLeaderElectionLifecycleManager into DefaultDispatcherRunner

2023-01-20 Thread GitBox
XComp commented on code in PR #21740: URL: https://github.com/apache/flink/pull/21740#discussion_r1082532829 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/runner/DefaultDispatcherRunner.java: ## @@ -89,11 +93,29 @@ public CompletableFuture closeAsync() {

[GitHub] [flink] XComp commented on a diff in pull request #21740: [FLINK-30759][runtime] Merges DispatcherRunnerLeaderElectionLifecycleManager into DefaultDispatcherRunner

2023-01-20 Thread GitBox
XComp commented on code in PR #21740: URL: https://github.com/apache/flink/pull/21740#discussion_r1082532829 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/runner/DefaultDispatcherRunner.java: ## @@ -89,11 +93,29 @@ public CompletableFuture closeAsync() {

[GitHub] [flink] dawidwys commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

2023-01-20 Thread GitBox
dawidwys commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1082525394 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java: ## @@ -280,4 +280,13 @@ public class

[jira] [Updated] (FLINK-11313) [checkpoint] Introduce LZ4 compression for keyed state in full checkpoints and savepoints

2023-01-20 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-11313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-11313: --- Priority: Major (was: Not a Priority) > [checkpoint] Introduce LZ4 compression for keyed

[GitHub] [flink] zentol commented on a diff in pull request #21740: [FLINK-30759][runtime] Merges DispatcherRunnerLeaderElectionLifecycleManager into DefaultDispatcherRunner

2023-01-20 Thread GitBox
zentol commented on code in PR #21740: URL: https://github.com/apache/flink/pull/21740#discussion_r1082519363 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/runner/DefaultDispatcherRunner.java: ## @@ -89,11 +93,29 @@ public CompletableFuture closeAsync() {

[GitHub] [flink] XComp commented on a diff in pull request #21737: [FLINK-30760][runtime] Fixes wrongly used @GuardedBy annotation

2023-01-20 Thread GitBox
XComp commented on code in PR #21737: URL: https://github.com/apache/flink/pull/21737#discussion_r1082508795 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -48,9 +48,11 @@ private final

[GitHub] [flink] XComp commented on a diff in pull request #21737: [FLINK-30760][runtime] Fixes wrongly used @GuardedBy annotation

2023-01-20 Thread GitBox
XComp commented on code in PR #21737: URL: https://github.com/apache/flink/pull/21737#discussion_r1082508795 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -48,9 +48,11 @@ private final

[GitHub] [flink] hehuiyuan commented on pull request #21731: [FLINK-30679][hive]Fix IndexOutOfBoundsException for Hive lookup join when column pushdown to Hive lookup table source

2023-01-20 Thread GitBox
hehuiyuan commented on PR #21731: URL: https://github.com/apache/flink/pull/21731#issuecomment-1398347485 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Assigned] (FLINK-30715) FLIP-289: Support Online Inference

2023-01-20 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin reassigned FLINK-30715: Assignee: Jiang Xin > FLIP-289: Support Online Inference > -- >

[jira] [Assigned] (FLINK-30764) Include generic delegation token params in the main config page

2023-01-20 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi reassigned FLINK-30764: - Assignee: Gabor Somogyi > Include generic delegation token params in the main config

[jira] [Created] (FLINK-30764) Include generic delegation token params in the main config page

2023-01-20 Thread Gabor Somogyi (Jira)
Gabor Somogyi created FLINK-30764: - Summary: Include generic delegation token params in the main config page Key: FLINK-30764 URL: https://issues.apache.org/jira/browse/FLINK-30764 Project: Flink

[GitHub] [flink] flinkbot commented on pull request #21740: [FLINK-30759][runtime] Merges DispatcherRunnerLeaderElectionLifecycleManager into DefaultDispatcherRunner

2023-01-20 Thread GitBox
flinkbot commented on PR #21740: URL: https://github.com/apache/flink/pull/21740#issuecomment-1398335456 ## CI report: * 46ab3d550b0d2be1b260f7c200ca6d168c7625ae UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Comment Edited] (FLINK-30745) Check-pointing with Azure Data Lake Storage

2023-01-20 Thread Dheeraj Panangat (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679120#comment-17679120 ] Dheeraj Panangat edited comment on FLINK-30745 at 1/20/23 12:48 PM:

[jira] [Updated] (FLINK-30759) Merge DispatcherRunnerLeaderElectionLifecycleManager into DefaultDispatcherRunner

2023-01-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30759: --- Labels: pull-request-available (was: ) > Merge

[jira] [Assigned] (FLINK-30759) Merge DispatcherRunnerLeaderElectionLifecycleManager into DefaultDispatcherRunner

2023-01-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-30759: - Assignee: Matthias Pohl > Merge DispatcherRunnerLeaderElectionLifecycleManager into >

[GitHub] [flink] XComp opened a new pull request, #21740: [FLINK-30759][runtime] Merges DispatcherRunnerLeaderElectionLifecycleManager into DefaultDispatcherRunner

2023-01-20 Thread GitBox
XComp opened a new pull request, #21740: URL: https://github.com/apache/flink/pull/21740 ## What is the purpose of the change The entire purpose of this wrapper `DispatcherRunnerLeaderElectionLifecycleManager` is to have the start/stop of the `LeaderElectionService` out of the

[GitHub] [flink] zentol commented on a diff in pull request #21737: [FLINK-30760][runtime] Fixes wrongly used @GuardedBy annotation

2023-01-20 Thread GitBox
zentol commented on code in PR #21737: URL: https://github.com/apache/flink/pull/21737#discussion_r1082457711 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -48,9 +48,11 @@ private final

[jira] [Created] (FLINK-30763) Make TestingLeaderElectionService comply to how the LeaderElectionService interface is intended

2023-01-20 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-30763: - Summary: Make TestingLeaderElectionService comply to how the LeaderElectionService interface is intended Key: FLINK-30763 URL: https://issues.apache.org/jira/browse/FLINK-30763

[jira] [Updated] (FLINK-30759) Merge DispatcherRunnerLeaderElectionLifecycleManager into DefaultDispatcherRunner

2023-01-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30759: -- Affects Version/s: 1.17.0 > Merge DispatcherRunnerLeaderElectionLifecycleManager into >

[jira] [Updated] (FLINK-30760) Fix @GuardedBy and @Nullable annotations in DefaultLeaderElectionService

2023-01-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30760: -- Affects Version/s: 1.15.3 1.16.0 1.17.0 > Fix

[jira] [Updated] (FLINK-30761) Remove JVM asserts from leader election code

2023-01-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30761: -- Affects Version/s: 1.15.3 1.16.0 1.17.0 >

[jira] [Comment Edited] (FLINK-30745) Check-pointing with Azure Data Lake Storage

2023-01-20 Thread Dheeraj Panangat (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679120#comment-17679120 ] Dheeraj Panangat edited comment on FLINK-30745 at 1/20/23 12:01 PM:

[jira] [Updated] (FLINK-30760) Fix @GuardedBy and @Nullable annotations in DefaultLeaderElectionService

2023-01-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30760: -- Summary: Fix @GuardedBy and @Nullable annotations in DefaultLeaderElectionService (was: Fix

[jira] [Assigned] (FLINK-30761) Remove JVM asserts from leader election code

2023-01-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-30761: - Assignee: Matthias Pohl > Remove JVM asserts from leader election code >

[jira] [Comment Edited] (FLINK-30745) Check-pointing with Azure Data Lake Storage

2023-01-20 Thread Dheeraj Panangat (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679120#comment-17679120 ] Dheeraj Panangat edited comment on FLINK-30745 at 1/20/23 11:57 AM:

[GitHub] [flink] XComp commented on a diff in pull request #21738: [FLINK-30761][coordination,test] Replaces JVM assert with Preconditions in leader election code

2023-01-20 Thread GitBox
XComp commented on code in PR #21738: URL: https://github.com/apache/flink/pull/21738#discussion_r1082412814 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderElectionService.java: ## @@ -48,7 +49,7 @@ public synchronized CompletableFuture

[jira] [Commented] (FLINK-30745) Check-pointing with Azure Data Lake Storage

2023-01-20 Thread Dheeraj Panangat (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679120#comment-17679120 ] Dheeraj Panangat commented on FLINK-30745: -- Hi [~surendralilhore] , Might have been able to

[GitHub] [flink-web] mbalassi closed pull request #602: Blog post on the Delegation Token Framework

2023-01-20 Thread GitBox
mbalassi closed pull request #602: Blog post on the Delegation Token Framework URL: https://github.com/apache/flink-web/pull/602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] XComp commented on a diff in pull request #21737: [FLINK-30760][runtime] Fixes wrongly used @GuardedBy annotation

2023-01-20 Thread GitBox
XComp commented on code in PR #21737: URL: https://github.com/apache/flink/pull/21737#discussion_r1082408148 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -48,9 +48,11 @@ private final

[GitHub] [flink] XComp commented on a diff in pull request #21737: [FLINK-30760][runtime] Fixes wrongly used @GuardedBy annotation

2023-01-20 Thread GitBox
XComp commented on code in PR #21737: URL: https://github.com/apache/flink/pull/21737#discussion_r1082408148 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -48,9 +48,11 @@ private final

[GitHub] [flink] XComp commented on a diff in pull request #21737: [FLINK-30760][runtime] Fixes wrongly used @GuardedBy annotation

2023-01-20 Thread GitBox
XComp commented on code in PR #21737: URL: https://github.com/apache/flink/pull/21737#discussion_r1082408148 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -48,9 +48,11 @@ private final

[GitHub] [flink] pnowojski commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

2023-01-20 Thread GitBox
pnowojski commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1082365656 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java: ## @@ -280,4 +280,13 @@ public class

[jira] [Closed] (FLINK-30704) Add S3 delegation token support

2023-01-20 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-30704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi closed FLINK-30704. -- Fix Version/s: 1.17.0 Resolution: Fixed 0141f13 in master > Add S3 delegation token

[GitHub] [flink] mbalassi merged pull request #21694: [FLINK-30704][filesystems][s3] Add S3 delegation token support

2023-01-20 Thread GitBox
mbalassi merged PR #21694: URL: https://github.com/apache/flink/pull/21694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #21739: [FLINK-30673][docs][table] Add documentation for "EXPLAIN PLAN_ADVICE" statement

2023-01-20 Thread GitBox
flinkbot commented on PR #21739: URL: https://github.com/apache/flink/pull/21739#issuecomment-1398198832 ## CI report: * e19d7dc89412bb6cd9bcf781a8938e9023e23048 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30673) Add documentation for "EXPLAIN PLAN_ADVICE" statement

2023-01-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30673: --- Labels: pull-request-available (was: ) > Add documentation for "EXPLAIN PLAN_ADVICE"

[GitHub] [flink] LadyForest opened a new pull request, #21739: [FLINK-30673][docs][table] Add documentation for "EXPLAIN PLAN_ADVICE" statement

2023-01-20 Thread GitBox
LadyForest opened a new pull request, #21739: URL: https://github.com/apache/flink/pull/21739 ## What is the purpose of the change This pull request adds documentation for `EXPLAIN PLAN_ADVICE` statement. ## Brief change log Add doc. ## Verifying this

[GitHub] [flink] zentol commented on a diff in pull request #21738: [FLINK-30761][coordination,test] Replaces JVM assert with Preconditions in leader election code

2023-01-20 Thread GitBox
zentol commented on code in PR #21738: URL: https://github.com/apache/flink/pull/21738#discussion_r1082324266 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderElectionService.java: ## @@ -48,7 +49,7 @@ public synchronized CompletableFuture

[jira] [Assigned] (FLINK-30762) Add nightly builds for AWS connectors repo

2023-01-20 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-30762: - Assignee: Aleksandr Pilipenko > Add nightly builds for AWS connectors repo >

[jira] [Updated] (FLINK-30762) Add nightly builds for AWS connectors repo

2023-01-20 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-30762: -- Fix Version/s: aws-connector-4.1.0 > Add nightly builds for AWS connectors repo >

[GitHub] [flink] zentol commented on a diff in pull request #21737: [FLINK-30760][runtime] Fixes wrongly used @GuardedBy annotation

2023-01-20 Thread GitBox
zentol commented on code in PR #21737: URL: https://github.com/apache/flink/pull/21737#discussion_r1082321263 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -48,9 +48,11 @@ private final

[jira] [Created] (FLINK-30762) Add nightly builds for AWS connectors repo

2023-01-20 Thread Aleksandr Pilipenko (Jira)
Aleksandr Pilipenko created FLINK-30762: --- Summary: Add nightly builds for AWS connectors repo Key: FLINK-30762 URL: https://issues.apache.org/jira/browse/FLINK-30762 Project: Flink

[GitHub] [flink-connector-kafka] zentol commented on a diff in pull request #1: [FLINK-30052][Connectors/Kafka] Move existing Kafka connector code from Flink repo to dedicated Kafka repo

2023-01-20 Thread GitBox
zentol commented on code in PR #1: URL: https://github.com/apache/flink-connector-kafka/pull/1#discussion_r1082317243 ## flink-connector-kafka/pom.xml: ## @@ -18,259 +18,292 @@ specific language governing permissions and limitations under the License. -->

[GitHub] [flink] flinkbot commented on pull request #21738: [FLINK-30761][coordination,test] Replaces JVM assert with Preconditions in leader election code

2023-01-20 Thread GitBox
flinkbot commented on PR #21738: URL: https://github.com/apache/flink/pull/21738#issuecomment-1398166208 ## CI report: * b6fb5cacd48f5c91c7cf27ea45395696b2eb04f8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-connector-cassandra] zentol commented on pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-20 Thread GitBox
zentol commented on PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#issuecomment-1398165894 > So I think I'll try to reuse this code, migrate it to Flink and update it to the latest Cassandra version and push it in this PR. Sounds good to me so far. -- This

[GitHub] [flink-connector-cassandra] zentol commented on pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-20 Thread GitBox
zentol commented on PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#issuecomment-1398165328 > I don't think it is an ASF rule but fair enough, FYI; By and large it should be viewed as a legal requirement. By copying code from cassandra you have to adhere to

  1   2   >