[GitHub] [flink] lsyldliu opened a new pull request, #22024: [FLINK-30989][table] Fix some options don't take effect in batch mode

2023-02-26 Thread via GitHub
lsyldliu opened a new pull request, #22024: URL: https://github.com/apache/flink/pull/22024

[GitHub] [flink] lsyldliu commented on pull request #22024: [FLINK-30989][table] Fix some options don't take effect in batch mode

2023-02-26 Thread via GitHub
lsyldliu commented on PR #22024: URL: https://github.com/apache/flink/pull/22024#issuecomment-1445293148 cc @godfreyhe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[jira] [Commented] (FLINK-29636) Add micro benchmark module in flink table store

2023-02-26 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693600#comment-17693600 ] Yun Tang commented on FLINK-29636: -- JMH is under GPL license which is not compatible wi

[GitHub] [flink] flinkbot commented on pull request #22024: [FLINK-30989][table] Fix some options don't take effect in batch mode

2023-02-26 Thread via GitHub
flinkbot commented on PR #22024: URL: https://github.com/apache/flink/pull/22024#issuecomment-1445294283 ## CI report: * 56d794399c2edcd57101dadae0c3553b2eaf4ce7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Comment Edited] (FLINK-29636) Add micro benchmark module in flink table store

2023-02-26 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693600#comment-17693600 ] Yun Tang edited comment on FLINK-29636 at 2/26/23 8:10 AM: --- JM

[jira] [Updated] (FLINK-31225) rocksdb max open file can lead to oom

2023-02-26 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaogang zhou updated FLINK-31225: -- Description: the default value for  state.backend.rocksdb.files.open is -1   [https://gith

[jira] [Created] (FLINK-31226) Bump the FRocksDB version in table-store's lookup module

2023-02-26 Thread Yun Tang (Jira)
Yun Tang created FLINK-31226: Summary: Bump the FRocksDB version in table-store's lookup module Key: FLINK-31226 URL: https://issues.apache.org/jira/browse/FLINK-31226 Project: Flink Issue Type:

[jira] [Updated] (FLINK-31226) Bump the FRocksDB version in table-store's lookup module

2023-02-26 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-31226: - Fix Version/s: table-store-0.4.0 > Bump the FRocksDB version in table-store's lookup module > --

[GitHub] [flink-table-store] zhuangchong commented on pull request #556: [hotfix] Adds the Kafka version reference in the dependencies

2023-02-26 Thread via GitHub
zhuangchong commented on PR #556: URL: https://github.com/apache/flink-table-store/pull/556#issuecomment-1445318736 > LGTM. BTW, @zhuangchong, could you update the tittle of the pull request to `[hotfix] Adds the Kafka version reference in the dependencies`? OK, Thanks. -- This is

[jira] [Closed] (FLINK-29346) File naming configuration for filesink output

2023-02-26 Thread Kwang-in (Dennis) JUNG (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kwang-in (Dennis) JUNG closed FLINK-29346. -- Resolution: Incomplete > File naming configuration for filesink output > -

[jira] [Closed] (FLINK-27601) Translation in Korean

2023-02-26 Thread Kwang-in (Dennis) JUNG (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kwang-in (Dennis) JUNG closed FLINK-27601. -- Resolution: Incomplete > Translation in Korean > - > >

[jira] [Created] (FLINK-31227) Remove 'scala version' from file sink modules

2023-02-26 Thread Kwang-in (Dennis) JUNG (Jira)
Kwang-in (Dennis) JUNG created FLINK-31227: -- Summary: Remove 'scala version' from file sink modules Key: FLINK-31227 URL: https://issues.apache.org/jira/browse/FLINK-31227 Project: Flink

[GitHub] [flink] snuyanzin merged pull request #22017: [BP-1.17][FLINK-31142][Table SQL/Client] Catch TokenMgrError in SqlCommandParserImpl#scan

2023-02-26 Thread via GitHub
snuyanzin merged PR #22017: URL: https://github.com/apache/flink/pull/22017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[jira] [Resolved] (FLINK-31142) Some queries lead to abrupt sql client close

2023-02-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-31142. - Fix Version/s: 1.17.0 Resolution: Fixed > Some queries lead to abrupt sql client

[jira] [Comment Edited] (FLINK-31142) Some queries lead to abrupt sql client close

2023-02-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693366#comment-17693366 ] Sergey Nuyanzin edited comment on FLINK-31142 at 2/26/23 2:00 PM:

[jira] [Created] (FLINK-31228) flink-playgrounds is using a buggy zookeeper

2023-02-26 Thread CHEN Zhongpu (Jira)
CHEN Zhongpu created FLINK-31228: Summary: flink-playgrounds is using a buggy zookeeper Key: FLINK-31228 URL: https://issues.apache.org/jira/browse/FLINK-31228 Project: Flink Issue Type: Bug

[GitHub] [flink] lincoln-lil opened a new pull request, #22025: [bp-1.17][FLINK-30396][table-planner] Fix incorrect hint propagation into sub-query of lookup join hint

2023-02-26 Thread via GitHub
lincoln-lil opened a new pull request, #22025: URL: https://github.com/apache/flink/pull/22025 This is a backport pr for release-1.17 branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Updated] (FLINK-31228) flink-playgrounds is using a buggy zookeeper

2023-02-26 Thread CHEN Zhongpu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] CHEN Zhongpu updated FLINK-31228: - Labels: playground (was: ) > flink-playgrounds is using a buggy zookeeper > ---

[jira] [Updated] (FLINK-31228) flink-playgrounds is using a buggy zookeeper

2023-02-26 Thread CHEN Zhongpu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] CHEN Zhongpu updated FLINK-31228: - Labels: (was: playground) > flink-playgrounds is using a buggy zookeeper > ---

[GitHub] [flink] flinkbot commented on pull request #22025: [bp-1.17][FLINK-30396][table-planner] Fix incorrect hint propagation into sub-query of lookup join hint

2023-02-26 Thread via GitHub
flinkbot commented on PR #22025: URL: https://github.com/apache/flink/pull/22025#issuecomment-1445374878 ## CI report: * 783eeac69dea012a596e12f906853e1836b0d2c8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-30720) KafkaChangelogTableITCase.testKafkaDebeziumChangelogSource failed due to a topic already exist when creating it

2023-02-26 Thread wgcn (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693657#comment-17693657 ] wgcn commented on FLINK-30720: -- Hi [~mapohl] ,does this Exception occur in every test? C

[GitHub] [flink] reswqa opened a new pull request, #22026: [FLINK-31223] sql-client.sh fails to start with ssl enabled

2023-02-26 Thread via GitHub
reswqa opened a new pull request, #22026: URL: https://github.com/apache/flink/pull/22026 ## What is the purpose of the change *`SqlClient` now uses `SqlGateway` for job submission. It will connect to the gateway's `RestServer` through the `RestClient` to interact. when we create th

[jira] [Updated] (FLINK-31223) sql-client.sh fails to start with ssl enabled

2023-02-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31223: --- Labels: pull-request-available (was: ) > sql-client.sh fails to start with ssl enabled > --

[GitHub] [flink] flinkbot commented on pull request #22026: [FLINK-31223] sql-client.sh fails to start with ssl enabled

2023-02-26 Thread via GitHub
flinkbot commented on PR #22026: URL: https://github.com/apache/flink/pull/22026#issuecomment-1445392265 ## CI report: * 3604ca17dd3e38cb44fe3311f93c8269a8dbfebb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] reswqa commented on pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-26 Thread via GitHub
reswqa commented on PR #21999: URL: https://github.com/apache/flink/pull/21999#issuecomment-1445393395 @RocMarshal Would you mind creating the `backport` pull request of `release-1.17` and `release-1.16` after all reviewers approved. -- This is an automated message from the Apache Git Ser

[GitHub] [flink] reswqa commented on pull request #21998: [Flink-clients][api] Adding a method to get ClusterClientProvider

2023-02-26 Thread via GitHub
reswqa commented on PR #21998: URL: https://github.com/apache/flink/pull/21998#issuecomment-1445394384 @jhkkhtd Sorry for the delay, you can request a jira account reference this [doc](https://flink.apache.org/community/#i-do-not-have-an-asf-jira-account-want-to-request-an-account-and-be-add

[GitHub] [flink] reswqa opened a new pull request, #22027: [hotfix] Add GuardedBy annotation and some clean up for result partition.

2023-02-26 Thread via GitHub
reswqa opened a new pull request, #22027: URL: https://github.com/apache/flink/pull/22027 ## What is the purpose of the change Add GuardedBy annotation and some clean up for result partition. ## Brief change log - *Add missing @GuardedBy annotation for SortMergeResultPartit

[GitHub] [flink] flinkbot commented on pull request #22027: [hotfix] Add GuardedBy annotation and some clean up for result partition.

2023-02-26 Thread via GitHub
flinkbot commented on PR #22027: URL: https://github.com/apache/flink/pull/22027#issuecomment-1445401185 ## CI report: * 89a6f138c7518fe08dec0a6db6dc786d44c37f06 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-31229) Implement a Pub/Sub Lite source and sink

2023-02-26 Thread Daniel Collins (Jira)
Daniel Collins created FLINK-31229: -- Summary: Implement a Pub/Sub Lite source and sink Key: FLINK-31229 URL: https://issues.apache.org/jira/browse/FLINK-31229 Project: Flink Issue Type: New

[GitHub] [flink] snuyanzin commented on pull request #21500: [FLINK-27995][table] Upgrade Janino version to 3.1.9

2023-02-26 Thread via GitHub
snuyanzin commented on PR #21500: URL: https://github.com/apache/flink/pull/21500#issuecomment-1445435871 Rebased to resolve ci issue ``` Reading package lists... E: Unsupported file ./libssl1.0.0_1.0.2n-1ubuntu5.10_amd64.deb given on commandline ##[error]Bash exited with code '1

[GitHub] [flink] MartijnVisser merged pull request #22009: [FLINK-31109][yarn] Support Hadoop proxy user when delegation token f…

2023-02-26 Thread via GitHub
MartijnVisser merged PR #22009: URL: https://github.com/apache/flink/pull/22009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[GitHub] [flink] MartijnVisser commented on pull request #22009: [FLINK-31109][yarn] Support Hadoop proxy user when delegation token f…

2023-02-26 Thread via GitHub
MartijnVisser commented on PR #22009: URL: https://github.com/apache/flink/pull/22009#issuecomment-1445455213 @venkata91 Can you also create a back port towards `release-1.17`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Commented] (FLINK-31109) Fails with proxy user not supported even when security.kerberos.fetch.delegation-token is set to false

2023-02-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693699#comment-17693699 ] Martijn Visser commented on FLINK-31109: Fixed in Master: 78136133fbec4ca145dec

[jira] [Updated] (FLINK-31228) flink-playgrounds is using a buggy zookeeper

2023-02-26 Thread CHEN Zhongpu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] CHEN Zhongpu updated FLINK-31228: - Labels: Docker (was: ) > flink-playgrounds is using a buggy zookeeper > ---

[jira] [Created] (FLINK-31230) Improve YarnClusterDescriptor memory unit display

2023-02-26 Thread Shilun Fan (Jira)
Shilun Fan created FLINK-31230: -- Summary: Improve YarnClusterDescriptor memory unit display Key: FLINK-31230 URL: https://issues.apache.org/jira/browse/FLINK-31230 Project: Flink Issue Type: Imp

[GitHub] [flink] slfan1989 opened a new pull request, #22028: [FLINK-31230] Improve YarnClusterDescriptor memory unit display.

2023-02-26 Thread via GitHub
slfan1989 opened a new pull request, #22028: URL: https://github.com/apache/flink/pull/22028 ## What is the purpose of the change JIRA: [FLINK-31230] Improve YarnClusterDescriptor memory unit display. When we use the yarn-session.sh -q command, the basic information of t

[jira] [Updated] (FLINK-31230) Improve YarnClusterDescriptor memory unit display

2023-02-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31230: --- Labels: pull-request-available (was: ) > Improve YarnClusterDescriptor memory unit display

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #212: [FLINK-31125] Flink ML benchmark framework should minimize the source operator overhead

2023-02-26 Thread via GitHub
lindong28 commented on code in PR #212: URL: https://github.com/apache/flink-ml/pull/212#discussion_r1118201388 ## flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/datagenerator/common/DenseVectorArrayGenerator.java: ## @@ -42,7 +42,7 @@ protected RowGenerator[] ge

[GitHub] [flink] flinkbot commented on pull request #22028: [FLINK-31230] Improve YarnClusterDescriptor memory unit display.

2023-02-26 Thread via GitHub
flinkbot commented on PR #22028: URL: https://github.com/apache/flink/pull/22028#issuecomment-1445547559 ## CI report: * 08c662fee24f32931227f95dc333471e4676e5f1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #212: [FLINK-31125] Flink ML benchmark framework should minimize the source operator overhead

2023-02-26 Thread via GitHub
lindong28 commented on code in PR #212: URL: https://github.com/apache/flink-ml/pull/212#discussion_r1118201388 ## flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/datagenerator/common/DenseVectorArrayGenerator.java: ## @@ -42,7 +42,7 @@ protected RowGenerator[] ge

[GitHub] [flink] lincoln-lil commented on pull request #21545: [FLINK-30396][table]make alias hint take effect in correlate

2023-02-26 Thread via GitHub
lincoln-lil commented on PR #21545: URL: https://github.com/apache/flink/pull/21545#issuecomment-1445551956 @Mulavar I've created one https://github.com/apache/flink/pull/22025, please help to check if you have time -- This is an automated message from the Apache Git Service. To respond

[GitHub] [flink-ml] Fanoid commented on pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-26 Thread via GitHub
Fanoid commented on PR #214: URL: https://github.com/apache/flink-ml/pull/214#issuecomment-1445556809 > Update `ModelServable#setModelData` to use the signature `default T setModelData(InputStream... modelDataInputs) throws IOException`. Hi, I just found we have made this change. I h

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #212: [FLINK-31125] Flink ML benchmark framework should minimize the source operator overhead

2023-02-26 Thread via GitHub
zhipeng93 commented on code in PR #212: URL: https://github.com/apache/flink-ml/pull/212#discussion_r1118206725 ## flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/datagenerator/common/DenseVectorArrayGenerator.java: ## @@ -42,7 +42,7 @@ protected RowGenerator[] ge

[GitHub] [flink-ml] zhipeng93 commented on pull request #212: [FLINK-31125] Flink ML benchmark framework should minimize the source operator overhead

2023-02-26 Thread via GitHub
zhipeng93 commented on PR #212: URL: https://github.com/apache/flink-ml/pull/212#issuecomment-1445559813 Thanks for the update. There are many other data generators in the benchmark settings, do you think we should apply same optimization here? -- This is an automated message from the Apa

[GitHub] [flink-ml] zhipeng93 commented on pull request #206: [FLINK-30933] Fix missing max watermark when executing join in iteration body

2023-02-26 Thread via GitHub
zhipeng93 commented on PR #206: URL: https://github.com/apache/flink-ml/pull/206#issuecomment-1445562174 @gaoyunhaii Can you help to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [flink-ml] zhipeng93 commented on pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-02-26 Thread via GitHub
zhipeng93 commented on PR #215: URL: https://github.com/apache/flink-ml/pull/215#issuecomment-1445562467 @gaoyunhaii Can you help to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [flink] RocMarshal commented on pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-26 Thread via GitHub
RocMarshal commented on PR #21999: URL: https://github.com/apache/flink/pull/21999#issuecomment-1445562489 > @RocMarshal Would you mind creating the `backport` pull request of `release-1.17` and `release-1.16` after all reviewers approved. @reswqa Yes. I'm glad to ~ -- This is an

[GitHub] [flink-ml] zhipeng93 commented on pull request #216: [Flink-31173] Fix serveral iteration bugs

2023-02-26 Thread via GitHub
zhipeng93 commented on PR #216: URL: https://github.com/apache/flink-ml/pull/216#issuecomment-1445562636 @gaoyunhaii Can you help to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [flink-ml] zhipeng93 commented on pull request #217: [FLINK-31191] Fix null pointer exception in VectorIndexer

2023-02-26 Thread via GitHub
zhipeng93 commented on PR #217: URL: https://github.com/apache/flink-ml/pull/217#issuecomment-1445562764 @gaoyunhaii Can you help to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Commented] (FLINK-31223) sql-client.sh fails to start with ssl enabled

2023-02-26 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693751#comment-17693751 ] Shengkai Fang commented on FLINK-31223: --- Hello. In the embedded mode, we always as

[jira] [Comment Edited] (FLINK-31223) sql-client.sh fails to start with ssl enabled

2023-02-26 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693751#comment-17693751 ] Shengkai Fang edited comment on FLINK-31223 at 2/27/23 2:08 AM: --

[jira] [Commented] (FLINK-31192) dataGen takes too long to initialize under sequence

2023-02-26 Thread xzw0223 (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693754#comment-17693754 ] xzw0223 commented on FLINK-31192: - [~Weijie Guo]  It's taken care of. Can you take a loo

[GitHub] [flink] 1996fanrui merged pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-26 Thread via GitHub
1996fanrui merged PR #21999: URL: https://github.com/apache/flink/pull/21999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[jira] [Resolved] (FLINK-30634) HiveTableSourceITCase.setupSourceDatabaseAndData fails with InvalidObjectException

2023-02-26 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia resolved FLINK-30634. -- Resolution: Duplicate > HiveTableSourceITCase.setupSourceDatabaseAndData fails with > InvalidObjectEx

[jira] [Commented] (FLINK-30664) [Connector/Hive] cleanup hive/haoop package ambiguous package dependencies

2023-02-26 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693755#comment-17693755 ] luoyuxia commented on FLINK-30664: -- What do you mean by saying "hive and hive-metastore

[jira] [Commented] (FLINK-29816) Userfunction exception in ProcessWindowFunction was called before invoke during restore state(subtask was in INITIALIZING state), but SteamTask skip handle Exception

2023-02-26 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693756#comment-17693756 ] Rui Fan commented on FLINK-29816: - Thanks [~RocMarshal] for your contribution, and [~Wei

[GitHub] [flink] HuangXingBo closed pull request #21770: [FLINK-30277][python]Allow PYTHONPATH of Python Worker configurable

2023-02-26 Thread via GitHub
HuangXingBo closed pull request #21770: [FLINK-30277][python]Allow PYTHONPATH of Python Worker configurable URL: https://github.com/apache/flink/pull/21770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Closed] (FLINK-30277) Allow PYTHONPATH of Python Worker configurable

2023-02-26 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang closed FLINK-30277. Fix Version/s: 1.18.0 Resolution: Fixed Merged into master via 2e0efe4e0723429e26ca04e2f61f

[GitHub] [flink] liuyongvs commented on a diff in pull request #21993: [FLINK-31166][table] Fix array_contains does not support null argumen…

2023-02-26 Thread via GitHub
liuyongvs commented on code in PR #21993: URL: https://github.com/apache/flink/pull/21993#discussion_r1118238858 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayElementArgumentTypeStrategy.java: ## @@ -31,24 +31,28 @@ imp

[GitHub] [flink] liuyongvs commented on a diff in pull request #21993: [FLINK-31166][table] Fix array_contains does not support null argumen…

2023-02-26 Thread via GitHub
liuyongvs commented on code in PR #21993: URL: https://github.com/apache/flink/pull/21993#discussion_r1118239596 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificInputTypeStrategies.java: ## @@ -71,7 +71,11 @@ public final

[GitHub] [flink] slfan1989 commented on pull request #22019: [FLINK-31221] Fix Typo in YarnConfigOptions.

2023-02-26 Thread via GitHub
slfan1989 commented on PR #22019: URL: https://github.com/apache/flink/pull/22019#issuecomment-1445628767 @1996fanrui Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [flink] slfan1989 commented on pull request #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.

2023-02-26 Thread via GitHub
slfan1989 commented on PR #22020: URL: https://github.com/apache/flink/pull/22020#issuecomment-1445629495 @1996fanrui Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #558: [FLINK-31213] Aggregation merge engine supports retract inputs

2023-02-26 Thread via GitHub
JingsongLi commented on code in PR #558: URL: https://github.com/apache/flink-table-store/pull/558#discussion_r1118243404 ## docs/content/docs/features/table-types.md: ## @@ -102,6 +102,9 @@ Current supported aggregate functions and data types are: * `listagg`: supports STRING

[GitHub] [flink-table-store] zhangjun0x01 commented on a diff in pull request #547: [FLINK-31128] Add Create Table As for flink table store

2023-02-26 Thread via GitHub
zhangjun0x01 commented on code in PR #547: URL: https://github.com/apache/flink-table-store/pull/547#discussion_r1118244978 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/CoreOptions.java: ## @@ -474,6 +474,20 @@ public class CoreOptions implements Serializ

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #558: [FLINK-31213] Aggregation merge engine supports retract inputs

2023-02-26 Thread via GitHub
JingsongLi commented on code in PR #558: URL: https://github.com/apache/flink-table-store/pull/558#discussion_r1118245870 ## flink-table-store-flink/flink-table-store-flink-common/src/main/java/org/apache/flink/table/store/connector/sink/TableStoreSink.java: ## @@ -88,6 +90,10 @

[GitHub] [flink-table-store] JingsongLi commented on pull request #558: [FLINK-31213] Aggregation merge engine supports retract inputs

2023-02-26 Thread via GitHub
JingsongLi commented on PR #558: URL: https://github.com/apache/flink-table-store/pull/558#issuecomment-1445638482 @SteNicholas Thanks for the review, comments addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [flink-table-store] JingsongLi commented on pull request #557: [FLINK-31209] Introduce creation time to files table

2023-02-26 Thread via GitHub
JingsongLi commented on PR #557: URL: https://github.com/apache/flink-table-store/pull/557#issuecomment-1445638952 > File is immutable, should never be modified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink-table-store] JingsongLi merged pull request #556: [hotfix] Adds the Kafka version reference in the dependencies

2023-02-26 Thread via GitHub
JingsongLi merged PR #556: URL: https://github.com/apache/flink-table-store/pull/556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [flink] liuyongvs commented on a diff in pull request #19623: [FLINK-27471][table] Add ARRAY_DISTINCT function

2023-02-26 Thread via GitHub
liuyongvs commented on code in PR #19623: URL: https://github.com/apache/flink/pull/19623#discussion_r1118251199 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayDistinctFunction.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to t

[GitHub] [flink] 1996fanrui commented on pull request #22020: [FLINK-31222] Remove usage of deprecated ConverterUtils.toApplicationId.

2023-02-26 Thread via GitHub
1996fanrui commented on PR #22020: URL: https://github.com/apache/flink/pull/22020#issuecomment-1445656410 Hi @slfan1989 , thanks for your contribution, please run `mvn spotless:apply` to fix the checkstyle. https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=46536

[GitHub] [flink] liuyongvs commented on a diff in pull request #19623: [FLINK-27471][table] Add ARRAY_DISTINCT function

2023-02-26 Thread via GitHub
liuyongvs commented on code in PR #19623: URL: https://github.com/apache/flink/pull/19623#discussion_r1118251199 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayDistinctFunction.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to t

[GitHub] [flink] godfreyhe commented on a diff in pull request #22024: [FLINK-30989][table] Fix some options don't take effect in batch mode

2023-02-26 Thread via GitHub
godfreyhe commented on code in PR #22024: URL: https://github.com/apache/flink/pull/22024#discussion_r1118269139 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/SorMergeJoinOperatorUtil.java: ## @@ -48,6 +49,17 @@ public static SortMerg

[jira] [Created] (FLINK-31231) flink-playgrounds has permission errors in mounted files

2023-02-26 Thread CHEN Zhongpu (Jira)
CHEN Zhongpu created FLINK-31231: Summary: flink-playgrounds has permission errors in mounted files Key: FLINK-31231 URL: https://issues.apache.org/jira/browse/FLINK-31231 Project: Flink Issu

[jira] [Commented] (FLINK-31092) Hive ITCases fail with OutOfMemoryError

2023-02-26 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693779#comment-17693779 ] luoyuxia commented on FLINK-31092: -- Try to analyze the heap dump, I found most of objec

[jira] [Comment Edited] (FLINK-31092) Hive ITCases fail with OutOfMemoryError

2023-02-26 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693779#comment-17693779 ] luoyuxia edited comment on FLINK-31092 at 2/27/23 4:29 AM: --- Tr

[jira] [Updated] (FLINK-30277) Allow PYTHONPATH of Python Worker configurable

2023-02-26 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-30277: - Affects Version/s: 1.18.0 (was: 1.16.0) > Allow PYTHONPATH of Python

[jira] [Updated] (FLINK-30277) Allow PYTHONPATH of Python Worker configurable

2023-02-26 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-30277: - Issue Type: New Feature (was: Improvement) > Allow PYTHONPATH of Python Worker configurable > -

[jira] [Commented] (FLINK-31231) flink-playgrounds has permission errors in mounted files

2023-02-26 Thread CHEN Zhongpu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693785#comment-17693785 ] CHEN Zhongpu commented on FLINK-31231: -- It seems that this issue only occurs in Mac

[jira] [Assigned] (FLINK-31221) Fix Typo in YarnConfigOptions

2023-02-26 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-31221: --- Assignee: Shilun Fan > Fix Typo in YarnConfigOptions > - > >

[GitHub] [flink] pgaref commented on pull request #21923: FLINK-13871: Consolidate volatile status fields in StreamTask

2023-02-26 Thread via GitHub
pgaref commented on PR #21923: URL: https://github.com/apache/flink/pull/21923#issuecomment-1445719083 > Hi @pgaref , thanks a lot for the refactor, it's very useful for maintainability. I have left some comments, please help take a look in your free time, thanks~ > > Thanks @pnowojs

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #546: [FLINK-31009] Add recordCount to snapshot meta

2023-02-26 Thread via GitHub
JingsongLi commented on code in PR #546: URL: https://github.com/apache/flink-table-store/pull/546#discussion_r1118300656 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/table/system/SnapshotsTable.java: ## @@ -71,7 +71,10 @@ public class SnapshotsTable impl

[GitHub] [flink-benchmarks] fredia opened a new pull request, #66: [FLINK-29825] Replace median-based regression detect algorithm with max/min-based

2023-02-26 Thread via GitHub
fredia opened a new pull request, #66: URL: https://github.com/apache/flink-benchmarks/pull/66 Replace median-based regression detect algorithm with max/min-based. Detailed design is in https://docs.google.com/document/d/1Bvzvq79Ll5yxd1UtC0YzczgFbZPAgPcN3cI0MjVkIag/edit -- This is an a

[jira] [Updated] (FLINK-29825) Improve benchmark stability

2023-02-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29825: --- Labels: pull-request-available (was: ) > Improve benchmark stability >

[GitHub] [flink-ml] lindong28 commented on pull request #212: [FLINK-31125] Flink ML benchmark framework should minimize the source operator overhead

2023-02-26 Thread via GitHub
lindong28 commented on PR #212: URL: https://github.com/apache/flink-ml/pull/212#issuecomment-1445747413 @zhipeng93 Thanks for the review. The change made in this PR should be able to improve all existing data generators via `RowGenerator`. Can you check if there is anything missing? --

[GitHub] [flink] dianfu closed pull request #20756: [FLINK-27929][python] Drop support for python36

2023-02-26 Thread via GitHub
dianfu closed pull request #20756: [FLINK-27929][python] Drop support for python36 URL: https://github.com/apache/flink/pull/20756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [flink] dianfu commented on pull request #20756: [FLINK-27929][python] Drop support for python36

2023-02-26 Thread via GitHub
dianfu commented on PR #20756: URL: https://github.com/apache/flink/pull/20756#issuecomment-1445749286 Closed this PR as this should have already been supported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (FLINK-31232) Parquet format supports MULTISET type for Table Store

2023-02-26 Thread Nicholas Jiang (Jira)
Nicholas Jiang created FLINK-31232: -- Summary: Parquet format supports MULTISET type for Table Store Key: FLINK-31232 URL: https://issues.apache.org/jira/browse/FLINK-31232 Project: Flink Iss

[GitHub] [flink-ml] zhipeng93 commented on pull request #212: [FLINK-31125] Flink ML benchmark framework should minimize the source operator overhead

2023-02-26 Thread via GitHub
zhipeng93 commented on PR #212: URL: https://github.com/apache/flink-ml/pull/212#issuecomment-1445758405 > @zhipeng93 Thanks for the review. The change made in this PR should be able to improve all existing data generators via `RowGenerator`. Can you check if there is anything missing?

[jira] [Created] (FLINK-31233) no error should be logged when retrieving the task manager's stdout if it does not exist

2023-02-26 Thread Weihua Hu (Jira)
Weihua Hu created FLINK-31233: - Summary: no error should be logged when retrieving the task manager's stdout if it does not exist Key: FLINK-31233 URL: https://issues.apache.org/jira/browse/FLINK-31233 P

[GitHub] [flink-ml] zhipeng93 merged pull request #212: [FLINK-31125] Flink ML benchmark framework should minimize the source operator overhead

2023-02-26 Thread via GitHub
zhipeng93 merged PR #212: URL: https://github.com/apache/flink-ml/pull/212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink-table-store] SteNicholas opened a new pull request, #560: [FLINK-31232] Parquet format supports MULTISET type for Table Store

2023-02-26 Thread via GitHub
SteNicholas opened a new pull request, #560: URL: https://github.com/apache/flink-table-store/pull/560 Parquet format should support MULTISET type for Table Store. Meanwhile, the FileStats couldn't support the MULTISET type because the null count of ColumnStatistics for ARRAY, MAP and MULTI

[jira] [Updated] (FLINK-31232) Parquet format supports MULTISET type for Table Store

2023-02-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31232: --- Labels: pull-request-available (was: ) > Parquet format supports MULTISET type for Table St

[jira] [Updated] (FLINK-31233) no error should be logged when retrieving the task manager's stdout if it does not exist

2023-02-26 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weihua Hu updated FLINK-31233: -- Description: When running Flink on Kubernetes, the stdout logs is not redirected to files so it will

[jira] [Commented] (FLINK-31223) sql-client.sh fails to start with ssl enabled

2023-02-26 Thread macdoor615 (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693802#comment-17693802 ] macdoor615 commented on FLINK-31223: [~fsk119] you are right. it is not a big proble

[jira] [Commented] (FLINK-31214) Add support for new command line option -py.pythonpath

2023-02-26 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693806#comment-17693806 ] Samrat Deb commented on FLINK-31214: I would like to work in this issue.    can yo

[jira] [Assigned] (FLINK-31139) not upload empty state changelog file

2023-02-26 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanfei Lei reassigned FLINK-31139: -- Assignee: Feifan Wang > not upload empty state changelog file > -

[GitHub] [flink] lsyldliu commented on pull request #22024: [FLINK-30989][table] Fix some options don't take effect in batch mode

2023-02-26 Thread via GitHub
lsyldliu commented on PR #22024: URL: https://github.com/apache/flink/pull/22024#issuecomment-1445784931 @godfreyhe Thanks for reviewing, I've addressed your comments. Regarding removing the config from `GeneratedClass`, I think we can complete it in another PR. -- This is an automated m

[GitHub] [flink] lincoln-lil closed pull request #22025: [bp-1.17][FLINK-30396][table-planner] Fix incorrect hint propagation into sub-query of lookup join hint

2023-02-26 Thread via GitHub
lincoln-lil closed pull request #22025: [bp-1.17][FLINK-30396][table-planner] Fix incorrect hint propagation into sub-query of lookup join hint URL: https://github.com/apache/flink/pull/22025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Comment Edited] (FLINK-30396) sql hint 'LOOKUP' which is defined in outer query block may take effect in inner query block

2023-02-26 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693587#comment-17693587 ] lincoln lee edited comment on FLINK-30396 at 2/27/23 6:47 AM:

[jira] [Closed] (FLINK-30396) sql hint 'LOOKUP' which is defined in outer query block may take effect in inner query block

2023-02-26 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-30396. --- Resolution: Fixed > sql hint 'LOOKUP' which is defined in outer query block may take effect in > in

  1   2   >