[jira] [Closed] (FLINK-8606) Clean up Table API for Java users

2023-03-11 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-8606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-8606. -- Resolution: Not A Problem TableEnvironment has been migrated to Java, so this is not a problem any more. >

[jira] [Commented] (FLINK-29541) [JUnit5 Migration] Module: flink-table-planner

2023-03-11 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699311#comment-17699311 ] Jark Wu commented on FLINK-29541: - Hi [~rskraba], what's the progress now? I agree with you this might

[GitHub] [flink] flinkbot commented on pull request #22162: [BP-1.16][FLINK-31393] Fix the bug that HsFileDataManager use an incorrect default timeout.

2023-03-11 Thread via GitHub
flinkbot commented on PR #22162: URL: https://github.com/apache/flink/pull/22162#issuecomment-1465106164 ## CI report: * ebc927186b8a2b0577686fdb820757ae54425bf3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Comment Edited] (FLINK-31393) HsFileDataManager use an incorrect default timeout

2023-03-11 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699217#comment-17699217 ] Weijie Guo edited comment on FLINK-31393 at 3/12/23 6:42 AM: - master(1.18)

[GitHub] [flink] reswqa opened a new pull request, #22162: [BP-1.16][FLINK-31393] Fix the bug that HsFileDataManager use an incorrect default timeout.

2023-03-11 Thread via GitHub
reswqa opened a new pull request, #22162: URL: https://github.com/apache/flink/pull/22162 Backport FLINK-31393 to release-1.16. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Reopened] (FLINK-31393) HsFileDataManager use an incorrect default timeout

2023-03-11 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reopened FLINK-31393: > HsFileDataManager use an incorrect default timeout >

[jira] [Comment Edited] (FLINK-31393) HsFileDataManager use an incorrect default timeout

2023-03-11 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699217#comment-17699217 ] Weijie Guo edited comment on FLINK-31393 at 3/12/23 6:37 AM: - release-1.17

[jira] [Closed] (FLINK-31393) HsFileDataManager use an incorrect default timeout

2023-03-11 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-31393. -- Resolution: Fixed > HsFileDataManager use an incorrect default timeout >

[GitHub] [flink] reswqa closed pull request #22147: [FLINK-31393][runtime] Fix the bug that HsFileDataManager use an incorrect default timeout.

2023-03-11 Thread via GitHub
reswqa closed pull request #22147: [FLINK-31393][runtime] Fix the bug that HsFileDataManager use an incorrect default timeout. URL: https://github.com/apache/flink/pull/22147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink-table-store] JingsongLi opened a new pull request, #594: [core] Introduce LookupMergeFunction and ForceUpLevel0Compaction

2023-03-11 Thread via GitHub
JingsongLi opened a new pull request, #594: URL: https://github.com/apache/flink-table-store/pull/594 ### Introduce `LookupMergeFunction` When Lookup Changelog producer is enabled, each merge will query the old merged record, so the latest high level record should be the final merged

[jira] [Commented] (FLINK-18696) Java 14 Records are not recognized as POJOs

2023-03-11 Thread Ungureanu Sergiu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699274#comment-17699274 ] Ungureanu Sergiu commented on FLINK-18696: -- Hi [~rmetzger] and [~twalthr] , Is this still an

[GitHub] [flink] flinkbot commented on pull request #22161: [FLINK-31405] Refactor tests to git rid of timeout of CompletableFuture assertions.

2023-03-11 Thread via GitHub
flinkbot commented on PR #22161: URL: https://github.com/apache/flink/pull/22161#issuecomment-1464992077 ## CI report: * bc189248cbaf7665ecf3139a1d95b15e8045d355 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31405) Refactor tests to git rid of timeout of CompletableFuture assertions.

2023-03-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31405: --- Labels: pull-request-available (was: ) > Refactor tests to git rid of timeout of

[GitHub] [flink] reswqa opened a new pull request, #22161: [FLINK-31405] Refactor tests to git rid of timeout of CompletableFuture assertions.

2023-03-11 Thread via GitHub
reswqa opened a new pull request, #22161: URL: https://github.com/apache/flink/pull/22161 ## What is the purpose of the change *In general, we want to avoid relying on local timeouts in the Flink test suite to get additional context (thread dump) in case something gets stuck(see

[jira] [Updated] (FLINK-31405) Refactor tests to git rid of timeout of CompletableFuture assertions.

2023-03-11 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-31405: --- Summary: Refactor tests to git rid of timeout of CompletableFuture assertions. (was: Refactor

[jira] [Created] (FLINK-31405) Refactor tests to git rid of timeout for CompletableFuture assertions.

2023-03-11 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-31405: -- Summary: Refactor tests to git rid of timeout for CompletableFuture assertions. Key: FLINK-31405 URL: https://issues.apache.org/jira/browse/FLINK-31405 Project: Flink

[GitHub] [flink] reswqa commented on pull request #22147: [FLINK-31393][runtime] Fix the bug that HsFileDataManager use an incorrect default timeout.

2023-03-11 Thread via GitHub
reswqa commented on PR #22147: URL: https://github.com/apache/flink/pull/22147#issuecomment-1464946454 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] wuchong commented on a diff in pull request #21521: [FLINK-30435][table] `SHOW CREATE TABLE` statement shows column comment

2023-03-11 Thread via GitHub
wuchong commented on code in PR #21521: URL: https://github.com/apache/flink/pull/21521#discussion_r1133107037 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java: ## @@ -82,7 +82,11 @@ static String getColumnString(Column

[GitHub] [flink] wuchong commented on pull request #22158: [FLINK-25347][table] Replace deprecated TableSchema with Schema in MergeTableLikeUtil

2023-03-11 Thread via GitHub
wuchong commented on PR #22158: URL: https://github.com/apache/flink/pull/22158#issuecomment-1464930287 Hi @Aitozi , do you want to review this PR? I saw you were quite active in the TableSchema migration work. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] kination commented on pull request #22039: [FLINK-31227][docs] Remove scala version for file system artifactId

2023-03-11 Thread via GitHub
kination commented on PR #22039: URL: https://github.com/apache/flink/pull/22039#issuecomment-1464926346 @MartijnVisser thanks for feedback. Applied  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Closed] (FLINK-29743) CatalogPropertiesUtil supports de/serializing column comment

2023-03-11 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-29743. --- Fix Version/s: 1.18.0 Resolution: Fixed Fixed in master: e22d164ff710571ff2708568a90a21dee194116a >

[GitHub] [flink] wuchong merged pull request #22131: [FLINK-29743][table] CatalogPropertiesUtil supports de/serializing column comment

2023-03-11 Thread via GitHub
wuchong merged PR #22131: URL: https://github.com/apache/flink/pull/22131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] wuchong commented on pull request #22131: [FLINK-29743][table] CatalogPropertiesUtil supports de/serializing column comment

2023-03-11 Thread via GitHub
wuchong commented on PR #22131: URL: https://github.com/apache/flink/pull/22131#issuecomment-1464923487 Thank you for the reviewing @LadyForest :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (FLINK-31395) AbstractPartitionDiscoverer.discoverPartitions calls remove on immutable collection

2023-03-11 Thread xzw0223 (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699220#comment-17699220 ] xzw0223 commented on FLINK-31395: - I guess it's the test code, but I'll keep watching >

[GitHub] [flink] flinkbot commented on pull request #22160: [FLINK-31404][table-planner] Support extracting all mapping of Calc node's input references for StreamNonDeterminisiticUpdatePlanVsitior

2023-03-11 Thread via GitHub
flinkbot commented on PR #22160: URL: https://github.com/apache/flink/pull/22160#issuecomment-1464916383 ## CI report: * 399dc91f31b2b4e00d3c711176003bff5e3a6246 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-31393) HsFileDataManager use an incorrect default timeout

2023-03-11 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699217#comment-17699217 ] Weijie Guo commented on FLINK-31393: release-1.17 via 02814d686592950b1b47b152cceca308d805af80. >

[jira] [Updated] (FLINK-31393) HsFileDataManager use an incorrect default timeout

2023-03-11 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-31393: --- Fix Version/s: 1.17.0 > HsFileDataManager use an incorrect default timeout >

[jira] [Updated] (FLINK-31404) Support extracting all mapping of Calc node's input references

2023-03-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31404: --- Labels: pull-request-available (was: ) > Support extracting all mapping of Calc node's

[GitHub] [flink] LadyForest opened a new pull request, #22160: [FLINK-31404][table-planner] Support extracting all mapping of Calc node's input references for StreamNonDeterminisiticUpdatePlanVsitior

2023-03-11 Thread via GitHub
LadyForest opened a new pull request, #22160: URL: https://github.com/apache/flink/pull/22160 ## What is the purpose of the change This PR tries to improve the `StreamNonDeterminisiticUpdatePlanVsitior` by supporting all kinds of `RexNode` when computing the source mapping

[GitHub] [flink] reswqa commented on pull request #22147: [FLINK-31393][runtime] Fix the bug that HsFileDataManager use an incorrect default timeout.

2023-03-11 Thread via GitHub
reswqa commented on PR #22147: URL: https://github.com/apache/flink/pull/22147#issuecomment-1464915123 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] reswqa merged pull request #22154: [BP-1.17][FLINK-31393] Fix the bug that HsFileDataManager use an incorrect default timeout.

2023-03-11 Thread via GitHub
reswqa merged PR #22154: URL: https://github.com/apache/flink/pull/22154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-31363) KafkaSink failed to commit transactions under EXACTLY_ONCE semantics

2023-03-11 Thread lightzhao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699215#comment-17699215 ] lightzhao commented on FLINK-31363: --- [~tzulitai] You are right, it is true that data cannot be

[GitHub] [flink] lightzhao commented on a diff in pull request #22126: [Bug][FLINK-31363]KafkaSink failed to commit transactions under EXACTLY_ONCE semantics.

2023-03-11 Thread via GitHub
lightzhao commented on code in PR #22126: URL: https://github.com/apache/flink/pull/22126#discussion_r1133083274 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/FlinkKafkaInternalProducer.java: ## @@ -302,7 +302,7 @@ public void

[jira] [Updated] (FLINK-31404) Support extracting all mapping of Calc node's input references

2023-03-11 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-31404: -- Summary: Support extracting all mapping of Calc node's input references (was: Support extracting

[GitHub] [flink] lightzhao commented on a diff in pull request #22126: [Bug][FLINK-31363]KafkaSink failed to commit transactions under EXACTLY_ONCE semantics.

2023-03-11 Thread via GitHub
lightzhao commented on code in PR #22126: URL: https://github.com/apache/flink/pull/22126#discussion_r1133078900 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/FlinkKafkaInternalProducer.java: ## @@ -302,7 +302,7 @@ public void

[jira] [Created] (FLINK-31404) Support extracting source mapping for all RexNode

2023-03-11 Thread Jane Chan (Jira)
Jane Chan created FLINK-31404: - Summary: Support extracting source mapping for all RexNode Key: FLINK-31404 URL: https://issues.apache.org/jira/browse/FLINK-31404 Project: Flink Issue Type:

[GitHub] [flink] Aitozi commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

2023-03-11 Thread via GitHub
Aitozi commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1130546283 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/Schema.java: ## @@ -611,7 +611,9 @@ private void addResolvedColumns(List columns) {

[jira] [Closed] (FLINK-31392) Refactor classes code of full-compaction

2023-03-11 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-31392. Resolution: Fixed master: c3e24fa4b0fd052a227296b03f9dfb0521ad833e > Refactor classes code of

[GitHub] [flink-table-store] JingsongLi merged pull request #589: [FLINK-31392] Refactor classes code of full-compaction

2023-03-11 Thread via GitHub
JingsongLi merged PR #589: URL: https://github.com/apache/flink-table-store/pull/589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] Myasuka commented on a diff in pull request #21835: [FLINK-30854][state] Support periodic compaction for RocksdbCompactFilterCleanupStrategy

2023-03-11 Thread via GitHub
Myasuka commented on code in PR #21835: URL: https://github.com/apache/flink/pull/21835#discussion_r1133051134 ## flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java: ## @@ -437,18 +465,43 @@ public boolean runCleanupForEveryRecord() {